[Linuxptp-devel] [PATCH 2/2] Clock Class Threshold Feature addition for PTP4L

2021-02-14 Thread Karthikkumar V
Implemented code review comments. This code changes brings in the ability to program the acceptable clockClass threshold beyond which device will move to holdover/free-run. Default clockClass threshold is 248. Example Use-Case This is needed in the cases where T-SC/T-BC Slave might want to listen

Re: [Linuxptp-devel] [PATCH v3 1/1] clock: Introduce step_window to free run x Sync events after after a clock step.

2021-02-14 Thread Richard Cochran
Vincent, This is shaping up nicely. I only have a few nits to pick... On Sun, Feb 14, 2021 at 05:22:09PM -0500, vincent.cheng...@renesas.com wrote: > @@ -1193,6 +1195,9 @@ struct clock *clock_create(enum clock_type type, struct > config *config, > return NULL; > } > > +

[Linuxptp-devel] [PATCH v3 1/1] clock: Introduce step_window to free run x Sync events after after a clock step.

2021-02-14 Thread vincent.cheng.xh
From: Vincent Cheng When clock stepping is unable to happen instantaneously the subsequent timestamps after a clock step does not reflect the step result and undesired clock freq and step adjustments will occur. When using ts2phc to synchronize timestamping clock using external 1 PPS, it could

[Linuxptp-devel] [PATCH v3 0/1] clock: Introduce step_window to free run x Sync events after a clock step.

2021-02-14 Thread vincent.cheng.xh
From: Vincent Cheng When clock stepping is unable to happen instantaneously the subsequent timestamps after a clock step does not reflect the step result and undesired clock freq and clock steps would occur. When using ts2phc to synchronize timestamping clock using external 1 PPS, it could take

Re: [Linuxptp-devel] [PATCH v2 0/1] clock: Introduce step_window to free run n Sync events after a clock step.

2021-02-14 Thread Vincent Cheng
On Sun, Feb 14, 2021 at 04:30:29AM EST, Luigi 'Comio' Mantellini wrote: >Hi, > >This patch cover my scenario where the timestamper can be aligned once at >second. >Can I suggest to a avoid to touch free_running variable and introduce >another one? Hi Luigi, Sure. Fixed in v3 patch. Vincent

Re: [Linuxptp-devel] [PATCH v2 0/1] clock: Introduce step_window to free run n Sync events after a clock step.

2021-02-14 Thread Luigi 'Comio' Mantellini
Hi, This patch cover my scenario where the timestamper can be aligned once at second. Can I suggest to a avoid to touch free_running variable and introduce another one? Thanks, Luigi Il dom 14 feb 2021, 06:55 ha scritto: > From: Vincent Cheng > > When clock stepping is unable to happen