Re: [Linuxptp-devel] Is intel i350 ptp driver broken?

2023-05-26 Thread egg car
Well I just read the i350 datasheet again and found why the driver was designed so. i350 SYSTIMH has only 8 valid bits, thus the SYSTIM could only count 2^40 ns aka 1099.5s. It's a bit complicated to use, I see why they use 'struct timecounter' instead of hardware PHC counter, and in this case all

Re: [Linuxptp-devel] Is intel i350 ptp driver broken?

2023-05-26 Thread Frantisek Rysanek
Hello Egg Car, prompted by your discovery, I've tried comparing the datasheets for the 82576, 82580, i350/354 and i210. And after quite a bit of cross-checking between the sparse and "not quite comparable" datasheets, and the driver source code, I have to agree with your conclusion. It is quite pr

Re: [Linuxptp-devel] Is intel i350 ptp driver broken?

2023-05-26 Thread Richard Cochran
On Fri, May 26, 2023 at 03:02:43PM +0800, egg car wrote: > It's a bit complicated to use, I see why they use 'struct timecounter' > instead of hardware PHC > counter, and in this case all the timestamp regs cannot be used directly. > Needs more time to find out how to fix this, either the driver o

Re: [Linuxptp-devel] Is intel i350 ptp driver broken?

2023-05-26 Thread egg car
Dear Richard, Ah yes I have figured out that the problem is not ts2phc, it should be fixed in igb_extts() at igb_main.c if (hw->mac .type == e1000_82580 || > hw

[Linuxptp-devel] Side note: i225 / igc time sync and TSN capabilities...

2023-05-26 Thread Frantisek Rysanek
Dear gents, this is just a slightly off topic gratuitous side note. In the context of fumbling in the "igb" driver in the other thread, I also took a look inside driver "igc" for comparison = to see what the i225 had to offer. Unsurprisingly, the register map related to time sync features seems

Re: [Linuxptp-devel] Side note: i225 / igc time sync and TSN capabilities...

2023-05-26 Thread Keller, Jacob E
> -Original Message- > From: Frantisek Rysanek > Sent: Friday, May 26, 2023 9:01 AM > To: linuxptp-devel@lists.sourceforge.net > Subject: [Linuxptp-devel] Side note: i225 / igc time sync and TSN > capabilities... > > Dear gents, > > this is just a slightly off topic gratuitous side no

Re: [Linuxptp-devel] Is intel i350 ptp driver broken?

2023-05-26 Thread Jacob Keller
On 5/26/2023 7:36 AM, egg car wrote: > Dear Richard, > > Ah yes I have figured out that the problem is not ts2phc, it should be > fixed in igb_extts() at igb_main.c > > if (hw->mac .type > == e1000_82580