Re: [Linuxptp-devel] [PATCH v1 3/3] ts2phc: Fix generic pps source when tai offset is not set in OS

2022-12-03 Thread Richard Cochran
On Tue, Oct 18, 2022 at 05:08:30PM +0200, Maciek Machnikowski wrote: > This patch adds support for the leapfile in the generic pps source. > Such implementations prevents situtation when TAI offset is not set in the > system (which is true when there is no NTP daemon running that sets it) from > se

Re: [Linuxptp-devel] [PATCH v1 2/3] lstab: move update_leapsecond_table function to lstab

2022-12-03 Thread Richard Cochran
les changed, 67 insertions(+), 47 deletions(-) > > diff --git a/lstab.c b/lstab.c > index a44aead..019e2d1 100644 > --- a/lstab.c > +++ b/lstab.c > @@ -3,6 +3,7 @@ > * @note Copyright (C) 2012 Richard Cochran > * @note SPDX-License-Identifier: GPL-2.0+ > */ &

Re: [Linuxptp-devel] [PATCH v1 1/3] lstab: Add LSTAB_EXPIRED result

2022-12-03 Thread Richard Cochran
On Tue, Oct 18, 2022 at 05:08:28PM +0200, Maciek Machnikowski wrote: > LSTAB_UNKNOWN is too generic, add LSTAB_EXPIRED result to return the latest > lstab correction and indicate that the tab used to resolve it is expired. > > This is useful for more precise reporting of lstab file state and will

Re: [Linuxptp-devel] [PATCH] makefile: use conditional assignment for KBUILD_OUTPUT

2022-12-03 Thread Richard Cochran
On Sat, Dec 03, 2022 at 08:01:53AM +0100, Heiko Thiery wrote: > Hi, > > Am Mi., 23. Nov. 2022 um 02:09 Uhr schrieb : > > > > From: Changqing Li > > > > Refer [1],from make 4.4, all variables that are marked as export will > > also be passed to the shell started by the shell function. use "=" will

Re: [Linuxptp-devel] [PATCH] Added support for Standard Baudrates supported by GNSS receivers

2022-11-28 Thread Richard Cochran
On Mon, Oct 17, 2022 at 05:20:02AM -0700, Michael Galassi wrote: > I mention this because in the kernel we use (4.4.8-armada-17.02.2) I > find in .../drivers/tty/tty_ioctl.c that these rates are protected by > "#ifndef __sparc__". I don't know if anyone much cares about > supporting Sparc any mor

Re: [Linuxptp-devel] [PATCH] Added support for Standard Baudrates supported by GNSS receivers

2022-11-28 Thread Richard Cochran
On Mon, Oct 17, 2022 at 04:38:20PM +0530, amarnagendr...@gmail.com wrote: > From: Amar Subramanyam > > Signed-off-by: Amar Subramanyam > --- > serial.c | 9 + > 1 file changed, 9 insertions(+) Applied. Thanks, Richard ___ Linuxptp-devel ma

Re: [Linuxptp-devel] [PATCH] Add source only option to phc2sys autoconfiguration

2022-11-28 Thread Richard Cochran
On Wed, Oct 12, 2022 at 01:45:35PM +0200, Jakub Raczynski wrote: > Implementation of two-way gPTP synchronization requires two phc2sys instances: > - one synchronizing CLOCK_REALTIME->phc when in Master (phc2sys -a -rr), > - second synchronizing phc->ntpshm when in Slave state (phc2sys -a -r -E >

Re: [Linuxptp-devel] [PATCH] Add source only option to phc2sys autoconfiguration

2022-11-28 Thread Richard Cochran
On Fri, Oct 14, 2022 at 09:29:10AM +0200, Jakub Raczyński wrote: > --- a/phc2sys.c 2022-10-14 09:24:53.643279501 +0200 > +++ b/phc2sys.c 2022-10-14 09:17:27.256854202 +0200 > @@ -558,11 +558,11 @@ > rt->state = PS_SLAVE; > } else if (rt) { > if (rt->state != PS_MASTER) { > - rt->state = PS_

Re: [Linuxptp-devel] [PATCH v3 0/4] Bug fix and improved clockcheck

2022-11-28 Thread Richard Cochran
On Mon, Oct 24, 2022 at 03:25:28PM +0200, Miroslav Lichvar wrote: > v3: > - improved documentation > > v2: > - added patch to exit on errors returned by read-only clock_adjtime() > - simplified last patch to reuse the set frequency and allow +/-1 ppb > error due to conversions between int, doubl

Re: [Linuxptp-devel] [PATCH v2 1/3] ts2phc: Rename pps_sink to tod_sink in main()

2022-11-28 Thread Richard Cochran
On Thu, Oct 06, 2022 at 03:57:03PM +0200, Maciek Machnikowski wrote: > From: Maciej Machnikowski > > Rename pps_sink to tod_sink, as it stores the source > of the time of day > > Signed-off-by: Maciej Machnikowski > --- > ts2phc.c | 19 ++- > 1 file changed, 10 insertions(+), 9

Re: [Linuxptp-devel] [PATCH] bmc: Fix PortId comparison

2022-11-17 Thread Richard Cochran
On Thu, Nov 17, 2022 at 07:38:02PM +0100, luigi.mantell...@gmail.com wrote: > Suppose to have the PortNumber_a=0x1234 and PortNumber_b=4512. On a > LittleEndian CPU, you will have the following memory streams: > > a) 0x34 0x12 > b) 0x12 0x45 > > Using a raw memory compare the a) will be erroneou

Re: [Linuxptp-devel] [PATCH 2/4] Add sock servo.

2022-11-15 Thread Richard Cochran
On Tue, Nov 15, 2022 at 07:29:23AM +, Keller, Jacob E wrote: > Both of those sound good to me. Slight preference to refclock_sock if its not > too long. +1 refclock_sock Thanks, Richard ___ Linuxptp-devel mailing list Linuxptp-devel@lists.sourcef

Re: [Linuxptp-devel] [PATCH 1/5] ptp4l: Add SET for defaultDS.domainNumber

2022-11-06 Thread Richard Cochran
On Wed, Nov 02, 2022 at 05:32:57PM -0400, izunna.otiji...@renesas.com wrote: > @@ -521,6 +521,12 @@ static int clock_management_set(struct clock *c, struct > port *p, > *changed = 1; > respond = 1; > break; > + case MID_DOMAIN: > + mtd = (

Re: [Linuxptp-devel] Introducing SyncESMC (ESMC client) from SyncMonk

2022-10-20 Thread Richard Cochran
On Thu, Oct 20, 2022 at 11:07:55AM +0530, Devasish Dey wrote: > SyncMonk is excited to introduce *SyncESMC*, an implementation for Ethernet > Synchronous Message Channel based on ITU-T G.8264 (03/2018) and ITU-T > G.781(04/2020) standards as a precision timing solution. I looked around for your r

Re: [Linuxptp-devel] Introducing SyncESMC (ESMC client) from SyncMonk

2022-10-20 Thread Richard Cochran
On Thu, Oct 20, 2022 at 11:07:55AM +0530, Devasish Dey wrote: > Few advantages of design: > >- Single-threaded architecture. >- Hardware agnostic >- Dynamic configuration supported with Sync-Yang, Netconf and SyncCLI. >- Monitoring and visibilities. >- Integrated with Enterpri

Re: [Linuxptp-devel] [PATCH] port: don't clear fault if link is down

2022-10-18 Thread Richard Cochran
On Tue, Sep 13, 2022 at 01:39:52PM -0700, Jacob Keller wrote: > When ptp4l detects a fault, the application stops for a short time until > the fault_reset_interval has passed. > > Since commit 3b82f227ce96 ("clock: Monitor the link status using a RT > netlink socket."), the clock state machine wil

Re: [Linuxptp-devel] [PATCH] sk: Handle EINTR when waiting for transmit timestamp.

2022-10-18 Thread Richard Cochran
On Tue, Sep 13, 2022 at 01:44:10PM +0200, Miroslav Lichvar wrote: > If ptp4l received a signal in poll() waiting for a transmit timestamp, > multiple (possibly confusing) error messages are logged before exit. > > If poll() returns with EINTR, call it once again to get the timestamp > and avoid lo

Re: [Linuxptp-devel] [PATCH v3 1/3] Adding virtual PTP port support

2022-10-18 Thread Richard Cochran
On Sat, Oct 08, 2022 at 01:27:28PM -0700, Richard Cochran wrote: > On Sat, Oct 08, 2022 at 01:24:23PM -0700, Richard Cochran wrote: > > > Why can't the virtual port function be an option for the UDS port > > already in place? > > To answer my own question, it needs

Re: [Linuxptp-devel] [PATCH v1] ts2phc: Update default lstab expiry date

2022-10-18 Thread Richard Cochran
On Mon, Oct 17, 2022 at 07:54:14PM +0200, Maciek Machnikowski wrote: > Update leap second table expiry date to 28 June 2023 based on > the latest leap-seconds.list from IETF > https://www.ietf.org/timezones/data/leap-seconds.list > > This fixes the need to give leapfile when running ts2phc with >

Re: [Linuxptp-devel] [PATCH v1] phc2sys: Update TAI to UTC offset in manual

2022-10-18 Thread Richard Cochran
On Mon, Oct 17, 2022 at 11:53:12AM +0200, Maciek Machnikowski wrote: > To avoid confusion - update offset in the man page to current value. Applied. Thanks, Richard ___ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net https://lists.sou

Re: [Linuxptp-devel] [PATCH 1/3] Packet Timing Signal Fail (PTSF)(G.8275.2 Section 6.7.11)

2022-10-18 Thread Richard Cochran
On Mon, Oct 17, 2022 at 06:28:33PM +0530, Devasish Dey wrote: > > > > > The management interface follows the IEEE standard. > > > Please follow the standard, and do not add values that break the > > standard. > > > > Yes, this is an absolute no-go. > > > > We have used the Reserved range which is

Re: [Linuxptp-devel] [PATCH] Inclusion of a virtual PTP port on a PTP clock

2022-10-18 Thread Richard Cochran
On Mon, Oct 17, 2022 at 05:38:36PM +0200, Maciek Machnikowski wrote: > Since the GNSS itself doesn't come with any dataset attached, the virtual port > concept was created. Its sole purpose is to present the BMCA with the dataset > of > the physical PPS+ToD signal. > > The way to implement would

Re: [Linuxptp-devel] [PATCH 2/2] Alternate master support

2022-10-18 Thread Richard Cochran
On Mon, Oct 17, 2022 at 06:27:12PM +0530, Devasish Dey wrote: > "The PTP connections between the T-BC-Ps allow the T-BC-Ps to support > specific monitoring types. For example, T-BC-P #D may monitor and learn the > PDV characteristics of the PTP service from T-BC-P #C. This may be used to > help th

Re: [Linuxptp-devel] [PATCH 2/2] Alternate master support

2022-10-14 Thread Richard Cochran
On Wed, Aug 24, 2022 at 03:57:12PM +0530, SyncMonk Technologies wrote: > adding alternate master support for linuxptp > > A PTP Master Clock, which is not the Best Master, > may act as a master with the Alternate Master flag > set on the messages it sends. > Need to support Alternate Master, inclu

Re: [Linuxptp-devel] [PATCH 2/2] Alternate master support

2022-10-14 Thread Richard Cochran
On Wed, Aug 24, 2022 at 03:57:12PM +0530, SyncMonk Technologies wrote: > @@ -1595,6 +1611,10 @@ int port_tx_announce(struct port *p, struct address > *dst, uint16_t sequence_id) > > msg->header.flagField[1] = tp.flags; > > + if (p->state != PS_MASTER && clock_telecom_profile(p->cloc

Re: [Linuxptp-devel] [PATCH 1/2] Alternate master support

2022-10-14 Thread Richard Cochran
On Wed, Aug 24, 2022 at 03:57:11PM +0530, SyncMonk Technologies wrote: > Slave Event Monitoring channel for the alternate connections AFACIT this patch has nothing to do with alternate master as described in IEEE 1588. No thanks, Richard ___ Linuxptp

Re: [Linuxptp-devel] [PATCH 2/2] Alternate master support

2022-10-14 Thread Richard Cochran
On Wed, Aug 24, 2022 at 03:57:12PM +0530, SyncMonk Technologies wrote: > diff --git a/config.c b/config.c > index b5cf397..ce8a3ae 100644 > --- a/config.c > +++ b/config.c > @@ -226,6 +226,7 @@ static struct config_enum bmca_enu[] = { > }; > > struct config_item config_tab[] = { > + PORT_I

Re: [Linuxptp-devel] [PATCH] ptp4l: Add profile_id configuration support for G.8275.1 and G.8275.2.

2022-10-14 Thread Richard Cochran
On Tue, Aug 16, 2022 at 01:08:35PM -0400, izunna.otiji...@renesas.com wrote: > From: Izunna Otiji > > Signed-off-by: Izunna Otiji > --- > port.c | 13 - > transport.c | 5 + > transport.h | 5 + > 3 files changed, 22 insertions(+), 1 deletion(-) > > diff --git a/port

Re: [Linuxptp-devel] [PATCH] Inclusion of a virtual PTP port on a PTP clock

2022-10-14 Thread Richard Cochran
On Sat, Oct 08, 2022 at 04:05:17PM -0700, Richard Cochran wrote: > > So I really don't see any reason for merging the Virtual Port patch > series. It merely adds a second way to accomplish existing > functionality, but having two ways of doing the same thing violated >

Re: [Linuxptp-devel] [PATCH 1/4] [Interface Rate TLV] function to support get interface speed via ethtool

2022-10-11 Thread Richard Cochran
On Mon, Oct 10, 2022 at 01:07:30PM +0530, SyncMonk Technologies wrote: > diff --git a/sk.h b/sk.h > index 486dbc4..ea19a8e 100644 > --- a/sk.h > +++ b/sk.h > @@ -49,6 +49,17 @@ struct sk_ts_info { > unsigned int rx_filters; > }; > > +/** > + * Contains interface information returned by th

Re: [Linuxptp-devel] [PATCH 4/4] [Interface Rate TLV] adding delay asymmetry calculation

2022-10-11 Thread Richard Cochran
On Mon, Oct 10, 2022 at 01:07:33PM +0530, SyncMonk Technologies wrote: > @@ -161,10 +189,14 @@ int process_signaling(struct port *p, struct > ptp_message *m) > > case TLV_ORGANIZATION_EXTENSION: > r = (struct msg_interval_req_tlv *) extra->tlv; > +

Re: [Linuxptp-devel] [PATCH v6] Strip Parallel Redundancy Protocol (PRP) trailer

2022-10-11 Thread Richard Cochran
On Tue, Oct 11, 2022 at 07:31:13PM +0300, Magnus Armholt wrote: > Strip the IEC62439-3 PRP trailer if it is present > to support PTP over PRP. > The implementation is very pedantic about > trailing bytes and will indicate bad message if the > PRP trailer bytes are present when parsing the PTP messa

Re: [Linuxptp-devel] [PATCH] Inclusion of a virtual PTP port on a PTP clock

2022-10-08 Thread Richard Cochran
I read Annex B and Appendix III of T-REC-G.8275-202010, and I claim that linuxptp already implements this functionality, even though there is no "virtual port" explicitly modeled. I also read about APTS in T-REC-G.8275.2-202003. This is what I learned... On Mon, Jul 25, 2022 at 02:02:11AM +,

Re: [Linuxptp-devel] [PATCH 1/3] Packet Timing Signal Fail (PTSF)(G.8275.2 Section 6.7.11)

2022-10-08 Thread Richard Cochran
On Wed, Aug 24, 2022 at 03:31:44PM +0200, Erez wrote: > On Wed, 24 Aug 2022 at 12:37, SyncMonk Technologies > wrote: > > > - adding sync receipt timeout, delay response timeout and signal fail > > support to portDS as per G.8275.2. > > - This also sets the signal fail condition for timeout. > >

Re: [Linuxptp-devel] [PATCH 4/4] [Interface Rate TLV] adding delay asymmetry calculation

2022-10-08 Thread Richard Cochran
On Wed, Jul 27, 2022 at 01:25:22PM +0530, SyncMonk Technologies wrote: > @@ -705,6 +705,12 @@ the interval, the sample will be printed instead of the > statistics. The > messages are printed at the LOG_INFO level. > The default is 0 (1 second). > .TP > +.B interface_rate_tlv > +When master and

Re: [Linuxptp-devel] [PATCH 4/4] [Interface Rate TLV] adding delay asymmetry calculation

2022-10-08 Thread Richard Cochran
On Wed, Jul 27, 2022 at 01:25:22PM +0530, SyncMonk Technologies wrote: > diff --git a/interface.c b/interface.c > index 9bcb343..ec8964c 100644 > --- a/interface.c > +++ b/interface.c > @@ -93,3 +93,12 @@ int interface_get_vclock(struct interface *iface) > { > return iface->vclock; > } > +

Re: [Linuxptp-devel] [PATCH 3/4] [Interface Rate TLV] organization TLV support for interface rate

2022-10-08 Thread Richard Cochran
On Wed, Jul 27, 2022 at 01:25:21PM +0530, SyncMonk Technologies wrote: > @@ -241,6 +241,7 @@ struct config_item config_tab[] = { > GLOB_ITEM_ENU("clock_type", CLOCK_TYPE_ORDINARY, clock_type_enu), > GLOB_ITEM_ENU("dataset_comparison", DS_CMP_IEEE1588, dataset_comp_enu), > PORT_IT

Re: [Linuxptp-devel] [PATCH 1/4] [Interface Rate TLV] function to support get interface speed via ethtool

2022-10-08 Thread Richard Cochran
On Wed, Jul 27, 2022 at 01:25:19PM +0530, SyncMonk Technologies wrote: > +/** > + * Contains interface information returned by theGLINKSETTINGS ioctl. > + * @valid:set to non-zero when the info struct contains valid > data. > + * @speed:interface speed. > + */ > +struct sk

Re: [Linuxptp-devel] [PATCH 3/3] [Interface Rate TLV] adding TLV support

2022-10-08 Thread Richard Cochran
On Tue, Jul 26, 2022 at 06:26:46PM +0530, Devasish Dey wrote: > > > + GLOB_ITEM_INT("interface_rate_tlv", 0, 0, 1), > > > > Why is it not a port-specific option? If you reject a suggestion, it's > > a good practice to explain your reasoning. > > > [Devasish]: It is for TLV support and this see

Re: [Linuxptp-devel] [PATCH v5] Strip Parallel Redundancy Protocol (PRP) trailer

2022-10-08 Thread Richard Cochran
On Tue, Aug 09, 2022 at 08:26:08AM +0300, Magnus Armholt wrote: > Strip the IEC62439-3 PRP trailer if it is present > to support PTP over PRP. Fails when building against Linux kernel 3.0 headers (the earliest supported kernel version). /home/richard/git/linuxptp/raw.c: In function ‘has_prp_trail

Re: [Linuxptp-devel] [PATCH v3 1/3] Adding virtual PTP port support

2022-10-08 Thread Richard Cochran
On Sat, Oct 08, 2022 at 01:24:23PM -0700, Richard Cochran wrote: > Why can't the virtual port function be an option for the UDS port > already in place? To answer my own question, it needs to be in the list of "normal" ports in order to participate in the BCMA. But as I s

Re: [Linuxptp-devel] [PATCH v3 1/3] Adding virtual PTP port support

2022-10-08 Thread Richard Cochran
On Fri, Sep 02, 2022 at 12:26:11PM +0530, SyncMonk Technologies wrote: > diff --git a/clock.c b/clock.c > index d37bb87..eba0833 100644 > --- a/clock.c > +++ b/clock.c > @@ -97,9 +97,10 @@ struct clock { > LIST_HEAD(ports_head, port) ports; > struct port *uds_rw_port; > struct po

Re: [Linuxptp-devel] [PATCH v3 2/3] adding virtual port support for ts2phc

2022-10-08 Thread Richard Cochran
On Fri, Sep 02, 2022 at 12:26:12PM +0530, SyncMonk Technologies wrote: > +static int ts2phc_vport_init_sync(struct ts2phc_vport *p, > + struct address address) > +{ > + > + struct ptp_message *msg; > + > + msg = msg_allocate(); > + if (!msg) { > +

Re: [Linuxptp-devel] [PATCH v3 1/3] Adding virtual PTP port support

2022-10-08 Thread Richard Cochran
On Thu, Oct 06, 2022 at 08:58:31PM +0530, SyncMonk Tech Services wrote: > Please let us know if there are any action items on us related to this or > other patches raised by SyncMonk. You need to address the review comments: As presented, this functionality won't work correctly. If the ts2phc

Re: [Linuxptp-devel] [PATCH v3 3/3] Adding support for passing announce message from external source

2022-10-08 Thread Richard Cochran
On Fri, Sep 02, 2022 at 12:26:13PM +0530, SyncMonk Technologies wrote: > @@ -426,7 +427,10 @@ int ts2phc_pps_sink_poll(struct ts2phc_pps_source *src) > > err = ts2phc_pps_source_getppstime(src, &source_ts.ts); > source_ts.valid = err ? false : true; > - > + if (source_ts.valid) {

Re: [Linuxptp-devel] [PATCH v3 1/3] Adding virtual PTP port support

2022-10-07 Thread Richard Cochran
On Thu, Oct 06, 2022 at 08:58:31PM +0530, SyncMonk Tech Services wrote: > Hi Richard, > > Please let us know if there are any action items on us related to this or > other patches raised by SyncMonk. I'll review as time allows. Thanks, Richard ___ Li

Re: [Linuxptp-devel] [PATCH v1] ts2phc: Add option to specify the ToD source in the config file

2022-10-04 Thread Richard Cochran
On Tue, Oct 04, 2022 at 10:30:58AM +0200, Maciek Machnikowski wrote: > Current implementation requires specifying the -s argument for PPS > sources that don't provide ToD information and for GNSS modules. > > Add ts2phc.tod_source config option to enable specifying the source > in the config file.

Re: [Linuxptp-devel] [PATCH v6 00/10] Dynamic sync direction for ts2phc

2022-10-02 Thread Richard Cochran
On Wed, Aug 31, 2022 at 02:12:54AM +0300, Vladimir Oltean wrote: > As discussed in this email thread: > https://sourceforge.net/p/linuxptp/mailman/message/37047555/ > there is a desire to synchronize multiple DSA switches in a > boundary_clock_jbod setup, using a PPS signal, and the ts2phc program

Re: [Linuxptp-devel] [PATCH] sk.c: Unreachable switch case TS_SOFTWARE

2022-09-25 Thread Richard Cochran
On Sun, Sep 25, 2022 at 11:37:31AM -0700, Michael Galassi wrote: > I've developed the habit of closing all non-exhaustive switches where > no sensible default exists with a default which asserts with a > meaningful diagnostic. Doing so has helped me find a number of my own > mistaken assumptions.

Re: [Linuxptp-devel] [PATCH] sk.c: Unreachable switch case TS_SOFTWARE

2022-09-25 Thread Richard Cochran
On Thu, Jul 21, 2022 at 01:20:47PM +, Geva, Erez wrote: > Hi, > > I think the "if (type != TS_SOFTWARE" is wrong. > The "type" only refer to TX. No, "type" is an enumerated value, timestamp_type, and it describes the flavor of time stamping in use. > But hwts_init() also set the RX. > So no

Re: [Linuxptp-devel] [PATCH] sk.c: Unreachable switch case TS_SOFTWARE

2022-09-25 Thread Richard Cochran
On Thu, Jul 21, 2022 at 03:10:40PM +0530, Siddharth Vadapalli via Linuxptp-devel wrote: > Remove the unreachable switch case TS_SOFTWARE. > > Signed-off-by: Siddharth Vadapalli > --- > sk.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/sk.c b/sk.c > index b55d6b5..a49bcf4 100644 >

Re: [Linuxptp-devel] Planning release 3.2

2022-09-25 Thread Richard Cochran
On Tue, May 04, 2021 at 04:46:59AM -0700, Richard Cochran wrote: > On Mon, May 03, 2021 at 05:09:09PM +0200, Michael Walle wrote: > > did I miss something or wasn't there a 3.2 release? > > You didn't miss anything. I have been delayed in pushing out the 3.2 > releas

Re: [Linuxptp-devel] [PATCH] ptp4l: Allow setting of socket priority for UDPv4/UDPv6

2022-09-25 Thread Richard Cochran
On Mon, Sep 05, 2022 at 04:35:58PM +0200, Kurt Kanzenbach wrote: > Yes, this should work. Thanks! Kurt, Does this mean you can use the dscp_ settings, and the new "socket_priority" from your patch isn't needed? Thanks, Richard ___ Linuxptp-devel ma

Re: [Linuxptp-devel] linuxptp result doesn't match 1PPS measurement

2022-09-08 Thread Richard Cochran
On Fri, Sep 09, 2022 at 08:45:19AM +0800, Hamilton Alex wrote: > Hi, Richard: > I am not quite understand. I am using Calnex master-->board slave, if the > linuxptp print out is correct, that means local clock > has the same frequency and phase as master clock, then the 1PPS out should > near the

Re: [Linuxptp-devel] linuxptp result doesn't match 1PPS measurement

2022-09-08 Thread Richard Cochran
On Thu, Sep 08, 2022 at 01:56:59PM +0200, Luigi 'Comio' Mantellini wrote: > - How is the 1PPS driven? Is there any reclocking logic? You need to ask > your FPGA-experts. +1 The circuit the produces the 1 PPS could well delay the signal by ten or more nanoseconds. Thanks, Richard

Re: [Linuxptp-devel] linuxptp result doesn't match 1PPS measurement

2022-09-08 Thread Richard Cochran
On Thu, Sep 08, 2022 at 06:40:26AM -0700, Richard Cochran wrote: > On Thu, Sep 08, 2022 at 07:41:53PM +0800, Hamilton Alex wrote: > > > however, the 1pps time error is around 40 NS, which means my board is > > ahead of the reference for about 40NS, which doesn't match t

Re: [Linuxptp-devel] linuxptp result doesn't match 1PPS measurement

2022-09-08 Thread Richard Cochran
On Thu, Sep 08, 2022 at 07:41:53PM +0800, Hamilton Alex wrote: > however, the 1pps time error is around 40 NS, which means my board is > ahead of the reference for about 40NS, which doesn't match the result > dumped by ptp4l. > > anyone has met similar issue before? how to debug such issue? Th

Re: [Linuxptp-devel] [PATCH v3 1/3] Adding virtual PTP port support

2022-09-06 Thread Richard Cochran
On Mon, Sep 05, 2022 at 05:21:32PM +0200, Miroslav Lichvar wrote: > On Mon, Sep 05, 2022 at 07:20:49AM -0700, Richard Cochran wrote: > > I can imagine that allowing an Announce messages on the UDS port and > > letting the UDS port participate in BMCA might make the whole syste

Re: [Linuxptp-devel] PTP minor version change breaking at least one type of GM

2022-09-06 Thread Richard Cochran
On Mon, Sep 05, 2022 at 06:06:23PM +, Zdenek Chaloupka via Linuxptp-devel wrote: > I have been playing with development version of Linuxptp connected to > Microchip’s TP4100. It seems that commit (2a2532d) breaks compatibility with > this particular GM. I am using G.8275.2 profile PTP config

Re: [Linuxptp-devel] PTP minor version change breaking at least one type of GM

2022-09-06 Thread Richard Cochran
On Tue, Sep 06, 2022 at 08:43:43AM +0200, Miroslav Lichvar wrote: > On Mon, Sep 05, 2022 at 06:06:23PM +, Zdenek Chaloupka via Linuxptp-devel > wrote: > > It seems that the reason for that is that this particular GMs do not reply > > to Delay_Req messages with PTP minor version set to 1. Belo

Re: [Linuxptp-devel] [PATCH v3 1/3] Adding virtual PTP port support

2022-09-05 Thread Richard Cochran
On Mon, Sep 05, 2022 at 02:37:13PM +0200, Miroslav Lichvar wrote: > It's not clear to me how would you prevent two things from controlling > the same clock at once. With a management message you could be > monitoring the state (as phc2sys does for instance), but with an > announce and/or sync mess

Re: [Linuxptp-devel] [PATCH v3 3/3] Adding support for passing announce message from external source

2022-09-05 Thread Richard Cochran
On Fri, Sep 02, 2022 at 12:26:13PM +0530, SyncMonk Technologies wrote: > The announce message from the External source is passed by virtual port > for BMCA participation so that it becomes a selection source > along with other ports for linuxPTP. As presented, this functionality won't work correct

Re: [Linuxptp-devel] [PATCH v3 1/3] Adding virtual PTP port support

2022-09-05 Thread Richard Cochran
On Mon, Sep 05, 2022 at 12:50:51PM +0200, Miroslav Lichvar wrote: > Can you please describe advantages of this approach over using the > existing GRANDMASTER_SETTINGS_NP management message and/or a new > management message that can set all values needed for the telecom > profile? +1 I was thinki

Re: [Linuxptp-devel] [PATCH 00/11] synce4l: add software for Synchronous Ethernet

2022-09-05 Thread Richard Cochran
On Wed, Aug 31, 2022 at 09:23:25PM +, Kubalewski, Arkadiusz wrote: > Richard, > I know our solution in its current state is far from being perfect. > It communicates with EEC by shell commands specified by the user, but at least > it is not specific for any particular hardware. > Although it do

Re: [Linuxptp-devel] [Linuxptp-users] linuxptp servo can't converge

2022-09-02 Thread Richard Cochran
On Sat, Sep 03, 2022 at 08:09:14AM +0800, Hamilton Alex wrote: > I didn't use custom vendor linux driver, Zarlink provided steps to adjust > its DPLL frequency and I implement > it by my self. Oh, well, in that case, probably your own custom driver has a bug. Good luck, Richard ___

Re: [Linuxptp-devel] [Linuxptp-users] linuxptp servo can't converge

2022-09-02 Thread Richard Cochran
On Fri, Sep 02, 2022 at 08:38:08AM +0800, Hamilton Alex wrote: > Hi, my friends: > I got an issue for linux ptp servo. my board is using zarlink DPLL, I'm not familiar with "zarlink DPLL". I guess this is using a custom vendor Linux driver? If so, your issue is likely a bug in the driver and/or

Re: [Linuxptp-devel] [PATCH v3 1/3] Adding virtual PTP port support

2022-09-02 Thread Richard Cochran
On Fri, Sep 02, 2022 at 12:26:11PM +0530, SyncMonk Technologies wrote: > @@ -1094,6 +1098,32 @@ struct clock *clock_create(enum clock_type type, > struct config *config, > return NULL; > } > > + /* Configure the Virtual Port. */ > + vport_ifname = config_get_string(co

Re: [Linuxptp-devel] [PATCH 2/2] Alternate master support

2022-09-01 Thread Richard Cochran
On Wed, Aug 24, 2022 at 03:57:12PM +0530, SyncMonk Technologies wrote: > adding alternate master support for linuxptp Why are you posting the same stuff twice but with different subject lines!? 24.Aug'22 SyncMonk Techno [Linuxptp-devel] [PATCH 1/2] Slave Event Monitoring channel for th

Re: [Linuxptp-devel] [PATCH v2 1/4] Adding virtual PTP port support

2022-09-01 Thread Richard Cochran
On Fri, Sep 02, 2022 at 01:06:30AM +0530, SyncMonk Technologies wrote: > Virtual PTP port is for unidirectional tranfer of phase/time interface > on a PTP clock. > When associated with an external input signal, a virtual PTP port allows > this external interface to participate in the PTP protocol.

Re: [Linuxptp-devel] [PATCH] ptp4l: Allow setting of socket priority for UDPv4/UDPv6

2022-08-30 Thread Richard Cochran
On Tue, Aug 30, 2022 at 09:30:33AM +0200, Kurt Kanzenbach wrote: > ptp4l supports setting of socket priority. This is useful for traffic shaping > e.g., utilizing Tx steering using TAPRIO or mqprio Qdisc or VLAN egress > mappings. Why can't Qdisc use the dialed dscp_event and dscp_general settings

Re: [Linuxptp-devel] [PATCH v5 07/13] ts2phc: instantiate a full clock structure for every PPS source of the PHC kind

2022-08-08 Thread Richard Cochran
On Fri, Aug 05, 2022 at 07:56:38PM +0300, Vladimir Oltean wrote: > > Need to keep this include in order to make sure declaration and > > definition of ts2phc_phc_pps_source_create() are consistent. > > ts2phc.h includes ts2phc_phc_pps_source.h. Still it is best practice NOT to rely on transitive

Re: [Linuxptp-devel] [PATCH v4] Strip PRP trailer

2022-08-08 Thread Richard Cochran
On Mon, Aug 08, 2022 at 01:11:36PM +0200, Erez wrote: > On Mon, 8 Aug 2022 at 12:36, Miroslav Lichvar wrote: > > would be nice to convert them all avoid confusion. Yes, but not here with new code. > The question is not if other code uses it, but what is better. > Though the function name suggest

Re: [Linuxptp-devel] [PATCH v5 08/13] ts2phc: instantiate a pmc agent

2022-08-08 Thread Richard Cochran
On Fri, Aug 05, 2022 at 07:56:11PM +0300, Vladimir Oltean wrote: > Can't I just delete "case PS_INITIALIZING:" ... "case PS_GRAND_MASTER:" > since I have to put "default:" anyway (we may get arbitrary input over > the management messages)? sure > I'm also wondering if PS_PRE_MASTER and PS_UNCAL

Re: [Linuxptp-devel] [PATCH 00/11] synce4l: add software for Synchronous Ethernet

2022-07-30 Thread Richard Cochran
On Fri, Jul 29, 2022 at 04:24:47PM +, Michalik, Michal wrote: > Richard - since you obviously have the last word, would you mind to state your > final decision clearly to avoid any further interpretations of your answer? As it is, I am really not even keeping up with the PTP patches, and so I

Re: [Linuxptp-devel] [PATCH v1] ts2phc: Enable corrections reporting in default log level

2022-07-28 Thread Richard Cochran
On Thu, Jul 28, 2022 at 10:37:04AM +0200, Maciek Machnikowski wrote: > Change loglevel of the current PPS corrections to pr_info to enable > reporting corrections when the tool is ran with -m parameter only. > > Current implementation requires -l 7 to see them and this debug level > brings much mo

Re: [Linuxptp-devel] [PATCH v4] phc2sys: Add support for free-running mode

2022-07-25 Thread Richard Cochran
On Mon, Jul 25, 2022 at 03:25:11PM +0200, Maciek Machnikowski wrote: > Add support for the free-running mode that will not adjust the sink > clock when enabled. > > V2: changed implementation to instantiate NTPSHM servo that serves as > the nochange servo > V3: revert to original implementatio

Re: [Linuxptp-devel] [PATCH] G.8275.2 support for delay_mechanism NO_MECHANISM

2022-07-25 Thread Richard Cochran
On Mon, Jul 25, 2022 at 01:55:25PM +0530, SyncMonk Technologies wrote: > As per IEEE1588-2019, Table 21 adding NO_MECHANISM support. In this > case port does not implement the delay mechanism. > > Signed-off-by: Greg Armstrong > Signed-off-by: Leon Goldin > Signed-off-by: Devasish Dey > Signed-

Re: [Linuxptp-devel] [PATCH v2] port: Disable PHC switch with vclocks.

2022-07-25 Thread Richard Cochran
On Mon, Jul 25, 2022 at 09:57:07AM +0200, Miroslav Lichvar wrote: > With a virtual PHC, don't try to switch to the physical PHC after a > link-state change. JBOD and other multi-PHC configurations are not > supported with vclocks yet. > > Fixes: 9b9c2c58e6ed ("port: Check for virtual clocks.") >

Re: [Linuxptp-devel] [PATCH] unicast: Update announce timer when renew

2022-07-25 Thread Richard Cochran
On Tue, Jun 14, 2022 at 06:17:51AM -0700, Vadim Fedorenko via Linuxptp-devel wrote: > After first timeout of Announce message ptp4l will send Announce > requests messages to all of configured non-master clock peers > without updating timeout on approval packet making huge unneeded > workload on se

Re: [Linuxptp-devel] [PATCH] unicast: Update announce timer when renew

2022-07-25 Thread Richard Cochran
On Mon, Jul 25, 2022 at 10:07:16AM +0200, Miroslav Lichvar wrote: > On Sun, Jul 24, 2022 at 03:49:41PM -0700, Richard Cochran wrote: > > On Tue, Jun 14, 2022 at 06:17:51AM -0700, Vadim Fedorenko via > > Linuxptp-devel wrote: > > > @@ -467,6 +467,7 @@ void unicast_cli

Re: [Linuxptp-devel] [PATCH] G.8275.2 support for delay_mechanism NO_MECHANISM

2022-07-25 Thread Richard Cochran
On Mon, Jul 25, 2022 at 02:09:15PM +0530, Devasish Dey wrote: > > Can you please explain what this extra test accomplishes? > > > [Devasish]: This is to enable ts_proc to use t1 and t2 for > tsproc_update_offset. As of now if the initial delay is zero it returns an > error. Got it. Thanks, Richa

Re: [Linuxptp-devel] [PATCH 1/1 v3] Strip PRP trailer

2022-07-24 Thread Richard Cochran
On Thu, Jul 14, 2022 at 11:45:04AM +0200, Miroslav Lichvar wrote: > On Thu, Jul 14, 2022 at 12:24:39PM +0300, Magnus Armholt wrote: > > Strip the IEC62439-3 PRP trailer if it is present > > to support PTP over PRP. > > The implementation is very pedantic about > > trailing bytes and will indicate b

Re: [Linuxptp-devel] [PATCH v2] phc2sys: Allow multiple sink clocks

2022-07-24 Thread Richard Cochran
On Thu, Jun 23, 2022 at 05:34:02PM +0200, Maciek Machnikowski wrote: > Currently, if the -c parameter is used multiple times only the last > clock will be synchronized and no error will be returned. > > This patch implements proper support for multiple -c parameter and will > synchronize all clock

Re: [Linuxptp-devel] [PATCH v3] phc2sys: Add support for free-running mode

2022-07-24 Thread Richard Cochran
On Tue, Jun 21, 2022 at 12:16:40PM +0200, Maciek Machnikowski wrote: > @@ -544,6 +546,9 @@ static void update_clock(struct phc2sys_private *priv, > struct clock *clock, > > offset += get_sync_offset(priv, clock); > > + if (priv->free_running) > + goto report; I think th

Re: [Linuxptp-devel] [PATCH 1/1] Add new ptp capability.

2022-07-24 Thread Richard Cochran
On Mon, Jul 04, 2022 at 04:21:50PM +0200, Erez Geva wrote: > Add new adjust phase support flag to the phc control tool. > > Signed-off-by: Erez Geva Applied, with a trivial grammar correction. Thanks, Richard ___ Linuxptp-devel mailing list Linuxptp

Re: [Linuxptp-devel] [PATCH] port: Disable PHC switch with vclocks.

2022-07-24 Thread Richard Cochran
On Thu, Jul 14, 2022 at 05:19:31PM +0200, Miroslav Lichvar wrote: > With a virtual PHC, don't try to switch to the physical PHC after a > link-state change. JBOD and other multi-PHC configurations are not > supported with vclocks yet. > > Signed-off-by: Miroslav Lichvar The code moved to port_ch

Re: [Linuxptp-devel] [PATCH] Inclusion of a virtual PTP port on a PTP clock

2022-07-24 Thread Richard Cochran
On Fri, Jun 17, 2022 at 02:55:02PM +0530, SyncMonk Technologies wrote: > As per G.8275 (Annex-B) including virtual PTP ports on a PTP clock. This > virtual port will be used to support APTS, IWF between different > clock_domains. What the heck is a "virtual PTP port"? Is that anything like a Spec

Re: [Linuxptp-devel] [PATCH] Inclusion of a virtual PTP port on a PTP clock

2022-07-24 Thread Richard Cochran
On Fri, Jun 17, 2022 at 02:55:02PM +0530, SyncMonk Technologies wrote: > +static int vport_recv(struct transport *t, int fd, void *buf, int buflen, > + struct address *addr, struct hw_timestamp *hwts) > +{ > + int cnt; > + struct vport *vport = container_of(t, struct vport,

Re: [Linuxptp-devel] [PATCH] unicast: Update announce timer when renew

2022-07-24 Thread Richard Cochran
On Tue, Jun 14, 2022 at 06:17:51AM -0700, Vadim Fedorenko via Linuxptp-devel wrote: > After first timeout of Announce message ptp4l will send Announce > requests messages to all of configured non-master clock peers > without updating timeout on approval packet making huge unneeded > workload on se

Re: [Linuxptp-devel] [PATCH] G.8275.2 support for delay_mechanism NO_MECHANISM

2022-07-24 Thread Richard Cochran
On Fri, Jun 03, 2022 at 05:00:24PM +0530, SyncMonk Technologies wrote: > @@ -1996,8 +1996,10 @@ static void handle_state_decision_event(struct clock > *c) > if (c->sanity_check) > clockcheck_reset(c->sanity_check); > tsproc_reset(c->tsproc, 1); >

Re: [Linuxptp-devel] [PATCH] Add new management TLVs to pmc.8

2022-07-24 Thread Richard Cochran
On Wed, Jun 01, 2022 at 05:32:33AM -0700, Alexander Bulimov via Linuxptp-devel wrote: > As far as I can tell, three new management TLVs were added recently > without updating the pmc.8 man page: > * PORT_SERVICE_STATS_NP > * UNICAST_MASTER_TABLE_NP > * PORT_HWCLOCK_NP > > This simple change fixes

Re: [Linuxptp-devel] [PATCHv7 0/3] add VLAN over bond support

2022-07-24 Thread Richard Cochran
On Wed, May 25, 2022 at 02:46:13PM +0800, Hangbin Liu wrote: > Latest Linux kernel has supported getting PHC from bond directly. This > would help topology like VLAN over bond to get PHC natively. To achieve > this, the new hwtstamp flag is needed when passing hwtstamp_config to > kernel. Let's sup

Re: [Linuxptp-devel] [PATCHv3 0/5] Handle temporary errors in reading of PHC

2022-07-24 Thread Richard Cochran
On Wed, May 18, 2022 at 11:33:33AM +0200, Miroslav Lichvar wrote: > v3: > - limited ignored errors to EBUSY > - requires new patch for clockadj_compare() > - reduced number of retries from 99 to 2 > - changed log level of non-EOPNOTSUPP ioctl error messages > > v2: > - added patches to make prob

Re: [Linuxptp-devel] [PATCHv3 2/8] rtnl: Add function to detect virtual clocks.

2022-07-24 Thread Richard Cochran
On Sun, Jul 24, 2022 at 07:34:10AM -0700, Richard Cochran wrote: ># bonus: native compile with older kernel headers: >cd ~/git/linux >git checkout v3.0 >make INSTALL_HDR_PATH=~/build/linuxptp/l3oh headers_install forgot a step: mkdir ~/build/linuxptp/l3oh/usr mv ~/bu

Re: [Linuxptp-devel] [PATCHv3 2/8] rtnl: Add function to detect virtual clocks.

2022-07-24 Thread Richard Cochran
On Mon, May 16, 2022 at 07:54:02PM +0300, Vladimir Oltean wrote: > I also compile the Linux kernel so I won't set KBUILD_OUTPUT unless I > want to garble my toolchain sysroot with junk. Um, the header files that ship with the toolchain are not "junk". They are essential to the compiler (unless yo

Re: [Linuxptp-devel] [PATCH v5 00/13] Dynamic sync direction for ts2phc

2022-07-23 Thread Richard Cochran
On Mon, Mar 07, 2022 at 11:27:02PM +0200, Vladimir Oltean wrote: > Would you mind taking another look at these patches? Sorry about the massive delay. I'm done reviewing now. If you are willing to consider the feed back and re-submit the series, I'll apply it. Thanks, Richard

Re: [Linuxptp-devel] [PATCH v5 13/13] ts2phc_phc_pps_source: make use of new kernel API for perout waveform

2022-07-23 Thread Richard Cochran
On Tue, Nov 23, 2021 at 02:14:21AM +0200, Vladimir Oltean wrote: > This API was introduced for 2 reasons: > > 1. Some hardware can emit PPS signals but not starting from arbitrary >absolute times, but rather just emit at a certain phase offset from >the beginning of each second. We _could_

Re: [Linuxptp-devel] [PATCH v5 12/13] ts2phc: allow PHC PPS sources to be synchronized

2022-07-23 Thread Richard Cochran
On Tue, Nov 23, 2021 at 02:14:20AM +0200, Vladimir Oltean wrote: > Now that we are registering a clock even for the PPS source when it > supports that (i.e. when it is a PHC), introduce a new API to retrieve > its clock in order to add timestamps to it. > > The timestamps are a mere approximation.

Re: [Linuxptp-devel] [PATCH] phc2sys: Add support for free-running mode

2022-06-20 Thread Richard Cochran
On Mon, Jun 20, 2022 at 03:02:24PM +0200, Maciek Machnikowski wrote: > Add support for the free-running mode that will not adjust the sink > clock when enabled. Nice. This is useful, especially for testing/validation. I've hacked this in myself time and again, but I was too lazy to make a patch!

Re: [Linuxptp-devel] S2 State

2022-06-17 Thread Richard Cochran
On Fri, Jun 17, 2022 at 09:43:23AM -0700, Dave Fish wrote: > What determines if a connection is in the S2 state? /** * The servo is not yet ready to track the master clock. */ s0 SERVO_UNLOCKED, /** * The is ready to track and requests a clock jump

<    1   2   3   4   5   6   7   8   9   10   >