Re: [Linuxptp-devel] [PATCH 1/1] Fix SLAVE_ONLY TLV

2021-04-17 Thread Richard Cochran
On Tue, Mar 30, 2021 at 01:26:19AM +0200, Erez Geva wrote: > According to IEEE 1588 The slave only flag in the SLAVE_ONLY TLV > is bit 0 and not bit 1 as in the DEFAULT_DATA_SET TLV. > > In pmc we can simply print the value. > According to IEEE 1588 the other bits are zero. > When pmc query old p

[Linuxptp-devel] [PATCH 1/1] Fix SLAVE_ONLY TLV

2021-03-29 Thread Erez Geva
According to IEEE 1588 The slave only flag in the SLAVE_ONLY TLV is bit 0 and not bit 1 as in the DEFAULT_DATA_SET TLV. In pmc we can simply print the value. According to IEEE 1588 the other bits are zero. When pmc query old ptp4l it will print 2 instead of 1. Signed-off-by: Erez Geva --- cloc

Re: [Linuxptp-devel] [PATCH 1/1] Fix SLAVE_ONLY TLV

2021-03-28 Thread Richard Cochran
On Mon, Mar 22, 2021 at 04:31:43PM +0100, Erez Geva wrote: > According to IEEE 1588 The slave only flag in the SLAVE_ONLY TLV > is bit 0 and not bit 1 as in the DEFAULT_DATA_SET TLV. > > To retain backward compatibility and as bit 1 in SLAVE_ONLY > is not used anyway. Read and set both bits with

Re: [Linuxptp-devel] [PATCH 1/1] Fix SLAVE_ONLY TLV

2021-03-22 Thread Geva, Erez
On 22/03/2021 16:31, Erez Geva wrote: > According to IEEE 1588 The slave only flag in the SLAVE_ONLY TLV > is bit 0 and not bit 1 as in the DEFAULT_DATA_SET TLV. > > To retain backward compatibility and as bit 1 in SLAVE_ONLY > is not used anyway. Read and set both bits with same value. > ---

[Linuxptp-devel] [PATCH 1/1] Fix SLAVE_ONLY TLV

2021-03-22 Thread Erez Geva
According to IEEE 1588 The slave only flag in the SLAVE_ONLY TLV is bit 0 and not bit 1 as in the DEFAULT_DATA_SET TLV. To retain backward compatibility and as bit 1 in SLAVE_ONLY is not used anyway. Read and set both bits with same value. --- clock.c | 2 +- pmc.c | 2 +- 2 files changed, 2