Re: [Linuxptp-devel] [PATCH RFC 0/4] Time stamp asymmetry correction

2014-12-10 Thread Delio Brignoli
Hello Jiri, On 10 Dec 2014, at 09:10, Jiri Benc jb...@redhat.com wrote: On Mon, 8 Dec 2014 14:04:56 +0100, Delio Brignoli wrote: Yes, I was thinking it would allow to query if the driver supports this feature and get/set current offsets. I agree. That way, with correctly implemented

Re: [Linuxptp-devel] [PATCH RFC 0/4] Time stamp asymmetry correction

2014-12-10 Thread Richard Cochran
On Wed, Dec 10, 2014 at 10:20:06AM +0100, Jiri Benc wrote: actual addition/subtraction should be indeed done in ptp4l. It also seems that ptp4l will need to listen for link change events. Or this can be done by a helper program. Thanks, Richard

Re: [Linuxptp-devel] [PATCH RFC 0/4] Time stamp asymmetry correction

2014-12-10 Thread Keller, Jacob E
-Original Message- From: Jiri Benc [mailto:jb...@redhat.com] Sent: Wednesday, December 10, 2014 12:11 AM To: Delio Brignoli Cc: linuxptp-devel@lists.sourceforge.net Subject: Re: [Linuxptp-devel] [PATCH RFC 0/4] Time stamp asymmetry correction On Mon, 8 Dec 2014 14:04:56 +0100

Re: [Linuxptp-devel] [PATCH RFC 0/4] Time stamp asymmetry correction

2014-12-10 Thread Keller, Jacob E
-Original Message- From: Richard Cochran [mailto:richardcoch...@gmail.com] Sent: Wednesday, December 10, 2014 7:54 AM To: Jiri Benc Cc: linuxptp-devel@lists.sourceforge.net Subject: Re: [Linuxptp-devel] [PATCH RFC 0/4] Time stamp asymmetry correction On Wed, Dec 10, 2014 at 10:20

Re: [Linuxptp-devel] [PATCH RFC 0/4] Time stamp asymmetry correction

2014-12-08 Thread Delio Brignoli
Hello Richard, We implemented this correction in our driver using a private IOCTL and it would have been nice to have used some standardised interface instead. However, I think timestamp correction belongs in the PHY’s driver (or whatever is doing the times-tamping). Data sheets report

Re: [Linuxptp-devel] [PATCH RFC 0/4] Time stamp asymmetry correction

2014-12-08 Thread Delio Brignoli
Hi Richard, On 08 Dec 2014, at 13:33, Richard Cochran richardcoch...@gmail.com wrote: […] Because providing corrections in-kernel will be spotty at best, maybe it better just to say, Linux drivers do *not* correct these delays. At leas that makes things consistent. Otherwise end users will