Re: [Linuxptp-devel] [PATCH v2 10/27] Custom management TLV PORT_ENUMERATION_NP

2014-04-07 Thread Richard Cochran
On Mon, Apr 07, 2014 at 06:02:13PM +0200, Jiri Benc wrote: > On Sat, 5 Apr 2014 13:02:14 +0200, Richard Cochran wrote: > > > +struct port_enumeration_np { > > > + UInteger16 numberPorts; > > > + UInteger16 portNumber[0]; > > > +} PACKED; > > > + > > > > I don't like this variable sized message. We

Re: [Linuxptp-devel] [PATCH v2 10/27] Custom management TLV PORT_ENUMERATION_NP

2014-04-07 Thread Jiri Benc
On Sat, 5 Apr 2014 13:02:14 +0200, Richard Cochran wrote: > > +struct port_enumeration_np { > > + UInteger16 numberPorts; > > + UInteger16 portNumber[0]; > > +} PACKED; > > + > > I don't like this variable sized message. We should stick to fixed > sized items. Why do we need this at all? The

Re: [Linuxptp-devel] [PATCH v2 10/27] Custom management TLV PORT_ENUMERATION_NP

2014-04-05 Thread Richard Cochran
On Mon, Mar 24, 2014 at 09:53:27AM +0100, Jiri Benc wrote: > Used to enumerate all ports. With the future dynamic port adding/removal, > there may be holes in the port number sequence. For now, just fill it with > the sequence numbers. > > Signed-off-by: Jiri Benc > --- > clock.c | 16

[Linuxptp-devel] [PATCH v2 10/27] Custom management TLV PORT_ENUMERATION_NP

2014-03-24 Thread Jiri Benc
Used to enumerate all ports. With the future dynamic port adding/removal, there may be holes in the port number sequence. For now, just fill it with the sequence numbers. Signed-off-by: Jiri Benc --- clock.c | 16 tlv.c | 29 + tlv.h |6 ++