- support getting counters of port RX/TX messages
- support set(clear) counters of port RX/TX messages
Signed-off-by: Mykola Zhuravel
---
clock.c | 1 +
pmc.c| 45 ++
pmc_common.c | 3 +++
port.c | 71 ++
On Wed, Jul 19, 2017 at 06:40:35PM +0300, Mykola Zhuravel wrote:
> - support getting counters of port RX/TX messages
> - support set(clear) counters of port RX/TX messages
This patch adds too many thing at once. It really should be a series,
step by step.
The naming is terrible. "port_counters"
> -Original Message-
> From: Hangbin Liu [mailto:liuhang...@gmail.com]
> Sent: Tuesday, July 18, 2017 8:08 PM
> To: Keller, Jacob E
> Cc: linuxptp-devel@lists.sourceforge.net; Sushil Kulkarni
> ; Jiri Benc
> Subject: Re: [Linuxptp-devel] [PATCHv2 4/9] rtnl: add function rtnl_link_info
>
> -Original Message-
> From: Richard Cochran [mailto:richardcoch...@gmail.com]
> Sent: Tuesday, July 18, 2017 10:52 PM
> To: Hangbin Liu
> Cc: Keller, Jacob E ; Sushil Kulkarni
> ; linuxptp-devel@lists.sourceforge.net; Jiri Benc
>
> Subject: Re: [Linuxptp-devel] [PATCHv2 4/9] rtnl: add
On Wed, Jul 19, 2017 at 08:47:43PM +, Keller, Jacob E wrote:
> if (rtnl_link_query(fd, index))
> err = -1;
> else if (rtnl_link_status(fd, NULL, iface->ts_iface))
> err = -1;
This is poor practice, because you clobber the code returned from
the sub-routine that experienced the error.
