Re: [Linuxptp-users] Overflow issue for 32bit machines: ptp_clock_info.max_adj versus timex.freq

2022-10-06 Thread Miroslav Lichvar
On Thu, Oct 06, 2022 at 09:23:57AM +0200, Janusz Użycki wrote: > OK. The issue is not related to linuxptp v3.1. Thank you for pointing the > clamp. > Is it common for phc2sys and ts2phc also ? I see a phc_max_adj() call in both phc2sys and ts2phc, so I'd expect them to handle it correctly. -- Mi

Re: [Linuxptp-users] Overflow issue for 32bit machines: ptp_clock_info.max_adj versus timex.freq

2022-10-06 Thread Janusz Użycki
OK. The issue is not related to linuxptp v3.1. Thank you for pointing the clamp. Is it common for phc2sys and ts2phc also ? best regards Janusz W dniu 06/10/2022 o 09:19, Janusz Użycki pisze: On Thu, Oct 06, 2022 at 12:11:39AM +0200, Janusz Użycki wrote: Hi. A lot of PTP/PHC drivers set

Re: [Linuxptp-users] Overflow issue for 32bit machines: ptp_clock_info.max_adj versus timex.freq

2022-10-06 Thread Janusz Użycki
On Thu, Oct 06, 2022 at 12:11:39AM +0200, Janusz Użycki wrote: Hi. A lot of PTP/PHC drivers set max_adj value quite big. Howover due to kernel's API limit of 32bit long type value (freq) and POSIX frequency conversion it should limited to 32767999 ppb. It concerns the frequency limit check bo

Re: [Linuxptp-users] Overflow issue for 32bit machines: ptp_clock_info.max_adj versus timex.freq

2022-10-06 Thread Miroslav Lichvar
On Thu, Oct 06, 2022 at 12:11:39AM +0200, Janusz Użycki wrote: > Hi. > > A lot of PTP/PHC drivers set max_adj value quite big. Howover due to > kernel's API limit of 32bit long type value (freq) and POSIX frequency > conversion it should limited to 32767999 ppb. > > It concerns the frequency limi

Re: [Linuxptp-users] Overflow issue for 32bit machines: ptp_clock_info.max_adj versus timex.freq

2022-10-05 Thread Janusz Użycki
More details: The type of "freq" field in "__kernel_timex" structure is fixed in mainline kernel to "long long" type. However "__kernel_long_t freq" in timex structure depends on machine. Eg. for some machines it see: include/uapi/asm-generic/posix_types.h:typedef long __kernel_long_t; arch/spar

[Linuxptp-users] Overflow issue for 32bit machines: ptp_clock_info.max_adj versus timex.freq

2022-10-05 Thread Janusz Użycki
Hi. A lot of PTP/PHC drivers set max_adj value quite big. Howover due to kernel's API limit of 32bit long type value (freq) and POSIX frequency conversion it should limited to 32767999 ppb. It concerns the frequency limit check both for kernel, testptp and ptp4linux servos. Simply 65.536 * 3