Re: [Linuxsampler-devel] msvc patch

2019-02-18 Thread justnope
On 15/02/2019 16:00, justnope wrote: On 15/02/2019 15:15, Christian Schoenebeck wrote: I suggest that I commit your msvc patch first, and then sure, if you like to adapt the cmakes for other architectures, very much appreciated of course! So your previous patch sent to the list is the

Re: [Linuxsampler-devel] msvc patch

2019-02-15 Thread justnope
On 15/02/2019 15:15, Christian Schoenebeck wrote: I suggest that I commit your msvc patch first, and then sure, if you like to adapt the cmakes for other architectures, very much appreciated of course! So your previous patch sent to the list is the latest one, or should I wait for an updated pat

Re: [Linuxsampler-devel] msvc patch

2019-02-15 Thread justnope
On 14/02/2019 17:03, Christian Schoenebeck wrote: Ok, then just leave the cmake files at their locations as you did. Then later on we try to make them shared ones for other architectures as well. I can adapt the cmake files to build for other systems now if you'd like. This means I'll have to

Re: [Linuxsampler-devel] msvc patch

2019-02-13 Thread justnope
I found a mistake which resulted in a compile error when I tried it with gcc, added an install option in the cmake file and split it into libgig & libakai so it's the same as the makefile. On 12/02/2019 17:37, Christian Schoenebeck wrote: Looks fine to me. Just one last thing: You added CMake

[Linuxsampler-devel] msvc patch

2019-02-11 Thread justnope
Hi, Could you check the attached patch for possible mistakes or things you'd like to see implemented differently? About the directory functions (opendir,...), I'm currently also porting zynaddsubfx to msvc and have a partial implementation ready. As soon as it's complete, tested and approved

Re: [Linuxsampler-devel] msvc patch

2019-02-07 Thread justnope
> Yes, that makes sense. Would you also share your real name so I can credit you > for your patch? I'm fine with being uncredited or using justnope. Another thing I noticed but I'm unable to test is that in Serialization.cpp the return value of abi::__cxa_demangle isn

Re: [Linuxsampler-devel] msvc patch (out-of-band patch)

2019-02-03 Thread justnope
Hi, This patch has nothing directly to do with the msvc development. I noticed it when I was trying out the GigWriteTest. Depending on the constructor, RIFF:File can be allocated by the constructor or passed on. In case DLS::File allocates RIFF::File itself, it never gets destroyed. This res

Re: [Linuxsampler-devel] msvc patch

2019-02-01 Thread justnope
included in every version of windows. Another option was to use boost, I thought it included a demangler. The advantage is that it is cross platform, but maybe it's a bit too heavy handed. I don't know what your thoughts are on using boost. If it's ok, I've made a projec

[Linuxsampler-devel] msvc patch

2019-01-28 Thread justnope
Hi, This is a first attempt to compile the library with msvc. The changes are: * ssize_t -> size_t * vasprintf -> vsnprintf, malloc, sprintf * removed unavailable headers * added cmake file To compile it, use cmake . This will generate a visual studio solution file which you can open and build

[Linuxsampler-devel] msvc patch

2019-01-28 Thread justnope
Hi, This is a first attempt to compile the library with msvc. The changes are: * ssize_t -> size_t * vasprintf -> vsnprintf, malloc, sprintf * removed unavailable headers * added cmake file To compile it, use cmake . This will generate a visual studio solution file which you can open and build