> Ok, I have reviewed your patch. There are several issues with your suggested
> patch, some which you already pointed out, but also you are doing things which
> are not real-time safe, and overall it simply looks like more changes than
> actually required.
I think that there's no need for a voice
On Freitag, 8. März 2019 05:45:38 CET Jacek Roszkowski wrote:
> This is my second approach to handling polyphony. I'm not submitting
> it into bugzilla, since I'm not sure if that's the way it should be
> resolved. It works for me, but it's not thoroughly tested even for my
> needs.
Ok, I have rev
Hi.
This is my second approach to handling polyphony. I'm not submitting
it into bugzilla, since I'm not sure if that's the way it should be
resolved. It works for me, but it's not thoroughly tested even for my
needs.
These are my concerns.
1. It can't be implemented in AbstractEngineChannel, be
pon., 25 lut 2019 o 21:37 Christian Schoenebeck
napisał(a):
> What do you mean with common interface released?
By final solution and common interface I thought about adding
parameters you have already mentioned (amount of voices per key group,
and whether a key group shall use a soft release or
On Montag, 25. Februar 2019 21:05:22 CET Jacek Roszkowski wrote:
> pon., 25 lut 2019 o 19:10 Christian Schoenebeck
>
> napisał(a):
> > From what you described so far, I don't see why you would need to open a
> > separate concept to the existing key group conflict concept. As far as I
> > can see
pon., 25 lut 2019 o 19:10 Christian Schoenebeck
napisał(a):
> From what you described so far, I don't see why you would need to open a
> separate concept to the existing key group conflict concept. As far as I can
> see it, the key group concept just would need some additional options for
> allow
On Montag, 25. Februar 2019 16:56:33 CET Jacek Roszkowski wrote:
> napisał(a):
> > Then it might make sense to extend the existing key group handling code by
> > optionally using the number provided by the patch. You might want to have
> > a
> > look at AbstractEngineChannel::HandleKeyGroupConflic
niedz., 24 lut 2019 o 23:34 Christian Schoenebeck
napisał(a):
> Then it might make sense to extend the existing key group handling code by
> optionally using the number provided by the patch. You might want to have a
> look at AbstractEngineChannel::HandleKeyGroupConflicts().
That method was my s
On Sonntag, 24. Februar 2019 19:26:57 CET Jacek Roszkowski wrote:
> > Having said, your intention is to extend this existing feature for
> > optionally raising the amount of active notes in a key group to
> > another higher value than just 1, is that correct?
>
> Yes, it's correct. With sfz 2 form
niedz., 24 lut 2019 o 18:38 Christian Schoenebeck <
[email protected]> napisał(a):
> Mja, the thing is that src/engines/sfz/EngineChannel.cpp is usually not
the
> right place for doing such core engine event handling that you attempt
with
> your patch. The source files dediciated for the
On Sonntag, 24. Februar 2019 17:30:15 CET Jacek Roszkowski wrote:
> I'm sorry. I forgot to include the attachment file. Now I've also
> found out that it compiles only with developer mode enabled. Otherwise
> it fails, because the required interface is not public:
>
> EngineChannel.cpp:250:52: err
It seems that I'm also not familiar with mailing lists. Excuse me for
writing replies to your personal e-mail. I've sent them once more to
the list.
Regards
Jacek Roszkowski
___
Linuxsampler-devel mailing list
[email protected]
h
niedz., 24 lut 2019 o 16:46 Christian Schoenebeck
napisał(a):
> Please do me a favour, if you want something to be applied on our side, then
> please provide either a patch or link to an appropriate patch against our SVN
> trunk with exactly the changes you want to be applied.
I'm sorry. I forgot
On Sonntag, 24. Februar 2019 16:22:11 CET Jacek Roszkowski wrote:
> I needed more control over my samples with polyphony and
> note_polyphony opcodes. I'm not familiar with linuxsampler internals,
> but I've managed to create this patch to add support for those. It
> works for me on Raspberry Pi.
Hi.
I needed more control over my samples with polyphony and
note_polyphony opcodes. I'm not familiar with linuxsampler internals,
but I've managed to create this patch to add support for those. It
works for me on Raspberry Pi.
It's hosted on github as well:
https://github.com/jarosz/linuxsampler
15 matches
Mail list logo
