This is an automatic generated email to let you know that the following patch 
were queued:

Subject: media: stm32-dcmipp: Remove redundant printk
Author:  Ricardo Ribalda <riba...@chromium.org>
Date:    Mon Apr 29 16:04:45 2024 +0100

platform_get_irq() already prints an error message.

Also platform_get_irq() can never return 0, so lets fix the condition
now that we are at it.

Found by cocci:
drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c:444:3-10: line 444 
is redundant because platform_get_irq() already prints an error

Link: 
https://lore.kernel.org/linux-media/20240429-fix-cocci-v3-6-3c4865f5a...@chromium.org
Signed-off-by: Ricardo Ribalda <riba...@chromium.org>
Signed-off-by: Mauro Carvalho Chehab <mche...@kernel.org>

 drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

---

diff --git a/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c 
b/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c
index bce821eb71ce..4acc3b90d03a 100644
--- a/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c
+++ b/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c
@@ -439,11 +439,8 @@ static int dcmipp_probe(struct platform_device *pdev)
                                     "Could not get reset control\n");
 
        irq = platform_get_irq(pdev, 0);
-       if (irq <= 0) {
-               if (irq != -EPROBE_DEFER)
-                       dev_err(&pdev->dev, "Could not get irq\n");
-               return irq ? irq : -ENXIO;
-       }
+       if (irq < 0)
+               return irq;
 
        dcmipp->regs = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
        if (IS_ERR(dcmipp->regs)) {

Reply via email to