Re: [Linuxwacom-devel] ISDV4 rework

2010-03-08 Thread Peter Hutterer
On Mon, Mar 08, 2010 at 10:13:49PM -0800, Ping Cheng wrote: > On Mon, Mar 8, 2010 at 9:43 PM, Peter Hutterer > wrote: > > > I think I may have it now, thanks much for the pointers. The patch is > > attached but it also needs a revert of the "Remove superfluous > > packet-length > > assignment" pa

Re: [Linuxwacom-devel] ISDV4 rework

2010-03-08 Thread Ping Cheng
On Mon, Mar 8, 2010 at 9:43 PM, Peter Hutterer wrote: > On Mon, Mar 08, 2010 at 12:16:00PM -0600, Chris Bagwell wrote: > > Have we verified yet if these ISDV4 devices return 2 sizes of packets? > > The logic in isdv4Parse() reads to me like it must or else your only > > going to be able to parse

Re: [Linuxwacom-devel] ISDV4 rework

2010-03-08 Thread Peter Hutterer
On Mon, Mar 08, 2010 at 12:16:00PM -0600, Chris Bagwell wrote: > Have we verified yet if these ISDV4 devices return 2 sizes of packets? > The logic in isdv4Parse() reads to me like it must or else your only > going to be able to parse pen data or touch data but not both. > > This development bran

Re: [Linuxwacom-devel] [PATCH] use kernel multi-touch input for bamboo touches

2010-03-08 Thread Ping Cheng
Hi Chris, I see your point. But I need to get in touch with kernel input tree maintainer to see what's they think. This may take some time. So, your patchset will not be considered in -11 since I am planning, I used this phrase more than once :(, to post it soon. Did you test your patch (I gues

[Linuxwacom-devel] [PATCH] use kernel multi-touch input for bamboo touches

2010-03-08 Thread chris
From: Chris Bagwell Bamboo P&T code supports multi-touch but is using the standard input driver's ABS_X/Y/PRESSURE which filters duplicate events since it does not know they are unrelated. Its also using Wacom-specific "serial channels" concept to inform X driver which finger is currently being s

[Linuxwacom-devel] [PATCH] Replacement patch for lost kernel events

2010-03-08 Thread chris
From: Chris Bagwell The following patch is meant as a replacement to my previous patch to overcome lost events when 2 fingers had same X/Y/PRESSURE values between them. This uses standard kernel solution that I somehow missed while previously reviewing input layer (MT = Multi-Touch!) This requi

Re: [Linuxwacom-devel] ISDV4 rework

2010-03-08 Thread Ping Cheng
Chris is correct. The packet length is a dynamic runtime value since a touch data could be followed by a pen data or vice versa. So, depending on what kind of data we are getting, the size can be 9 (pen), 5 (1FGT) , or 13 (2FGT) . There are three packet lengths for ISDv4. Ping On Mon, Mar 8,

Re: [Linuxwacom-devel] ISDV4 rework

2010-03-08 Thread Chris Bagwell
Have we verified yet if these ISDV4 devices return 2 sizes of packets? The logic in isdv4Parse() reads to me like it must or else your only going to be able to parse pen data or touch data but not both. This development branch changes things so that packet size is only computed in isdv4GetRanges(

Re: [Linuxwacom-devel] ISDV4 rework

2010-03-08 Thread Peter Hutterer
On Mon, Mar 08, 2010 at 02:40:17AM -0500, Thomas Jaeger wrote: > I see a regression introduced in dc513e8e1e6813e6d8d0f101a56fbf1b2f388dbc: > Strokes are noticeably less smooth, they look more like sequences of > line segments. My guess is that this is either due to increased jitter > or to a redu