Re: [Linuxwacom-devel] [PATCH 2/4] Set WCM_PEN feature based on wcmKeys

2011-01-11 Thread Chris Bagwell
On Tue, Jan 11, 2011 at 10:12 PM, Ping Cheng wrote: > On Tue, Jan 11, 2011 at 8:07 PM, Chris Bagwell wrote: >> On Tue, Jan 11, 2011 at 10:03 PM, Ping Cheng wrote: >>> On Tue, Jan 11, 2011 at 5:34 PM,   wrote: From: Chris Bagwell A previous commit removed all bamboo ID's which cau

Re: [Linuxwacom-devel] [PATCH 2/4] Set WCM_PEN feature based on wcmKeys

2011-01-11 Thread Ping Cheng
On Tue, Jan 11, 2011 at 8:07 PM, Chris Bagwell wrote: > On Tue, Jan 11, 2011 at 10:03 PM, Ping Cheng wrote: >> On Tue, Jan 11, 2011 at 5:34 PM,   wrote: >>> From: Chris Bagwell >>> >>> A previous commit removed all bamboo ID's which caused it >>> to hit default statement removed in this patch an

Re: [Linuxwacom-devel] [PATCH 4/4] delete unneeded code in wcmVirtualTabletSize

2011-01-11 Thread Ping Cheng
On Tue, Jan 11, 2011 at 5:34 PM, wrote: > From: Chris Bagwell > > Signed-off-by: Chris Bagwell Reviewed-by: Ping Cheng Ping > --- >  src/xf86Wacom.c |    7 --- >  1 files changed, 0 insertions(+), 7 deletions(-) > > diff --git a/src/xf86Wacom.c b/src/xf86Wacom.c > index 5be8409..078a488

Re: [Linuxwacom-devel] [PATCH 3/4] Init relative X/Y axis to use tablets min/max size

2011-01-11 Thread Ping Cheng
On Tue, Jan 11, 2011 at 5:52 PM, Chris Bagwell wrote: > On Tue, Jan 11, 2011 at 7:34 PM,   wrote: >> From: Chris Bagwell >> >> wcmRotateAndScaleCoordinates() uses these values to scale >> values based on initialized.  The change to use -1..-1 >> caused it to scale to 0 value always and make curso

Re: [Linuxwacom-devel] [PATCH 2/4] Set WCM_PEN feature based on wcmKeys

2011-01-11 Thread Chris Bagwell
On Tue, Jan 11, 2011 at 10:03 PM, Ping Cheng wrote: > On Tue, Jan 11, 2011 at 5:34 PM,   wrote: >> From: Chris Bagwell >> >> A previous commit removed all bamboo ID's which caused it >> to hit default statement removed in this patch and mistakenly >> add WCM_PEN for Bamboo touchpad. >> >> That fl

Re: [Linuxwacom-devel] [PATCH 2/4] Set WCM_PEN feature based on wcmKeys

2011-01-11 Thread Ping Cheng
On Tue, Jan 11, 2011 at 5:34 PM, wrote: > From: Chris Bagwell > > A previous commit removed all bamboo ID's which caused it > to hit default statement removed in this patch and mistakenly > add WCM_PEN for Bamboo touchpad. > > That flag only seems to be used by a debug statement so not > a big d

Re: [Linuxwacom-devel] [PATCH 1/4] Init device_type during ABS_MT_TRACKING_ID

2011-01-11 Thread Ping Cheng
On Tue, Jan 11, 2011 at 5:34 PM, wrote: > From: Chris Bagwell > > ABS_MT_SLOT is normally zero which means it will not be sent > when xf86-input-wacom first starts up normally.  During 2 > finger touch, this event will constantly toggle between > slot 0 and 1. > > Move initialization of device_t

Re: [Linuxwacom-devel] [PATCH 3/4] Init relative X/Y axis to use tablets min/max size

2011-01-11 Thread Chris Bagwell
On Tue, Jan 11, 2011 at 7:34 PM, wrote: > From: Chris Bagwell > > wcmRotateAndScaleCoordinates() uses these values to scale > values based on initialized.  The change to use -1..-1 > caused it to scale to 0 value always and make cursor not > move. Opps, I wrote wrong symptom. The cursor is ove

[Linuxwacom-devel] [PATCH 2/4] Set WCM_PEN feature based on wcmKeys

2011-01-11 Thread chris
From: Chris Bagwell A previous commit removed all bamboo ID's which caused it to hit default statement removed in this patch and mistakenly add WCM_PEN for Bamboo touchpad. That flag only seems to be used by a debug statement so not a big deal unless you want that information out of log file. C

[Linuxwacom-devel] [PATCH 3/4] Init relative X/Y axis to use tablets min/max size

2011-01-11 Thread chris
From: Chris Bagwell wcmRotateAndScaleCoordinates() uses these values to scale values based on initialized. The change to use -1..-1 caused it to scale to 0 value always and make cursor not move. This is probably a revert more then bug fix because it seems standard behavior to init relative to -

[Linuxwacom-devel] [PATCH 1/4] Init device_type during ABS_MT_TRACKING_ID

2011-01-11 Thread chris
From: Chris Bagwell ABS_MT_SLOT is normally zero which means it will not be sent when xf86-input-wacom first starts up normally. During 2 finger touch, this event will constantly toggle between slot 0 and 1. Move initialization of device_type to ABS_MT_TRACKING_ID because its more effecient to

[Linuxwacom-devel] [PATCH 4/4] delete unneeded code in wcmVirtualTabletSize

2011-01-11 Thread chris
From: Chris Bagwell Signed-off-by: Chris Bagwell --- src/xf86Wacom.c |7 --- 1 files changed, 0 insertions(+), 7 deletions(-) diff --git a/src/xf86Wacom.c b/src/xf86Wacom.c index 5be8409..078a488 100644 --- a/src/xf86Wacom.c +++ b/src/xf86Wacom.c @@ -209,13 +209,6 @@ void wcmVirtualTab

[Linuxwacom-devel] [PATCH 0/4] Initial fixes for Bamboo regressions

2011-01-11 Thread chris
From: Chris Bagwell This patch series almost fixes all the recent regressions that made Bamboo touchpad stot working. I still need this hack added to top of wcmMappingFactor() to get it working: + /* FIXME */ + priv->maxWidth = priv->maxX; + priv->maxHeight = priv->maxY; Sin

Re: [Linuxwacom-devel] Bamboo P&T touch broken with new commits?

2011-01-11 Thread Peter Hutterer
On Mon, Jan 10, 2011 at 07:20:29PM -0600, Chris Bagwell wrote: > Here is what my bisect turns up: > > At this commit, the cursor becomes overly accelerated or jumpy: > > 1e4d3d7060a1c438ac619cb64febb44bc45b47ed > Remove wcmInitialCoordiantes, move into wcmInitAxes > > At this commit, it always s

Re: [Linuxwacom-devel] Functional responsibility of code

2011-01-11 Thread Favux ...
Hi Peter, It was originally posted by Christoph in linuxwacom-devel: http://sourceforge.net/mailarchive/forum.php?thread_name=AANLkTimO9QX5%3Dx1VGNRVNkLiHLyULtvcav%3DXzimfgedx%40mail.gmail.com&forum_name=linuxwacom-devel Sanette's modifications (two so far) are posted at Ubuntu forums. It's one o

Re: [Linuxwacom-devel] Functional responsibility of code

2011-01-11 Thread Peter Hutterer
On Tue, Jan 11, 2011 at 05:53:01PM +0100, Cedric Sodhi wrote: > I'd like to address the issue of LEDs in this separate thread. The > solution that is provided by Christoph Karg's utility is a great step > forward, given that we can now use the OLEDs at all, but it's also in > several areas problema

Re: [Linuxwacom-devel] [PATCH] Remove one duplicate default option setting.

2011-01-11 Thread Peter Hutterer
On Tue, Jan 11, 2011 at 11:31:58AM -0600, Chris Bagwell wrote: > Reviewed-by: Chris Bagwell > > On a related note, several of the *Default variables can probably be > converted to constants (#defines). It seems only useful as a variable > for cases were there is a hardware specific default value

Re: [Linuxwacom-devel] Using the pen as Airbrush

2011-01-11 Thread Nikolai Kondrashov
On 01/11/2011 09:52 PM, Ping Cheng wrote: > I am not sure if I understand the questions correctly or not. The > value reported through ABS_DISTANCE from the kernel is the raw > distance. For clients that sit on top of X server, we > (xf86-input-wacom) need to pass those vaules to XI through valuato

Re: [Linuxwacom-devel] Using the pen as Airbrush

2011-01-11 Thread Ping Cheng
On Tue, Jan 11, 2011 at 1:37 AM, Nikolai Kondrashov wrote: > On Tue, Jan 11, 2011 at 4:07 AM, Peter Hutterer > wrote: >> it's a different axis. so instead of x, y, pressure, ... you get x, y, >> pressure, distance, ... >> that's the correct integration, mix-and-match with other axes will just com

Re: [Linuxwacom-devel] Using the pen as Airbrush

2011-01-11 Thread Ping Cheng
On Mon, Jan 10, 2011 at 5:12 PM, Peter Hutterer wrote: > On Mon, Jan 10, 2011 at 11:34:55AM -0800, Ping Cheng wrote: >> On Mon, Jan 10, 2011 at 3:10 AM, Cedric Sodhi wrote: >> > On Mon, Jan 10, 2011 at 09:16:14AM +1000, Peter Hutterer wrote: >> >> On Sat, Jan 08, 2011 at 11:51:41AM +0100, Cedric

Re: [Linuxwacom-devel] [PATCH 0/7] TPC button fixes

2011-01-11 Thread Chris Bagwell
For the series: Reviewed-by: Chris Bagwell On Mon, Jan 10, 2011 at 8:12 PM, Peter Hutterer wrote: > > I noticed that on my I4, the TPCButton setting didn't do anything > whatsoever. This was likely due to 4/7, but because I'm trying to implement > a different feature and this code was a tad co

Re: [Linuxwacom-devel] [PATCH] Remove one duplicate default option setting.

2011-01-11 Thread Chris Bagwell
Reviewed-by: Chris Bagwell On a related note, several of the *Default variables can probably be converted to constants (#defines). It seems only useful as a variable for cases were there is a hardware specific default value. This variable may one day be that case. I can see how default should

Re: [Linuxwacom-devel] [PATCH] Abstract USB device check through a macro.

2011-01-11 Thread Chris Bagwell
I'm not really sure some of those USB checks should even be there... but thats not the point of this patch, so: Reviewed-by: Chris Bagwell On Mon, Jan 10, 2011 at 8:07 PM, Peter Hutterer wrote: > Signed-off-by: Peter Hutterer > --- >  src/wcmCommon.c         |    8 >  src/wcmValidate

Re: [Linuxwacom-devel] [PATCH] Split re-used oldButton into self-explanatory variables.

2011-01-11 Thread Chris Bagwell
Reviewed-by: Chris Bagwell On Mon, Jan 10, 2011 at 8:06 PM, Peter Hutterer wrote: > Much nicer to read, especially when viewed in patch context only. > > Signed-off-by: Peter Hutterer > --- >  src/wcmValidateDevice.c |   37 + >  1 files changed, 21 insertion

[Linuxwacom-devel] Functional responsibility of code

2011-01-11 Thread Cedric Sodhi
Hello, I'd like to address the issue of LEDs in this separate thread. The solution that is provided by Christoph Karg's utility is a great step forward, given that we can now use the OLEDs at all, but it's also in several areas problematic: -> The utility interferes with the kernel driver, requir

Re: [Linuxwacom-devel] Using the pen as Airbrush

2011-01-11 Thread Nikolai Kondrashov
On Tue, Jan 11, 2011 at 4:07 AM, Peter Hutterer wrote: > it's a different axis. so instead of x, y, pressure, ... you get x, y, > pressure, distance, ... > that's the correct integration, mix-and-match with other axes will just come > back to bite us in the future.. Do you know anything about ABS_