Re: [Linuxwacom-devel] [PATCH] Re-vamp source inclusion for test build suite.

2011-03-12 Thread Ping Cheng
On Sat, Mar 12, 2011 at 6:06 AM, Eduard Hasenleithner wrote: > Hi Ping > > 2011/3/12 Ping Cheng : > > Do you mind testing the patch and sending a "Tested-by" to the list if it > > does the job for you? > > Thanks for the notice, I did not yet completely understand how the > development for xf86-in

Re: [Linuxwacom-devel] [PATCH v2 5/5] Add tests for convert_value_from_user

2011-03-12 Thread Chris Bagwell
If you make change in 1/5 from my comment then: Reviewed-by: Chris Bagwell Chris On Fri, Mar 11, 2011 at 5:13 PM, Jason Gerecke wrote: > Some basic tests to ensure booleans and non-booleans act like we > want them to. > > Signed-off-by: Jason Gerecke > --- >  tools/xsetwacom.c |   43

Re: [Linuxwacom-devel] [PATCH v2 1/5] Change signature of convert_value_from_user

2011-03-12 Thread Chris Bagwell
On Fri, Mar 11, 2011 at 5:13 PM, Jason Gerecke wrote: > Have it return true/false to indicate conversion success/failure. > Note that in its current state the function cannot tell if there > was a conversion failure... > > Signed-off-by: Jason Gerecke > --- >  tools/xsetwacom.c |   47 +++

Re: [Linuxwacom-devel] [PATCH] Re-vamp source inclusion for test build suite.

2011-03-12 Thread Eduard Hasenleithner
2011/3/12 Eduard Hasenleithner : > One thing I can notice is that nothing in the "test" directory is > built automatically when doing make in the root directory. A "make > wacom-tests" in "test" does work though. Ah, I found now the wiki page for TestSuite. "make check" works fine with the patch.

Re: [Linuxwacom-devel] [PATCH] Re-vamp source inclusion for test build suite.

2011-03-12 Thread Eduard Hasenleithner
Hi Ping 2011/3/12 Ping Cheng : > Do you mind testing the patch and sending a "Tested-by" to the list if it > does the job for you? Thanks for the notice, I did not yet completely understand how the development for xf86-input-wacom works. Apparently the patches are not only for documentation purpo