Re: [Linuxwacom-devel] [PATCH] Re-vamp source inclusion for test build suite.

2011-03-12 Thread Eduard Hasenleithner
Hi Ping 2011/3/12 Ping Cheng pingli...@gmail.com: Do you mind testing the patch and sending a Tested-by to the list if it does the job for you? Thanks for the notice, I did not yet completely understand how the development for xf86-input-wacom works. Apparently the patches are not only for

Re: [Linuxwacom-devel] [PATCH v2 1/5] Change signature of convert_value_from_user

2011-03-12 Thread Chris Bagwell
On Fri, Mar 11, 2011 at 5:13 PM, Jason Gerecke killert...@gmail.com wrote: Have it return true/false to indicate conversion success/failure. Note that in its current state the function cannot tell if there was a conversion failure... Signed-off-by: Jason Gerecke killert...@gmail.com ---  

Re: [Linuxwacom-devel] [PATCH v2 5/5] Add tests for convert_value_from_user

2011-03-12 Thread Chris Bagwell
If you make change in 1/5 from my comment then: Reviewed-by: Chris Bagwell ch...@cnpbagwell.com Chris On Fri, Mar 11, 2011 at 5:13 PM, Jason Gerecke killert...@gmail.com wrote: Some basic tests to ensure booleans and non-booleans act like we want them to. Signed-off-by: Jason Gerecke