Re: [Linuxwacom-devel] [PATCH 1/2] Fix X crash after remapping touchstrips and wheels

2011-03-23 Thread Peter Hutterer
On Thu, Mar 24, 2011 at 11:30:35AM +1000, Peter Hutterer wrote: > On Wed, Mar 23, 2011 at 12:58:21PM -0700, Jason Gerecke wrote: > > As I'm working on the X11 wheel mapping, I'm finding a few weird > > quirks in the code. I pretty much understand 'how' things work, but > > I'm not sure why some thi

Re: [Linuxwacom-devel] [PATCH 2/2] ISDV4: use libudev instead of manual syspath creation.

2011-03-23 Thread Ping Cheng
On Thu, Mar 24, 2011 at 9:40 AM, Peter Hutterer wrote: > Signed-off-by: Peter Hutterer > --- > configure.ac|3 ++ > src/Makefile.am |2 +- > src/wcmISDV4.c | 92 > ++ > 3 files changed, 69 insertions(+), 28 deletions(-) > > diff

Re: [Linuxwacom-devel] [PATCH 1/2] ISDV4: udpate a comment, we may return tablet id 0x90 on failure.

2011-03-23 Thread Ping Cheng
Reviewed-by: Ping Cheng Ping On Thu, Mar 24, 2011 at 9:40 AM, Peter Hutterer wrote: > Signed-off-by: Peter Hutterer > --- > src/wcmISDV4.c |6 +- > 1 files changed, 5 insertions(+), 1 deletions(-) > > diff --git a/src/wcmISDV4.c b/src/wcmISDV4.c > index bfa0d0f..bbbfcf0 100644 > --- a

Re: [Linuxwacom-devel] [PATCH] Silence compiler warning.

2011-03-23 Thread Ping Cheng
Reviewed-by: Ping Cheng Ping On Thu, Mar 24, 2011 at 9:20 AM, Peter Hutterer wrote: > ./src/wcmCommon.c: In function 'sendCommonEvents': > ./src/wcmCommon.c:382:2: warning: 'value' may be used uninitialized in this > function [-Wuninitialized] > ./src/wcmCommon.c:329:22: note: 'value' was decla

Re: [Linuxwacom-devel] [draft-patch] OLED setting for xsetwacom

2011-03-23 Thread Peter Hutterer
On Wed, Mar 23, 2011 at 11:36:25AM +0100, Eduard Hasenleithner wrote: > 2011/3/23 Peter Hutterer : > > On Tue, Mar 22, 2011 at 10:47:12PM +0100, Eduard Hasenleithner wrote: > >> For accessing USB-FS, I already considered libusb, just to find out > >> that it does not (yet?) provide the USBDEVFS_IOC

Re: [Linuxwacom-devel] [draft-patch] OLED setting for xsetwacom

2011-03-23 Thread Peter Hutterer
On Wed, Mar 23, 2011 at 01:48:45PM -0500, Favux ... wrote: > usbfs was deprecated in kernel 2.6.31 I think. Certainly by 2.6.32 > Ubuntu (Lucid 10.04) and several other distributions dropped it. This > all happened at about the same time. There was some conflict with > changes in udev. Apparent

Re: [Linuxwacom-devel] Kernel driver for OLED support (was: OLED setting for xsetwacom)

2011-03-23 Thread Peter Hutterer
On Wed, Mar 23, 2011 at 04:42:05PM -0700, Ping Cheng wrote: > On Wed, Mar 23, 2011 at 4:09 PM, Eduard Hasenleithner > wrote: > > > 2011/3/23 Ping Cheng : > > > On Wed, Mar 23, 2011 at 12:55 PM, Eduard Hasenleithner < > > ehase...@gmail.com> > > > wrote: > > >> Now I even tested the linuxwacom/src

Re: [Linuxwacom-devel] [PATCH 3/3] PAD is always on PAD_CHANNEL

2011-03-23 Thread Peter Hutterer
On Wed, Mar 23, 2011 at 02:57:51PM -0700, Ping Cheng wrote: > Don't assume the last tool was a pad, which confuses those tools > that never receive a serial number. Keep PAD on the PAD_CHANNEL. > > Signed-off-by: Ping Cheng merged, thanks. Cheers, Peter > --- > src/wcmUSB.c | 21 -

Re: [Linuxwacom-devel] [PATCH 2/3] Fix a copy/paste error in usbFindDeviceType comment

2011-03-23 Thread Peter Hutterer
On Wed, Mar 23, 2011 at 02:57:33PM -0700, Ping Cheng wrote: > Signed-off-by: Ping Cheng > --- > src/wcmUSB.c |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/wcmUSB.c b/src/wcmUSB.c > index 197d9fc..d58a740 100644 > --- a/src/wcmUSB.c > +++ b/src/wcmUSB.c > @@

Re: [Linuxwacom-devel] [PATCH 1/3 v4] Support pen and MT on the same logical port

2011-03-23 Thread Peter Hutterer
On Wed, Mar 23, 2011 at 02:57:12PM -0700, Ping Cheng wrote: > Serial ISDv4 kernel driver, wacom_w8001.ko, provides both pen and > touch events on the same logical port. Filtering touch events when > pen is in proximity while allowing pen events (ABS_X/Y, etc) pass. > > Making this action configura

[Linuxwacom-devel] [PATCH 2/2] ISDV4: use libudev instead of manual syspath creation.

2011-03-23 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- configure.ac|3 ++ src/Makefile.am |2 +- src/wcmISDV4.c | 92 ++ 3 files changed, 69 insertions(+), 28 deletions(-) diff --git a/configure.ac b/configure.ac index 85ec1a9..1d6ef0f 100644 --- a/c

[Linuxwacom-devel] [PATCH 1/2] ISDV4: udpate a comment, we may return tablet id 0x90 on failure.

2011-03-23 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- src/wcmISDV4.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/src/wcmISDV4.c b/src/wcmISDV4.c index bfa0d0f..bbbfcf0 100644 --- a/src/wcmISDV4.c +++ b/src/wcmISDV4.c @@ -893,7 +893,11 @@ static ISDV4ModelDesc isdv4_models[] = { /

Re: [Linuxwacom-devel] [PATCH 1/2] Fix X crash after remapping touchstrips and wheels

2011-03-23 Thread Peter Hutterer
On Wed, Mar 23, 2011 at 12:58:21PM -0700, Jason Gerecke wrote: > As I'm working on the X11 wheel mapping, I'm finding a few weird > quirks in the code. I pretty much understand 'how' things work, but > I'm not sure why some things are the way they are... > > 1. Why does WACOM_PROP_BUTTON_ACTIONS h

[Linuxwacom-devel] [PATCH] Silence compiler warning.

2011-03-23 Thread Peter Hutterer
./src/wcmCommon.c: In function 'sendCommonEvents': ./src/wcmCommon.c:382:2: warning: 'value' may be used uninitialized in this function [-Wuninitialized] ./src/wcmCommon.c:329:22: note: 'value' was declared here Signed-off-by: Peter Hutterer --- src/wcmCommon.c |2 +- 1 files changed, 1 ins

Re: [Linuxwacom-devel] Kernel driver for OLED support (was: OLED setting for xsetwacom)

2011-03-23 Thread Ping Cheng
On Wed, Mar 23, 2011 at 4:09 PM, Eduard Hasenleithner wrote: > 2011/3/23 Ping Cheng : > > On Wed, Mar 23, 2011 at 12:55 PM, Eduard Hasenleithner < > ehase...@gmail.com> > > wrote: > >> Now I even tested the linuxwacom/src/2.6.30 driver on a fresh > >> linux-2.6.38 from kernel.org. I had to do a fe

[Linuxwacom-devel] Kernel driver for OLED support (was: OLED setting for xsetwacom)

2011-03-23 Thread Eduard Hasenleithner
2011/3/23 Ping Cheng : > On Wed, Mar 23, 2011 at 12:55 PM, Eduard Hasenleithner > wrote: >> Now I even tested the linuxwacom/src/2.6.30 driver on a fresh >> linux-2.6.38 from kernel.org. I had to do a few minor modifications to >> the driver source (ioctl has been renamed to unlocked_ioctl in >> u

Re: [Linuxwacom-devel] [PATCH] Fix strip_keys index, copy/paste error.

2011-03-23 Thread Ping Cheng
Reviewed-by: Ping Cheng Ping On Mon, Mar 21, 2011 at 9:04 PM, Peter Hutterer wrote: > Signed-off-by: Peter Hutterer > --- > src/wcmCommon.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/src/wcmCommon.c b/src/wcmCommon.c > index d024ad8..caa6774 100644 > --- a/

[Linuxwacom-devel] [PATCH 3/3] PAD is always on PAD_CHANNEL

2011-03-23 Thread Ping Cheng
Don't assume the last tool was a pad, which confuses those tools that never receive a serial number. Keep PAD on the PAD_CHANNEL. Signed-off-by: Ping Cheng --- src/wcmUSB.c | 21 - 1 files changed, 4 insertions(+), 17 deletions(-) diff --git a/src/wcmUSB.c b/src/wcmUSB.c i

[Linuxwacom-devel] [PATCH 2/3] Fix a copy/paste error in usbFindDeviceType comment

2011-03-23 Thread Ping Cheng
Signed-off-by: Ping Cheng --- src/wcmUSB.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/wcmUSB.c b/src/wcmUSB.c index 197d9fc..d58a740 100644 --- a/src/wcmUSB.c +++ b/src/wcmUSB.c @@ -945,8 +945,8 @@ static int usbIdToType(int id) } /** - * Find the tool typ

[Linuxwacom-devel] [PATCH 1/3 v4] Support pen and MT on the same logical port

2011-03-23 Thread Ping Cheng
Serial ISDv4 kernel driver, wacom_w8001.ko, provides both pen and touch events on the same logical port. Filtering touch events when pen is in proximity while allowing pen events (ABS_X/Y, etc) pass. Making this action configurable would make sense when XInput 2.1 is ready. At that point, we can p

Re: [Linuxwacom-devel] [draft-patch] OLED setting for xsetwacom

2011-03-23 Thread Ping Cheng
On Wed, Mar 23, 2011 at 12:55 PM, Eduard Hasenleithner wrote: > Now I even tested the linuxwacom/src/2.6.30 driver on a fresh > linux-2.6.38 from kernel.org. I had to do a few minor modifications to > the driver source (ioctl has been renamed to unlocked_ioctl in > usb_device and input->abs is mis

Re: [Linuxwacom-devel] [PATCH 1/2] Fix X crash after remapping touchstrips and wheels

2011-03-23 Thread Jason Gerecke
As I'm working on the X11 wheel mapping, I'm finding a few weird quirks in the code. I pretty much understand 'how' things work, but I'm not sure why some things are the way they are... 1. Why does WACOM_PROP_BUTTON_ACTIONS have room for only 16 buttons, yet priv->btn_actions (storing the same dat

Re: [Linuxwacom-devel] [draft-patch] OLED setting for xsetwacom

2011-03-23 Thread Eduard Hasenleithner
Now I even tested the linuxwacom/src/2.6.30 driver on a fresh linux-2.6.38 from kernel.org. I had to do a few minor modifications to the driver source (ioctl has been renamed to unlocked_ioctl in usb_device and input->abs is missing) but it works perfectly! Apparently the driver did not diverge too

Re: [Linuxwacom-devel] [draft-patch] OLED setting for xsetwacom

2011-03-23 Thread Favux ...
Interesting. That's why I didn't say anything earlier. Supposedly you could use some symlinks to get around the lack of a /proc/bus/usb, but we could never get that working. Launchpad bug report: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/488274 Favux On Wed, Mar 23, 2011 at 1:56 PM,

Re: [Linuxwacom-devel] [draft-patch] OLED setting for xsetwacom

2011-03-23 Thread Eduard Hasenleithner
2011/3/23 Favux ... : > usbfs was deprecated in kernel 2.6.31 I think.  Certainly by 2.6.32 > Ubuntu (Lucid 10.04) and several other distributions dropped it.  This > all happened at about the same time.  There was some conflict with > changes in udev.  Apparently since usbfs implicitly changes eve

Re: [Linuxwacom-devel] [draft-patch] OLED setting for xsetwacom

2011-03-23 Thread Favux ...
Hi, usbfs was deprecated in kernel 2.6.31 I think. Certainly by 2.6.32 Ubuntu (Lucid 10.04) and several other distributions dropped it. This all happened at about the same time. There was some conflict with changes in udev. Apparently since usbfs implicitly changes event behavior it was breaki

Re: [Linuxwacom-devel] [draft-patch] OLED setting for xsetwacom

2011-03-23 Thread Ping Cheng
On Wed, Mar 23, 2011 at 3:36 AM, Eduard Hasenleithner wrote: > 2011/3/23 Peter Hutterer : > > On Tue, Mar 22, 2011 at 10:47:12PM +0100, Eduard Hasenleithner wrote: > >> For accessing USB-FS, I already considered libusb, just to find out > >> that it does not (yet?) provide the USBDEVFS_IOCTL. Idea

Re: [Linuxwacom-devel] [draft-patch] OLED setting for xsetwacom

2011-03-23 Thread Eduard Hasenleithner
2011/3/23 Peter Hutterer : > On Tue, Mar 22, 2011 at 10:47:12PM +0100, Eduard Hasenleithner wrote: >> For accessing USB-FS, I already considered libusb, just to find out >> that it does not (yet?) provide the USBDEVFS_IOCTL. Ideal would be >> IOCTL tunneling through the linux event subsystem in the