Re: [Linuxwacom-devel] [PATCH 1/3] Only convert I4 tilt bits to rotation for the I4 mouse

2011-10-20 Thread Peter Hutterer
On Thu, Oct 20, 2011 at 04:59:44PM -0700, Jason Gerecke wrote: > The comment claims that the conversion is to be performed for the > I4 mouse only, but doesn't actually check to see if the tool is > indeed a mouse. This patch adds in the necessary check, allowing > the I4 stylus to properly report

Re: [Linuxwacom-devel] [PATCH 2/2] Pressure is not reported for touch devices in the kernel

2011-10-20 Thread Peter Hutterer
On Thu, Oct 20, 2011 at 12:44:40PM -0700, Ping Cheng wrote: > On Thu, Oct 20, 2011 at 8:03 AM, Chris Bagwell wrote: > > On Wed, Oct 19, 2011 at 9:10 PM, Chris Bagwell wrote: > >> On Wed, Oct 19, 2011 at 7:01 PM, Ping Cheng wrote: > >>> So, we can not rely on pressure to set button 1 click for to

Re: [Linuxwacom-devel] [PATCH 1/2] Process pressure only when it is supported

2011-10-20 Thread Peter Hutterer
On Wed, Oct 19, 2011 at 05:01:08PM -0700, Ping Cheng wrote: > normalizePressure crashes if wcmMaxZ is 0. > > Signed-off-by: Ping Cheng > --- > src/wcmCommon.c |8 > 1 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/src/wcmCommon.c b/src/wcmCommon.c > index c3c8907..

Re: [Linuxwacom-devel] [PATCH 1/3] Only convert I4 tilt bits to rotation for the I4 mouse

2011-10-20 Thread Peter Hutterer
On Thu, Oct 20, 2011 at 04:59:44PM -0700, Jason Gerecke wrote: > The comment claims that the conversion is to be performed for the > I4 mouse only, but doesn't actually check to see if the tool is > indeed a mouse. This patch adds in the necessary check, allowing > the I4 stylus to properly report

[Linuxwacom-devel] [PATCH 3/3] Add 0x10804 to recognized Art Pen device IDs

2011-10-20 Thread Jason Gerecke
Intuos4 Art Pens may have an ID of 0x10804 for their tip and 0x1080C for their eraser. There may be other IDs which need matching as well, but that is a "to investigate" item for the moment. Note that due to a mostly-benign issue in the kernel driver, the highest nybble of the ID is placed one nyb

[Linuxwacom-devel] [PATCH 2/3] Correct Cintiq 21UX2 features to advertise touch strips, not rings

2011-10-20 Thread Jason Gerecke
Moves the 0xCC case (21UX2) to be in the proper spot. There are touch strips, not rings on this device. Signed-off-by: Jason Gerecke --- src/wcmValidateDevice.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/src/wcmValidateDevice.c b/src/wcmValidateDevice.c index a6

[Linuxwacom-devel] [PATCH 1/3] Only convert I4 tilt bits to rotation for the I4 mouse

2011-10-20 Thread Jason Gerecke
The comment claims that the conversion is to be performed for the I4 mouse only, but doesn't actually check to see if the tool is indeed a mouse. This patch adds in the necessary check, allowing the I4 stylus to properly report tilt data. Signed-off-by: Jason Gerecke --- src/wcmCommon.c | 16 +

Re: [Linuxwacom-devel] [PATCH] Initial driver for Wacom Intuos4 Wireless - version 2, merge with hid-wacom.c

2011-10-20 Thread Ping Cheng
On Tue, Oct 18, 2011 at 12:18 PM, Przemo Firszt wrote: > Please test & comment. I cannot convince git to block text in a > different way - if anyone knows how to do it please let me know. Can I assume you have tested the driver with your Graphire WL? Why do we need to move INPUT_PROP_POINTER ins

Re: [Linuxwacom-devel] [PATCH 2/2] Pressure is not reported for touch devices in the kernel

2011-10-20 Thread Ping Cheng
On Thu, Oct 20, 2011 at 8:03 AM, Chris Bagwell wrote: > On Wed, Oct 19, 2011 at 9:10 PM, Chris Bagwell wrote: >> On Wed, Oct 19, 2011 at 7:01 PM, Ping Cheng wrote: >>> So, we can not rely on pressure to set button 1 click for touch >>> screen devices. >> >> This code shouldn't be needed... or it

Re: [Linuxwacom-devel] [PATCH] Initial driver for Wacom Intuos4 Wireless - version 2, merge with hid-wacom.c

2011-10-20 Thread Przemo Firszt
Dnia 2011-10-18, wto o godzinie 21:01 -0500, Chris Bagwell pisze: > On Tue, Oct 18, 2011 at 2:18 PM, Przemo Firszt wrote: > > Please test & comment. I cannot convince git to block text in a > > different way - if anyone knows how to do it please let me know. > > > > I've just lived with the git d

Re: [Linuxwacom-devel] [PATCH 2/2] Pressure is not reported for touch devices in the kernel

2011-10-20 Thread Ping Cheng
On Thu, Oct 20, 2011 at 8:03 AM, Chris Bagwell wrote: > On Wed, Oct 19, 2011 at 9:10 PM, Chris Bagwell wrote: >> On Wed, Oct 19, 2011 at 7:01 PM, Ping Cheng wrote: >>> So, we can not rely on pressure to set button 1 click for touch >>> screen devices. >> >> This code shouldn't be needed... or it

Re: [Linuxwacom-devel] [PATCH 1/2] Process pressure only when it is supported

2011-10-20 Thread Ping Cheng
On Wed, Oct 19, 2011 at 7:01 PM, Chris Bagwell wrote: > On Wed, Oct 19, 2011 at 7:01 PM, Ping Cheng wrote: >> normalizePressure crashes if wcmMaxZ is 0. > > The crash must depend on version of Xorg your using.  I'd assume I'd > see this crash as well now that I'm using the Bamboo driver that > re

Re: [Linuxwacom-devel] [PATCH 2/2] Pressure is not reported for touch devices in the kernel

2011-10-20 Thread Chris Bagwell
On Wed, Oct 19, 2011 at 9:10 PM, Chris Bagwell wrote: > On Wed, Oct 19, 2011 at 7:01 PM, Ping Cheng wrote: >> So, we can not rely on pressure to set button 1 click for touch >> screen devices. > > This code shouldn't be needed... or its a bug elsewhere if it is needed. > > wcmSingleFingerPress()