Re: [Linuxwacom-devel] [PATCH v3 5/5] De-duplicate code for wheel/strip scrolling

2011-12-18 Thread Peter Hutterer
On Tue, Dec 13, 2011 at 01:59:02PM -0800, Jason Gerecke wrote: > Replaces sendWheelStripEvents and getWheelButton with several > small functions to reduce unnecessary code duplication. > > As a side-effect, it is now possible for the driver to handle > simultaneous scrolls on multiple axes. Previo

[Linuxwacom-devel] [PATCH 3/3] test: fix linker error 'input_option_new' undefined

2011-12-18 Thread Peter Hutterer
We need a copy of it in the driver. This is just the one the driver uses for pre-ABI 14 compatibility, we don't need the server's exact copy since we're not testing that API (that's the server's job), only our use of the API. Signed-off-by: Peter Hutterer --- test/fake-symbols.c | 35 +

[Linuxwacom-devel] [PATCH 2/3] test: add more #defines to fix build issues.

2011-12-18 Thread Peter Hutterer
sigh, upstream changed the option function prototypes without bumping the ABI. This is the best we can do, though there will be a period between the actual abi bump and this commit where we get test build errors now. commit 09e4b78f7944234865f4648940453303af0c2663 Author: Alan Coopersmith Date:

[Linuxwacom-devel] [PATCH 1/3] test: drop duplicate definition of xf86FindOptionValue

2011-12-18 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- test/fake-symbols.h |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/test/fake-symbols.h b/test/fake-symbols.h index b811364..9b85eac 100644 --- a/test/fake-symbols.h +++ b/test/fake-symbols.h @@ -25,7 +25,6 @@ extern char* xf86CheckStrOpt

Re: [Linuxwacom-devel] [PATCH] Update 2.6.38 kernel to dtor-next

2011-12-18 Thread Favux ...
You have my vote. :) Favux -- Learn Windows Azure Live! Tuesday, Dec 13, 2011 Microsoft is holding a special Learn Windows Azure training event for developers. It will provide a great way to learn Windows Azure and wha

Re: [Linuxwacom-devel] [PATCH] Update 2.6.38 kernel to dtor-next

2011-12-18 Thread Chris Bagwell
Hi all, I messed up in input-wacom 0.12.0 release. I said that it supported 2nd gen Bamboo but it did not. Its just a few lines of code so I missed it in the noise. At the moment I took the dtor-next snapshot, the 2nd gen support was only in his dtor-for-linus branch. So this patch is to get t

[Linuxwacom-devel] [PATCH] Update 2.6.38 kernel to dtor-next

2011-12-18 Thread chris
From: Chris Bagwell Previous version was missing 2nd gen Bamboo support even though git commit said it was supported. Signed-off-by: Chris Bagwell --- 2.6.38/wacom_sys.c | 19 ++-- 2.6.38/wacom_wac.c | 129 +-- 2.6.38/wacom_wac.h |1 +

Re: [Linuxwacom-devel] [PATCH v3 3/5] Have the second touch ring emulate wheel events by default

2011-12-18 Thread Peter Hutterer
On Tue, Dec 13, 2011 at 01:59:00PM -0800, Jason Gerecke wrote: > Touch strips as well as the first touch ring are set up to emulate > mouse wheel events by default. This patch duplicates this behavior > for the second touch ring, so that it behaves in an identical manner. > > Signed-off-by: Jason

Re: [Linuxwacom-devel] [PATCH v3 4/5] Expose the second touch ring's raw value in a new 7th valuator

2011-12-18 Thread Peter Hutterer
On Tue, Dec 13, 2011 at 01:59:01PM -0800, Jason Gerecke wrote: > This patch expands the number of valuators reported by devices to > seven. The new seventh valuator reports the raw value provided from > the kernel for the second touch ring. > > Signed-off-by: Jason Gerecke Reviewed-by: Peter Hut

Re: [Linuxwacom-devel] [PATCH v4 2/5] Add 'abswheel2' to device state for dual-ring devices

2011-12-18 Thread Peter Hutterer
On Tue, Dec 13, 2011 at 03:38:27PM -0800, Jason Gerecke wrote: > This patch adds an 'abswheel2' field to the _WacomDeviceState > structure, along with corresponding 'oldWheel2' field to the > _WacomDeviceRec structure. These fields store the state of the > second touch ring on dual-ring devices suc

Re: [Linuxwacom-devel] [PATCH v3 1/5] Add basic support for Cintiq 24HD

2011-12-18 Thread Peter Hutterer
On Tue, Dec 13, 2011 at 01:58:58PM -0800, Jason Gerecke wrote: > Adds the Cintiq 24HD (056a:00f4) to the device lists. The 24HD > has two features not found on prior tablets: three capacitive > buttons, and a second touch ring. Subsuquent patches will > address adding support for them. > > Signed-

Re: [Linuxwacom-devel] [PATCH v3 3/5] Have the second touch ring emulate wheel events by default

2011-12-18 Thread Peter Hutterer
On Tue, Dec 13, 2011 at 01:59:00PM -0800, Jason Gerecke wrote: > Touch strips as well as the first touch ring are set up to emulate > mouse wheel events by default. This patch duplicates this behavior > for the second touch ring, so that it behaves in an identical manner. > > Signed-off-by: Jason

Re: [Linuxwacom-devel] [PATCH v4 2/5] Add 'abswheel2' to device state for dual-ring devices

2011-12-18 Thread Chris Bagwell
I've really been meaning to review these but to busy. So let me at least nock some of easy ones out. For 1st patch and v2 of 2nd patch: Reviewed-by: Chris Bagwell Since the ABS_THROTTLE is in dtor's next branch, I guess its safe to add here as well. I'll try to finish the other reviews in a d