Re: [Linuxwacom-devel] [PATCH v3 3/5] Have the second touch ring emulate wheel events by default

I've finished reviewing this one and have no comments beyond Peter's. Chris On Sun, Dec 18, 2011 at 8:56 PM, Peter Hutterer wrote: > On Tue, Dec 13, 2011 at 01:59:00PM -0800, Jason Gerecke wrote: >> Touch strips as well as the first touch ring are set up to emulate >> mouse wheel events by defau

Re: [Linuxwacom-devel] [PATCH v3 4/5] Expose the second touch ring's raw value in a new 7th valuator

Reviewed-by: Chris Bagwell On Tue, Dec 13, 2011 at 3:59 PM, Jason Gerecke wrote: > This patch expands the number of valuators reported by devices to > seven. The new seventh valuator reports the raw value provided from > the kernel for the second touch ring. > > Signed-off-by: Jason Gerecke > -

Re: [Linuxwacom-devel] [PATCH 3/3] test: fix linker error 'input_option_new' undefined

For the series: Reviewed-by: Chris Bagwell On Sun, Dec 18, 2011 at 9:37 PM, Peter Hutterer wrote: > We need a copy of it in the driver. This is just the one the driver uses for > pre-ABI 14 compatibility, we don't need the server's exact copy since we're > not testing that API (that's the serve

Re: [Linuxwacom-devel] [PATCH 2/3] test: add more #defines to fix build issues.

On Sun, Dec 18, 2011 at 7:37 PM, Peter Hutterer wrote: > sigh, upstream changed the option function prototypes without bumping the > ABI. This is the best we can do, though there will be a period between the > actual abi bump and this commit where we get test build errors now. > > commit 09e4b78f7

Re: [Linuxwacom-devel] [PATCH v3 5/5] De-duplicate code for wheel/strip scrolling

On Sun, Dec 18, 2011 at 10:06 PM, Peter Hutterer wrote: > On Tue, Dec 13, 2011 at 01:59:02PM -0800, Jason Gerecke wrote: >> Replaces sendWheelStripEvents and getWheelButton with several >> small functions to reduce unnecessary code duplication. >> >> As a side-effect, it is now possible for the dr

Re: [Linuxwacom-devel] [PATCH 2/3] test: add more #defines to fix build issues.

On Mon, Dec 19, 2011 at 11:40:55AM -0800, Jason Gerecke wrote: > On Sun, Dec 18, 2011 at 7:37 PM, Peter Hutterer > wrote: > > sigh, upstream changed the option function prototypes without bumping the > > ABI. This is the best we can do, though there will be a period between the > > actual abi bump

Re: [Linuxwacom-devel] [PATCH v3 5/5] De-duplicate code for wheel/strip scrolling

On Mon, Dec 19, 2011 at 12:25:24PM -0800, Jason Gerecke wrote: > On Sun, Dec 18, 2011 at 10:06 PM, Peter Hutterer > wrote: > > On Tue, Dec 13, 2011 at 01:59:02PM -0800, Jason Gerecke wrote: > >> Replaces sendWheelStripEvents and getWheelButton with several > >> small functions to reduce unnecessar