Re: [Linuxwacom-devel] Waltop class?

2012-04-30 Thread Favux ...
Hi Peter, On Mon, Apr 30, 2012 at 10:54 PM, Peter Hutterer wrote: > On Mon, Apr 30, 2012 at 10:10:59PM -0500, Favux ... wrote: >> Another libwacom question for Waltop tablets.  Could/should I create a >> WCLASS_Waltop?  Or should I follow the lead in wcmUSB.c in which case >> the valid classes in

Re: [Linuxwacom-devel] Waltop class?

2012-04-30 Thread Peter Hutterer
On Mon, Apr 30, 2012 at 10:10:59PM -0500, Favux ... wrote: > Another libwacom question for Waltop tablets. Could/should I create a > WCLASS_Waltop? Or should I follow the lead in wcmUSB.c in which case > the valid classes include Intuos4, Bamboo, and Graphire? Or should I > leave in the Waltop t

[Linuxwacom-devel] Waltop class?

2012-04-30 Thread Favux ...
Hi, Another libwacom question for Waltop tablets. Could/should I create a WCLASS_Waltop? Or should I follow the lead in wcmUSB.c in which case the valid classes include Intuos4, Bamboo, and Graphire? Or should I leave in the Waltop tablet data the class as WCLASS_UNKNOWN? Either assign it unkn

Re: [Linuxwacom-devel] [PATCH libwacom 10/11] test: add test for database entry validity

2012-04-30 Thread Peter Hutterer
On Mon, Apr 30, 2012 at 11:40:47AM +0100, Bastien Nocera wrote: > On Mon, 2012-04-30 at 15:53 +1000, Peter Hutterer wrote: > > Test each tablet returned for some basic sanity (largely >= 0 values) > > Are you going to hook that up? hook it up to? 'make check' runs all the tests, I'm not sure what

[Linuxwacom-devel] [PATCH v2 08/11 and 09/11] data: fix class for isdv4-e4, isdv4-e6 and WACf004

2012-04-30 Thread Peter Hutterer
The E6 is so far found only in the x220t, size measured and rounded to the nearest inch. The other tablets may be of varying size. Signed-off-by: Peter Hutterer Reviewed-by: Bastien Nocera --- Squashed the two together and updated the class for all serial tablet. The E6 so far has a fixed size,

Re: [Linuxwacom-devel] [PATCH libwacom 11/11] Replace INCLUDES with AM_CPPFLAGS

2012-04-30 Thread Peter Hutterer
On Mon, Apr 30, 2012 at 11:41:30AM +0100, Bastien Nocera wrote: > On Mon, 2012-04-30 at 15:53 +1000, Peter Hutterer wrote: > > INCLUDES is deprecated in favour of the latter > > In the future, no need to send those for review, use your best > judgement. half of the reason is review, the other hal

Re: [Linuxwacom-devel] GNOME Wacom Graphics Tablet applet, libwacom and non-Wacom tablets.

2012-04-30 Thread Favux ...
On Mon, Apr 30, 2012 at 4:55 AM, Bastien Nocera wrote: > On Mon, 2012-04-30 at 16:26 +1000, Peter Hutterer wrote: >> On Mon, Apr 30, 2012 at 01:12:13AM -0500, Favux ... wrote: >> > I have a question for the list.  Is it intended that non-wacom tablets >> > on the xf86-input-driver, like the Hanwan

Re: [Linuxwacom-devel] [PATCH libwacom 11/11] Replace INCLUDES with AM_CPPFLAGS

2012-04-30 Thread Bastien Nocera
On Mon, 2012-04-30 at 15:53 +1000, Peter Hutterer wrote: > INCLUDES is deprecated in favour of the latter In the future, no need to send those for review, use your best judgement. > Signed-off-by: Peter Hutterer Reviewed-By: Bastien Nocera > --- > test/Makefile.am |2 +- > tools/Makefil

Re: [Linuxwacom-devel] [PATCH libwacom 10/11] test: add test for database entry validity

2012-04-30 Thread Bastien Nocera
On Mon, 2012-04-30 at 15:53 +1000, Peter Hutterer wrote: > Test each tablet returned for some basic sanity (largely >= 0 values) Are you going to hook that up? > Signed-off-by: Peter Hutterer Reviewed-By: Bastien Nocera > --- > test/Makefile.am |3 +- > test/tablet-validity.c | 9

Re: [Linuxwacom-devel] [PATCH libwacom 09/11] data: Fix class and dimensions for WACf004

2012-04-30 Thread Bastien Nocera
On Mon, 2012-04-30 at 15:53 +1000, Peter Hutterer wrote: > This thing ships in the HP 2710p, calculated from screen res, round to the > nearest inch. Same question as for patch 8 > Signed-off-by: Peter Hutterer > --- > data/serial-wacf004.tablet |3 +++ > 1 file changed, 3 insertions(+) >

Re: [Linuxwacom-devel] [PATCH libwacom 08/11] data: fix class and dimensions for isdv4-e4 and isdv4-e6

2012-04-30 Thread Bastien Nocera
On Mon, 2012-04-30 at 15:53 +1000, Peter Hutterer wrote: > E6 was simply measured, E3 calculated from dimensions found on the tm2 tech > specs. Both rounded to the nearest inch. Is this really useful when the size depends on what laptop make this is in? > Signed-off-by: Peter Hutterer Reviewed-

Re: [Linuxwacom-devel] [PATCH libwacom 07/11] data: fix bamboo class and size

2012-04-30 Thread Bastien Nocera
On Mon, 2012-04-30 at 15:53 +1000, Peter Hutterer wrote: > Fractional sizes don't get parse properly, round up to the nearest inch > > Signed-off-by: Peter Hutterer Reviewed-By: Bastien Nocera > --- > data/bamboo-one.tablet |5 +++-- > data/bamboo-pen-and-touch.tablet |4 ++-

Re: [Linuxwacom-devel] [PATCH libwacom 06/11] lib: add PenDisplay as class type

2012-04-30 Thread Bastien Nocera
On Mon, 2012-04-30 at 15:53 +1000, Peter Hutterer wrote: > Listed as "Interactive Pen Display" on the Wacom website Link? > Signed-off-by: Peter Hutterer Reviewed-By: Bastien Nocera > --- > data/dtf-720.tablet |1 + > data/dti-520.tablet |1 + > data/dtu-1631.tablet

Re: [Linuxwacom-devel] [PATCH libwacom 05/11] lib: if no stylus is defined, assume the generic stylus

2012-04-30 Thread Bastien Nocera
On Mon, 2012-04-30 at 15:53 +1000, Peter Hutterer wrote: > There is no touch-only wacom tablet at this point, so it's safe to assume > that all tablets have some stylus. > > Signed-off-by: Peter Hutterer Reviewed-By: Bastien Nocera > --- > libwacom/libwacom-database.c |4 > 1 file ch

Re: [Linuxwacom-devel] [PATCH libwacom 04/11] lib: add missing ISDV4 class string conversion

2012-04-30 Thread Bastien Nocera
On Mon, 2012-04-30 at 15:53 +1000, Peter Hutterer wrote: > Signed-off-by: Peter Hutterer Reviewed-By: Bastien Nocera > --- > libwacom/libwacom-database.c |2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libwacom/libwacom-database.c b/libwacom/libwacom-database.c > index 8351e06..

Re: [Linuxwacom-devel] [PATCH libwacom 03/11] data: rename Graphire Wireless .tablet file

2012-04-30 Thread Bastien Nocera
On Mon, 2012-04-30 at 15:53 +1000, Peter Hutterer wrote: > Easier to find now > > Signed-off-by: Peter Hutterer Reviewed-By: Bastien Nocera > --- > data/graphire-wireless-8x6.tablet | 13 + > data/wireless-pen-tablet.tablet | 13 - > 2 files changed, 13 insertion

Re: [Linuxwacom-devel] [PATCH libwacom 02/11] lib: add Intuos and Intuos2 classes

2012-04-30 Thread Bastien Nocera
On Mon, 2012-04-30 at 15:53 +1000, Peter Hutterer wrote: > The datafiles already use them, might as well have the code for them > > Signed-off-by: Peter Hutterer Reviewed-By: Bastien Nocera > --- > libwacom/libwacom-database.c |4 > libwacom/libwacom.c |2 ++ > libwacom/

Re: [Linuxwacom-devel] [PATCH libwacom 01/11] lib: constify libwacom_get_styli()

2012-04-30 Thread Bastien Nocera
On Mon, 2012-04-30 at 15:53 +1000, Peter Hutterer wrote: > We return internal memory here, make sure it's const. > > Signed-off-by: Peter Hutterer Reviewed-By: Bastien Nocera > --- > libwacom/libwacom.c |5 +++-- > libwacom/libwacom.h |2 +- > test/dbverify.c |3 ++- > 3 files

Re: [Linuxwacom-devel] GNOME Wacom Graphics Tablet applet, libwacom and non-Wacom tablets.

2012-04-30 Thread Bastien Nocera
On Mon, 2012-04-30 at 16:26 +1000, Peter Hutterer wrote: > On Mon, Apr 30, 2012 at 01:12:13AM -0500, Favux ... wrote: > > I have a question for the list. Is it intended that non-wacom tablets > > on the xf86-input-driver, like the Hanwang, N-Trig, and Waltop, be > > able to configure their styli t