[Linuxwacom-devel] [PATCH 1/4 v2] Remove channel duplication code for generic devices

2012-12-16 Thread Ping Cheng
On Sunday, December 16, 2012, Peter Hutterer wrote: > On Thu, Dec 13, 2012 at 10:19:09PM -0800, Ping Cheng wrote: > > On Thursday, December 13, 2012, Peter Hutterer wrote: > > > > > On Thu, Dec 13, 2012 at 12:16:52PM -0800, Ping Cheng wrote: > > > > We use true MT protocol for MT devices in kernel

Re: [Linuxwacom-devel] [PATCH 3/4 v2] Send generic PAD events before other events

2012-12-16 Thread Ping Cheng
On Sunday, December 16, 2012, Ping Cheng wrote: > On Sunday, December 16, 2012, Chris Bagwell wrote: > >> >> On Sun, Dec 16, 2012 at 7:17 PM, Ping Cheng wrote: >> >>> On Sun, Dec 16, 2012 at 1:40 PM, Chris Bagwell wrote: >>> On Thu, Dec 13, 2012 at 2:18 PM, Ping Cheng wrote: >

Re: [Linuxwacom-devel] [PATCH 1/4 v2] Remove channel duplication code for generic devices

2012-12-16 Thread Peter Hutterer
On Thu, Dec 13, 2012 at 10:19:09PM -0800, Ping Cheng wrote: > On Thursday, December 13, 2012, Peter Hutterer wrote: > > > On Thu, Dec 13, 2012 at 12:16:52PM -0800, Ping Cheng wrote: > > > We use true MT protocol for MT devices in kernel now. This code > > > was introduced to deal with ABS_TOOL_*TA

Re: [Linuxwacom-devel] [PATCH 3/4 v2] Send generic PAD events before other events

2012-12-16 Thread Ping Cheng
On Sunday, December 16, 2012, Chris Bagwell wrote: > > On Sun, Dec 16, 2012 at 7:17 PM, Ping Cheng > > > wrote: > >> On Sun, Dec 16, 2012 at 1:40 PM, Chris Bagwell >> >> > wrote: >> >>> >>> >>> >>> On Thu, Dec 13, 2012 at 2:18 PM, Ping Cheng >>> >>> > wrote: >>> If we wait until we fini

Re: [Linuxwacom-devel] [PATCH 1/4 v2] Remove channel duplication code for generic devices

2012-12-16 Thread Ping Cheng
Hi Chris, Thank you for your reply and your comments. Most importantly, thank you for your time. The patch does not have to be merged. Let's figure out if the duplicated channel is necessary or not. On Sun, Dec 16, 2012 at 2:56 PM, Chris Bagwell wrote: > > On Thu, Dec 13, 2012 at 2:16 PM, Pin

Re: [Linuxwacom-devel] [PATCH 3/4 v2] Send generic PAD events before other events

2012-12-16 Thread Chris Bagwell
On Sun, Dec 16, 2012 at 7:17 PM, Ping Cheng wrote: > On Sun, Dec 16, 2012 at 1:40 PM, Chris Bagwell wrote: > >> >> >> >> On Thu, Dec 13, 2012 at 2:18 PM, Ping Cheng wrote: >> >>> If we wait until we finish other verifications, we could miss >>> PAD events since they will be filtered out when the

Re: [Linuxwacom-devel] [PATCH 3/4 v2] Send generic PAD events before other events

2012-12-16 Thread Ping Cheng
On Sun, Dec 16, 2012 at 1:40 PM, Chris Bagwell wrote: > > > > On Thu, Dec 13, 2012 at 2:18 PM, Ping Cheng wrote: > >> If we wait until we finish other verifications, we could miss >> PAD events since they will be filtered out when there are no >> motion events sent simultaneously. >> > > >> Sign

Re: [Linuxwacom-devel] [PATCH 1/4 v2] Remove channel duplication code for generic devices

2012-12-16 Thread Chris Bagwell
On Thu, Dec 13, 2012 at 2:16 PM, Ping Cheng wrote: > We use true MT protocol for MT devices in kernel now. This code > was introduced to deal with ABS_TOOL_*TAP events loss issue. It > is uncessary any more. And its existence makes it hard to support > generic PAD cleanly. > > I can't think of an

Re: [Linuxwacom-devel] [PATCH 1/4] Remove channel duplication code for generic devices

2012-12-16 Thread Chris Bagwell
On Fri, Dec 14, 2012 at 6:39 PM, Ping Cheng wrote: > Hi Chris, > > Long time no "say". What's your opinion about the patchset? Do you care to > give an acked-by or nacked-by? Without your help, the bamboo PAD is broken > every so often these days > Sorry I haven't been able to contribute muc

Re: [Linuxwacom-devel] [PATCH 3/4 v2] Send generic PAD events before other events

2012-12-16 Thread Chris Bagwell
On Thu, Dec 13, 2012 at 2:18 PM, Ping Cheng wrote: > If we wait until we finish other verifications, we could miss > PAD events since they will be filtered out when there are no > motion events sent simultaneously. > > Signed-off-by: Ping Cheng > Acked-by: Jason Gerecke > --- > src/wcmUSB.c

Re: [Linuxwacom-devel] [PATCH 4/4 v2] BTN_TOOL_FINGER is not for PAD if MT is supported

2012-12-16 Thread Chris Bagwell
On Thu, Dec 13, 2012 at 2:19 PM, Ping Cheng wrote: > BTN_TOOL_FINGER indicates single touch/first finger if MT is enabled > > Signed-off-by: Ping Cheng > Reviewed-by: Jason Gerecke > Oh, good point. I assume the new Intuos5's are tracked as Protocol 5 devices but also with MT. If this is tr

Re: [Linuxwacom-devel] [PATCH 2/4 v2] Initialize wcmBTNChannel in usbWcmInitPadState()

2012-12-16 Thread Chris Bagwell
On Thu, Dec 13, 2012 at 2:18 PM, Ping Cheng wrote: > wcmBTNChannel is only used by generic PAD device. > And it is statically assigned to PAD_CHANNEL. No > need to reassign it for every packet. > > Signed-off-by: Ping Cheng > Acked-by: Jason Gerecke > Reviewed-by: Chris Bagwell > --- > src