[Linuxwacom-devel] [PATCH 3/8] xsetwacom: Fix format string provided used by 'get_button'

xsetwacom.c: In function ‘get_button’: xsetwacom.c:2080:2: warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has type ‘Atom’ [-Wformat=] print_button_value(param, offset, %d, prop); Signed-off-by: Jason Gerecke killert...@gmail.com --- tools/xsetwacom.c | 2 +- 1 file

[Linuxwacom-devel] [PATCH 6/8] tools: Fix up const warnings

Resolve numerous initialization discards ‘const’ qualifier from pointer target type warnings that were present. Note that in the process of fixing the warning in 'parse_actions', a small buffer overflow was also corrected (the statement 'sprintf(new_words[0], +%d, i)' writes one character more

[Linuxwacom-devel] [PATCH 5/8] xsetwacom: Use 'fabs' instead of 'abs' where necessary

Fixes multiple clang warnings about the use of 'abs' with a floating- point argument. Signed-off-by: Jason Gerecke killert...@gmail.com --- src/wcmCommon.c | 2 +- src/wcmTouchFilter.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/wcmCommon.c b/src/wcmCommon.c

[Linuxwacom-devel] [PATCH 8/8] doc: Fix doxygen.conf warnings

Remove the obsolete XML_SCHEMA and XML_DTD definitions, as well as clear the definition of DOT_FONTNAME. Signed-off-by: Jason Gerecke killert...@gmail.com --- doc/doxygen.conf.in | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/doc/doxygen.conf.in

[Linuxwacom-devel] [PATCH 4/8] xsetwacom: Remove unused variable from 'strjoinsplit'

Signed-off-by: Jason Gerecke killert...@gmail.com --- tools/xsetwacom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/xsetwacom.c b/tools/xsetwacom.c index 284e6e2..db3a776 100644 --- a/tools/xsetwacom.c +++ b/tools/xsetwacom.c @@ -1285,7 +1285,7 @@ static int

[Linuxwacom-devel] [PATCH 7/8] xsetwacom: Ease static analysis of get_mapped_area

Fixes warnings about the width, height, x_org, and y_org variables in set_output_next potentially being undefined. Although careful consideration of the code shows that they must be defined, GCC's static analyzer apparently isn't quite up to the task. This commit rewrites the loop/switch construct

[Linuxwacom-devel] [PATCH 1/8] tools: Build with CWARNFLAGS

Signed-off-by: Jason Gerecke killert...@gmail.com --- tools/Makefile.am | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/Makefile.am b/tools/Makefile.am index 0aad526..5622362 100644 --- a/tools/Makefile.am +++ b/tools/Makefile.am @@ -20,7 +20,8 @@ bin_PROGRAMS =

[Linuxwacom-devel] [PATCH 2/8] xsetwacom: Declare printf attribute on print_{, button_}value

Signed-off-by: Jason Gerecke killert...@gmail.com --- tools/xsetwacom.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/xsetwacom.c b/tools/xsetwacom.c index 97f572d..bc22be0 100644 --- a/tools/xsetwacom.c +++ b/tools/xsetwacom.c @@ -661,6 +661,7 @@ static param_t* find_parameter(char

Re: [Linuxwacom-devel] [PATCH 4/5] xsetwacom: Add print_button_value function

On 1/27/2015 4:35 PM, Peter Hutterer wrote: On Mon, Jan 26, 2015 at 01:27:59PM -0800, Jason Gerecke wrote: Setting a button value requires a slightly different format than most other properties. In particular, they require the presence of a button number either concatenated onto the prefix

Re: [Linuxwacom-devel] [PATCH 5/8] xsetwacom: Use 'fabs' instead of 'abs' where necessary

On Thu, Jan 29, 2015 at 06:14:07PM -0800, Jason Gerecke wrote: Fixes multiple clang warnings about the use of 'abs' with a floating- point argument. Signed-off-by: Jason Gerecke killert...@gmail.com --- src/wcmCommon.c | 2 +- src/wcmTouchFilter.c | 4 ++-- 2 files changed, 3

Re: [Linuxwacom-devel] [PATCH 8/8] doc: Fix doxygen.conf warnings

On Thu, Jan 29, 2015 at 06:14:10PM -0800, Jason Gerecke wrote: Remove the obsolete XML_SCHEMA and XML_DTD definitions, as well as clear the definition of DOT_FONTNAME. Signed-off-by: Jason Gerecke killert...@gmail.com series: Reviewed-by: Peter Hutterer peter.hutte...@who-t.net thanks