Re: [Linuxwacom-devel] [PATCH] lib: Don't export private symbols

2012-01-31 Thread Bastien Nocera
Robert Ancell writes: > > Attached patch stops private symbols from being exported in the library > (currently bus_from_str, bus_to_str, type_from_str) The patch is fine by me. People that want to port it to Solaris will need to start by making libgudev a compile-time dependency. We can see a

Re: [Linuxwacom-devel] [PATCH] lib: Don't export private symbols

2012-01-11 Thread Peter Hutterer
On Wed, Jan 11, 2012 at 04:38:54PM +0100, Robert Ancell wrote: > Attached patch stops private symbols from being exported in the > library (currently bus_from_str, bus_to_str, type_from_str) Can we use something similar to X.org's _X_EXPORT. At least that forces us to mark symbols we actually want

Re: [Linuxwacom-devel] [PATCH] lib: Don't export private symbols

2012-01-11 Thread Jason Gerecke
I've been meaning to get around to fixing up and submitting the Solaris patches that were submitted a while back (they work fine, but are in need of some editing)... Higher priority projects keep appearing on my plate before I can do much with it, but I'd still like to keep the GNU-isms to a minimu

Re: [Linuxwacom-devel] [PATCH] lib: Don't export private symbols

2012-01-11 Thread Ping Cheng
On Wed, Jan 11, 2012 at 12:57 PM, Chris Bagwell wrote: > This uses a gnu-ish. Not sure if this matters or if any of the other > xf86-input-* do this type stuff. > > Once upon a time, there was a port of xf86-input-wacom to Solaris > using non-GNU linker. We still need this port. So, please keep

Re: [Linuxwacom-devel] [PATCH] lib: Don't export private symbols

2012-01-11 Thread Chris Bagwell
This uses a gnu-ish. Not sure if this matters or if any of the other xf86-input-* do this type stuff. Once upon a time, there was a port of xf86-input-wacom to Solaris using non-GNU linker. Chris On Wed, Jan 11, 2012 at 9:38 AM, Robert Ancell wrote: > Attached patch stops private symbols from

[Linuxwacom-devel] [PATCH] lib: Don't export private symbols

2012-01-11 Thread Robert Ancell
Attached patch stops private symbols from being exported in the library (currently bus_from_str, bus_to_str, type_from_str) Thanks, --Robert Ancell >From b4a7a3a434f1fa03a3f8a94c84f5b60d83980a1c Mon Sep 17 00:00:00 2001 From: Robert Ancell Date: Tue, 10 Jan 2012 10:19:46 +0100 Subject: [PATCH]