Re: [Linuxwacom-devel] [PATCH] optionally support multi-touch input interface

2010-03-20 Thread Ping Cheng
On Sat, Mar 20, 2010 at 1:38 AM, Giuseppe Bilotta wrote: > On Sat, Mar 20, 2010 at 1:32 AM, Ping Cheng wrote: >> I am aware of the issues for Bamboo touch. And I can remove the second >> finger data.  But, I'd like to know what the community would like to >> have for Bamboo - one finger only or a

Re: [Linuxwacom-devel] [PATCH] optionally support multi-touch input interface

2010-03-20 Thread Giuseppe Bilotta
On Sat, Mar 20, 2010 at 1:32 AM, Ping Cheng wrote: > I am aware of the issues for Bamboo touch. And I can remove the second > finger data.  But, I'd like to know what the community would like to > have for Bamboo - one finger only or a buggy two fingers.  TBH, I > don't have a hard deadline for Ba

Re: [Linuxwacom-devel] [PATCH] optionally support multi-touch input interface

2010-03-19 Thread Ping Cheng
On Fri, Mar 19, 2010 at 4:26 PM, Chris Bagwell wrote: > No complaints here... Do what ever allows you to keep moving forward > with least resistance..  I am lead of other projects so I understand. Thank you for your understand. It was very hard for me to make that decision. > If Bamboo P&T suppo

Re: [Linuxwacom-devel] [PATCH] optionally support multi-touch input interface

2010-03-19 Thread Chris Bagwell
No complaints here... Do what ever allows you to keep moving forward with least resistance.. I am lead of other projects so I understand. If Bamboo P&T support is going to wacom-linux tested branch soon, can I recommend not including support for the second finger since its basically broken? That

Re: [Linuxwacom-devel] [PATCH] optionally support multi-touch input interface

2010-03-18 Thread Ping Cheng
Hi Chris, I know how much effort you have put on the _MT_ support. I'd love to go with your solution if I don't have to support older kernels. Considering _MT_ support haven't officially been introduced into X server yet, we are not too far away from the reality by using xxxTAPs in wacom_drv.so.

Re: [Linuxwacom-devel] [PATCH] optionally support multi-touch input interface

2010-03-18 Thread Chris Bagwell
On Wed, Mar 17, 2010 at 11:25 PM, Ping Cheng wrote: > Hi Chris, > > Thank you for the two patches. I agree that Bamboo touch doesn't have > to follow TPC code since it doesn't have one finger model.  I have no > problem for you to merge the in and out routines together. > > I will apply your chang

Re: [Linuxwacom-devel] [PATCH] optionally support multi-touch input interface

2010-03-17 Thread Ping Cheng
Hi Chris, Thank you for the two patches. I agree that Bamboo touch doesn't have to follow TPC code since it doesn't have one finger model. I have no problem for you to merge the in and out routines together. I will apply your changes into the next release. For kernels older than 2.6.30, I can n

Re: [Linuxwacom-devel] [PATCH] optionally support multi-touch input interface

2010-03-17 Thread Chris Bagwell
That patch is a little hard to read unless you apply it first. I've attached the meet of the function here to read comments: static void wacom_bpt_touch(struct wacom_wac *wacom, void *wcombo, int force_out) { char *data = wacom->data; int pressure1 = 0,

Re: [Linuxwacom-devel] [PATCH] optionally support multi-touch input interface

2010-03-17 Thread Chris Bagwell
Hi Ping, So let me talk with code... I've attached two patches. The first is what you can apply to 2.6.27 kernel right now and should work same as today... Well, it adds back some logic you removed related to attempting to not send back-to-back out-of-prox events to work around issues this input

Re: [Linuxwacom-devel] [PATCH] optionally support multi-touch input interface

2010-03-17 Thread Ping Cheng
Hi Chris, You made a valid argument for Bamboo touch. And I am willing to compromise. I'll show my part of the picture before discussing what to do next. (sorry Chris. I want to make sure Peter read this line in case he is too busy to read the rest of the message) Peter, should xf86-input-wac

Re: [Linuxwacom-devel] [PATCH] optionally support multi-touch input interface

2010-03-17 Thread Chris Bagwell
Late reply from myself as well. My main laptop died last week and I've been offline more then normal as I recover from that. Replies below. On Tue, Mar 16, 2010 at 12:40 AM, Ping Cheng wrote: > Hi Chris, > > Sorry for my late reply.  I was investigating a "decent" solution for MT > support.  As

Re: [Linuxwacom-devel] [PATCH] optionally support multi-touch input interface

2010-03-15 Thread Ping Cheng
Hi Chris, Sorry for my late reply. I was investigating a "decent" solution for MT support. As you know backward compatibility is the major concern here. Replacing xxxTAP with _MT_ events at this stage requires both kernel and X driver changes. Plus there are third party developers relying on

Re: [Linuxwacom-devel] [PATCH] optionally support multi-touch input interface

2010-03-09 Thread Chris Bagwell
+ if (common->wcmMTChan) + { + int mtc; + + for (mtc = 1; mtc < common->wcmMTChan; mtc++) + wcmEvent(common, mtc, &common->wcmChannel[mtc].work); + common->wcmMTChan = 0; + } Opps, I decided to change this to support

[Linuxwacom-devel] [PATCH] optionally support multi-touch input interface

2010-03-09 Thread chris
From: Chris Bagwell The wacom kernel driver will eventually move to use the linux input multi-touch interface to return multi-touch finger data to wacom X driver. If multi-touch events are received, this patch disables old way of splitting up finger data based on BTN_TOOL_DOUBLETAP and BTN_TOOL_