Re: [Linuxwacom-devel] [PATCH] wcmUSB: change MOD_BUTTONS macro into a function

2011-03-22 Thread Peter Hutterer
On Tue, Mar 22, 2011 at 11:17:46AM -0700, Jason Gerecke wrote: > On Mon, Mar 21, 2011 at 9:16 PM, Peter Hutterer > wrote: > > +/** > > + * Flip the mask bit in buttons corresponding to btn to the specified > > state. > > + * > > + * @param buttons The current button mask > > + * @param btn Zero-i

Re: [Linuxwacom-devel] [PATCH] wcmUSB: change MOD_BUTTONS macro into a function

2011-03-22 Thread Jason Gerecke
On Mon, Mar 21, 2011 at 9:16 PM, Peter Hutterer wrote: > +/** > + * Flip the mask bit in buttons corresponding to btn to the specified state. > + * > + * @param buttons The current button mask > + * @param btn Zero-indexed button number to change > + * @param state Zero to unset, non-zero to set t

Re: [Linuxwacom-devel] [PATCH] wcmUSB: change MOD_BUTTONS macro into a function

2011-03-21 Thread Ping Cheng
Reviewed-by: Ping Cheng Ping On Mon, Mar 21, 2011 at 9:16 PM, Peter Hutterer wrote: > Values in, values out. No magic state structs, keep it simple. > > Signed-off-by: Peter Hutterer > --- > src/wcmUSB.c | 55 > --- > test/wacom-tests.c |

[Linuxwacom-devel] [PATCH] wcmUSB: change MOD_BUTTONS macro into a function

2011-03-21 Thread Peter Hutterer
Values in, values out. No magic state structs, keep it simple. Signed-off-by: Peter Hutterer --- src/wcmUSB.c | 55 --- test/wacom-tests.c | 16 +++ 2 files changed, 55 insertions(+), 16 deletions(-) diff --git a/src/wcmUSB.c