Re: [Linuxwacom-devel] [PATCH 1/2] Fix X crash after remapping touchstrips and wheels

2011-03-24 Thread Jason Gerecke
On Wed, Mar 23, 2011 at 6:30 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Wed, Mar 23, 2011 at 12:58:21PM -0700, Jason Gerecke wrote: As I'm working on the X11 wheel mapping, I'm finding a few weird quirks in the code. I pretty much understand 'how' things work, but I'm not sure why

Re: [Linuxwacom-devel] [PATCH 1/2] Fix X crash after remapping touchstrips and wheels

2011-03-23 Thread Jason Gerecke
As I'm working on the X11 wheel mapping, I'm finding a few weird quirks in the code. I pretty much understand 'how' things work, but I'm not sure why some things are the way they are... 1. Why does WACOM_PROP_BUTTON_ACTIONS have room for only 16 buttons, yet priv-btn_actions (storing the same

Re: [Linuxwacom-devel] [PATCH 1/2] Fix X crash after remapping touchstrips and wheels

2011-03-23 Thread Peter Hutterer
On Wed, Mar 23, 2011 at 12:58:21PM -0700, Jason Gerecke wrote: As I'm working on the X11 wheel mapping, I'm finding a few weird quirks in the code. I pretty much understand 'how' things work, but I'm not sure why some things are the way they are... 1. Why does WACOM_PROP_BUTTON_ACTIONS have

Re: [Linuxwacom-devel] [PATCH 1/2] Fix X crash after remapping touchstrips and wheels

2011-03-23 Thread Peter Hutterer
On Thu, Mar 24, 2011 at 11:30:35AM +1000, Peter Hutterer wrote: On Wed, Mar 23, 2011 at 12:58:21PM -0700, Jason Gerecke wrote: As I'm working on the X11 wheel mapping, I'm finding a few weird quirks in the code. I pretty much understand 'how' things work, but I'm not sure why some things

Re: [Linuxwacom-devel] [PATCH 1/2] Fix X crash after remapping touchstrips and wheels

2011-03-22 Thread Jason Gerecke
*grumble, grumble* There has got to be a GMail extension that makes Reply to all more prominent than Reply for lists... On Mon, Mar 21, 2011 at 9:11 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Fri, Mar 18, 2011 at 06:01:16PM -0700, Jason Gerecke wrote: Crash first appears in

Re: [Linuxwacom-devel] [PATCH 1/2] Fix X crash after remapping touchstrips and wheels

2011-03-22 Thread Peter Hutterer
On Tue, Mar 22, 2011 at 10:47:02AM -0700, Jason Gerecke wrote: On Mon, Mar 21, 2011 at 9:11 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Fri, Mar 18, 2011 at 06:01:16PM -0700, Jason Gerecke wrote: Crash first appears in ab311bf20535acd6e7201e024bc311e0e15b5b6b. This commit rewrote

Re: [Linuxwacom-devel] [PATCH 1/2] Fix X crash after remapping touchstrips and wheels

2011-03-21 Thread Peter Hutterer
On Fri, Mar 18, 2011 at 06:01:16PM -0700, Jason Gerecke wrote: Crash first appears in ab311bf20535acd6e7201e024bc311e0e15b5b6b. This commit rewrote wcmUpdateButtonKeyActions with one-indexed arrays in mind and extended the 'keys' array in _WacomDeviceRec to make room. However, the 'wheel_keys'

Re: [Linuxwacom-devel] [PATCH 1/2] Fix X crash after remapping touchstrips and wheels

2011-03-20 Thread Chris Bagwell
Looks needed to me based on other patch. I do not have way to test these types of pad buttons. Acked-by: Chris Bagwell ch...@cnpbagwell.com On Fri, Mar 18, 2011 at 8:01 PM, Jason Gerecke killert...@gmail.com wrote: Crash first appears in ab311bf20535acd6e7201e024bc311e0e15b5b6b. This commit