Re: [Linuxwacom-devel] [PATCH 3/3] Fix usbGetRanges() for any load order of touch/pad

2010-03-05 Thread Chris Bagwell
On Thu, Mar 4, 2010 at 11:45 PM, Ping Cheng wrote: > On Thu, Mar 4, 2010 at 5:41 PM, wrote: >> This is applies to devices that have both BTN_TOOL_FINGER >> and BTN_TOOL_DOUBLETAP which currently is limitted to >> Bamboo touch devices. > > Since the patch applies to the devices that have both BTN_

Re: [Linuxwacom-devel] [PATCH 3/3] Fix usbGetRanges() for any load order of touch/pad

2010-03-04 Thread Ping Cheng
On Thu, Mar 4, 2010 at 5:41 PM, wrote: > From: Chris Bagwell > > For Bamboo P&T devices, both a touch and pad type are > shared for single input device and can be called in any > order based on xorg.conf. And normal HAL order is to > invoke usbGetRanges() from pad first. > > This meant all logi

Re: [Linuxwacom-devel] [PATCH 3/3] Fix usbGetRanges() for any load order of touch/pad

2010-03-04 Thread Chris Bagwell
Thanks. For those interested, the touch part of Bamboo Pen and Touches should be working fine now in xf86-input-wacom. Thats without gesture support though. There are reports of pen having some issues linuxwacom-discuss so I might switch over and debug that while Ping works on 0.8.5-11. Chris

Re: [Linuxwacom-devel] [PATCH 3/3] Fix usbGetRanges() for any load order of touch/pad

2010-03-04 Thread Peter Hutterer
On Thu, Mar 04, 2010 at 07:41:57PM -0600, ch...@cnpbagwell.com wrote: > From: Chris Bagwell > > For Bamboo P&T devices, both a touch and pad type are > shared for single input device and can be called in any > order based on xorg.conf. And normal HAL order is to > invoke usbGetRanges() from pad

[Linuxwacom-devel] [PATCH 3/3] Fix usbGetRanges() for any load order of touch/pad

2010-03-04 Thread chris
From: Chris Bagwell For Bamboo P&T devices, both a touch and pad type are shared for single input device and can be called in any order based on xorg.conf. And normal HAL order is to invoke usbGetRanges() from pad first. This meant all logic related to IsTouch() was not correctly running. Upda

Re: [Linuxwacom-devel] [PATCH 3/3] Fix usbGetRanges() for any load order of touch/pad

2010-02-28 Thread Ping Cheng
Hi Chris, I read your commit comments again. It clearly spelled out the rational behind the patch. I am convinced. Sorry for making you explain it again. Reviewed-by: Ping Cheng Ping On Sat, Feb 27, 2010 at 8:56 PM, Chris Bagwell wrote: > On Sat, Feb 27, 2010 at 10:23 PM, Ping Cheng wrot

Re: [Linuxwacom-devel] [PATCH 3/3] Fix usbGetRanges() for any load order of touch/pad

2010-02-27 Thread Chris Bagwell
On Sat, Feb 27, 2010 at 10:23 PM, Ping Cheng wrote: > On Sat, Feb 27, 2010 at 7:10 PM, Chris Bagwell wrote: >> Ping, was this a comment about the patch or a general statement?  The >> patch limits special logic to Bamboo Touch series when invoked with >> pad type. > > A general statement. > >> Bu

Re: [Linuxwacom-devel] [PATCH 3/3] Fix usbGetRanges() for any load order of touch/pad

2010-02-27 Thread Ping Cheng
On Sat, Feb 27, 2010 at 7:10 PM, Chris Bagwell wrote: > Ping, was this a comment about the patch or a general statement?  The > patch limits special logic to Bamboo Touch series when invoked with > pad type. A general statement. > But in general, we need to support calling GetRanges() with pads

Re: [Linuxwacom-devel] [PATCH 3/3] Fix usbGetRanges() for any load order of touch/pad

2010-02-27 Thread Chris Bagwell
Ping, was this a comment about the patch or a general statement? The patch limits special logic to Bamboo Touch series when invoked with pad type. But in general, we need to support calling GetRanges() with pads for cases when user defines devices in xorg.conf. Most devices with pad support also

Re: [Linuxwacom-devel] [PATCH 3/3] Fix usbGetRanges() for any load order of touch/pad

2010-02-27 Thread Ping Cheng
Pad doesn't need MaxX/Y and ResX/Y since it doesn't send motion events. So, there is no need to get range for pad, except for Intuos3/4 and Cintiq's, which is for the menu strips. Ping On Tue, Feb 23, 2010 at 6:55 PM, wrote: > From: Chris Bagwell > > For Bamboo P&T devices, both a touch and p

Re: [Linuxwacom-devel] [PATCH 3/3] Fix usbGetRanges() for any load order of touch/pad

2010-02-23 Thread Peter Hutterer
On Tue, Feb 23, 2010 at 08:55:40PM -0600, ch...@cnpbagwell.com wrote: > From: Chris Bagwell > > For Bamboo P&T devices, both a touch and pad type are > shared for single input device and can be called in any > order based on xorg.conf. And normal HAL order is to > invoke usbGetRanges() from pad

[Linuxwacom-devel] [PATCH 3/3] Fix usbGetRanges() for any load order of touch/pad

2010-02-23 Thread chris
From: Chris Bagwell For Bamboo P&T devices, both a touch and pad type are shared for single input device and can be called in any order based on xorg.conf. And normal HAL order is to invoke usbGetRanges() from pad first. This meant all logic related to IsTouch() was not correctly running. Upda