Re: [Linuxwacom-devel] [PATCH v2] usb: count the number of buttons instead of hardcoding them.

2011-03-31 Thread Peter Hutterer
On Wed, Mar 30, 2011 at 10:34:34AM -0500, Chris Bagwell wrote: > On Tue, Mar 29, 2011 at 10:53 PM, Peter Hutterer > wrote: > > Signed-off-by: Peter Hutterer > > --- > > > > Chris, can you comment on the fixme I have added here. The current code > > seems to increase the number of buttons on the d

Re: [Linuxwacom-devel] [PATCH v2] usb: count the number of buttons instead of hardcoding them.

2011-03-30 Thread Chris Bagwell
On Tue, Mar 29, 2011 at 10:53 PM, Peter Hutterer wrote: > Signed-off-by: Peter Hutterer > --- > > Chris, can you comment on the fixme I have added here. The current code > seems to increase the number of buttons on the device when mouse buttons are > found but I don't understand why. As I underst

[Linuxwacom-devel] [PATCH v2] usb: count the number of buttons instead of hardcoding them.

2011-03-29 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- Chris, can you comment on the fixme I have added here. The current code seems to increase the number of buttons on the device when mouse buttons are found but I don't understand why. As I understand this, the code is still overlapping, so you get one pad code and