The isdv4ParseTouchQuery and isdv4ParseTouchData functions
return 0 and -1 if errors occur. At the moment, only the -1
case is being handled, which can result in the callers using
uninitialized ISDV4TouchQueryReply or ISDV4TouchData results.
Signed-off-by: Jason Gerecke killert...@gmail.com
Signed-off-by: Jason Gerecke killert...@gmail.com
---
tools/xsetwacom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/xsetwacom.c b/tools/xsetwacom.c
index 5a5173d..805fba9 100644
--- a/tools/xsetwacom.c
+++ b/tools/xsetwacom.c
@@ -1252,7 +1252,7 @@ static Bool
^
isdv4-serial-inputattach.c:22:9: warning: macro is not used [-Wunused-macros]
#define WACOM_TOOLS
^
Signed-off-by: Jason Gerecke killert...@gmail.com
---
tools/isdv4-serial-debugger.c| 1 -
tools/isdv4-serial-inputattach.c | 1 -
tools/tools-shared.c | 1 -
tools
../src/wcmUSB.c:1140:9: warning: 'return' will never be executed
[-Wunreachable-code-return]
return 0;
^
Signed-off-by: Jason Gerecke killert...@gmail.com
---
src/wcmUSB.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/wcmUSB.c b/src/wcmUSB.c
index d2c8511
Signed-off-by: Jason Gerecke killert...@gmail.com
---
src/wcmUSB.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/wcmUSB.c b/src/wcmUSB.c
index 5332702..bb81175 100644
--- a/src/wcmUSB.c
+++ b/src/wcmUSB.c
@@ -80,9 +80,9 @@ static struct _WacomModel mname
Clang by default does not emit warnings for system headers, but
most includes will be added with '-I' which doesn't count as a
system header. This patch has them included with '-isystem' so
that we can more easily see problems with *our* code.
Signed-off-by: Jason Gerecke killert...@gmail.com
]
{ NULL }
^
Signed-off-by: Jason Gerecke killert...@gmail.com
---
src/wcmISDV4.c | 1 +
src/wcmTouchFilter.c | 12 ++--
tools/xsetwacom.c| 2 +-
3 files changed, 8 insertions(+), 7 deletions(-)
diff --git a/src/wcmISDV4.c b/src/wcmISDV4.c
index 55439eb
../src/wcmXCommand.c:439:5: warning: 'break' will never be executed
[-Wunreachable-code-break]
break;
^
Signed-off-by: Jason Gerecke killert...@gmail.com
---
src/wcmXCommand.c | 1 -
1 file changed, 1 deletion(-)
diff --git
True on success or False otherwise.
^
Signed-off-by: Jason Gerecke killert...@gmail.com
---
src/wcmCommon.c | 2 +-
src/wcmUSB.c| 2 +-
src/wcmValidateDevice.c | 6 +++---
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/wcmCommon.c b/src/wcmCommon.c
index
-static variable 'verbose' [-Wmissing-variable-declarations]
int verbose;
^
Signed-off-by: Jason Gerecke killert...@gmail.com
---
src/wcmConfig.c | 2 +-
src/wcmXCommand.c| 44
tools/isdv4-serial-debugger.c| 1
Signed-off-by: Jason Gerecke killert...@gmail.com
---
tools/xsetwacom.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/xsetwacom.c b/tools/xsetwacom.c
index 26b3513..304f9fa 100644
--- a/tools/xsetwacom.c
+++ b/tools/xsetwacom.c
@@ -655,6 +655,7 @@ static void print_value(param_t
-by: Jason Gerecke killert...@gmail.com
---
Changes in v2:
* Changed from a pre-decrement 'while' to a 'for' loop. The former
wouldn't work right with ndevices == 0 and would have required a
second 'Unable to locate device' error message.
tools/xsetwacom.c | 7 ---
1 file changed, 4
On Thu, Sep 18, 2014 at 3:08 PM, Peter Hutterer
peter.hutte...@who-t.net wrote:
On Wed, Sep 17, 2014 at 07:11:35PM -0700, Jason Gerecke wrote:
../src/wcmConfig.c:701:16: warning: no previous extern declaration for
non-static variable 'WACOM' [-Wmissing-variable-declarations]
InputDriverRec
On Thu, Sep 18, 2014 at 5:50 PM, Peter Hutterer
peter.hutte...@who-t.net wrote:
On Thu, Sep 18, 2014 at 05:30:55PM -0700, Jason Gerecke wrote:
[...]
diff --git a/tools/isdv4-serial-debugger.c b/tools/isdv4-serial-debugger.c
index 6629cb6..03abd26 100644
--- a/tools/isdv4-serial-debugger.c
On Thu, Sep 18, 2014 at 3:07 PM, Peter Hutterer
peter.hutte...@who-t.net wrote:
On Wed, Sep 17, 2014 at 07:11:25PM -0700, Jason Gerecke wrote:
Clang by default does not emit warnings for system headers, but
most includes will be added with '-I' which doesn't count as a
system header
On Thu, Sep 18, 2014 at 6:15 PM, Peter Hutterer
peter.hutte...@who-t.net wrote:
On Thu, Sep 18, 2014 at 06:10:49PM -0700, Jason Gerecke wrote:
On Thu, Sep 18, 2014 at 5:50 PM, Peter Hutterer
peter.hutte...@who-t.net wrote:
On Thu, Sep 18, 2014 at 05:30:55PM -0700, Jason Gerecke wrote
, and only
while it remains held.
This patch strengthens the condition that the pad may never be granted
control by making it the first thing checked.
Signed-off-by: Jason Gerecke killert...@gmail.com
---
src/wcmCommon.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git
and undesired catch up effect due to the large built-up delta.
To work around this, when a gesture starts, we reset the wcmGestureState
so that the functions are working with a clean slate and do not see the
large delta.
Signed-off-by: Jason Gerecke killert...@gmail.com
---
src/wcmTouchFilter.c | 23
* Add missing semicolon to 0x4004 definition (2.6.38)
* Remove duplicate device definition (2.6.30)
* Add missing closing brace (2.6.30)
Signed-off-by: Jason Gerecke killert...@gmail.com
---
2.6.30/wacom_wac.c | 3 +--
2.6.38/wacom_wac.c | 2 +-
2 files changed, 2 insertions(+), 3 deletions
Signed-off-by: Jason Gerecke killert...@gmail.com
---
2.6.36/wacom_sys.c | 4 ++--
2.6.38/wacom_sys.c | 6 +++---
3.7/wacom_sys.c| 6 +++---
3 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/2.6.36/wacom_sys.c b/2.6.36/wacom_sys.c
index 14962d7..6fb0d10 100644
--- a/2.6.36
only if it has not already been registered and use the
new behavior otherwise.
Fixes SF bug #248
Signed-off-by: Jason Gerecke killert...@gmail.com
---
2.6.38/wacom_sys.c | 15 ++-
2.6.38/wacom_wac.h | 1 +
3.7/wacom_sys.c| 15 ++-
3.7/wacom_wac.h| 1 +
4 files
On Thu, Oct 9, 2014 at 6:41 AM, Ron r...@debian.org wrote:
Hi,
The SF downloads appear to be showing a 0.26.1 release tarball,
but I'm not seeing a version bump commit, or tag in the SF git
repo. Did someone just forget to push, or did the primary git
tree move again while I wasn't looking
Signed-off-by: Jason Gerecke killert...@gmail.com
---
data/cintiq-21ux2.tablet | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/data/cintiq-21ux2.tablet b/data/cintiq-21ux2.tablet
index 6e780a2..d09461e 100644
--- a/data/cintiq-21ux2.tablet
+++ b/data/cintiq-21ux2.tablet
Signed-off-by: Jason Gerecke killert...@gmail.com
---
data/cintiq-companion.tablet | 44 +++
data/layouts/cintiq-companion.svg | 234 ++
2 files changed, 278 insertions(+)
create mode 100644 data/cintiq-companion.tablet
create mode 100644 data
On Fri, Nov 14, 2014 at 1:09 AM, Robert Miller yocto...@gmail.com wrote:
Hi! I've never submitted a patch to anything before so I hope I'm not
wasting your time, but I found a bug while using my cintiq companion hybrid
and I traced it to linux_wacom.
I'm on Ubuntu 14.04, and the device I'm
Fixes a minor error in commit 52fe01c which results in the driver
invalidating an fd prior to (potentially) closing it. This reversed
order causes us to leak the fd and can result in eventual exhasution.
Fixes SF #263
Signed-off-by: Jason Gerecke killert...@gmail.com
---
src/xf86Wacom.c | 2
Signed-off-by: Jason Gerecke killert...@gmail.com
---
tools/xsetwacom.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/xsetwacom.c b/tools/xsetwacom.c
index 5a35ee8..d1b6242 100644
--- a/tools/xsetwacom.c
+++ b/tools/xsetwacom.c
@@ -593,6 +593,8 @@ static struct modifier specialkeys
On Sun, Dec 7, 2014 at 4:59 PM, Peter Hutterer peter.hutte...@who-t.net wrote:
On Fri, Dec 05, 2014 at 01:39:26PM -0800, Jason Gerecke wrote:
Fixes a minor error in commit 52fe01c which results in the driver
invalidating an fd prior to (potentially) closing it. This reversed
order causes us
On Sun, Dec 7, 2014 at 4:59 PM, Peter Hutterer peter.hutte...@who-t.net wrote:
On Fri, Dec 05, 2014 at 01:39:25PM -0800, Jason Gerecke wrote:
Signed-off-by: Jason Gerecke killert...@gmail.com
Reviewed-by: Peter Hutterer peter.hutte...@who-t.net
---
tools/xsetwacom.c | 2 ++
1 file
On Sat, Dec 13, 2014 at 11:33 PM, Feng Yu rainwood...@gmail.com wrote:
Greetings.
Recently I purchased a x230 tablet; it has an on-screen digitizer. My first
stylus computer and I was quite excited.
I was pretty sad when I figured that no matter how I calibrated the stylus,
in much of the
Signed-off-by: Jason Gerecke killert...@gmail.com
---
2.6.36/wacom_sys.c | 2 +-
2.6.36/wacom_wac.c | 2 +-
2.6.36/wacom_wac.h | 1 +
3 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/2.6.36/wacom_sys.c b/2.6.36/wacom_sys.c
index 4e84089..4ea452f 100644
--- a/2.6.36/wacom_sys.c
+++ b
The Wacom Cintiq Companion shares the same sensor than the Cintiq
Companion Hybrid, with the exception of the different PIDs.
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com
Signed-off-by: Jiri Kosina jkos...@suse.cz
---
3.17/wacom_wac.c | 10 ++
1 file changed, 10
From: Ping Cheng pingli...@gmail.com
touch_input is stored in wacom_shared for pen data to report touch
switch status. It is possible, although we didn't see it happen on
Linux yet, that pen data is procesed before touch interface is
fully probed.
As a by-product of this patch, it fixes the
if !CONFIG_PM
Jason Gerecke (4):
HID: wacom: Add support for the Cintiq Companion
Backport: Add support for the Cintiq Companion
Backport: make the WL connection friendly for the desktop
Backport: Fix compilation of generic HID handling patch under 3.17
Ping Cheng (1):
Input: wacom
Signed-off-by: Jason Gerecke killert...@gmail.com
---
2.6.38/wacom_sys.c | 4
3.7/wacom_sys.c| 4
2 files changed, 8 insertions(+)
diff --git a/2.6.38/wacom_sys.c b/2.6.38/wacom_sys.c
index 51376e7..8a1a41f 100644
--- a/2.6.38/wacom_sys.c
+++ b/2.6.38/wacom_sys.c
@@ -1192,6
-by: Ping Cheng pi...@wacom.com
Reviewed-by: Jason Gerecke killert...@gmail.com
Signed-off-by: Dmitry Torokhov dmitry.torok...@gmail.com
---
3.17/wacom_wac.c | 28 +++-
1 file changed, 7 insertions(+), 21 deletions(-)
diff --git a/3.17/wacom_wac.c b/3.17/wacom_wac.c
index
From: Ping Cheng pingli...@gmail.com
Defined outbound offset for DTU and Cintiq. But didn't update
the relevant maximum values. Oops...
Signed-off-by: Ping Cheng pi...@wacom.com
Signed-off-by: Jiri Kosina jkos...@suse.cz
---
3.17/wacom_wac.c | 18 +-
1 file changed, 9
From: Benjamin Tissoires benjamin.tissoi...@redhat.com
Since the conversion from USB to HID (in v3.17), some people reported a
freeze on boot with the wacom driver. Hans managed to get a stacktrace:
[ 240.272331] Call Trace:
[ 240.272338] [813de7b9] ? usb_hcd_submit_urb+0xa9/0xb10
[
From: Ping Cheng pingli...@gmail.com
Graphire 4 only has two tablet buttons; Bamboo Fun touch ring is only
for PAD.
Signed-off-by: Ping Cheng pi...@wacom.com
Reviewed-by: Benjamin Tissoires benjamin.tissoi...@redhat.com
Signed-off-by: Jiri Kosina jkos...@suse.cz
---
3.17/wacom_wac.c | 5 -
From: Ping Cheng pingli...@gmail.com
There are screen to tablet offsets for newer Cintiq and DTU models.
These offsets serve as outbound tracking for those display tablets.
Use defines instead of hardcoded numbers for the offsets.
Signed-off-by: Ping Cheng pi...@wacom.com
Signed-off-by: Jiri
ISDv4-5).
This patch only splits the allocation and registration, but do not
change where we allocate the input. This will come in a later patch.
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com
Acked-by: Jason Gerecke killert...@gmail.com
Signed-off-by: Jiri Kosina jkos...@suse.cz
Signed-off-by: Jason Gerecke killert...@gmail.com
---
2.6.38/wacom_wac.c | 7 +--
3.7/wacom_wac.c| 7 +--
2 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/2.6.38/wacom_wac.c b/2.6.38/wacom_wac.c
index 6dd2a51..c58abcc 100644
--- a/2.6.38/wacom_wac.c
+++ b/2.6.38
From: Benjamin Tissoires benjamin.tissoi...@redhat.com
Currently, tablets connected to the WL receiver all share the same
VID/PID. There is no way for the user space to know which one is which
besides parsing the name. We can force the PID to be set to the
actual hardware. This way, the input
Backports several bugfix patches that are destined for Linux 3.19.
Benjamin Tissoires (1):
HID: wacom: fix freeze on open when autosuspend is on
Jason Gerecke (3):
Backport: make sure touch_input is valid before using it
Backport: add defines for new Cintiq and DTU outbound tracking
Signed-off-by: Jason Gerecke killert...@gmail.com
---
2.6.30/wacom_wac.c | 22 +-
2.6.36/wacom_wac.c | 31 ++-
2.6.38/wacom_wac.c | 37 ++---
3.7/wacom_wac.c| 37 ++---
4 files
From: Benjamin Tissoires benjamin.tissoi...@redhat.com
Some Wacom tablets (at least the ISDv4 found in the Lenovo X230) timeout
during probe while retrieving the input reports.
The only time this information is valuable is during the feature_mapping
stage, so we can ask for it there and discard
From: Benjamin Tissoires benjamin.tissoi...@redhat.com
This allows to have the input devices ready in while parsing the reports
descriptor.
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com
Acked-by: Jason Gerecke killert...@gmail.com
Signed-off-by: Jiri Kosina jkos...@suse.cz
Signed-off-by: Jason Gerecke killert...@gmail.com
---
2.6.38/wacom_wac.c | 9 +
3.7/wacom_wac.c| 10 +-
2 files changed, 18 insertions(+), 1 deletion(-)
diff --git a/2.6.38/wacom_wac.c b/2.6.38/wacom_wac.c
index 223b744..6dd2a51 100644
--- a/2.6.38/wacom_wac.c
+++ b/2.6.38
From: Benjamin Tissoires benjamin.tissoi...@redhat.com
Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com
Acked-by: Jason Gerecke killert...@gmail.com
Signed-off-by: Jiri Kosina jkos...@suse.cz
---
3.17/wacom_sys.c | 39 --
3.17/wacom_wac.c | 120
Signed-off-by: Jason Gerecke killert...@gmail.com
---
2.6.30/wacom_wac.c | 14 +++---
2.6.36/wacom_wac.c | 14 +++---
2.6.38/wacom_wac.c | 18 +-
3.7/wacom_wac.c| 18 +-
4 files changed, 32 insertions(+), 32 deletions(-)
diff --git a/2.6.30
From: Ping Cheng pingli...@gmail.com
ENODEV indicates no device is added. Hence, the associated pad input device
is simply freed.
Signed-off-by: Ping Cheng pi...@wacom.com
Reviewed-by: Benjamin Tissoires benjamin.tissoi...@redhat.com
Signed-off-by: Jiri Kosina jkos...@suse.cz
---
From: Ping Cheng pingli...@gmail.com
Bamboo models do not support HID_DG_CONTACTMAX. Plus, Bamboo pen-only
has touch descriptor. This leads to some complications in the code.
This patch also fixes duplicated PAD interfeaces for Intuos Pen
models.
Signed-off-by: Ping Cheng pi...@wacom.com
From: Geert Uytterhoeven ge...@linux-m68k.org
If CONFIG_PM is not set:
drivers/hid/wacom_sys.c:1436: warning: ‘wacom_reset_resume’ defined but
not used
Protect the unused functions by #ifdef CONFIG_PM to fix this.
Signed-off-by: Geert Uytterhoeven ge...@linux-m68k.org
Reviewed-by: Benjamin
benjamin.tissoi...@redhat.com
Acked-by: Jason Gerecke killert...@gmail.com
Signed-off-by: Jiri Kosina jkos...@suse.cz
---
3.17/wacom_sys.c | 49 +
1 file changed, 29 insertions(+), 20 deletions(-)
diff --git a/3.17/wacom_sys.c b/3.17/wacom_sys.c
index 2508628
From: Jason Gerecke killert...@gmail.com
As suggested in the prior patch, we manually set hdev-claimed with
the necessary flag value (which is hardcoded since HID_CLAIMED_DRIVER
is not available in 3.17)
Signed-off-by: Jason Gerecke killert...@gmail.com
---
3.17/wacom.h | 1 +
3.17
an error will be printed.
Signed-off-by: Jason Gerecke killert...@gmail.com
---
tools/xsetwacom.c | 23 ++-
1 file changed, 22 insertions(+), 1 deletion(-)
diff --git a/tools/xsetwacom.c b/tools/xsetwacom.c
index 2460659..75305e8 100644
--- a/tools/xsetwacom.c
+++ b/tools
Setting a button value requires a slightly different format than most
other properties. In particular, they require the presence of a button
number either concatenated onto the prefix 'Button' (for xorg.conf format)
or as a seperate parameter (for shell format).
Signed-off-by: Jason Gerecke
Both FORMAT_XORG_CONF and FORMAT_SHELL are formatted for setting in xorg.conf
or xsetwacom. It makes no sense to bother printing out the value of readonly
values for these two cases though since it is impossible to set them.
Signed-off-by: Jason Gerecke killert...@gmail.com
---
tools/xsetwacom.c
Signed-off-by: Jason Gerecke killert...@gmail.com
---
tools/xsetwacom.c | 22 +-
1 file changed, 21 insertions(+), 1 deletion(-)
diff --git a/tools/xsetwacom.c b/tools/xsetwacom.c
index 402cc09..6b4189f 100644
--- a/tools/xsetwacom.c
+++ b/tools/xsetwacom.c
@@ -2570,7
Signed-off-by: Jason Gerecke killert...@gmail.com
---
tools/xsetwacom.c | 30 +++---
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/tools/xsetwacom.c b/tools/xsetwacom.c
index ec5d24e..2460659 100644
--- a/tools/xsetwacom.c
+++ b/tools/xsetwacom.c
To prevent the situation like the prior from occuring again, define
a list once up front and reference it elsewhere.
Signed-off-by: Jason Gerecke killert...@gmail.com
---
configure.ac | 50 +++---
1 file changed, 23 insertions(+), 27 deletions(-)
diff
If the kernel sources cannot be found (or --with-kernel=no), then
the 'make' later on has no chance of finishing successfully. Just
produce a warning and exit as soon as possible.
Signed-off-by: Jason Gerecke killert...@gmail.com
---
configure.ac | 15 ++-
1 file changed, 6
Adds '/lib/modules/`uname -r`/source' to the first loop's list
of search paths. This path is already used by the rest of the
code.
Signed-off-by: Jason Gerecke killert...@gmail.com
---
configure.ac | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/configure.ac b
Since configure now exits if the kernel sources could not be found,
it is no longer necessary to surround the kernel version check or
final message with 'if' blocks.
Signed-off-by: Jason Gerecke killert...@gmail.com
---
configure.ac | 96
in an
automated environment.
Jason Gerecke (7):
configure: Remove vestigal AC_SUBST
configure: Add missing kernel source search path
configure: Replace multiple kernel search paths with just one
configure: Stop with an error if the kernel sources can't be found
configure: Remove no-longer-necessary
It appears that the Cintiq Companion Hybrid does not send an ABS_MISC
event to userspace when any of its ExpressKeys are pressed. This causes
problems for xf86-input-wacom beginning with its 8f44f35 commit.
Fixes: https://sourceforge.net/p/linuxwacom/bugs/272/
Signed-off-by: Jason Gerecke killert
://sourceforge.net/p/linuxwacom/bugs/269/
Signed-off-by: Jason Gerecke killert...@gmail.com
---
tools/xsetwacom.c | 46 ++
1 file changed, 38 insertions(+), 8 deletions(-)
diff --git a/tools/xsetwacom.c b/tools/xsetwacom.c
index 3d6b417..ec5d24e 100644
--- a/tools
to support signed tilt values in late-2012 (2f2acec).
Signed-off-by: Jason Gerecke killert...@gmail.com
Reviewed-by: Ping Cheng pi...@wacom.com
Signed-off-by: Jiri Kosina jkos...@suse.cz
Signed-off-by: Jason Gerecke killert...@gmail.com
---
3.17/wacom_wac.c | 16
1 file changed
contact; when such a field is encountered all the stored
contact data will be reported.
Signed-off-by: Jason Gerecke killert...@gmail.com
Reviewed-by: Benjamin Tissoires benjamin.tissoi...@redhat.com
Signed-off-by: Jiri Kosina jkos...@suse.cz
Signed-off-by: Jason Gerecke killert...@gmail.com
...@redhat.com
Signed-off-by: Jiri Kosina jkos...@suse.cz
Signed-off-by: Jason Gerecke killert...@gmail.com
---
3.17/wacom_wac.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/3.17/wacom_wac.c b/3.17/wacom_wac.c
index 9e46288..734c223 100644
--- a/3.17/wacom_wac.c
+++ b/3.17/wacom_wac.c
@@ -3061,6
Signed-off-by: Jason Gerecke killert...@gmail.com
---
3.17/wacom_sys.c | 12
1 file changed, 12 insertions(+)
diff --git a/3.17/wacom_sys.c b/3.17/wacom_sys.c
index 8b841e5..40a70f3 100644
--- a/3.17/wacom_sys.c
+++ b/3.17/wacom_sys.c
@@ -1321,6 +1321,14 @@ static void
From: Jason Gerecke jason.gere...@wacom.com
Signed-off-by: Jason Gerecke killert...@gmail.com
---
2.6.30/wacom_wac.c | 5 +
2.6.30/wacom_wac.h | 1 +
2.6.36/wacom_wac.c | 7 +++
2.6.36/wacom_wac.h | 1 +
2.6.38/wacom_wac.c | 7 +++
2.6.38/wacom_wac.h | 1 +
3.7/wacom_wac.c| 7
the values and range by at least 10x would reduce the error in
the resolution to acceptable levels, but the xf86-input-wacom driver is not
able to use pre-scaled values for these axes at this time.
Signed-off-by: Jason Gerecke killert...@gmail.com
Reviewed-by: Ping Cheng pi...@wacom.com
Signed-off
The following patches have been merged by linus into his 3.19 tree and
need to be applied to input-wacom as well.
Benjamin Tissoires (1):
HID: wacom: re-add accidentally dropped Lenovo PID
Jason Gerecke (7):
HID: wacom: Report ABS_TILT_{X,Y} as signed values
HID: wacom: Add angular
,/
So you look at the sixty-fours
On Mon, Jan 12, 2015 at 11:48 AM, Jason Gerecke killert...@gmail.com wrote:
It is not necessarily sufficient to look only at the physical and logical
usages when determining if a field is for the pen or touch. Some fields
are not contained in a sub
I do not have a Bamboo Pad, but I've heard that people have had
success getting it to work using the steps described at [1].
Unfortunately, the workaround stopped working in Linux 3.17, so please
check that first.
[1]: http://thottingal.in/blog/2014/10/26/howto-wacom-bamboo-cth301k-in-debian/
Apparently xf86-input-wacom and input-wacom have a slightly different
notion of the project root.
Signed-off-by: Jason Gerecke killert...@gmail.com
---
release.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/release.sh b/release.sh
index 78c40f4..622eee9 100755
xf86-input-wacom hasn't used them for years now, and they're far less
popular to download anyway.
Signed-off-by: Jason Gerecke killert...@gmail.com
---
configure.ac | 2 +-
release.sh | 11 ++-
2 files changed, 3 insertions(+), 10 deletions(-)
diff --git a/configure.ac b/configure.ac
On 3/17/2015 4:51 PM, Peter Hutterer wrote:
On Tue, Mar 17, 2015 at 04:23:38PM -0700, Jason Gerecke wrote:
Apparently xf86-input-wacom and input-wacom have a slightly different
notion of the project root.
Signed-off-by: Jason Gerecke killert...@gmail.com
---
release.sh | 2 +-
1 file
On Wed, Mar 18, 2015 at 4:22 PM, Ping Cheng pingli...@gmail.com wrote:
On Wed, Mar 18, 2015 at 3:22 PM, Benjamin Tissoires
benjamin.tissoi...@gmail.com wrote:
On Sun, Mar 15, 2015 at 10:01 PM, Peter Hutterer
peter.hutte...@who-t.net wrote:
On Fri, Mar 13, 2015 at 11:24:27AM -0400, Benjamin
the final
release (when re-point the default download location to the new file).
Acked-by: Jason Gerecke killert...@gmail.com
Jason
---
Now instead of four in the eights place /
you’ve got three, ‘Cause you added one /
(That is to say, eight) to the two, /
But you can’t take seven from three
On 3/11/2015 6:15 PM, Peter Hutterer wrote:
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
src/wcmCommon.c | 3 +++
src/wcmTouchFilter.c | 8 +---
2 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/src/wcmCommon.c b/src/wcmCommon.c
index 7d56ba5..92f8cf8
at the moment with patch 2 where you
explicitly ignore the return value, but for everything else in the set:
Reviewed-by: Jason Gerecke killert...@gmail.com
--
Jason
---
Now instead of four in the eights place /
you’ve got three, ‘Cause you added one /
(That is to say, eight) to the two
The HID_CONNECT_DRIVER flag was added in Linux 3.18, while the
'hid_report_len' function was added in Linux 3.19.
Signed-off-by: Jason Gerecke killert...@gmail.com
---
3.17/wacom_sys.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/3.17/wacom_sys.c b/3.17/wacom_sys.c
xsetwacom.c: In function ‘get_button’:
xsetwacom.c:2080:2: warning: format ‘%d’ expects argument of type ‘int’, but
argument 4 has type ‘Atom’ [-Wformat=]
print_button_value(param, offset, %d, prop);
Signed-off-by: Jason Gerecke killert...@gmail.com
---
tools/xsetwacom.c | 2 +-
1 file
than
originally existed in new_words[0]).
Signed-off-by: Jason Gerecke killert...@gmail.com
---
tools/tools-shared.c | 2 +-
tools/tools-shared.h | 2 +-
tools/xsetwacom.c| 33 +
3 files changed, 15 insertions(+), 22 deletions(-)
diff --git a/tools/tools
Fixes multiple clang warnings about the use of 'abs' with a floating-
point argument.
Signed-off-by: Jason Gerecke killert...@gmail.com
---
src/wcmCommon.c | 2 +-
src/wcmTouchFilter.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/wcmCommon.c b/src/wcmCommon.c
Remove the obsolete XML_SCHEMA and XML_DTD definitions, as well
as clear the definition of DOT_FONTNAME.
Signed-off-by: Jason Gerecke killert...@gmail.com
---
doc/doxygen.conf.in | 14 +-
1 file changed, 1 insertion(+), 13 deletions(-)
diff --git a/doc/doxygen.conf.in b/doc
Signed-off-by: Jason Gerecke killert...@gmail.com
---
tools/xsetwacom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/xsetwacom.c b/tools/xsetwacom.c
index 284e6e2..db3a776 100644
--- a/tools/xsetwacom.c
+++ b/tools/xsetwacom.c
@@ -1285,7 +1285,7 @@ static int
to be more straightforward
and analyzable.
Signed-off-by: Jason Gerecke killert...@gmail.com
---
tools/xsetwacom.c | 29 +
1 file changed, 9 insertions(+), 20 deletions(-)
diff --git a/tools/xsetwacom.c b/tools/xsetwacom.c
index 22b47de..1fd70c8 100644
--- a/tools
Signed-off-by: Jason Gerecke killert...@gmail.com
---
tools/Makefile.am | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/Makefile.am b/tools/Makefile.am
index 0aad526..5622362 100644
--- a/tools/Makefile.am
+++ b/tools/Makefile.am
@@ -20,7 +20,8 @@
bin_PROGRAMS
Signed-off-by: Jason Gerecke killert...@gmail.com
---
tools/xsetwacom.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/xsetwacom.c b/tools/xsetwacom.c
index 97f572d..bc22be0 100644
--- a/tools/xsetwacom.c
+++ b/tools/xsetwacom.c
@@ -661,6 +661,7 @@ static param_t* find_parameter(char
On 1/27/2015 4:35 PM, Peter Hutterer wrote:
On Mon, Jan 26, 2015 at 01:27:59PM -0800, Jason Gerecke wrote:
Setting a button value requires a slightly different format than most
other properties. In particular, they require the presence of a button
number either concatenated onto the prefix
Currently its possible to provide a negative (or zero) button number
on the commandline, which will be dutifully translated into a negative
offset. Detect this and throw an error if encountered.
Signed-off-by: Jason Gerecke jason.jgere...@wacom.com
---
tools/xsetwacom.c | 4 ++--
1 file changed
by the server to take up only 4
bytes of memory. This is the case on 32-bit systems, but not
on 64-bit ones. This was partially addressed in bc5fd9e, but
not here.
Signed-off-by: Jason Gerecke jason.gere...@wacom.com
---
tools/xsetwacom.c | 30 ++
1 file changed, 18
Add a new --enable-fuzz-interface configuration option which will
cause xsetwacom to read NUL-separated arguments from stdin (for
example: `echo -en 'list\0devices' | xsetwacom`). This makes it
easier to plug into fuzzing software for debugging.
Signed-off-by: Jason Gerecke jason.gere
Address several leaks present in the code, as well as two uses of 'free' where
'XFree' should have been used instead.
Signed-off-by: Jason Gerecke jason.gere...@wacom.com
---
tools/xsetwacom.c | 37 +
1 file changed, 25 insertions(+), 12 deletions(-)
diff
These functions access argv[0] before checking that argc is at least
1. In the interest of correctness, swap it around so that the check
occurs before the dereference.
Signed-off-by: Jason Gerecke jason.gere...@wacom.com
---
tools/xsetwacom.c | 9 +
1 file changed, 5 insertions(+), 4
: AddressSanitizer: undefined-behavior ../src/wcmUSB.c:1000
Signed-off-by: Jason Gerecke jason.gere...@wacom.com
---
src/wcmUSB.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/wcmUSB.c b/src/wcmUSB.c
index c15cd4a..5ceba95 100644
--- a/src/wcmUSB.c
+++ b/src/wcmUSB.c
@@ -815,11
as written (valuators[6] = v6)
won't do anything (since valuators[6] == v6). Even stil...
Signed-off-by: Jason Gerecke jason.gere...@wacom.com
---
src/wcmCommon.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/wcmCommon.c b/src/wcmCommon.c
index 92f8cf8..4dd537c 100644
501 - 600 of 924 matches
Mail list logo
