Re: [Linuxwacom-devel] [PATCH] xsetwacom: Remove unnecessary static state from 'get_actions'

2016-01-19 Thread Jason Gerecke
On Mon, Jan 18, 2016 at 9:01 PM, Peter Hutterer wrote: > On Mon, Jan 18, 2016 at 10:48:57AM -0800, Jason Gerecke wrote: >> The 'last_type' variable within 'get_actions' stores the type of the last >> action encountered. When dealing with "key" or &q

[Linuxwacom-devel] [PATCH v2 1/3] xsetwacom: Remove unnecessary static state from 'get_actions'

2016-01-19 Thread Jason Gerecke
unction is independent. Fixes: http://sourceforge.net/p/linuxwacom/bugs/303/ Fixes: https://github.com/linuxwacom/xf86-input-wacom/issues/3 Signed-off-by: Jason Gerecke --- tools/xsetwacom.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/xsetwacom.c b/tools/xsetwacom.

[Linuxwacom-devel] [PATCH 2/3] xsetwacom: Only print action name for "modetoggle" and "displaytoggle"

2016-01-19 Thread Jason Gerecke
Running "xsetwacom get" on a button which contain a "modetoggle" or "displaytoggle" action will result in output which cannot be parsed by "xsetwacom set". Both of these actions are treated like buttons, printing extra data that is not expected by the &quo

[Linuxwacom-devel] [PATCH 3/3] xsetwacom: Use stderr for 'core' and 'displaytogle' deprecation notices

2016-01-19 Thread Jason Gerecke
Signed-off-by: Jason Gerecke --- tools/xsetwacom.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/xsetwacom.c b/tools/xsetwacom.c index cf43fe7..2f75d78 100644 --- a/tools/xsetwacom.c +++ b/tools/xsetwacom.c @@ -1026,7 +1026,7 @@ static int special_map_core(Display

[Linuxwacom-devel] [PATCH input-wacom 16/21] backport: HID: wacom: Rename wacom ID report ID macros

2016-02-12 Thread Jason Gerecke
"INTUOSREAD" and "INTUOSWRITE" are poorly named. These are report IDs for pen ID (proximity) packets. It should be noted that the latter is only used on Intuos/Intuos2 for a second stylus when DualTrack is in use. Signed-off-by: Jason Gerecke Signed-off-by: Jiri Kosina [jas

[Linuxwacom-devel] [PATCH input-wacom 19/21] backport: HID: wacom: Report 'strip2' values in ABS_RY

2016-02-12 Thread Jason Gerecke
Commit c7f0522 accidentally used ABS_RX for reporting both 'strip1' and 'strip2', when the latter should actually be reported through ABS_RY. Signed-off-by: Jason Gerecke Signed-off-by: Jiri Kosina [jason.gere...@wacom.com: Imported into input-wacom repository (03a0dc5)]

[Linuxwacom-devel] [PATCH input-wacom 15/21] backport: HID: wacom: Clean up value reading

2016-02-12 Thread Jason Gerecke
. Signed-off-by: Jason Gerecke Signed-off-by: Jiri Kosina [jason.gere...@wacom.com: Imported into input-wacom repository (5f33f43)] Signed-off-by: Jason Gerecke [jason.gere...@wacom.com: backported from input-wacom 6425413] Signed-off-by: Jason Gerecke --- 2.6.38/wacom_wac.c | 27

[Linuxwacom-devel] [PATCH input-wacom 09/21] backport: HID: wacom: Delete an unnecessary check before kobject_put()

2016-02-12 Thread Jason Gerecke
Cheng [jason.gere...@wacom.com: backported from input-wacom 571a97e] Signed-off-by: Jason Gerecke --- 2.6.38/wacom_sys.c | 3 +-- 3.7/wacom_sys.c| 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/2.6.38/wacom_sys.c b/2.6.38/wacom_sys.c index 69aa7d5..7902e21 100644 --- a

[Linuxwacom-devel] [PATCH input-wacom 07/21] backport: Input: wacom_w8001 - split pen and touch initialization up

2016-02-12 Thread Jason Gerecke
From: Peter Hutterer This is preparation work for splitting it up for two event nodes. Signed-off-by: Peter Hutterer Acked-by: Benjamin Tissoires Signed-off-by: Dmitry Torokhov [jason.gere...@wacom.com: Imported into input-wacom repository (5d0a4fe)] Signed-off-by: Jason Gerecke [jason.gere

[Linuxwacom-devel] [PATCH input-wacom 08/21] backport: Input: wacom_w8001 - split the touch and pen devices into two devices

2016-02-12 Thread Jason Gerecke
ted into input-wacom repository (e0361b7)] Signed-off-by: Jason Gerecke [jason.gere...@wacom.com: backported from input-wacom repository 550a798] Signed-off-by: Jason Gerecke --- 2.6.38/wacom_w8001.c | 167 +++ 3.7/wa

[Linuxwacom-devel] [PATCH input-wacom 10/21] backport: HID: wacom: Move Intuos pad handling code into dedicated function

2016-02-12 Thread Jason Gerecke
Begin slimming down the body of 'wacom_intuos_irq' by moving out its largest block of code to a dedicated 'wacom_intuos_pad' function. Signed-off-by: Jason Gerecke Signed-off-by: Jiri Kosina [jason.gere...@wacom.com: Imported into input-wacom repository (fb013a0)] Signed-o

[Linuxwacom-devel] [PATCH input-wacom 06/21] backport: Input: wacom_w8001 - handle touch error case correctly

2016-02-12 Thread Jason Gerecke
Torokhov [jason.gere...@wacom.com: Imported into input-wacom repository (e171735)] Signed-off-by: Jason Gerecke [jason.gere...@wacom.com: backported from input-wacom repository 5e9fc5d] Signed-off-by: Jason Gerecke --- 2.6.38/wacom_w8001.c | 19 +-- 3.7/wacom_w8001.c| 19

[Linuxwacom-devel] [PATCH input-wacom 04/21] backport: Input: wacom_w8001 - use __set_bit for evbits

2016-02-12 Thread Jason Gerecke
From: Peter Hutterer Signed-off-by: Peter Hutterer Acked-by: Benjamin Tissoires Reviewed-by: Ping Cheng Signed-off-by: Dmitry Torokhov [jason.gere...@wacom.com: Imported into input-wacom repository (86c03f4)] Signed-off-by: Jason Gerecke [jason.gere...@wacom.com: backported from input-wacom

[Linuxwacom-devel] [PATCH input-wacom 11/21] backport: HID: wacom: Slim down wacom_intuos_pad processing

2016-02-12 Thread Jason Gerecke
Seperate the function into two halves: first gather data from the packet, next report all gathered data. The input subsystem should automatically mute any events that aren't actually declared for the tablet at hand. Signed-off-by: Jason Gerecke Signed-off-by: Jiri Kosina [jason

[Linuxwacom-devel] [PATCH input-wacom 05/21] backport: Input: wacom_w8001 - set BTN_TOOL_DOUBLETAP if we have 2fg support

2016-02-12 Thread Jason Gerecke
From: Peter Hutterer Signed-off-by: Peter Hutterer Acked-by: Benjamin Tissoires Reviewed-by: Ping Cheng Signed-off-by: Dmitry Torokhov [jason.gere...@wacom.com: Imported into input-wacom repository (ec9acda)] Signed-off-by: Jason Gerecke [jason.gere...@wacom.com: backported from input-wacom

[Linuxwacom-devel] [PATCH input-wacom 13/21] backport: HID: wacom: Replace magic masks and comparisons with switch cases

2016-02-12 Thread Jason Gerecke
packets that will be encountered. Signed-off-by: Jason Gerecke Signed-off-by: Jiri Kosina [jason.gere...@wacom.com: Imported into input-wacom repository (a8a09c8)] Signed-off-by: Jason Gerecke [jason.gere...@wacom.com: backported from input-wacom cf5e2de] Signed-off-by: Jason Gerecke --- 2.6

[Linuxwacom-devel] [PATCH input-wacom 20/21] backport: HID: wacom: Fix touchring value reporting

2016-02-12 Thread Jason Gerecke
heck (different?!) portions of the position bits. Furthermore, the full values of 'ring1' and 'ring2' are reported to userspace, despite the 'touched' flag needing to be trimmed beforehand. This commit addresses both issues. Signed-off-by: Jason Gerecke Signed-off-by

[Linuxwacom-devel] [PATCH input-wacom 00/21] input-wacom Linux 4.5 backports

2016-02-12 Thread Jason Gerecke
xel Lin (1): backport: Input: serio - use module_serio_driver Dan Carpenter (1): backport: HID: wacom: bitwise vs logical ORs Jason Gerecke (12): backport: Input: wacom - add POINTER and DIRECT device properties backport: HID: wacom: Move Intuos pad handling code into dedicated function

[Linuxwacom-devel] [PATCH input-wacom 21/21] backport: HID: wacom: Fix pad button range for CINTIQ_COMPANION_2

2016-02-12 Thread Jason Gerecke
Commit c7f0522 incorrectly constructs the 'buttons' variable for the CINTIQ_COMPANION_2 case. The high nybble of data[2] is shifted four bits too far, leaving the bits associated with BTN_7 through BTN_A unset. Signed-off-by: Jason Gerecke Signed-off-by: Jiri Kosina [jason.gere...

[Linuxwacom-devel] [PATCH input-wacom 18/21] backport: HID: wacom: Limit touchstrip data to 13 bits

2016-02-12 Thread Jason Gerecke
k that used prior to c7f0522. Signed-off-by: Jason Gerecke Signed-off-by: Jiri Kosina [jason.gere...@wacom.com: Imported into input-wacom repository (f73d08d)] Signed-off-by: Jason Gerecke [jason.gere...@wacom.com: backported from input-wacom 497c6e1] Signed-off-by: Jason Gerecke --- 2.6.38/wacom

[Linuxwacom-devel] [PATCH input-wacom 03/21] backport: Input: delete non-required instances of include

2016-02-12 Thread Jason Gerecke
d-off-by: Dmitry Torokhov [jason.gere...@wacom.com: Imported into input-wacom repository (bf9a9f8)] Signed-off-by: Jason Gerecke [jason.gere...@wacom.com: backported from input-wacom repository abcbe95] Signed-off-by: Jason Gerecke --- 2.6.30/wacom_w8001.c | 1 - 2.6.36/wacom_w8001.c | 1 - 2

[Linuxwacom-devel] [PATCH input-wacom 12/21] backport: HID: wacom: Centralize Intuos pen packet decoding

2016-02-12 Thread Jason Gerecke
Continue to slim down 'wacom_intuos_irq' by moving all decoding and reporting of pen packet data into the 'wacom_intuos_general' function. Signed-off-by: Jason Gerecke Signed-off-by: Jiri Kosina [jason.gere...@wacom.com: Imported into input-wacom repository (16e0a6a)]

[Linuxwacom-devel] [PATCH input-wacom 02/21] backport: Input: serio - use module_serio_driver

2016-02-12 Thread Jason Gerecke
: Jason Gerecke [jason.gere...@wacom.com: backported from input-wacom 8cadbac] Signed-off-by: Jason Gerecke --- 3.7/wacom_w8001.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/3.7/wacom_w8001.c b/3.7/wacom_w8001.c index d57340c..9a83be6 100644 --- a/3.7

[Linuxwacom-devel] [PATCH input-wacom 17/21] backport: HID: wacom: bitwise vs logical ORs

2016-02-12 Thread Jason Gerecke
#x27;) Signed-off-by: Dan Carpenter Reviewed-by: Jason Gerecke Signed-off-by: Jiri Kosina [jason.gere...@wacom.com: Imported into input-wacom repository (8f9cfdd)] Signed-off-by: Jason Gerecke [jason.gere...@wacom.com: backported from input-wacom ad81095] Signed-off-by: Jason Gerecke --- 2.6

[Linuxwacom-devel] [PATCH input-wacom 01/21] backport: Input: wacom - add POINTER and DIRECT device properties

2016-02-12 Thread Jason Gerecke
: Jason Gerecke Reviewed-by: Ping Cheng Signed-off-by: Dmitry Torokhov [jason.gere...@wacom.com: Imported into input-wacom repository (3512069)] Signed-off-by: Jason Gerecke [jason.gere...@wacom.com: backported from input-wacom db1d689] Signed-off-by: Jason Gerecke --- 2.6.38/wacom_w8001.c | 2

[Linuxwacom-devel] [PATCH input-wacom 14/21] backport: HID: wacom: Further clean up wacom_intuos_general packet decoder

2016-02-12 Thread Jason Gerecke
Continue re-organizing and trimming cases to make it easier to wrap the brain around. A number of changes were made after consulting the protocol spec and so don't necessarily follow from the code itself. Signed-off-by: Jason Gerecke Signed-off-by: Jiri Kosina [jason.gere...@wacom.com: Imp

[Linuxwacom-devel] [PATCH] conf: Prevent xf86-input-wacom from binding to pure-keyboard devices

2016-03-04 Thread Jason Gerecke
ce of KEY_* kernel events. Fixes: https://sourceforge.net/p/linuxwacom/bugs/294/ Fixes: https://github.com/linuxwacom/xf86-input-wacom/issues/1 Signed-off-by: Jason Gerecke --- conf/50-wacom.conf | 15 +++ 1 file changed, 15 insertions(+) diff --git a/conf/50-wacom.conf b/conf/50-wacom.

Re: [Linuxwacom-devel] [PATCH] conf: Prevent xf86-input-wacom from binding to pure-keyboard devices

2016-03-15 Thread Jason Gerecke
On 03/09/2016 05:41 PM, Peter Hutterer wrote: > On Fri, Mar 04, 2016 at 09:30:03AM -0800, Jason Gerecke wrote: >> The Wacom Bluetooth Keyboard matches the "Wacom class" and so is bound to the >> xf86-input-wacom driver. This driver is not designed to work with keyb

[Linuxwacom-devel] [PATCH input-wacom] Initialize intuos_prox_event_worker for all Intuos devices

2016-04-05 Thread Jason Gerecke
er than the Draw try to schedule the worker. This patch initializes the workqueue for all Intuos devices to prevent this WARNING from occuring. Signed-off-by: Jason Gerecke --- 3.17/wacom_wac.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/3.17/wacom_wac.c b/3.17/wacom_wac.c index c88

[Linuxwacom-devel] [PATCH] isdv4: Use last-known event position in touch up events

2016-04-14 Thread Jason Gerecke
known touch position as the current touch position. This mirrors what is done by the standard input kernel driver (which leaves X/Y at its last known position on touch up). Fixes: https://sourceforge.net/p/linuxwacom/bugs/312/ Signed-off-by: Jason Gerecke --- src/wcmISDV4.c | 8 1 file ch

[Linuxwacom-devel] [PATCH v2] conf: Prevent xf86-input-wacom from binding to pure-keyboard devices

2016-04-25 Thread Jason Gerecke
ad and Cintiq 27QHDT Pad from binding to our driver since both are recognized as (partial) keyboards due to the presence of KEY_* kernel events. Fixes: https://sourceforge.net/p/linuxwacom/bugs/294/ Fixes: https://github.com/linuxwacom/xf86-input-wacom/issues/1 Signed-off-by: Jason Gerecke --- Ch

[Linuxwacom-devel] [PATCH] conf: rename to 70-wacom.conf

2016-04-27 Thread Jason Gerecke
://github.com/linuxwacom/xf86-input-wacom/issues/4 Signed-off-by: Jason Gerecke --- conf/50-wacom.conf | 103 - conf/70-wacom.conf | 103 + conf/Makefile.am | 2 +- 3 files changed, 104

[Linuxwacom-devel] [PATCH input-wacom] Prevent NULL derefence when bNumEndpoints is 0

2016-05-03 Thread Jason Gerecke
/ubuntu/+source/linux/+bug/1556883 Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1283375 Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1283377 Signed-off-by: Jason Gerecke --- Open question: RHEL has no plans to fix this in their tree -- do we want to fix it in input-wacom? 2.6.30

[Linuxwacom-devel] [PATCH input-wacom] Run 'update-initramfs -u' during 'make install' if present

2016-05-03 Thread Jason Gerecke
n our module. Thankfully, Ubuntu provides a command to do just that: update-initramfs. By running this after the module is installed and depmod updated, the initramfs will be updated to contain our on-disk driver and load it on boot. Signed-off-by: Jason Gerecke --- 3.17/Makefile.in | 7 +++ 1

[Linuxwacom-devel] [PATCH input-wacom] Have git-version-gen produce better default output

2016-05-03 Thread Jason Gerecke
nformation being added to the version string to help us figure out exactly what is installed. Signed-off-by: Jason Gerecke --- git-version-gen | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/git-version-gen b/git-version-gen index d7eed0a..0f4b6cb 100755 --- a/git-version-gen

[Linuxwacom-devel] [PATCH v2 input-wacom] Run 'update-initramfs -u' during 'make install' if present

2016-05-04 Thread Jason Gerecke
n our module. Thankfully, Ubuntu provides a command to do just that: update-initramfs. By running this after the module is installed and depmod updated, the initramfs will be updated to contain our on-disk driver and load it on boot. Signed-off-by: Jason Gerecke --- Changes from v1: * update-init

Re: [Linuxwacom-devel] [PATCH libwacom] tools: mark the EKR as a ID_INPUT_TABLET_PAD

2016-05-25 Thread Jason Gerecke
Doesn't the EKR already get marked as ID_INPUT_PAD? On the current master, I get the following from generate-udev-rules: # Wacom ExpressKey Remote ENV{ID_BUS}=="usb", ENV{ID_VENDOR_ID}=="056a", ENV{ID_MODEL_ID}=="0331", ENV{ID_INPUT}="1", ENV{ID_INPUT_JOYSTICK}="", ENV{ID_INPUT_TABLET}="1" ATTRS{

[Linuxwacom-devel] [PATCH libwacom] data: Add "One by Wacom" medium and small

2016-06-01 Thread Jason Gerecke
Signed-off-by: Jason Gerecke --- data/one-by-wacom-m-p.tablet | 23 +++ data/one-by-wacom-s-p.tablet | 23 +++ 2 files changed, 46 insertions(+) create mode 100644 data/one-by-wacom-m-p.tablet create mode 100644 data/one-by-wacom-s-p.tablet diff --git a

Re: [Linuxwacom-devel] [PATCH libwacom] data: check for missing or unreferenced svg files

2016-06-01 Thread Jason Gerecke
On 05/31/2016 11:38 PM, Peter Hutterer wrote: > Oh shell-fu, don't leave me now. > > In data/, check for any svg files that are listed as Layout but don't exist. > In data/layout, check for any existing file that's not listed in the tablet > files. > > Signed-off-by: Peter Hutterer > --- Might

Re: [Linuxwacom-devel] [PATCH libwacom] data: add makefile hook to verify all files are in git

2016-06-03 Thread Jason Gerecke
gt; with /usr/bin/false and that code-path is not met. > > Signed-off-by: Peter Hutterer > --- This and the prior reference check patch look good to me. Thanks :) Reviewed-by: Jason Gerecke Jason --- Now instead of four in the eights place / you’ve got three, ‘Cause you added one /

[Linuxwacom-devel] [PATCH libwacom] tools: Add udev rules quirk for Wireless Accessory Kit

2016-06-08 Thread Jason Gerecke
is way are properly tagged, add general-purpose matches for the kit. Signed-off-by: Jason Gerecke --- tools/generate-udev-rules.c | 17 + 1 file changed, 17 insertions(+) diff --git a/tools/generate-udev-rules.c b/tools/generate-udev-rules.c index 87d43fe..8a73c9f 100644 --- a/tool

[Linuxwacom-devel] [PATCH libwacom] data: Add the MTE-450 "Bamboo"

2016-06-08 Thread Jason Gerecke
Signed-off-by: Jason Gerecke --- data/bamboo-0fg-s-p.tablet | 59 + data/layouts/bamboo-0fg-s-p.svg | 141 2 files changed, 200 insertions(+) create mode 100644 data/bamboo-0fg-s-p.tablet create mode 100644 data/layouts/bamboo-0fg

[Linuxwacom-devel] [PATCH libwacom] data: Update layouts for Intuos tablets

2016-06-08 Thread Jason Gerecke
Signed-off-by: Jason Gerecke --- data/layouts/intuos-m-p.svg | 34 -- data/layouts/intuos-m-pt.svg | 34 -- data/layouts/intuos-s-p.svg | 36 +--- data/layouts/intuos-s-pt.svg | 36

[Linuxwacom-devel] [PATCH] data: Add ISDv4 0x114 (Lenovo ThinkPad Tablet 10 - 1st gen)

2016-06-16 Thread Jason Gerecke
Signed-off-by: Jason Gerecke --- data/isdv4-114.tablet | 14 ++ 1 file changed, 14 insertions(+) create mode 100644 data/isdv4-114.tablet diff --git a/data/isdv4-114.tablet b/data/isdv4-114.tablet new file mode 100644 index 000..8511632 --- /dev/null +++ b/data/isdv4-114.tablet

[Linuxwacom-devel] [PATCH libwacom 7/8] tools: Display name of tablet in show-svg-image titlebar

2016-06-21 Thread Jason Gerecke
Signed-off-by: Jason Gerecke --- tools/show-svg-image.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/show-svg-image.c b/tools/show-svg-image.c index 152f71f..31fd589 100644 --- a/tools/show-svg-image.c +++ b/tools/show-svg-image.c @@ -473,6 +473,7 @@ main (int argc, char **argv

[Linuxwacom-devel] [PATCH libwacom 3/8] test: Strengthen buttons_have_direction check

2016-06-21 Thread Jason Gerecke
The buttons_have_direction check currently only checks if /any/ tablet button has its direction set. We strengthen this check so that it returns true only if /all/ buttons have a direction set. Signed-off-by: Jason Gerecke --- test/tablet-validity.c | 6 +++--- 1 file changed, 3 insertions

[Linuxwacom-devel] [PATCH libwacom 8/8] data: Standardize location of buttons on Intuos tablets

2016-06-21 Thread Jason Gerecke
uot;. Signed-off-by: Jason Gerecke --- data/intuos-m-p.tablet | 3 +-- data/intuos-m-p2.tablet | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/data/intuos-m-p.tablet b/data/intuos-m-p.tablet index ecf2c3a..6190fc4 100644 --- a/data/intuos-m-p.tablet +++ b/data/intuos-m-p.t

[Linuxwacom-devel] [PATCH libwacom 1/8] test: Require reversible tablets to have left/right buttons

2016-06-21 Thread Jason Gerecke
absolutely nothing. This updates the device tests to require that reversible tablets have buttons on the left or right. The no-button case is specifically ignored to allow several tablets in a family of reversible tablets to continue to pass. Signed-off-by: Jason Gerecke --- test/tablet-valid

[Linuxwacom-devel] [PATCH libwacom 2/8] data: Clear "reversible" flag on several tablets

2016-06-21 Thread Jason Gerecke
Signed-off-by: Jason Gerecke --- data/bamboo-0fg-s-p.tablet | 2 +- data/intuos-m-p.tablet | 2 +- data/intuos-m-p2.tablet| 2 +- data/intuos-m-pt.tablet| 2 +- data/intuos-m-pt2.tablet | 2 +- data/intuos-s-p.tablet | 2 +- data/intuos-s-p2.tablet| 2 +- data/intuos-s-p

[Linuxwacom-devel] [PATCH libwacom 5/8] tools: Fix show-svg-image to work with current rsvg

2016-06-21 Thread Jason Gerecke
As described in the gtk+ project's commit 7b4f82c, the rsvg loader apparently now restricts what external files it will load from an SVG. As a workaround, the data can be embedded in a data: URI. Signed-off-by: Jason Gerecke --- tools/show-svg-image.c | 11 +-- 1 file chang

[Linuxwacom-devel] [PATCH libwacom 4/8] data: Correct SVGs for 2nd-gen consumer "Intuos" devices

2016-06-21 Thread Jason Gerecke
The SVGs for the 2nd-gen consumer "Intuos" devices appear to have been just copy/pasted from the first generation, despite differences in apparenace. This updates the SVGs to appear correctly. Signed-off-by: Jason Gerecke --- data/layouts/intuos-m-p2

[Linuxwacom-devel] [PATCH libwacom 6/8] tools: Allow show-svg-image to take device ID from command line

2016-06-21 Thread Jason Gerecke
argument. Signed-off-by: Jason Gerecke --- tools/show-svg-image.c | 74 -- 1 file changed, 66 insertions(+), 8 deletions(-) diff --git a/tools/show-svg-image.c b/tools/show-svg-image.c index 674d27e..152f71f 100644 --- a/tools/show-svg-image.c

Re: [Linuxwacom-devel] [PATCH libwacom 6/8] tools: Allow show-svg-image to take device ID from command line

2016-06-22 Thread Jason Gerecke
On 06/21/2016 06:47 PM, Peter Hutterer wrote: > On Tue, Jun 21, 2016 at 03:52:53PM -0700, Jason Gerecke wrote: >> Providing the name of a tablet to show-svg-image can be difficult at >> times, since the name may not be exactly what you expect or there may >> be more than on

[Linuxwacom-devel] [PATCH] Fix a Cintiq 27QHD touch issue

2016-06-27 Thread Jason Gerecke
from causing problems, do not change the values after they have been set properly while parsing the multitouch report. Signed-off-by: Ping Cheng Signed-off-by: Jason Gerecke --- 2.6.38/wacom_sys.c | 24 ++-- 3.7/wacom_sys.c| 24 ++-- 2 files change

Re: [Linuxwacom-devel] [PATCH libwacom 6/8] tools: Allow show-svg-image to take device ID from command line

2016-06-28 Thread Jason Gerecke
On 06/23/2016 05:21 PM, Peter Hutterer wrote: > On Wed, Jun 22, 2016 at 09:20:36AM -0700, Jason Gerecke wrote: >> On 06/21/2016 06:47 PM, Peter Hutterer wrote: >>> On Tue, Jun 21, 2016 at 03:52:53PM -0700, Jason Gerecke wrote: >>>> Providing the name of a tablet to s

[Linuxwacom-devel] [PATCH input-wacom 2/3] Add support for passing EXTRA_CFLAGS on the make commandline

2016-08-05 Thread Jason Gerecke
quot; Signed-off-by: Jason Gerecke --- 2.6.30/Makefile.in | 2 +- 2.6.36/Makefile.in | 2 +- 2.6.38/Makefile.in | 2 +- 3.17/Makefile.in | 2 +- 3.7/Makefile.in| 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/2.6.30/Makefile.in b/2.6.30/Makefile.in index e2e7727..38876be

[Linuxwacom-devel] [PATCH input-wacom 1/3] Enable support for ISDv4 0x5013

2016-08-05 Thread Jason Gerecke
Commit 5ecf18a introduced the definitions necessary for the 0x5013 device to work with pre-3.17 kernels, but forgot to then also add the device to the wacom_ids table (which would have prevented the devices from ever actually being probed by the kernel). Signed-off-by: Jason Gerecke --- 2.6.30

[Linuxwacom-devel] [PATCH input-wacom 3/3] Fail the Travis-CI build if any warnings are present

2016-08-05 Thread Jason Gerecke
aders themselves from breaking the build, we forcefully use "-isystem" for key paths that are included by Kbuild as plain "-I". Signed-off-by: Jason Gerecke --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 1741

[Linuxwacom-devel] [PATCH input-wacom 3/3] Fail the Travis-CI build if any warnings are present

2016-08-19 Thread Jason Gerecke
aders themselves from breaking the build, we forcefully use "-isystem" for key paths that are included by Kbuild as plain "-I". Signed-off-by: Jason Gerecke --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 1741

[Linuxwacom-devel] [PATCH input-wacom 2/3] Add support for passing EXTRA_CFLAGS on the make commandline

2016-08-19 Thread Jason Gerecke
quot; Signed-off-by: Jason Gerecke --- 2.6.30/Makefile.in | 2 +- 2.6.36/Makefile.in | 2 +- 2.6.38/Makefile.in | 2 +- 3.17/Makefile.in | 2 +- 3.7/Makefile.in| 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/2.6.30/Makefile.in b/2.6.30/Makefile.in index e2e7727..38876be

[Linuxwacom-devel] [PATCH input-wacom 1/3] Enable support for ISDv4 0x5013

2016-08-19 Thread Jason Gerecke
Commit 5ecf18a introduced the definitions necessary for the 0x5013 device to work with pre-3.17 kernels, but forgot to then also add the device to the wacom_ids table (which would have prevented the devices from ever actually being probed by the kernel). Signed-off-by: Jason Gerecke --- 2.6.30

Re: [Linuxwacom-devel] [PATCH libwacom] data: the 22HD(T) have virtual modes - note it as a comment

2016-08-30 Thread Jason Gerecke
On 08/29/2016 10:57 PM, Peter Hutterer wrote: > Not adding the actual StripsNumModes entry because this would require callers > to display an OSD for mode changes. Right now callers (GNOME anyway) relies > on LEDs to show the mode, not an on-screen notification. Also, since the modes > are complete

[Linuxwacom-devel] [PATCH 2/2] Read TouchRing axis range from kernel instead of hardcoding

2016-10-07 Thread Jason Gerecke
in the combined case. Signed-off-by: Jason Gerecke --- src/wcmCommon.c | 5 +++-- src/wcmUSB.c| 10 ++ src/xf86Wacom.c | 8 src/xf86WacomDefs.h | 9 - 4 files changed, 21 insertions(+), 11 deletions(-) diff --git a/src/wcmCommon.c b/src/wcmCommon.c

[Linuxwacom-devel] [PATCH 1/2] Increase full-scale pressure range from 0..2047 to 0..65535

2016-10-07 Thread Jason Gerecke
compatibility, the value is interpreted as a fraction of 2048 and then scaled to the actual normalization range. Signed-off-by: Jason Gerecke --- src/wcmXCommand.c | 6 +- src/xf86WacomDefs.h | 2 +- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/wcmXCommand.c b/src

[Linuxwacom-devel] [PATCH v2 1/2] Increase full-scale pressure range from 0..2047 to 0..65535

2016-11-01 Thread Jason Gerecke
compatibility, the value is interpreted as a fraction of 2048 and then scaled to the actual normalization range. Signed-off-by: Jason Gerecke --- Changes from v1: * Added helper functions to isolate the scaling to/from the 2048-level range historically used. src/wcmXCommand.c | 26

[Linuxwacom-devel] [PATCH v2 2/2] Lazily allocate pressure curve table

2016-11-01 Thread Jason Gerecke
, we now lazily allocate space for the pressure curve tables only when they are set to a non-default curve. Signed-off-by: Jason Gerecke --- Changes from v1: * Added this patch to lazilly allocate the pressure curve as requested src/wcmCommon.c | 5 - src/wcmFilter.c | 30

[Linuxwacom-devel] [PATCH 2/2] Further reduce arbitration priority of cursor devices

2016-11-01 Thread Jason Gerecke
l not be granted "active" status in preference to any other tool (and will drop "active" status if gained after 100ms and while no buttons are pressed). Signed-off-by: Jason Gerecke --- src/wcmCommon.c | 27 ++- 1 file changed, 18 insertions(+), 9 deletions(-

[Linuxwacom-devel] [PATCH 1/2] Allow cursor devices to maintain "active" status while buttons are down

2016-11-01 Thread Jason Gerecke
ve even if the 100ms timeout has been exceeded. Not doing so could potentially allow another tool to grab "active" status and have our driver send a button-up message and stop an in- progress drag. Signed-off-by: Jason Gerecke --- src/wcmCommon.c | 2 +- 1 file changed, 1 insertion(+),

[Linuxwacom-devel] [PATCH] Add missing newline to log message

2016-11-01 Thread Jason Gerecke
Signed-off-by: Jason Gerecke --- src/wcmCommon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/wcmCommon.c b/src/wcmCommon.c index 1471fa5..2d7060d 100644 --- a/src/wcmCommon.c +++ b/src/wcmCommon.c @@ -1196,7 +1196,7 @@ static void commonDispatchDevice(InputInfoPtr

[Linuxwacom-devel] [PATCH v3] Lazily allocate pressure curve table

2016-11-11 Thread Jason Gerecke
, we now lazily allocate space for the pressure curve tables only when they are set to a non-default curve. Signed-off-by: Jason Gerecke --- Changes from v2: * Use affirmative (instead of negating) check for default (0,0,100,100) case. * Shuffle code to reduce duplication. * Log warning in case

[Linuxwacom-devel] [PATCH libwacom] data: Add data and SVG files for MobileStudio Pro

2016-11-11 Thread Jason Gerecke
hich share the same IDs (which apparently, according to the technical experts, are not guaranteed unique outside of a hardware generation). Such a change will require serious design and planning that are outside of the immediate scope of this patch. Signed-off-by: Jason Gerecke --- da

[Linuxwacom-devel] [PATCH libwacom v2] data: Add data and SVG files for MobileStudio Pro

2016-11-14 Thread Jason Gerecke
hich share the same IDs (which apparently, according to the technical experts, are not guaranteed unique outside of a hardware generation). Such a change will require serious design and planning that are outside of the immediate scope of this patch. Signed-off-by: Jason Gerecke --- Changes from v1

[Linuxwacom-devel] [PATCH input-wacom B 00/16] MobileStudio Pro prerequisites

2016-11-16 Thread Jason Gerecke
straightforward, so we go ahead and complete the backport for the whole set all the way to 2.6.30. Dan Carpenter (1): backport: HID: wacom: bitwise vs logical ORs Jason Gerecke (15): backport: HID: wacom: Set button bits based on a new numbered_buttons backport: HID: wacom: Move Intuos pad

[Linuxwacom-devel] [PATCH input-wacom C 00/17] MobileStudio Pro backport

2016-11-16 Thread Jason Gerecke
coding the reports. Dan Carpenter (1): backport: HID: wacom: Don't clear bits unintentionally Jason Gerecke (16): backport: HID: wacom: generic: Strip off excessive name prefixing backport: HID: wacom: generic: Add support for height, tilt, and twist usages backport: HID: wacom: g

[Linuxwacom-devel] [PATCH input-wacom C 17/17] backport: MobileStudio Pro to 3.7, 2.6.38, 2.6.36, 2.6.30

2016-11-16 Thread Jason Gerecke
--- 2.6.30/wacom_sys.c | 20 +++- 2.6.30/wacom_wac.c | 224 +++ 2.6.30/wacom_wac.h | 8 ++ 2.6.36/wacom_sys.c | 20 +++- 2.6.36/wacom_wac.c | 272 + 2.6.36/wacom_wac.h | 8 ++ 2.6.38/wacom_sys.c | 9

[Linuxwacom-devel] [PATCH input-wacom B 14/16] backport: HID: wacom: Have WACOM_PEN_FIELD and WACOM_FINGER_FIELD recgonize more fields

2016-11-16 Thread Jason Gerecke
We've defined several new usages (e.g. WACOM_G9_PEN and WACOM_G9_TOUCHSCREEN) which aren't checked by the WACOM_PEN_FIELD and WACOM_FINGER_FIELD macros but probably should be. Signed-off-by: Jason Gerecke Reviewed-by: Benjamin Tissoires [jason.gere...@wacom.com: Imported into i

[Linuxwacom-devel] [PATCH input-wacom C 04/17] backport: HID: wacom: generic: Add support for vendor-defined "Distance" usage

2016-11-16 Thread Jason Gerecke
n't invert the scale to be ABS_DISTANCE compatible like we do for HID_GD_Z. Signed-off-by: Jason Gerecke Reviewed-by: Benjamin Tissoires [jason.gere...@wacom.com: Imported into input-wacom repository (b5c921e)] Signed-off-by: Jason Gerecke [jason.gere...@wacom.com: backported from input-w

[Linuxwacom-devel] [PATCH input-wacom B 01/16] backport: HID: wacom: Set button bits based on a new numbered_buttons

2016-11-16 Thread Jason Gerecke
: This patch was backported earlier, but only as far back as 2.6.38. To make backporting the next few patches easier, we complete this backport all the way to 2.6.30. Signed-off-by: Aaron Skomra Reviewed-by: Jason Gerecke Signed-off-by: Ping Cheng [jason.gere...@wacom.com: backported from input

[Linuxwacom-devel] [PATCH input-wacom A 1/2] Add missing pen arbitration function calls

2016-11-16 Thread Jason Gerecke
The backport of the touch_arbitration parameter (a88d7da) missed a few cases where the new 'report_touch_events' or 'delay_pen_events' function should have been called. This commit adds them in. Signed-off-by: Jason Gerecke --- 3.17/wacom_wac.c | 11 ++- 1 file c

[Linuxwacom-devel] [PATCH input-wacom B 07/16] backport: HID: wacom: Clean up value reading

2016-11-16 Thread Jason Gerecke
. NOTE: This patch was backported earlier, but only as far back as 2.6.38. To make backporting the next few patches easier, we complete this backport all the way to 2.6.30. Signed-off-by: Jason Gerecke Signed-off-by: Jiri Kosina [jason.gere...@wacom.com: Imported into input-wacom repository

Re: [Linuxwacom-devel] [PATCH input-wacom B 04/16] backport: HID: wacom: Centralize Intuos pen packet decoding

2016-11-16 Thread Jason Gerecke
Whoops! Sorry for the spam. Looks like git-send-email decided to add you to the CC list :/ On Nov 16, 2016 12:15 PM, "Jiri Kosina" wrote: > > On Wed, 16 Nov 2016, Jason Gerecke wrote: > > > Continue to slim down 'wacom_intuos_irq' by moving all decoding and &g

[Linuxwacom-devel] [PATCH input-wacom B 05/16] backport: HID: wacom: Replace magic masks and comparisons with switch cases

2016-11-16 Thread Jason Gerecke
packets that will be encountered. NOTE: This patch was backported earlier, but only as far back as 2.6.38. To make backporting the next few patches easier, we complete this backport all the way to 2.6.30. Signed-off-by: Jason Gerecke Signed-off-by: Jiri Kosina [jason.gere...@wacom.com: Imported into in

[Linuxwacom-devel] [PATCH input-wacom A 2/2] Tweak style of touch_arbitration backport

2016-11-16 Thread Jason Gerecke
The backport of the touch_arbitration parameter (a88d7da) doesn't quite follow the style used by upstream, making it more difficult than necessary to import upstream patches into input-wacom. This commit syncs the code to more closely follow upstream. Signed-off-by: Jason Gerecke --- 2

[Linuxwacom-devel] [PATCH input-wacom C 14/17] backport: HID: input: Recognize ABS_WHEEL in hidinput_calc_abs_res

2016-11-16 Thread Jason Gerecke
s axis as one for which it can calculate a resolution. This effectively prevents wheels from being assigned a proper resolution that userspace can use to determine the precise angle of input. This commit adds ABS_WHEEL as a rotational axis to hidinput_calc_abs_res. Signed-off-by: Jason Gerecke R

[Linuxwacom-devel] [PATCH input-wacom C 10/17] backport: HID: wacom: generic: Add support for sensor offsets

2016-11-16 Thread Jason Gerecke
he X and Y axes accordingly, similar to what is done in the non-generic codepath. Signed-off-by: Jason Gerecke Reviewed-by: Benjamin Tissoires [jason.gere...@wacom.com: Imported into input-wacom repository (345857b)] Signed-off-by: Jason Gerecke [jason.gere...@wacom.com: backported from input-w

[Linuxwacom-devel] [PATCH input-wacom B 06/16] backport: HID: wacom: Further clean up wacom_intuos_general packet decoder

2016-11-16 Thread Jason Gerecke
rting the next few patches easier, we complete this backport all the way to 2.6.30. Signed-off-by: Jason Gerecke Signed-off-by: Jiri Kosina [jason.gere...@wacom.com: Imported into input-wacom repository (571f572)] Signed-off-by: Jason Gerecke [jason.gere...@wacom.com: backported from input-

[Linuxwacom-devel] [PATCH input-wacom B 03/16] backport: HID: wacom: Slim down wacom_intuos_pad processing

2016-11-16 Thread Jason Gerecke
make backporting the next few patches easier, we complete this backport all the way to 2.6.30. Signed-off-by: Jason Gerecke Signed-off-by: Jiri Kosina [jason.gere...@wacom.com: Imported into input-wacom repository (c7f0522)] Signed-off-by: Jason Gerecke [jason.gere...@wacom.com: backported from

[Linuxwacom-devel] [PATCH input-wacom B 16/16] backport: HID: wacom: Detect and correct descriptors missing HID_DG_BARRELSWITCH2

2016-11-16 Thread Jason Gerecke
are its presence and report its state. Signed-off-by: Jason Gerecke Reviewed-by: Benjamin Tissoires [jason.gere...@wacom.com: Imported into input-wacom repository (6005a13)] Signed-off-by: Jason Gerecke [jason.gere...@wacom.com: backported from input-wacom repository (4333a8f)] Signed-off-by: Jaso

[Linuxwacom-devel] [PATCH input-wacom C 06/17] backport: HID: wacom: generic: Add support for vendor-defined "Sense" usage

2016-11-16 Thread Jason Gerecke
dy defined by the HID standard and interpreted by our driver as meaning "in prox"). Signed-off-by: Jason Gerecke Reviewed-by: Benjamin Tissoires [jason.gere...@wacom.com: Imported into input-wacom repository (61ce346)] Signed-off-by: Jason Gerecke [jason.gere...@wacom.com: back

[Linuxwacom-devel] [PATCH input-wacom B 09/16] backport: HID: wacom: bitwise vs logical ORs

2016-11-16 Thread Jason Gerecke
ke backporting the next few patches easier, we complete this backport all the way to 2.6.30. Fixes: c7f0522a1ad1 ('HID: wacom: Slim down wacom_intuos_pad processing') Signed-off-by: Dan Carpenter Reviewed-by: Jason Gerecke Signed-off-by: Jiri Kosina [jason.gere...@wacom.com: Imported

[Linuxwacom-devel] [PATCH input-wacom C 01/17] backport: HID: wacom: generic: Strip off excessive name prefixing

2016-11-16 Thread Jason Gerecke
Signed-off-by: Jason Gerecke Reviewed-by: Benjamin Tissoires [jason.gere...@wacom.com: Imported into input-wacom repository (f2209d4)] Signed-off-by: Jason Gerecke [jason.gere...@wacom.com: backported from input-wacom repository (b0fa322)] Signed-off-by: Jason Gerecke --- 3.17/wacom_sys.c | 13 +

[Linuxwacom-devel] [PATCH input-wacom C 16/17] backport: HID: wacom: Declare tool ID 0x84a as an Intuos eraser

2016-11-16 Thread Jason Gerecke
ince, as a HID_GENERIC device, the driver relies on the state of the HID_DG_INVERT usage instead. It would, however, cause problems if the pen is used with devices that use the traditional 'wacom_intuos_irq' codepath instead. Signed-off-by: Jason Gerecke Acked-by: Benjamin Tissoires

[Linuxwacom-devel] [PATCH input-wacom B 04/16] backport: HID: wacom: Centralize Intuos pen packet decoding

2016-11-16 Thread Jason Gerecke
his backport all the way to 2.6.30. Signed-off-by: Jason Gerecke Signed-off-by: Jiri Kosina [jason.gere...@wacom.com: Imported into input-wacom repository (16e0a6a)] Signed-off-by: Jason Gerecke [jason.gere...@wacom.com: backported from input-wacom 633f39b] Signed-off-by: Jason Gerecke [jas

[Linuxwacom-devel] [PATCH input-wacom B 02/16] backport: HID: wacom: Move Intuos pad handling code into dedicated function

2016-11-16 Thread Jason Gerecke
kport all the way to 2.6.30. Signed-off-by: Jason Gerecke Signed-off-by: Jiri Kosina [jason.gere...@wacom.com: Imported into input-wacom repository (fb013a0)] Signed-off-by: Jason Gerecke [jason.gere...@wacom.com: backported from input-wacom d65d432] Signed-off-by: Jason Gerecke [jas

[Linuxwacom-devel] [PATCH input-wacom B 10/16] backport: HID: wacom: Limit touchstrip data to 13 bits

2016-11-16 Thread Jason Gerecke
k that used prior to c7f0522. NOTE: This patch was backported earlier, but only as far back as 2.6.38. To make backporting the next few patches easier, we complete this backport all the way to 2.6.30. Signed-off-by: Jason Gerecke Signed-off-by: Jiri Kosina [jason.gere...@wacom.com: Imported into in

[Linuxwacom-devel] [PATCH input-wacom C 07/17] backport: HID: wacom: Read and internally use corrected Intuos tool IDs

2016-11-16 Thread Jason Gerecke
order for 'wacom_intuos_get_tool_type' to work for with both codepaths, we correct this issue internally and have 'wacom_intuos_general' only mangle the ID when it is posted to userspace. Signed-off-by: Jason Gerecke Reviewed-by: Benjamin Tissoires [jason.gere...@wacom.com: Imported into i

[Linuxwacom-devel] [PATCH input-wacom C 11/17] backport: HID: wacom: generic: Introduce pad support

2016-11-16 Thread Jason Gerecke
As with usages for the pen, the Custom HID specificiation includes usages for the pad. Here we add functions to map and handle most of the pad usages present on the MobileStudio Pro. Signed-off-by: Jason Gerecke Reviewed-by: Benjamin Tissoires [jason.gere...@wacom.com: Imported into input-wacom

[Linuxwacom-devel] [PATCH input-wacom B 08/16] backport: HID: wacom: Rename wacom ID report ID macros

2016-11-16 Thread Jason Gerecke
k as 2.6.38. To make backporting the next few patches easier, we complete this backport all the way to 2.6.30. Signed-off-by: Jason Gerecke Signed-off-by: Jiri Kosina [jason.gere...@wacom.com: Imported into input-wacom repository (0610999)] Signed-off-by: Jason Gerecke [jason.gere...@wacom.com: b

[Linuxwacom-devel] [PATCH input-wacom C 02/17] backport: HID: wacom: generic: Add support for height, tilt, and twist usages

2016-11-16 Thread Jason Gerecke
ave linear units. To ensure it calculates a resolution with the actually-angular units provided in the HID descriptor we nedd to lie and tell it we're calculating it for the (rotational) ABS_RZ axis instead. Signed-off-by: Jason Gerecke Reviewed-by: Benjamin Tissoires [jason.gere...@w

[Linuxwacom-devel] [PATCH input-wacom C 13/17] backport: HID: wacom: generic: Extend pad support

2016-11-16 Thread Jason Gerecke
The HID specification that the MobileStudio Pro follows includes usages for several values that would be good to support so that future devices "just work" out of the box. Extend the HID_GENERIC pad codepath to handle these usages. Signed-off-by: Jason Gerecke Reviewed-by: Benjamin

<    4   5   6   7   8   9   10   11   12   >