[Lldb-commits] [lldb] r243922 - XFAIL TestInferiorAssert for Android API <= 16.

2015-08-03 Thread Chaoren Lin
Author: chaoren Date: Mon Aug 3 18:59:41 2015 New Revision: 243922 URL: http://llvm.org/viewvc/llvm-project?rev=243922&view=rev Log: XFAIL TestInferiorAssert for Android API <= 16. Modified: lldb/trunk/test/functionalities/inferior-assert/TestInferiorAssert.py Modified: lldb/trunk/test/func

Re: [Lldb-commits] [PATCH] D11667: Allow ValueObject::Dereference to dereference references.

2015-07-30 Thread Chaoren Lin
This revision was automatically updated to reflect the committed changes. Closed by commit rL243716: Allow ValueObject::Dereference to dereference references. (authored by chaoren). Changed prior to commit: http://reviews.llvm.org/D11667?vs=31084&id=31091#toc Repository: rL LLVM http://revi

[Lldb-commits] [PATCH] D11667: Allow ValueObject::Dereference to dereference references.

2015-07-30 Thread Chaoren Lin
chaoren created this revision. chaoren added a reviewer: clayborg. chaoren added a subscriber: lldb-commits. http://reviews.llvm.org/D11667 Files: source/Core/ValueObject.cpp Index: source/Core/ValueObject.cpp === --- source/Core/

[Lldb-commits] [lldb] r243667 - Use only unnamed pipes to launch lldb-server gdbserver.

2015-07-30 Thread Chaoren Lin
Author: chaoren Date: Thu Jul 30 12:48:44 2015 New Revision: 243667 URL: http://llvm.org/viewvc/llvm-project?rev=243667&view=rev Log: Use only unnamed pipes to launch lldb-server gdbserver. Summary: If we used unnamed pipes instead of named pipes, we can avoid having the file system littered with

Re: [Lldb-commits] [PATCH] D11609: Use only unnamed pipes to launch lldb-server gdbserver.

2015-07-30 Thread Chaoren Lin
This revision was automatically updated to reflect the committed changes. Closed by commit rL243667: Use only unnamed pipes to launch lldb-server gdbserver. (authored by chaoren). Changed prior to commit: http://reviews.llvm.org/D11609?vs=30946&id=31050#toc Repository: rL LLVM http://review

[Lldb-commits] [PATCH] D11609: Use only unnamed pipes to launch lldb-server gdbserver.

2015-07-29 Thread Chaoren Lin
chaoren created this revision. chaoren added reviewers: clayborg, vharron, chying. chaoren added a subscriber: lldb-commits. If we used unnamed pipes instead of named pipes, we can avoid having the file system littered with debugserver-named-pipes if lldb-server happens to crash for whatever reaso

Re: [Lldb-commits] [PATCH] D11540: Deprecate `SBValue::TypeIsPointerType`.

2015-07-27 Thread Chaoren Lin
Isn't this autogenerated? ``` // \deprecated { Please use blah instead } ``` Should work right? On Mon, Jul 27, 2015 at 2:36 PM, Siva Chandra wrote: > sivachandra added a subscriber: sivachandra. > sivachandra added a comment. > > If this change is OK, you should probably update the Python ref

Re: [Lldb-commits] [PATCH] D11540: Deprecate `SBValue::TypeIsPointerType`.

2015-07-27 Thread Chaoren Lin
chaoren added a subscriber: chaoren. chaoren added a comment. Isn't this autogenerated? // \deprecated { Please use blah instead } Should work right? http://reviews.llvm.org/D11540 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://l

Re: [Lldb-commits] [PATCH] D11539: Only test ObjC expression options on Darwin.

2015-07-27 Thread Chaoren Lin
This revision was automatically updated to reflect the committed changes. Closed by commit rL243329: Only test ObjC expression options on Darwin. (authored by chaoren). Changed prior to commit: http://reviews.llvm.org/D11539?vs=30735&id=30736#toc Repository: rL LLVM http://reviews.llvm.org/

[Lldb-commits] [lldb] r243329 - Only test ObjC expression options on Darwin.

2015-07-27 Thread Chaoren Lin
Author: chaoren Date: Mon Jul 27 16:15:01 2015 New Revision: 243329 URL: http://llvm.org/viewvc/llvm-project?rev=243329&view=rev Log: Only test ObjC expression options on Darwin. Reviewers: dawn, emaste, vharron, clayborg Subscribers: lldb-commits Differential Revision: http://reviews.llvm.org/

[Lldb-commits] [PATCH] D11539: Only test ObjC expression options on Darwin.

2015-07-27 Thread Chaoren Lin
chaoren created this revision. chaoren added reviewers: dawn, clayborg, emaste, vharron. chaoren added a subscriber: lldb-commits. http://reviews.llvm.org/D11539 Files: test/expression_command/options/TestExprOptions.py Index: test/expression_command/options/TestExprOptions.py

[Lldb-commits] [PATCH] D11533: Add SBValue::TypeIsReferenceType to SB API.

2015-07-27 Thread Chaoren Lin
chaoren created this revision. chaoren added a reviewer: clayborg. chaoren added a subscriber: lldb-commits. http://reviews.llvm.org/D11533 Files: include/lldb/API/SBValue.h include/lldb/Core/ValueObject.h scripts/interface/SBValue.i source/API/SBValue.cpp source/Core/ValueObject.cpp

[Lldb-commits] [lldb] r243230 - XFAIL TestExprOptions on Linux.

2015-07-25 Thread Chaoren Lin
Author: chaoren Date: Sat Jul 25 17:06:48 2015 New Revision: 243230 URL: http://llvm.org/viewvc/llvm-project?rev=243230&view=rev Log: XFAIL TestExprOptions on Linux. Modified: lldb/trunk/test/expression_command/options/TestExprOptions.py Modified: lldb/trunk/test/expression_command/options/T

[Lldb-commits] [PATCH] D11444: XFAIL TestReturnValue for OS X as well.

2015-07-22 Thread Chaoren Lin
chaoren created this revision. chaoren added reviewers: clayborg, tberghammer. chaoren added a subscriber: lldb-commits. Same reason as r242910; increased test coverage caused new failures. http://reviews.llvm.org/D11444 Files: test/functionalities/return-value/TestReturnValue.py Index: test/

[Lldb-commits] [lldb] r242932 - Xtimeout TestProcessAttach for Linux.

2015-07-22 Thread Chaoren Lin
Author: chaoren Date: Wed Jul 22 15:52:17 2015 New Revision: 242932 URL: http://llvm.org/viewvc/llvm-project?rev=242932&view=rev Log: Xtimeout TestProcessAttach for Linux. Modified: lldb/trunk/test/dosep.py Modified: lldb/trunk/test/dosep.py URL: http://llvm.org/viewvc/llvm-project/lldb/tru

[Lldb-commits] [lldb] r242814 - Re-enable static Android build after build master restart.

2015-07-21 Thread Chaoren Lin
Author: chaoren Date: Tue Jul 21 12:50:49 2015 New Revision: 242814 URL: http://llvm.org/viewvc/llvm-project?rev=242814&view=rev Log: Re-enable static Android build after build master restart. Modified: lldb/trunk/cmake/platforms/Android.cmake Modified: lldb/trunk/cmake/platforms/Android.cma

[Lldb-commits] [lldb] r242815 - Xfail TestGdbRemoteAbort for Android API <= 16.

2015-07-21 Thread Chaoren Lin
Author: chaoren Date: Tue Jul 21 12:50:52 2015 New Revision: 242815 URL: http://llvm.org/viewvc/llvm-project?rev=242815&view=rev Log: Xfail TestGdbRemoteAbort for Android API <= 16. Reviewers: sivachandra Subscribers: tberghammer, danalbert, srhines, lldb-commits Differential Revision: http://r

Re: [Lldb-commits] [PATCH] D11367: Update TestLoadUnload to use base Makefile.

2015-07-21 Thread Chaoren Lin
This revision was automatically updated to reflect the committed changes. Closed by commit rL242813: Update TestLoadUnload to use base Makefile. (authored by chaoren). Changed prior to commit: http://reviews.llvm.org/D11367?vs=30271&id=30272#toc Repository: rL LLVM http://reviews.llvm.org/D

[Lldb-commits] [lldb] r242813 - Update TestLoadUnload to use base Makefile.

2015-07-21 Thread Chaoren Lin
Author: chaoren Date: Tue Jul 21 12:50:16 2015 New Revision: 242813 URL: http://llvm.org/viewvc/llvm-project?rev=242813&view=rev Log: Update TestLoadUnload to use base Makefile. Summary: The current Makefile scheme only allows one dylib to be specified in each make invocation, so TestLoadUnload h

Re: [Lldb-commits] [PATCH] D11378: Xfail TestGdbRemoteAbort for Android API <= 16.

2015-07-21 Thread Chaoren Lin
chaoren updated this revision to Diff 30269. chaoren added a comment. Address review. http://reviews.llvm.org/D11378 Files: test/tools/lldb-server/inferior-crash/TestGdbRemoteAbort.py Index: test/tools/lldb-server/inferior-crash/TestGdbRemoteAbort.py =

Re: [Lldb-commits] [PATCH] D11367: Update TestLoadUnload to use base Makefile.

2015-07-20 Thread Chaoren Lin
chaoren updated this revision to Diff 30211. chaoren added a comment. - Split Makefile to isolate each dylib. http://reviews.llvm.org/D11367 Files: test/functionalities/load_unload/Makefile test/functionalities/load_unload/a.mk test/functionalities/load_unload/b.mk test/functionalities/

[Lldb-commits] [PATCH] D11367: Update TestLoadUnload to use base Makefile.

2015-07-20 Thread Chaoren Lin
chaoren created this revision. chaoren added a reviewer: clayborg. chaoren added a subscriber: lldb-commits. The current Makefile scheme only allows one dylib to be specified in each make invocation, so TestLoadUnload had a custom Makefile that's unrelated to the base Makefile.rules. This change u

Re: [Lldb-commits] [PATCH] D11357: Resolve DW_AT_comp_dir path if it contains a symlink

2015-07-20 Thread Chaoren Lin
chaoren accepted this revision. chaoren added a comment. This revision is now accepted and ready to land. LGTM. http://reviews.llvm.org/D11357 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-com

[Lldb-commits] [lldb] r242599 - Add evil hack to workaround the missing libdl.a in the Android toolchain.

2015-07-17 Thread Chaoren Lin
Author: chaoren Date: Fri Jul 17 20:09:43 2015 New Revision: 242599 URL: http://llvm.org/viewvc/llvm-project?rev=242599&view=rev Log: Add evil hack to workaround the missing libdl.a in the Android toolchain. Reviewers: vharron, ovyalov Subscribers: tberghammer, danalbert, srhines, lldb-commits

[Lldb-commits] [lldb] r242598 - Apply Android -pie switch to buildDefault as well.

2015-07-17 Thread Chaoren Lin
Author: chaoren Date: Fri Jul 17 19:37:55 2015 New Revision: 242598 URL: http://llvm.org/viewvc/llvm-project?rev=242598&view=rev Log: Apply Android -pie switch to buildDefault as well. Reviewers: ovyalov Subscribers: tberghammer, danalbert, srhines, lldb-commits Differential Revision: http://re

[Lldb-commits] [lldb] r242580 - Detect if necessary to build inferior with -pie for Android.

2015-07-17 Thread Chaoren Lin
Author: chaoren Date: Fri Jul 17 17:13:29 2015 New Revision: 242580 URL: http://llvm.org/viewvc/llvm-project?rev=242580&view=rev Log: Detect if necessary to build inferior with -pie for Android. Summary: - Add target_is_android check (with cached results). - Make android_device_api also cache res

[Lldb-commits] [lldb] r242560 - freeaddrinfo(NULL) segfaults on Android.

2015-07-17 Thread Chaoren Lin
Author: chaoren Date: Fri Jul 17 14:12:33 2015 New Revision: 242560 URL: http://llvm.org/viewvc/llvm-project?rev=242560&view=rev Log: freeaddrinfo(NULL) segfaults on Android. Reviewers: tberghammer Subscribers: tberghammer, danalbert, lldb-commits Differential Revision: http://reviews.llvm.org/

[Lldb-commits] [PATCH] D11285: freeaddrinfo(NULL) segfaults on Android.

2015-07-16 Thread Chaoren Lin
chaoren created this revision. chaoren added a reviewer: tberghammer. chaoren added a subscriber: lldb-commits. Herald added subscribers: danalbert, tberghammer. http://reviews.llvm.org/D11285 Files: source/Host/common/SocketAddress.cpp Index: source/Host/common/SocketAddress.cpp =

Re: [Lldb-commits] [PATCH] D11150: [NativeProcessLinux] Integrate MainLoop

2015-07-15 Thread Chaoren Lin
I wouldn't be surprised if this were Android specific (libc/kernel bug). Since we did run into problems with pthread_sigmask before. On Wed, Jul 15, 2015 at 11:17 PM, Chaoren Lin wrote: > Yeah, it's definitely related. Those two tests launch a large number of > processes.

[Lldb-commits] [lldb] r242332 - Remove shell-specific code from TestLoadUnload Makefile.

2015-07-15 Thread Chaoren Lin
Author: chaoren Date: Wed Jul 15 16:18:26 2015 New Revision: 242332 URL: http://llvm.org/viewvc/llvm-project?rev=242332&view=rev Log: Remove shell-specific code from TestLoadUnload Makefile. Reviewers: clayborg, sivachandra Subscribers: lldb-commits Differential Revision: http://reviews.llvm.or

Re: [Lldb-commits] [PATCH] D10887: Use accept instead of accept4 for Android.

2015-07-15 Thread Chaoren Lin
chaoren updated this revision to Diff 29811. chaoren added a comment. - Address review comments. http://reviews.llvm.org/D10887 Files: cmake/platforms/Android.cmake source/Host/common/Socket.cpp Index: source/Host/common/Socket.cpp ==

Re: [Lldb-commits] [PATCH] D11202: Remove shell-specific code from TestLoadUnload Makefile.

2015-07-15 Thread Chaoren Lin
chaoren updated this revision to Diff 29808. chaoren added a comment. - Added back the $(DS) variable since we don't source the base Makefile. http://reviews.llvm.org/D11202 Files: test/functionalities/load_unload/Makefile Index: test/functionalities/load_unload/Makefile

[Lldb-commits] [PATCH] D11202: Remove shell-specific code from TestLoadUnload Makefile.

2015-07-14 Thread Chaoren Lin
chaoren created this revision. chaoren added reviewers: clayborg, sivachandra. chaoren added a subscriber: lldb-commits. http://reviews.llvm.org/D11202 Files: test/functionalities/load_unload/Makefile Index: test/functionalities/load_unload/Makefile

Re: [Lldb-commits] [PATCH] D11099: [ClangASTType] Catch unhandled clang types at compile time

2015-07-14 Thread Chaoren Lin
AFAIK, there's no equivalent for this with MSVC. I think it would be a good idea to wrap the pragma around an ifdef. On Tue, Jul 14, 2015 at 2:09 AM, Pavel Labath wrote: > labath added a comment. > > In http://reviews.llvm.org/D11099#204409, @chaoren wrote: > > > Is it only this one switch state

Re: [Lldb-commits] [PATCH] D11094: Refactor Unix signals.

2015-07-13 Thread Chaoren Lin
We use local signals. ``` return getattr(signal, signal_name) ``` On Mon, Jul 13, 2015 at 11:07 AM, Greg Clayton wrote: > clayborg added a comment. > > So what happens if we are not connected to a remote platform? Do we get > UnixSignal that are empty? Do we fall back to some constant notion of

Re: [Lldb-commits] [PATCH] D11094: Refactor Unix signals.

2015-07-10 Thread Chaoren Lin
chaoren added a comment. > It would be nice from the standpoint that you might be able to grab a copy of > them and modify them before any processes are launched, but I don't see us > doing any of this anywhere so I would rather avoid it until we do. We do this in the gdb remote tests. I added

Re: [Lldb-commits] [PATCH] D11094: Refactor Unix signals.

2015-07-10 Thread Chaoren Lin
chaoren added inline comments. Comment at: include/lldb/API/SBUnixSignals.h:68 @@ -67,2 +67,3 @@ friend class SBProcess; +SBUnixSignals(const lldb::ProcessSP &process_sp); labath wrote: > You are changing the public API here. We are maintaining binary c

Re: [Lldb-commits] [PATCH] D11094: Refactor Unix signals.

2015-07-09 Thread Chaoren Lin
chaoren updated this revision to Diff 29418. chaoren added a comment. - UnixSignals::Reset should be virtual. http://reviews.llvm.org/D11094 Files: include/lldb/API/SBPlatform.h include/lldb/API/SBUnixSignals.h include/lldb/Core/StructuredData.h include/lldb/Host/Host.h include/lldb/T

[Lldb-commits] [PATCH] D11094: Refactor Unix signals.

2015-07-09 Thread Chaoren Lin
chaoren created this revision. chaoren added reviewers: ovyalov, clayborg. chaoren added a subscriber: lldb-commits. Herald added subscribers: tberghammer, emaste. - Consolidate Unix signals selection in Host. - Make Unix signals available from platform. - Delegate remote signal to platform. - Upd

[Lldb-commits] [lldb] r241837 - Fix 32-bit Linux watchpoint failures.

2015-07-09 Thread Chaoren Lin
Author: chaoren Date: Thu Jul 9 13:35:16 2015 New Revision: 241837 URL: http://llvm.org/viewvc/llvm-project?rev=241837&view=rev Log: Fix 32-bit Linux watchpoint failures. Summary: 32-bit signed return value from ptrace got sign extended when being converted to 64-bit unsigned. Also, replaced ta

Re: [Lldb-commits] [PATCH] D11014: Skip test that requires fork on Windows, which doesn't have fork.

2015-07-07 Thread Chaoren Lin
chaoren accepted this revision. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D11014 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D10976: Fix APFloat construction from 16 byte APInt.

2015-07-06 Thread Chaoren Lin
chaoren added a reviewer: clayborg. chaoren added a subscriber: lldb-commits. http://reviews.llvm.org/D10976 Files: source/Core/DataExtractor.cpp Index: source/Core/DataExtractor.cpp === --- source/Core/DataExtractor.cpp +++ sour

Re: [Lldb-commits] [PATCH] D10858: Default to linking lldb-server statically for Android.

2015-07-06 Thread Chaoren Lin
- Add comment for rational. http://reviews.llvm.org/D10858 Files: cmake/LLDBDependencies.cmake cmake/platforms/Android.cmake Index: cmake/platforms/Android.cmake === --- cmake/platforms/Android.cmake +++ cmake/platforms/Andro

Re: [Lldb-commits] [PATCH] D10887: Use accept instead of accept4 for Android.

2015-07-02 Thread Chaoren Lin
chaoren added a comment. We can't patch bugs on the system libc of shipped devices, while with static linking, we can avoid all but the latest bugs in the toolchain (which I think the toolchain guys would be more receptive to fixing). labath added a comment. In http://reviews.llvm.org/D10887#1985

Re: [Lldb-commits] [PATCH] D10887: Use accept instead of accept4 for Android.

2015-07-02 Thread Chaoren Lin
chaoren added a comment. That's what the shim does. You need to export the main symbol to call it with dlopen. http://reviews.llvm.org/D10887 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-comm

Re: [Lldb-commits] [PATCH] D10887: Use accept instead of accept4 for Android.

2015-07-02 Thread Chaoren Lin
For reference, the gdbserver binary currently in the toolchain is statically linked. Using a shim results in about a 5M increase in the lldb-server binary because of the need to export all symbols dynamically. And still has those two bugs (which would be in the system libs, if linked dynamically).

Re: [Lldb-commits] [PATCH] D10887: Use accept instead of accept4 for Android.

2015-07-02 Thread Chaoren Lin
chaoren added a comment. For reference, the gdbserver binary currently in the toolchain is statically linked. Using a shim results in about a 5M increase in the lldb-server binary because of the need to export all symbols dynamically. And still has those two bugs (which would be in the system lib

[Lldb-commits] [lldb] r241276 - Remove outdated comment.

2015-07-02 Thread Chaoren Lin
Author: chaoren Date: Thu Jul 2 10:30:59 2015 New Revision: 241276 URL: http://llvm.org/viewvc/llvm-project?rev=241276&view=rev Log: Remove outdated comment. Modified: lldb/trunk/test/functionalities/watchpoint/hello_watchpoint/TestMyFirstWatchpoint.py Modified: lldb/trunk/test/functional

Re: [Lldb-commits] [PATCH] Change executable name to a.out.

2015-07-02 Thread Chaoren Lin
Oops. Yeah, that doesn't make sense anymore. I'll remove it. On Jul 2, 2015 04:06, "Bruce Mitchener" wrote: > REPOSITORY > rL LLVM > > > Comment at: > lldb/trunk/test/functionalities/watchpoint/hello_watchpoint/TestMyFirstWatchpoint.py:41 > @@ -40,2 +40,3 @@ > self.dec

Re: [Lldb-commits] [PATCH] D10887: Use accept instead of accept4 for Android.

2015-07-02 Thread Chaoren Lin
chaoren added a comment. - b.android.com/178448 - pthread_sigmask doesn't work at all in the older toolchains The only possible problems I can see right now are missing syscalls, and we can easily get a diff of those between API 21 and API 9. labath requested changes to this revision. labath adde

Re: [Lldb-commits] [PATCH] D10887: Use accept instead of accept4 for Android.

2015-07-02 Thread Chaoren Lin
chaoren added a subscriber: chaoren. chaoren added a comment. I am statically linking against API-21. There are some bugs in the old toolchains that can be avoided by doing this. Aside from this issue, the resulting binary seem to run fine on API 10 devices (and passes most of the test suite). h

Re: [Lldb-commits] [PATCH] Fix TestCreateAfterAttach on Windows

2015-07-01 Thread Chaoren Lin
Comment at: test/functionalities/thread/create_after_attach/TestCreateAfterAttach.py:93 @@ -90,1 +92,3 @@ + 'main', + 'stop reason = breakpoint']) amccarth wrote: > chaoren wrote: > > amccarth wrote: > > > labath wrote

Re: [Lldb-commits] [PATCH] Default to linking lldb-server statically for Android.

2015-07-01 Thread Chaoren Lin
-pie is not compatible with -static. lldb-server can work on any API if linked statically. On Jul 1, 2015 02:17, "Tamas Berghammer" wrote: > > Comment at: cmake/platforms/Android.cmake:98-102 > @@ -97,7 +101,2 @@ > > -# PIE is required for API 21+ so we enable it > -# unfortunate

Re: [Lldb-commits] [PATCH] Fix TestCreateAfterAttach on Windows

2015-06-30 Thread Chaoren Lin
Comment at: test/functionalities/thread/create_after_attach/TestCreateAfterAttach.py:83 @@ -80,1 +82,3 @@ +# std::thread may cause the program to spin up a thread pool (and it does on +# Windows), so the thread numbers are non-deterministic. amc

Re: [Lldb-commits] [PATCH] Fix demangling of names if required by language

2015-06-30 Thread Chaoren Lin
REPOSITORY rL LLVM http://reviews.llvm.org/D10744 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] [NativeProcessLinux] Refactor PtraceWrapper

2015-06-30 Thread Chaoren Lin
LGTM. http://reviews.llvm.org/D10808 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] Rewrite FileSpec::EnumerateDirectory to avoid code duplication.

2015-06-29 Thread Chaoren Lin
- Shouldn't try to be clever. http://reviews.llvm.org/D10811 Files: include/lldb/Host/FileSpec.h source/Host/common/FileSpec.cpp EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ Index: include/lldb/Host/FileSpec.h =

[Lldb-commits] [PATCH] Rewrite FileSpec::EnumerateDirectory to avoid code duplication.

2015-06-29 Thread Chaoren Lin
Hi clayborg, http://reviews.llvm.org/D10811 Files: include/lldb/Host/FileSpec.h source/Host/common/FileSpec.cpp EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ Index: include/lldb/Host/FileSpec.h ===

Re: [Lldb-commits] [PATCH] Replace `rm -rf` with more portable implementation.

2015-06-29 Thread Chaoren Lin
Please let me fix this. I need to redeem myself. REPOSITORY rL LLVM http://reviews.llvm.org/D10787 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs

Re: [Lldb-commits] [PATCH] Replace `rm -rf` with more portable implementation.

2015-06-29 Thread Chaoren Lin
Please let me fix this. I need to redeem myself. On Mon, Jun 29, 2015 at 10:36 AM, Greg Clayton wrote: > Ah, I missed that this was committed. I will fix this. > > > REPOSITORY > rL LLVM > > http://reviews.llvm.org/D10787 > > EMAIL PREFERENCES > http://reviews.llvm.org/settings/panel/emailpr

Re: [Lldb-commits] [PATCH] [NativeProcessLinux] Refactor PtraceWrapper

2015-06-29 Thread Chaoren Lin
Comment at: source/Plugins/Process/Linux/NativeProcessLinux.h:145 @@ -146,1 +144,3 @@ +static Error +PtraceWrapper(int req, lldb::pid_t pid, void *addr, void *data, size_t data_size, long *result = nullptr); It seems like every argument besides `

[Lldb-commits] [lldb] r240894 - timegm in LibcGlue needs to be extern, not static.

2015-06-27 Thread Chaoren Lin
Author: chaoren Date: Sat Jun 27 18:11:32 2015 New Revision: 240894 URL: http://llvm.org/viewvc/llvm-project?rev=240894&view=rev Log: timegm in LibcGlue needs to be extern, not static. Reviewers: vharron Reviewed By: vharron Subscribers: lldb-commits Differential Revision: http://reviews.llvm.

Re: [Lldb-commits] [PATCH] Replace `rm -rf` with more portable implementation.

2015-06-27 Thread Chaoren Lin
REPOSITORY rL LLVM http://reviews.llvm.org/D10787 Files: lldb/trunk/source/Host/posix/FileSystem.cpp Index: lldb/trunk/source/Host/posix/FileSystem.cpp === --- lldb/trunk/source/Host/posix/FileSystem.cpp +++ lldb/trunk/source/Ho

Re: [Lldb-commits] [PATCH] timegm in LibcGlue needs to be extern, not static.

2015-06-27 Thread Chaoren Lin
REPOSITORY rL LLVM http://reviews.llvm.org/D10778 Files: lldb/trunk/include/lldb/Host/Time.h Index: lldb/trunk/include/lldb/Host/Time.h === --- lldb/trunk/include/lldb/Host/Time.h +++ lldb/trunk/include/lldb/Host/Time.h @@ -18,7

[Lldb-commits] [lldb] r240895 - Replace `rm -rf` with more portable implementation.

2015-06-27 Thread Chaoren Lin
Author: chaoren Date: Sat Jun 27 18:11:34 2015 New Revision: 240895 URL: http://llvm.org/viewvc/llvm-project?rev=240895&view=rev Log: Replace `rm -rf` with more portable implementation. Reviewers: clayborg, vharron Subscribers: lldb-commits Differential Revision: http://reviews.llvm.org/D10787

[Lldb-commits] [PATCH] Replace `rm -rf` with more portable implementation.

2015-06-26 Thread Chaoren Lin
Hi vharron, clayborg, http://reviews.llvm.org/D10787 Files: source/Host/posix/FileSystem.cpp Index: source/Host/posix/FileSystem.cpp === --- source/Host/posix/FileSystem.cpp +++ source/Host/posix/FileSystem.cpp @@ -10,6 +10,7 @@

Re: [Lldb-commits] [PATCH] [NativeProcessLinux] Use lambdas in DoOperation calls

2015-06-24 Thread Chaoren Lin
Comment at: source/Plugins/Process/Linux/NativeProcessLinux.cpp:3171 @@ +3170,3 @@ + +intptr_t data = 0; + chaoren wrote: > Why not make this `void *` to begin with? Whoops, didn't see the assignment right below. Please ignore this. http://reviews.llvm.org/D10

[Lldb-commits] [lldb] r240371 - Revert "Reduced packet counts to the remote GDB server where possible."

2015-06-22 Thread Chaoren Lin
Author: chaoren Date: Mon Jun 22 22:17:01 2015 New Revision: 240371 URL: http://llvm.org/viewvc/llvm-project?rev=240371&view=rev Log: Revert "Reduced packet counts to the remote GDB server where possible." This reverts commit 0cc0745ea9c68d7fdcadc9904cee3f13c96dae60. Due to breakage on Linux bui

[Lldb-commits] [lldb] r239419 - Rename `FileSpec::IsRelativeToCurrentWorkingDirectory` to `IsRelative`.

2015-06-09 Thread Chaoren Lin
Author: chaoren Date: Tue Jun 9 12:54:27 2015 New Revision: 239419 URL: http://llvm.org/viewvc/llvm-project?rev=239419&view=rev Log: Rename `FileSpec::IsRelativeToCurrentWorkingDirectory` to `IsRelative`. Summary: `IsRelativeToCurrentWorkingDirectory` was misleading, because relative paths are s

[Lldb-commits] [lldb] r239414 - XFail pexpect tests for Windows hosts.

2015-06-09 Thread Chaoren Lin
Author: chaoren Date: Tue Jun 9 12:39:27 2015 New Revision: 239414 URL: http://llvm.org/viewvc/llvm-project?rev=239414&view=rev Log: XFail pexpect tests for Windows hosts. Reviewers: vharron, zturner Subscribers: lldb-commits Differential Revision: http://reviews.llvm.org/D10340 Modified:

[Lldb-commits] [lldb] r239258 - Update dosep to display dotest command invoked on failure.

2015-06-07 Thread Chaoren Lin
Author: chaoren Date: Sun Jun 7 13:50:40 2015 New Revision: 239258 URL: http://llvm.org/viewvc/llvm-project?rev=239258&view=rev Log: Update dosep to display dotest command invoked on failure. Modified: lldb/trunk/test/dosep.py Modified: lldb/trunk/test/dosep.py URL: http://llvm.org/viewvc/

Re: [Lldb-commits] [PATCH] Skip TestInferiorChanged if host platform is windows.

2015-06-05 Thread Chaoren Lin
latform is, it'll be impossible for the inferior binaries to be modified. On Jun 5, 2015 21:42, "Chaoren Lin" wrote: > The host platform is not necessarily the same as the target platform. > On Jun 5, 2015 21:41, "Zachary Turner" wrote: > >> >> >>

[Lldb-commits] [lldb] r239135 - Check before using platform specific attributes.

2015-06-04 Thread Chaoren Lin
Author: chaoren Date: Fri Jun 5 01:28:43 2015 New Revision: 239135 URL: http://llvm.org/viewvc/llvm-project?rev=239135&view=rev Log: Check before using platform specific attributes. Summary: `os.uname` in TestUniversal and `os.geteuid` in TestTerminal. Reviewers: clayborg, zturner Subscribers:

[Lldb-commits] [lldb] r238852 - Use new get_signal_number utility function for tests.

2015-06-02 Thread Chaoren Lin
Author: chaoren Date: Tue Jun 2 12:01:13 2015 New Revision: 238852 URL: http://llvm.org/viewvc/llvm-project?rev=238852&view=rev Log: Use new get_signal_number utility function for tests. Summary: This fixes TestLldbGdbServer and TestSendSignal from Windows to Android. This change depends on D101

[Lldb-commits] [lldb] r238849 - Fix OBJCOPY and AR for Android.

2015-06-02 Thread Chaoren Lin
Author: chaoren Date: Tue Jun 2 11:43:19 2015 New Revision: 238849 URL: http://llvm.org/viewvc/llvm-project?rev=238849&view=rev Log: Fix OBJCOPY and AR for Android. Summary: Previously, OBJCOPY was empty because of the missing comma, and ar was just `ar`. Reviewers: ovyalov, tberghammer Subscr

Re: [Lldb-commits] [PATCH] Added utility function to get correct signal number from remote platform.

2015-06-01 Thread Chaoren Lin
Whoops. On Mon, Jun 1, 2015 at 6:27 PM, Oleksiy Vyalov wrote: > > Comment at: test/lldbutil.py:956 > @@ +955,3 @@ > +continue > +process = lldb.SBProcess() > +if not process.IsValid(): > > target.GetProcess() ? > > http://reviews.llvm

[Lldb-commits] [lldb] r238771 - Dump error if dotest itself fails and no tests were run.

2015-06-01 Thread Chaoren Lin
Author: chaoren Date: Mon Jun 1 14:06:01 2015 New Revision: 238771 URL: http://llvm.org/viewvc/llvm-project?rev=238771&view=rev Log: Dump error if dotest itself fails and no tests were run. Reviewers: zturner, clayborg Subscribers: lldb-commits Differential Revision: http://reviews.llvm.org/D1

[Lldb-commits] [lldb] r238765 - Updated dosep.py to output progress and dump std{out, err} on test failure.

2015-06-01 Thread Chaoren Lin
Author: chaoren Date: Mon Jun 1 12:49:25 2015 New Revision: 238765 URL: http://llvm.org/viewvc/llvm-project?rev=238765&view=rev Log: Updated dosep.py to output progress and dump std{out,err} on test failure. Reviewers: vharron, clayborg, zturner Subscribers: lldb-commits Differential Revision:

[Lldb-commits] [lldb] r238605 - Working directory FileSpec should use remote path syntax to display correctly.

2015-05-29 Thread Chaoren Lin
Author: chaoren Date: Fri May 29 14:52:37 2015 New Revision: 238605 URL: http://llvm.org/viewvc/llvm-project?rev=238605&view=rev Log: Working directory FileSpec should use remote path syntax to display correctly. Summary: Depends on D9728. Reviewers: ovyalov, zturner, clayborg Reviewed By: clay

[Lldb-commits] [lldb] r238599 - Implement snprintf for MSVC with correct return value.

2015-05-29 Thread Chaoren Lin
Author: chaoren Date: Fri May 29 14:34:57 2015 New Revision: 238599 URL: http://llvm.org/viewvc/llvm-project?rev=238599&view=rev Log: Implement snprintf for MSVC with correct return value. Reviewers: zturner Subscribers: lldb-commits Differential Revision: http://reviews.llvm.org/D10048 Modifi

[Lldb-commits] [lldb] r238594 - Fix hanging test suite when dosep.py is invoked directly.

2015-05-29 Thread Chaoren Lin
Author: chaoren Date: Fri May 29 13:43:46 2015 New Revision: 238594 URL: http://llvm.org/viewvc/llvm-project?rev=238594&view=rev Log: Fix hanging test suite when dosep.py is invoked directly. Reviewers: zturner, sivachandra Subscribers: lldb-commits Differential Revision: http://reviews.llvm.or

[Lldb-commits] [lldb] r238522 - Remove warning when testing for timeout command.

2015-05-28 Thread Chaoren Lin
Author: chaoren Date: Thu May 28 18:00:10 2015 New Revision: 238522 URL: http://llvm.org/viewvc/llvm-project?rev=238522&view=rev Log: Remove warning when testing for timeout command. Modified: lldb/trunk/test/dosep.py Modified: lldb/trunk/test/dosep.py URL: http://llvm.org/viewvc/llvm-proje

[Lldb-commits] [lldb] r238510 - Simplify regex in TestDataFormatterUnordered.py for better readability.

2015-05-28 Thread Chaoren Lin
Author: chaoren Date: Thu May 28 16:52:07 2015 New Revision: 238510 URL: http://llvm.org/viewvc/llvm-project?rev=238510&view=rev Log: Simplify regex in TestDataFormatterUnordered.py for better readability. Summary: Using `(match){3}` instead of `matchmatchmatch`. This is an update to D10078. Tes

[Lldb-commits] [lldb] r238460 - Allow both MSVC and Itanium mangling schemes.

2015-05-28 Thread Chaoren Lin
Author: chaoren Date: Thu May 28 14:15:31 2015 New Revision: 238460 URL: http://llvm.org/viewvc/llvm-project?rev=238460&view=rev Log: Allow both MSVC and Itanium mangling schemes. Summary: LLDB on Windows should now be able to demangle Linux/Android symbols. Also updated CxaDemangle.cpp to be co

Re: [Lldb-commits] [PATCH] [TestDataFormatterUnordered] Use patterns to match unordered_set elements

2015-05-27 Thread Chaoren Lin
I think it makes sense to update 64 and 65 as well. On Wed, May 27, 2015 at 5:29 PM, Siva Chandra wrote: > > Comment at: > test/functionalities/data-formatter/data-formatter-stl/libcxx/unordered/TestDataFormatterUnordered.py:66 > @@ -65,5 +65,3 @@ > self.look_for_conten

Re: [Lldb-commits] [PATCH] Make FileSpec::Dump use FileSpec::GetPath(), not the other way around.

2015-05-27 Thread Chaoren Lin
d to have not put a trailing slash in that case. See > the call to rtrim() in GetPath() > On Wed, May 27, 2015 at 3:14 PM Chaoren Lin wrote: > >> >> Comment at: source/Host/common/FileSpec.cpp:630 >> @@ +629,3 @@ >> +std::string path = G

[Lldb-commits] [lldb] r237966 - Fix lldb-platform usage string.

2015-05-21 Thread Chaoren Lin
Author: chaoren Date: Thu May 21 17:43:43 2015 New Revision: 237966 URL: http://llvm.org/viewvc/llvm-project?rev=237966&view=rev Log: Fix lldb-platform usage string. Modified: lldb/trunk/tools/lldb-server/lldb-platform.cpp Modified: lldb/trunk/tools/lldb-server/lldb-platform.cpp URL: http:/

Re: [Lldb-commits] [PATCH] [TestAttachDenied] Use a file instead of a pipe for synchronization.

2015-05-14 Thread Chaoren Lin
The workaround is for Android, the timeout is for Linux. I don't think they're related. On Thu, May 14, 2015 at 6:56 PM, Oleksiy Vyalov wrote: > With this CL in is > https://github.com/llvm-mirror/lldb/commit/8aca555d92918451fd852a71f6432c40b5bd7723 > still relevant? > > > http://reviews.llvm.or

[Lldb-commits] [lldb] r237016 - Doc talks about Platform_RunCommand while we actually use Platform_shell.

2015-05-11 Thread Chaoren Lin
Author: chaoren Date: Mon May 11 14:48:37 2015 New Revision: 237016 URL: http://llvm.org/viewvc/llvm-project?rev=237016&view=rev Log: Doc talks about Platform_RunCommand while we actually use Platform_shell. Modified: lldb/trunk/docs/lldb-gdb-remote.txt Modified: lldb/trunk/docs/lldb-gdb-rem

[Lldb-commits] [lldb] r236688 - Fix adb forward in gdbremote_testcase to support multiple devices.

2015-05-06 Thread Chaoren Lin
Author: chaoren Date: Wed May 6 20:42:53 2015 New Revision: 236688 URL: http://llvm.org/viewvc/llvm-project?rev=236688&view=rev Log: Fix adb forward in gdbremote_testcase to support multiple devices. Summary: Update to D9510. Reviewers: chying, tberghammer, ovyalov Reviewed By: ovyalov Subscr

[Lldb-commits] [lldb] r236543 - Fix typo. platfrom -> platform

2015-05-05 Thread Chaoren Lin
Author: chaoren Date: Tue May 5 15:34:36 2015 New Revision: 236543 URL: http://llvm.org/viewvc/llvm-project?rev=236543&view=rev Log: Fix typo. platfrom -> platform Modified: lldb/trunk/test/dotest.py lldb/trunk/test/tools/lldb-server/gdbremote_testcase.py Modified: lldb/trunk/test/dotes

[Lldb-commits] [lldb] r236138 - lldb-gdbserver should not use unnamed pipes on Windows.

2015-04-29 Thread Chaoren Lin
Author: chaoren Date: Wed Apr 29 14:01:43 2015 New Revision: 236138 URL: http://llvm.org/viewvc/llvm-project?rev=236138&view=rev Log: lldb-gdbserver should not use unnamed pipes on Windows. Modified: lldb/trunk/tools/lldb-server/lldb-gdbserver.cpp Modified: lldb/trunk/tools/lldb-server/lldb-

[Lldb-commits] [lldb] r236136 - Expose Close{Read/Write}FileDescriptor for pipes.

2015-04-29 Thread Chaoren Lin
Author: chaoren Date: Wed Apr 29 13:25:18 2015 New Revision: 236136 URL: http://llvm.org/viewvc/llvm-project?rev=236136&view=rev Log: Expose Close{Read/Write}FileDescriptor for pipes. Modified: lldb/trunk/include/lldb/Host/PipeBase.h lldb/trunk/include/lldb/Host/posix/PipePosix.h lldb

[Lldb-commits] [lldb] r236133 - Add file descriptor constructor for PipePosix.

2015-04-29 Thread Chaoren Lin
Author: chaoren Date: Wed Apr 29 12:36:58 2015 New Revision: 236133 URL: http://llvm.org/viewvc/llvm-project?rev=236133&view=rev Log: Add file descriptor constructor for PipePosix. Modified: lldb/trunk/include/lldb/Host/posix/PipePosix.h lldb/trunk/source/Host/posix/PipePosix.cpp lldb

[Lldb-commits] [lldb] r236132 - Remove trap code from disassembly.

2015-04-29 Thread Chaoren Lin
Author: chaoren Date: Wed Apr 29 12:24:48 2015 New Revision: 236132 URL: http://llvm.org/viewvc/llvm-project?rev=236132&view=rev Log: Remove trap code from disassembly. Summary: NativeProcessProtocol uses ReadMemory internally for setting/checking breakpoints but also for generic memory reads (Ha

[Lldb-commits] [lldb] r235653 - Fix build.

2015-04-23 Thread Chaoren Lin
Author: chaoren Date: Thu Apr 23 17:19:29 2015 New Revision: 235653 URL: http://llvm.org/viewvc/llvm-project?rev=235653&view=rev Log: Fix build. Modified: lldb/trunk/source/Expression/ClangModulesDeclVendor.cpp Modified: lldb/trunk/source/Expression/ClangModulesDeclVendor.cpp URL: http://ll

[Lldb-commits] [lldb] r235454 - Same issue as in D8685 but for i386.

2015-04-21 Thread Chaoren Lin
Author: chaoren Date: Tue Apr 21 18:00:58 2015 New Revision: 235454 URL: http://llvm.org/viewvc/llvm-project?rev=235454&view=rev Log: Same issue as in D8685 but for i386. Modified: lldb/trunk/source/Plugins/Process/Utility/RegisterContextFreeBSD_i386.cpp lldb/trunk/source/Plugins/Process/

Re: [Lldb-commits] [PATCH] TestMiBreak - func isn't always ??.

2015-04-17 Thread Chaoren Lin
Why not `func=\".*\"`? On Apr 17, 2015 06:26, "Ilia K" wrote: > > Comment at: test/tools/lldb-mi/breakpoint/TestMiBreak.py:34 > @@ -33,3 +33,3 @@ > self.expect("\^running") > - > self.expect("=breakpoint-modified,bkpt={number=\"1\",type=\"breakpoint\",disp=\"keep\",enabl

[Lldb-commits] [lldb] r235214 - TestMiBreak - func isn't always ??.

2015-04-17 Thread Chaoren Lin
Author: chaoren Date: Fri Apr 17 12:33:43 2015 New Revision: 235214 URL: http://llvm.org/viewvc/llvm-project?rev=235214&view=rev Log: TestMiBreak - func isn't always ??. Summary: Caused a failure because it showed up as `__printf`. Reviewers: ki.stfu Subscribers: lldb-commits Differential Revi

[Lldb-commits] [lldb] r234828 - Remove gcc xfail for TestTargetWatchAddress.

2015-04-13 Thread Chaoren Lin
Author: chaoren Date: Mon Apr 13 19:51:57 2015 New Revision: 234828 URL: http://llvm.org/viewvc/llvm-project?rev=234828&view=rev Log: Remove gcc xfail for TestTargetWatchAddress. Modified: lldb/trunk/test/python_api/watchpoint/watchlocation/TestTargetWatchAddress.py Modified: lldb/trunk/te

  1   2   >