Re: [Lldb-commits] [PATCH] D11595: Fix issues with separate symbolfile handling

This revision was automatically updated to reflect the committed changes. Closed by commit rL243637: Fix issues with separate symbolfile handling (authored by tberghammer). Changed prior to commit: http://reviews.llvm.org/D11595?vs=30907&id=31019#toc Repository: rL LLVM http://reviews.llvm.

Re: [Lldb-commits] [PATCH] D11384: Improve check for ASAN callbacks

tberghammer added a comment. I tried it, but it isn't help. Module::FindFunctions always parses the dwraf info for some reason (I haven't investigated why). Also I think "__asan_get_alloc_stack" is the name of a symbol so FindSymbol is the right function to call here. http://reviews.llvm.org/

[Lldb-commits] [lldb] r243521 - Fix read/write context in EmulateInstructionARM strd/ldrd

Author: tberghammer Date: Wed Jul 29 10:15:42 2015 New Revision: 243521 URL: http://llvm.org/viewvc/llvm-project?rev=243521&view=rev Log: Fix read/write context in EmulateInstructionARM strd/ldrd Modified: lldb/trunk/source/Plugins/Instruction/ARM/EmulateInstructionARM.cpp Modified: lldb/tru

[Lldb-commits] [lldb] r243520 - Remove non-utf-8 characters from EmulateInstructionARM

Author: tberghammer Date: Wed Jul 29 10:14:37 2015 New Revision: 243520 URL: http://llvm.org/viewvc/llvm-project?rev=243520&view=rev Log: Remove non-utf-8 characters from EmulateInstructionARM Modified: lldb/trunk/source/Plugins/Instruction/ARM/EmulateInstructionARM.cpp Modified: lldb/trunk/

Re: [Lldb-commits] [PATCH] D11465: Fix "process load/unload" on android

tberghammer added a comment. Friendly ping http://reviews.llvm.org/D11465 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r243000 - Remove XFAIL from ReturnValueTestCase after rL242972

Author: tberghammer Date: Thu Jul 23 04:49:59 2015 New Revision: 243000 URL: http://llvm.org/viewvc/llvm-project?rev=243000&view=rev Log: Remove XFAIL from ReturnValueTestCase after rL242972 Modified: lldb/trunk/test/functionalities/return-value/TestReturnValue.py Modified: lldb/trunk/test/f

[Lldb-commits] [lldb] r242887 - XFAIL watchpoint tests on Android arm/aarch64

Author: tberghammer Date: Wed Jul 22 06:00:06 2015 New Revision: 242887 URL: http://llvm.org/viewvc/llvm-project?rev=242887&view=rev Log: XFAIL watchpoint tests on Android arm/aarch64 Differential revision: http://reviews.llvm.org/D11409 Modified: lldb/trunk/test/functionalities/watchpoint/

[Lldb-commits] [lldb] r242671 - Improve aarch64 instruction emulation

Author: tberghammer Date: Mon Jul 20 08:52:50 2015 New Revision: 242671 URL: http://llvm.org/viewvc/llvm-project?rev=242671&view=rev Log: Improve aarch64 instruction emulation * Add emulation for STR/LDR immediate instructions * Cleanup existing emulation code Modified: lldb/trunk/source/Plu

Re: [Lldb-commits] [PATCH] D11256: Fix build errors on older versions of gcc

tberghammer accepted this revision. tberghammer added a comment. This revision is now accepted and ready to land. Looks good to me, but I am not sure if gcc-4.6 supports all c++11 feature we are using and LLVM officially supports gcc-4.7+, so you might run into other issues also using gcc-4.6. I

[Lldb-commits] [lldb] r242396 - Add missing include for android-arm build

Author: tberghammer Date: Thu Jul 16 07:35:04 2015 New Revision: 242396 URL: http://llvm.org/viewvc/llvm-project?rev=242396&view=rev Log: Add missing include for android-arm build Modified: lldb/trunk/source/Host/common/Socket.cpp Modified: lldb/trunk/source/Host/common/Socket.cpp URL: http

Re: [Lldb-commits] [PATCH] D11187: Add jThreadsInfo support to lldb-server

tberghammer added inline comments. Comment at: docs/lldb-gdb-remote.txt:1555-1575 @@ +1554,23 @@ +"registers": { + "0":"8000", + "1":"", + "2":"20fabf5fff7f", + "3":"e8f8bf5fff7f", + "4":"0100

Re: [Lldb-commits] [PATCH] D11187: Add jThreadsInfo support to lldb-server

tberghammer added inline comments. Comment at: docs/lldb-gdb-remote.txt:1555-1575 @@ +1554,23 @@ +"registers": { + "0":"8000", + "1":"", + "2":"20fabf5fff7f", + "3":"e8f8bf5fff7f", + "4":"0100

Re: [Lldb-commits] [PATCH] D11187: Add jThreadsInfo support to lldb-server

tberghammer added a comment. Generally looks good, but please clarify the format of the jThreads packet Comment at: docs/lldb-gdb-remote.txt:1555-1575 @@ +1554,23 @@ +"registers": { + "0":"8000", + "1":"", + "2":"20f

[Lldb-commits] [lldb] r242019 - Remove hack about the size of long doubles from DataExtractor

Author: tberghammer Date: Mon Jul 13 05:50:55 2015 New Revision: 242019 URL: http://llvm.org/viewvc/llvm-project?rev=242019&view=rev Log: Remove hack about the size of long doubles from DataExtractor The size of a long double was hardcoded in DataExtractor for x86 and x86_64 architectures. This C

Re: [Lldb-commits] [PATCH] D8417: Remove hack about the size of long doubles from DataExtractor

This revision was automatically updated to reflect the committed changes. Closed by commit rL242019: Remove hack about the size of long doubles from DataExtractor (authored by tberghammer). Changed prior to commit: http://reviews.llvm.org/D8417?vs=22191&id=29547#toc Repository: rL LLVM http

[Lldb-commits] [lldb] r241569 - Leave OS as unspecified unknown if it isn't specified in the ELF file

Author: tberghammer Date: Tue Jul 7 04:11:59 2015 New Revision: 241569 URL: http://llvm.org/viewvc/llvm-project?rev=241569&view=rev Log: Leave OS as unspecified unknown if it isn't specified in the ELF file This is the redone of r238623 what was reverted with the refactor in r239148. Differenti

[Lldb-commits] [PATCH] D10957: Leave OS as unspecified unknown if it isn't specified in the ELF file

tberghammer added reviewers: ovyalov, trixirt. tberghammer added a subscriber: lldb-commits. Leave OS as unspecified unknown if it isn't specified in the ELF file This is the redone of rL238623 what was reverted with the refactor in rL239148. http://reviews.llvm.org/D10957 Files: source/Core

[Lldb-commits] [lldb] r241436 - Make TestStopHook* remote platform compatible

Author: tberghammer Date: Mon Jul 6 05:46:34 2015 New Revision: 241436 URL: http://llvm.org/viewvc/llvm-project?rev=241436&view=rev Log: Make TestStopHook* remote platform compatible Modified: lldb/trunk/test/functionalities/stop-hook/TestStopHookMechanism.py lldb/trunk/test/functionali

[Lldb-commits] [lldb] r241435 - Fix final wait in ExprSyscallTestCase for aarch64

Author: tberghammer Date: Mon Jul 6 05:02:56 2015 New Revision: 241435 URL: http://llvm.org/viewvc/llvm-project?rev=241435&view=rev Log: Fix final wait in ExprSyscallTestCase for aarch64 Modified: lldb/trunk/test/expression_command/expr-in-syscall/TestExpressionInSyscall.py Modified: lldb

Re: [Lldb-commits] [PATCH] D10932: Improve UnwindLLDB with better detection for unwinding failures

This revision was automatically updated to reflect the committed changes. Closed by commit rL241434: Improve UnwindLLDB with better detection for unwinding failures (authored by tberghammer). Changed prior to commit: http://reviews.llvm.org/D10932?vs=29029&id=29068#toc Repository: rL LLVM h

Re: [Lldb-commits] [PATCH] D10932: Improve UnwindLLDB with better detection for unwinding failures

std::shared_ptr have an implicit constructor just for this purpose to make code simpler (without a typedef it would be odd to always write "return std::shared_ptr();") constexpr shared_ptr( std::nullptr_t ); http://reviews.llvm.org/D10932 ___ l

[Lldb-commits] [PATCH] D10932: Improve UnwindLLDB with better detection for unwinding failures

tberghammer created this revision. tberghammer added a reviewer: jasonmolenda. tberghammer added a subscriber: lldb-commits. Improve UnwindLLDB with better detection for unwinding failures Previously we accepted a frame as correct result if the PC pointed into an executable section of code. The

Re: [Lldb-commits] [PATCH] D10902: Enable usage of eh_frame based unwind plan as a fallback

This revision was automatically updated to reflect the committed changes. Closed by commit rL241334: Enable usage of eh_frame based unwind plan as a fallback (authored by tberghammer). Changed prior to commit: http://reviews.llvm.org/D10902?vs=28955&id=29001#toc Repository: rL LLVM http://r

Re: [Lldb-commits] [PATCH] D10843: Fix handling of DW_CFA_restore_state

This revision was automatically updated to reflect the committed changes. Closed by commit rL241331: Fix handling of DW_CFA_restore_state (authored by tberghammer). Changed prior to commit: http://reviews.llvm.org/D10843?vs=28797&id=28998#toc Repository: rL LLVM http://reviews.llvm.org/D108

Re: [Lldb-commits] [PATCH] D10899: Fix qMemoryRegionInfo packet to return current value for address after the last memory region

This revision was automatically updated to reflect the committed changes. Closed by commit rL241333: Fix qMemoryRegionInfo packet to return current value for address after the… (authored by tberghammer). Changed prior to commit: http://reviews.llvm.org/D10899?vs=28948&id=29000#toc Repository:

[Lldb-commits] [lldb] r241334 - Enable usage of eh_frame based unwind plan as a fallback

Author: tberghammer Date: Fri Jul 3 04:30:22 2015 New Revision: 241334 URL: http://llvm.org/viewvc/llvm-project?rev=241334&view=rev Log: Enable usage of eh_frame based unwind plan as a fallback Previously if the instruction emulation based unwind plan failed then we fall back to the arch default

[Lldb-commits] [lldb] r241331 - Fix handling of DW_CFA_restore_state

Author: tberghammer Date: Fri Jul 3 04:30:14 2015 New Revision: 241331 URL: http://llvm.org/viewvc/llvm-project?rev=241331&view=rev Log: Fix handling of DW_CFA_restore_state The CFA offset shouldn't be irestored to the saved value in case of a DW_CFA_restore_state opcode. Differential revision:

[Lldb-commits] [PATCH] D10902: Enable usage of eh_frame based unwind plan as a fallback

tberghammer created this revision. tberghammer added a reviewer: jasonmolenda. tberghammer added a subscriber: lldb-commits-list. Enable usage of eh_frame based unwind plan as a fallback Previously if the instruction emulation based unwind plan failed then we fall back to the arch default unwind

[Lldb-commits] [PATCH] D10899: Fix qMemoryRegionInfo packet to return current value for address after the last memory region

tberghammer created this revision. tberghammer added a reviewer: labath. tberghammer added a subscriber: lldb-commits-list. http://reviews.llvm.org/D10899 Files: source/Plugins/Process/Linux/NativeProcessLinux.cpp Index: source/Plugins/Process/Linux/NativeProcessLinux.cpp =

Re: [Lldb-commits] [PATCH] Add new bugreport command to lldb

REPOSITORY rL LLVM http://reviews.llvm.org/D10868 Files: lldb/trunk/lldb.xcodeproj/project.pbxproj lldb/trunk/source/Commands/CMakeLists.txt lldb/trunk/source/Commands/CommandObjectBugreport.cpp lldb/trunk/source/Commands/CommandObjectBugreport.h lldb/trunk/source/Interpreter/CommandI

Re: [Lldb-commits] [PATCH] Default to linking lldb-server statically for Android.

What is the implication of this change in terms of the size of lldb-server? You are linking statically against the system libraries (such as libc, libm, libdl) what might not be a portable solution if they are depending on features only present in some device / kernel. http://reviews.llvm.org/

Re: [Lldb-commits] [PATCH] Ignore teardown failure if it's caused by removing missing file or directory

LGTM http://reviews.llvm.org/D10830 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] Add new bugreport command to lldb

I agree that we can collect only a very limited information with a single command after the problem already occurred but my intuition is that if we want the user to reproduce the issue then there is much lower chance that they will submit a bug report even for people working on LLDB. For stack

Re: [Lldb-commits] [PATCH] Add new bugreport command to lldb

Address review comment about append and truncate http://reviews.llvm.org/D10868 Files: lldb.xcodeproj/project.pbxproj source/Commands/CMakeLists.txt source/Commands/CommandObjectBugreport.cpp source/Commands/CommandObjectBugreport.h source/Interpreter/CommandInterpreter.cpp EMAIL PREF

[Lldb-commits] [PATCH] Add new bugreport command to lldb

Hi clayborg, ovyalov, Add new bugreport command to lldb The new command add functionality to print out domain specific information for reporting a bug. Currently the only supported domain is stack unwinding (with "bugreport unwind") but adding new domains is fairly easy. http://reviews.llvm.org/

[Lldb-commits] [PATCH] Improve DWARF CFI CIE parsing and remove duplicated code

Hi labath, jasonmolenda, Improve DWARF CFI CIE parsing and remove duplicated code Previously we handled only a few opcode DWARF CFI opcode when we were parsing the CIE. With this change we use mostly the same code what we use for parsing the PDE which cover more opcode. http://reviews.llvm.org/D

[Lldb-commits] [lldb] r241057 - Fix [vdso] handling on Android (x86 and aarch64)

Author: tberghammer Date: Tue Jun 30 05:41:23 2015 New Revision: 241057 URL: http://llvm.org/viewvc/llvm-project?rev=241057&view=rev Log: Fix [vdso] handling on Android (x86 and aarch64) * Add in-memory object file handling to the core dynamic loader * Fix in memory object file handling in Object

[Lldb-commits] [lldb] r241050 - Fix LLDB build after r241035

Author: tberghammer Date: Tue Jun 30 04:26:52 2015 New Revision: 241050 URL: http://llvm.org/viewvc/llvm-project?rev=241050&view=rev Log: Fix LLDB build after r241035 Modified: lldb/trunk/source/Expression/ClangExpressionParser.cpp Modified: lldb/trunk/source/Expression/ClangExpressionParser

Re: [Lldb-commits] [PATCH] Fix [vdso] handling on Android (x86 and aarch64)

In http://reviews.llvm.org/D10800#196543, @vharron wrote: > If you've fixed vdso handling, shouldn't some i386 tests be marked as > passing? It is fixing it only on Android. There is a different between how the linker works on Linux and on Android and we need to solve one more additional issu

[Lldb-commits] [lldb] r240964 - Mark test_sb_api_listener_event_process_state as flakey

Author: tberghammer Date: Mon Jun 29 11:28:37 2015 New Revision: 240964 URL: http://llvm.org/viewvc/llvm-project?rev=240964&view=rev Log: Mark test_sb_api_listener_event_process_state as flakey Modified: lldb/trunk/test/api/multithreaded/TestMultithreaded.py Modified: lldb/trunk/test/api/mul

[Lldb-commits] [PATCH] Fix [vdso] handling on Android (x86 and aarch64)

Hi labath, clayborg, Fix [vdso] handling on Android (x86 and aarch64) * Add in-memory object file handling to the core dynamic loader * Fix in memory object file handling in ObjectFileELF (previously only part of the file was loaded before parsing) * Fix load address setting in ObjectFileELF fo

Re: [Lldb-commits] [PATCH] Add branch emulation to aarch64 instruction emulator

REPOSITORY rL LLVM http://reviews.llvm.org/D10702 Files: lldb/trunk/source/Plugins/Instruction/ARM64/EmulateInstructionARM64.cpp lldb/trunk/source/Plugins/Instruction/ARM64/EmulateInstructionARM64.h lldb/trunk/source/Plugins/UnwindAssembly/InstEmulation/UnwindAssemblyInstEmulation.cpp

Re: [Lldb-commits] [PATCH] [NativeProcessLinux] Use lambdas in DoOperation calls

Comment at: source/Plugins/Process/Linux/NativeProcessLinux.cpp:259 @@ -258,3 +258,3 @@ ProcessPOSIXLog::DecNestLevel(); -return bytes_read; +return error; } labath wrote: > tberghammer wrote: > > (n

[Lldb-commits] [lldb] r240651 - Fix TestThreadAPI on Linux

Author: tberghammer Date: Thu Jun 25 10:19:22 2015 New Revision: 240651 URL: http://llvm.org/viewvc/llvm-project?rev=240651&view=rev Log: Fix TestThreadAPI on Linux On Linux malloc calls itself in some case. Change the test case to handle this scenario. Modified: lldb/trunk/test/python_api/t

Re: [Lldb-commits] [PATCH] Add branch emulation to aarch64 instruction emulator

Comment at: source/Plugins/Instruction/ARM64/EmulateInstructionARM64.cpp:880 @@ +879,3 @@ +{ +#if 0 +// ARM64 pseudo code... emaste wrote: > Shouldn't this be a comment rather than `#if 0`? I did this based on the style we use in EmulateInstructionARM but it is

[Lldb-commits] [lldb] r240533 - Improve instruction emulation based stack unwinding on ARM

Author: tberghammer Date: Wed Jun 24 06:27:32 2015 New Revision: 240533 URL: http://llvm.org/viewvc/llvm-project?rev=240533&view=rev Log: Improve instruction emulation based stack unwinding on ARM * Add and fix the emulation of several instruction. * Disable frame pointer usage on Android. * Spec

Re: [Lldb-commits] [PATCH] Improve instruction emulation based stack unwinding on ARM

REPOSITORY rL LLVM http://reviews.llvm.org/D10447 Files: lldb/trunk/include/lldb/Symbol/FuncUnwinders.h lldb/trunk/source/Commands/CommandObjectTarget.cpp lldb/trunk/source/Plugins/Instruction/ARM/EmulateInstructionARM.cpp lldb/trunk/source/Plugins/Instruction/ARM64/EmulateInstructionAR

[Lldb-commits] [lldb] r240162 - Fix build brakage caused by r240154

Author: tberghammer Date: Fri Jun 19 14:28:13 2015 New Revision: 240162 URL: http://llvm.org/viewvc/llvm-project?rev=240162&view=rev Log: Fix build brakage caused by r240154 Modified: lldb/trunk/source/Symbol/ClangASTType.cpp Modified: lldb/trunk/source/Symbol/ClangASTType.cpp URL: http://l

Re: [Lldb-commits] [PATCH] Fetch object file load address if it isn't specified by the linker

Comment at: include/lldb/Host/common/NativeProcessProtocol.h:297 @@ -295,1 +296,3 @@ +virtual Error +GetFileLoadAddress(const llvm::StringRef& file_name, lldb::addr_t& load_addr) ovyalov wrote: > Nit - I think it's ok to make method pure virtual

Re: [Lldb-commits] [PATCH] Add a test for expression evaluation while inferior is blocked in a syscall

Comment at: test/expression_command/expr-in-syscall/TestExpressionInSyscall.py:53 @@ +52,3 @@ + +# give the child enough time to reach the syscall +# clearing out all the pending events What gives time to the inferior to reach the syscall? Should w

Re: [Lldb-commits] [PATCH] [TestLoadUnload] Enable for Android while skipping it for other remotes.

Looks good http://reviews.llvm.org/D10469 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] Fetch object file load address if it isn't specified by the linker

Improve documentation http://reviews.llvm.org/D10490 Files: docs/lldb-gdb-remote.txt include/lldb/Host/common/NativeProcessProtocol.h include/lldb/Target/Process.h source/Plugins/DynamicLoader/POSIX-DYLD/DYLDRendezvous.cpp source/Plugins/Process/Linux/NativeProcessLinux.cpp source/Pl

Re: [Lldb-commits] [PATCH] Add new test for stress testing stack unwinding

http://reviews.llvm.org/D10454 Files: test/functionalities/unwind/standard/Makefile test/functionalities/unwind/standard/TestStandardUnwind.py EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ Index: test/functionalities/unwind/standard/Makefile

[Lldb-commits] [PATCH] Fetch object file load address if it isn't specified by the linker

Hi ovyalov, Fetch object file load address if it isn't specified by the linker On Android the load address for the linker isn't specified in the rendezvous data structure. This patch add a new GDB packet to fetch this information from the inferior based on /proc//maps if it happens. http://rev

Re: [Lldb-commits] [PATCH] Fix several issue in arm single stepping and stack unwinding

Abandon because of an upcoming patch fixing this issue and several other issue also http://reviews.llvm.org/D9854 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu ht

Re: [Lldb-commits] [PATCH] Fix prologue and epilogue handling in UnwindAssemblyInstEmulation

Abandon because of an upcoming patch fixing this issue and several other issue also http://reviews.llvm.org/D9738 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu ht

[Lldb-commits] [lldb] r238836 - Mark TestHelloWorld as XTIMEOUT for Linux

Author: tberghammer Date: Tue Jun 2 09:45:25 2015 New Revision: 238836 URL: http://llvm.org/viewvc/llvm-project?rev=238836&view=rev Log: Mark TestHelloWorld as XTIMEOUT for Linux It is times out on the build bot ~10% of the times Modified: lldb/trunk/test/dosep.py Modified: lldb/trunk/test

[Lldb-commits] [lldb] r238411 - Fix breakpoint setting in gdb remote test cases on arm

Author: tberghammer Date: Thu May 28 05:55:01 2015 New Revision: 238411 URL: http://llvm.org/viewvc/llvm-project?rev=238411&view=rev Log: Fix breakpoint setting in gdb remote test cases on arm Modified: lldb/trunk/test/tools/lldb-server/TestLldbGdbServer.py lldb/trunk/test/tools/lldb-serv

[Lldb-commits] [lldb] r238312 - Fix write register context in EmulateInstructionARM::EmulateMOVRdRm

Author: tberghammer Date: Wed May 27 07:32:28 2015 New Revision: 238312 URL: http://llvm.org/viewvc/llvm-project?rev=238312&view=rev Log: Fix write register context in EmulateInstructionARM::EmulateMOVRdRm Modified: lldb/trunk/source/Plugins/Instruction/ARM/EmulateInstructionARM.cpp Modified

[Lldb-commits] [lldb] r238307 - Parse function name from DWARF DW_AT_abstract_origin

Author: tberghammer Date: Wed May 27 04:43:44 2015 New Revision: 238307 URL: http://llvm.org/viewvc/llvm-project?rev=238307&view=rev Log: Parse function name from DWARF DW_AT_abstract_origin A DW_TAG_subprogram entry can contain a reference to a DW_AT_abstract_origin entry instead of duplicating

[Lldb-commits] [lldb] r237901 - Handle aggregate return types in SysV-arm ABI

Author: tberghammer Date: Thu May 21 08:44:40 2015 New Revision: 237901 URL: http://llvm.org/viewvc/llvm-project?rev=237901&view=rev Log: Handle aggregate return types in SysV-arm ABI Differential revision: http://reviews.llvm.org/D9910 Modified: lldb/trunk/source/Plugins/ABI/SysV-arm/ABISys

[Lldb-commits] [lldb] r237679 - Mark TestEvents as XTIMEOUT on Linux

Author: tberghammer Date: Tue May 19 05:49:40 2015 New Revision: 237679 URL: http://llvm.org/viewvc/llvm-project?rev=237679&view=rev Log: Mark TestEvents as XTIMEOUT on Linux Modified: lldb/trunk/test/dosep.py Modified: lldb/trunk/test/dosep.py URL: http://llvm.org/viewvc/llvm-project/lldb/

[Lldb-commits] [lldb] r237578 - Fix test expectation in TestThreadExit after r237566

Author: tberghammer Date: Mon May 18 11:08:06 2015 New Revision: 237578 URL: http://llvm.org/viewvc/llvm-project?rev=237578&view=rev Log: Fix test expectation in TestThreadExit after r237566 Modified: lldb/trunk/test/functionalities/thread/thread_exit/TestThreadExit.py Modified: lldb/trunk/t

[Lldb-commits] [lldb] r237570 - Fix encoding of BX instrucion in EmulateInstructionARM

Author: tberghammer Date: Mon May 18 09:55:51 2015 New Revision: 237570 URL: http://llvm.org/viewvc/llvm-project?rev=237570&view=rev Log: Fix encoding of BX instrucion in EmulateInstructionARM Modified: lldb/trunk/source/Plugins/Instruction/ARM/EmulateInstructionARM.cpp Modified: lldb/trunk/

[Lldb-commits] [lldb] r237435 - Fix virtual step handling in ThreadPlanStepInRange

Author: tberghammer Date: Fri May 15 05:14:15 2015 New Revision: 237435 URL: http://llvm.org/viewvc/llvm-project?rev=237435&view=rev Log: Fix virtual step handling in ThreadPlanStepInRange Differential revision: http://reviews.llvm.org/D9773 Modified: lldb/trunk/source/Target/ThreadPlanStepI

[Lldb-commits] [lldb] r237240 - Fix arm instruction emulation of add (imm) and sub (imm)

Author: tberghammer Date: Wed May 13 04:25:06 2015 New Revision: 237240 URL: http://llvm.org/viewvc/llvm-project?rev=237240&view=rev Log: Fix arm instruction emulation of add (imm) and sub (imm) Differential revision: http://reviews.llvm.org/D9704 Modified: lldb/trunk/source/Plugins/Instruct

[Lldb-commits] [lldb] r237135 - XFAIL and Skip flaky test case on linux

Author: tberghammer Date: Tue May 12 09:25:43 2015 New Revision: 237135 URL: http://llvm.org/viewvc/llvm-project?rev=237135&view=rev Log: XFAIL and Skip flaky test case on linux Modified: lldb/trunk/test/functionalities/thread/create_after_attach/TestCreateAfterAttach.py Modified: lldb/tru

Re: [Lldb-commits] [lldb] r237089 - TestPublicAPIHeaders.py - Changed expectedFailureDarwin to skipIfDarwin

Hi Vince, Can you put back the @expectedFailure decorator next to the @skipIfDarwin decorator? Having both will have the same effect as @skipIfDarwin only but makes it easier when we grep for XFAIL-s (we do it for several test case which times out on the Linux build bot). Thanks, Tamas On Tue, M

[Lldb-commits] [lldb] r236997 - New test for llvm.org/pr23478

Author: tberghammer Date: Mon May 11 09:42:09 2015 New Revision: 236997 URL: http://llvm.org/viewvc/llvm-project?rev=236997&view=rev Log: New test for llvm.org/pr23478 When there is two brekapoint on two consecutive instruction then the second breakpoint is ignored by lldb. This test check for th

[Lldb-commits] [lldb] r236984 - Skip and XFAIL test occasionally timing out on the Linux build bot

Author: tberghammer Date: Mon May 11 05:32:16 2015 New Revision: 236984 URL: http://llvm.org/viewvc/llvm-project?rev=236984&view=rev Log: Skip and XFAIL test occasionally timing out on the Linux build bot Modified: lldb/trunk/test/functionalities/connect_remote/TestConnectRemote.py Modified:

[Lldb-commits] [lldb] r236843 - Use /data/local/tmp as temp directory on android

Author: tberghammer Date: Fri May 8 07:46:26 2015 New Revision: 236843 URL: http://llvm.org/viewvc/llvm-project?rev=236843&view=rev Log: Use /data/local/tmp as temp directory on android If no temp directory specified by the user on android then fall back to /data/local/tmp what is always present

Re: [Lldb-commits] [lldb] r236817 - This patch allows LLDB to use the $qXfer:Libraries: packet.

I committed in a fix for the issue as http://reviews.llvm.org/rL236826. Please take a look and let me know if it causing some issue for you. Tamas On Fri, May 8, 2015 at 11:42 AM, Tamas Berghammer wrote: > Hi Aidan, > > This patch caused a regression on android-arm (remote debugg

[Lldb-commits] [lldb] r236826 - Re-enable compute load address for shared modules

Author: tberghammer Date: Fri May 8 06:07:05 2015 New Revision: 236826 URL: http://llvm.org/viewvc/llvm-project?rev=236826&view=rev Log: Re-enable compute load address for shared modules It is required because of systems using PIE code Modified: lldb/trunk/source/Plugins/DynamicLoader/POSI

Re: [Lldb-commits] [lldb] r236817 - This patch allows LLDB to use the $qXfer:Libraries: packet.

Hi Aidan, This patch caused a regression on android-arm (remote debugging) with breaking the code for setting a breakpoint. I haven't found out the exact reason for the problem but it looks like as the location of the breakpoints isn't deduced correctly because of a wrong load address for the exec

[Lldb-commits] [lldb] r235715 - Fix condition detection in EmulateInstructionARM

Author: tberghammer Date: Fri Apr 24 07:13:44 2015 New Revision: 235715 URL: http://llvm.org/viewvc/llvm-project?rev=235715&view=rev Log: Fix condition detection in EmulateInstructionARM The condition detection code is calculating the result of the condition based on the first 3 bit of the condit

[Lldb-commits] [lldb] r235584 - Fix test expectation in TestNoreturnUnwind

Author: tberghammer Date: Thu Apr 23 05:54:27 2015 New Revision: 235584 URL: http://llvm.org/viewvc/llvm-project?rev=235584&view=rev Log: Fix test expectation in TestNoreturnUnwind The test case lookinhg for the abort function in the stack trace. Previously it lookd for a function which ends with

[Lldb-commits] [lldb] r235585 - Update cpsr register in BLX instruction emulation

Author: tberghammer Date: Thu Apr 23 05:56:51 2015 New Revision: 235585 URL: http://llvm.org/viewvc/llvm-project?rev=235585&view=rev Log: Update cpsr register in BLX instruction emulation Write the new cpsr value into the cpsr register if the BL or the BLX instruction change the instruction set o

[Lldb-commits] [lldb] r235291 - Stop read thread of Communication on EOF

Author: tberghammer Date: Mon Apr 20 04:52:47 2015 New Revision: 235291 URL: http://llvm.org/viewvc/llvm-project?rev=235291&view=rev Log: Stop read thread of Communication on EOF Previously the read thread was only stopped if CloseOnEOF was set on the communication channel. It caused it to spin i

[Lldb-commits] [lldb] r235098 - Fix thumb symbol value fixup in ObjectFileELF

Author: tberghammer Date: Thu Apr 16 09:06:18 2015 New Revision: 235098 URL: http://llvm.org/viewvc/llvm-project?rev=235098&view=rev Log: Fix thumb symbol value fixup in ObjectFileELF Modified: lldb/trunk/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp Modified: lldb/trunk/source/Plugins/Obj

[Lldb-commits] [lldb] r234987 - Add single stepping logic for linux arm

Author: tberghammer Date: Wed Apr 15 04:47:02 2015 New Revision: 234987 URL: http://llvm.org/viewvc/llvm-project?rev=234987&view=rev Log: Add single stepping logic for linux arm Linux arm don't support hardware stepping (neither mismatch breakpoints). This patch implement signle stepping with doi

[Lldb-commits] [lldb] r234986 - Fix breakpoint trap opcode detection for arm linux

Author: tberghammer Date: Wed Apr 15 04:38:48 2015 New Revision: 234986 URL: http://llvm.org/viewvc/llvm-project?rev=234986&view=rev Log: Fix breakpoint trap opcode detection for arm linux Modified: lldb/trunk/source/Plugins/Platform/Linux/PlatformLinux.cpp lldb/trunk/source/Plugins/Proce

[Lldb-commits] [lldb] r234985 - Fix test makefile after r234949.

Author: tberghammer Date: Wed Apr 15 04:28:31 2015 New Revision: 234985 URL: http://llvm.org/viewvc/llvm-project?rev=234985&view=rev Log: Fix test makefile after r234949. On non OSX architectures we don't need a space between the arch flag (-m) and the value. Modified: lldb/trunk/test/make/M

Re: [Lldb-commits] [Diffusion] rL234178: We have an issue where if you use a C function right now that has no prototype…

ht this might make the test work, but there is a difference > between the "complete object constructor" and the "base object > constructor". I don't think we should just interpose the two without > knowing more. > > Greg > > > On Apr 9, 2015, at 11:5

Re: [Lldb-commits] [PATCH] Add info on running remote test suite to the website

LGTM http://reviews.llvm.org/D8873 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] Add info on running remote test suite to the website

Looks good with 2 minor comment Comment at: www/test.html:72-73 @@ +71,4 @@ + decreasing the time it takes to run the full testsuite. The number of concurrent + tests is controlled by the LLDB_TEST_THREADS environment variable and + defaul

Re: [Lldb-commits] [PATCH] Fix expectedFailureLLGS to expect failure when host platform is not linux.

REPOSITORY rL LLVM Comment at: test/lldbtest.py:609 @@ -608,2 +608,3 @@ def fn(self): # llgs local is only an option on Linux systems +if not self.platformIsLinux(): Can you change it to "llgs local is only an option on Linux targets"? htt

[Lldb-commits] [lldb] r234322 - Fix host config for Android and remove android specific part form Linux.

Author: tberghammer Date: Tue Apr 7 11:08:32 2015 New Revision: 234322 URL: http://llvm.org/viewvc/llvm-project?rev=234322&view=rev Log: Fix host config for Android and remove android specific part form Linux. Modified: lldb/trunk/include/lldb/Host/android/Config.h lldb/trunk/include/lld

[Lldb-commits] [lldb] r234307 - Ignore mapping symbols on aarch64

Author: tberghammer Date: Tue Apr 7 05:43:50 2015 New Revision: 234307 URL: http://llvm.org/viewvc/llvm-project?rev=234307&view=rev Log: Ignore mapping symbols on aarch64 ELF symbol tables on aarch64 may contains some mapping symbols. They provide information about the underlying data but interf

Re: [Lldb-commits] [PATCH] Ignore mapping symbols on aarch64

REPOSITORY rL LLVM http://reviews.llvm.org/D8776 Files: lldb/trunk/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp lldb/trunk/source/Plugins/ObjectFile/ELF/ObjectFileELF.h EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ Index: lldb/trunk/source/Plugins/ObjectFi

Re: [Lldb-commits] [Diffusion] rL234178: We have an issue where if you use a C function right now that has no prototype…

USERS tberghammer (Auditor) http://reviews.llvm.org/rL234178 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] Use objcopy provided next to the compiler on android

REPOSITORY rL LLVM http://reviews.llvm.org/D8765 Files: lldb/trunk/test/make/Makefile.rules Index: lldb/trunk/test/make/Makefile.rules === --- lldb/trunk/test/make/Makefile.rules +++ lldb/trunk/test/make/Makefile.rules @@ -184,6

[Lldb-commits] [PATCH] Correctly detect sign-ness of wchar_t

Hi clayborg, Correctly detect sign-ness of wchar_t The underlying type of wchar_t is not defined by the standard. This CL add logic to correctly use the type specified for the current target based on TargetInfo. http://reviews.llvm.org/D8722 Files: source/Symbol/ClangASTContext.cpp Index: so

[Lldb-commits] [lldb] r233680 - Fix Windows build after r233679

Author: tberghammer Date: Tue Mar 31 05:11:04 2015 New Revision: 233680 URL: http://llvm.org/viewvc/llvm-project?rev=233680&view=rev Log: Fix Windows build after r233679 Modified: lldb/trunk/source/Plugins/Platform/Linux/PlatformLinux.cpp Modified: lldb/trunk/source/Plugins/Platform/Linux/Pl

Re: [Lldb-commits] [PATCH] Fix test expectation for aarch64 in several test case

In http://reviews.llvm.org/D8702#148933, @emaste wrote: > Looks reasonable. I wonder if we should have a machine-dependent test library > though to host these sorts of things. We'll probably have several more when > the test suite fully runs on !x86 architectures, no? We already have some basi

Re: [Lldb-commits] [PATCH] Allow multiple simultaneous connections to lldb-platform

If you are confident that it won't cause any regression then I am fine with increasing it to 5 but I have no idea how many different part of the code base use this class. http://reviews.llvm.org/D8696 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ _

[Lldb-commits] [lldb] r233546 - Fix check in TestNoreturnUnwind

Author: tberghammer Date: Mon Mar 30 09:05:37 2015 New Revision: 233546 URL: http://llvm.org/viewvc/llvm-project?rev=233546&view=rev Log: Fix check in TestNoreturnUnwind Modified: lldb/trunk/test/functionalities/unwind/noreturn/TestNoreturnUnwind.py Modified: lldb/trunk/test/functionalities/

Re: [Lldb-commits] [PATCH] Fix TestGdbRemote* on remote Linux

REPOSITORY rL LLVM http://reviews.llvm.org/D8454 Files: lldb/trunk/test/dotest.py lldb/trunk/test/tools/lldb-server/gdbremote_testcase.py EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ Index: lldb/trunk/test/tools/lldb-server/gdbremote_testcase.py

Re: [Lldb-commits] [PATCH] Replace sys.platform skips in tests with @skip decorators which check against remote platform.

lgtm REPOSITORY rL LLVM http://reviews.llvm.org/D8665 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] Fix type detection for 'char' variables

Move CharIsSignedByDefault to ArchSpec http://reviews.llvm.org/D8636 Files: include/lldb/Core/ArchSpec.h source/Core/ArchSpec.cpp source/Expression/ClangExpressionParser.cpp source/Symbol/ClangASTContext.cpp EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ In

Re: [Lldb-commits] [PATCH] Move lot of class from the global namespace into lldb_private

In http://reviews.llvm.org/D8654#147918, @clayborg wrote: > The main question is do we want to move each plug-in into its own namespace > within lldb_private namespace? > > All code from the GDB remote process plug-in could be in: > > namespace lldb_private { > namespace plugin { > na

  1   2   >