Can somebody close it? I can't:
Validation errors:
- You can not close this revision because it has not been accepted. You can
only close accepted revisions.
http://reviews.llvm.org/D7379
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
Thanks for review. I renamed the test as suggested. Also observed a line was
wrongly commented out in lldb-mi test case that I fixed. Committed in 228538.
http://reviews.llvm.org/D7379
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
__
I would probably call the test test_windows_double_slash, since
test_windows_path is really generic. But otherwise LGTM, feel free to commit.
http://reviews.llvm.org/D7379
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
__
Added test case that checks the FileSpec on Windows.
http://reviews.llvm.org/D7379
Files:
source/Host/common/FileSpec.cpp
test/functionalities/breakpoint/breakpoint_command/TestRegexpBreakCommand.py
test/functionalities/paths/TestPaths.py
test/tools/lldb-mi/TestMiBreakpoint.py
test/too
Can you have the test just run on windows? Then PathSyntaxWindows will be
the default
On Thu, Feb 5, 2015 at 5:10 AM Hafiz Abid Qadeer
wrote:
> Fixed a comment in the TestMiBreakpoint.py.
>
>
> http://reviews.llvm.org/D7379
>
> Files:
> source/Host/common/FileSpec.cpp
> test/functionalities/b
Fixed the : issue in lldb-mi. Changed FileSpec::Normalize to make sure that it
handles the path with \\ correctly. Added test cases to check for full path in
both lldb-mi and lldb.
zturner suggested to add test case for SBFileSpec that creates it with
PathSyntaxWindows. But PathSyntax enum is i
I would probably test SBFileSpec directly. Look at lldb/test/functionalitie
s/paths/TestPaths.py. Construct an SBFileSpec with PathSyntaxWindows and
give it multiple backslashes in the path, and make sure it's normalized
correctly.
On Wed Feb 04 2015 at 9:47:09 AM Hafiz Abid Qadeer
wrote:
> zt
zturner,
Sure. I can add test. Just test 'b' command with full path?
http://reviews.llvm.org/D7379
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.ui
I think the proposed change with std::unique looks fine. But can you add a
test alongside the patch?
http://reviews.llvm.org/D7379
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
___
lldb-commits mailing list
lldb-commi
On Linux, eclipse send the normal path like
37-break-insert -f /home/abidh/work/test.c:28
I agree with that check about ePathSyntaxWindows. We dont want to put penalty
on other platforms. But looking at Normalize function, it seems that
std::replace only gets called when we have syntax == ePathS
Hmm. What does eclipse do on other platforms? Does it use // or /? I'm
wondering if the logic should be behind an if (m_syntax ==
PathSyntaxWindows). Then just scan the string and remove double backslashes
before normalizing
On Wed, Feb 4, 2015 at 8:52 AM Hafiz Abid Qadeer
wrote:
> That function
That function may be relevent for command line. Lldb-mi calls
SBTarget::BreakpointCreateByLocation (and similar) functions to set the
breakpoint and Args::SetCommandString is never called.
http://reviews.llvm.org/D7379
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences
I see. I don't have code in front of me, but can you check
Args::SetCommandString? I thought it had code to convert \\ into \
On Wed, Feb 4, 2015 at 8:20 AM Hafiz Abid Qadeer
wrote:
> zturner,
> Command line case was just to show the problem. Real issue is that eclipse
> sends out path of the fil
zturner,
Command line case was just to show the problem. Real issue is that eclipse
sends out path of the file with 2 \\ in it which fails the breakpoint lookup.
So we have the following options.
1. Change the path in lldb-mi before it reaches lldb proper. This is what I
tried in initial patch.
Hi Greg,
Thanks for the review. I think I found the real problem now.
When FileSpec::Normalize is given this path with \\ in it, it ends up changing
it to //. But there are still 2 / in it.
Before: F:\\work\\demos\\main.c
After: F://work//demos//main.c
This then fails comparison in FileSpec::Equ
Are there other places that deal with file paths? If you use lldb::SBFileSpec
it will normalize the path for you. Do you really need to switch all of the \
chars with / chars? LLDB might now like a path like F:/a/b/main.c instead of
F:\a\b\main.c. Do we really want to be changing the path slashe
Hi ki.stfu, clayborg,
For some time, eclipse (CDT) uses full path of the file in break-insert command
when putting breakpoint on a source line. On windows, a typical command looks
like the following.
56-break-insert -f F:\\work\\ws\\test\\main.c:49
Current implementation in lldb-mi have problem
17 matches
Mail list logo
