Author: labath
Date: Fri Aug 21 05:38:31 2015
New Revision: 245687
URL: http://llvm.org/viewvc/llvm-project?rev=245687view=rev
Log:
Add repro test case for bug #24530
Modified:
lldb/trunk/test/functionalities/signal/raise/TestRaise.py
Modified:
Author: tberghammer
Date: Fri Aug 21 07:14:47 2015
New Revision: 245695
URL: http://llvm.org/viewvc/llvm-project?rev=245695view=rev
Log:
Fix type of dw_form_t in dwarf.h
Modified:
lldb/trunk/include/lldb/Core/dwarf.h
Modified: lldb/trunk/include/lldb/Core/dwarf.h
URL:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL245708: Implement handling of `library:` keys in thread stop
replies. (authored by sas).
Changed prior to commit:
http://reviews.llvm.org/D12218?vs=32766id=32835#toc
Repository:
rL LLVM
I agree that this change has caused many problems and is quite large to commit
to a release branch with little testing.
I do really want to get to a Scalar and RegisterValue that uses llvm::APInt and
llvm::APFloat as soon as possible, but seeing as this patch has continually
caused crashes it
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D12218
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D12233
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
Looks good (I assume when you dropped const from the argument it was
intentional)
http://reviews.llvm.org/D12237
___
lldb-commits
sas added a comment.
Thanks for the testing. I'll definitely setup a windows box.
http://reviews.llvm.org/D12245
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: sas
Date: Fri Aug 21 14:28:34 2015
New Revision: 245725
URL: http://llvm.org/viewvc/llvm-project?rev=245725view=rev
Log:
Implement basic DidAttach and DidLaunch for DynamicLoaderWindowsDYLD.
Summary:
This commit implements basic DidAttach and DidLaunch for the windows
DynamicLoader
zturner added a comment.
Can you verify that this does not break local debugging on Windows?
http://reviews.llvm.org/D12245
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
sas updated this revision to Diff 32842.
sas added a comment.
Style.
http://reviews.llvm.org/D12245
Files:
source/Plugins/DynamicLoader/Windows-DYLD/DynamicLoaderWindowsDYLD.cpp
Index: source/Plugins/DynamicLoader/Windows-DYLD/DynamicLoaderWindowsDYLD.cpp
sas added a comment.
@zturner, will do before submitting.
http://reviews.llvm.org/D12245
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
I'm not happy about this.
lldb builds fine on Linux for me. What's the build problem on mips? I
also don't see the relation between r245240 (which was also a large
patch) and this, but I haven't looked closely and am not familiar with
the code.
In general it would be nice if merge requests don't
Author: zturner
Date: Fri Aug 21 17:11:31 2015
New Revision: 245749
URL: http://llvm.org/viewvc/llvm-project?rev=245749view=rev
Log:
XFAIL the last Windows test that calls a function in the target.
Modified:
lldb/trunk/test/lang/cpp/static_methods/TestCPPStaticMethods.py
Modified:
Author: zturner
Date: Fri Aug 21 17:11:50 2015
New Revision: 245751
URL: http://llvm.org/viewvc/llvm-project?rev=245751view=rev
Log:
XFAIL pthreads test on Windows.
This test needs to be ported to c++ threads.
Modified:
zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.
Looks good. I'm guessing that at some point the RegisterContext and
ExceptionRecord stuff will be moved to Common?
http://reviews.llvm.org/D12252
Hello everyone,
LLVM buildmaster will be restarted after 6 PM Pacific time today.
Thanks
Galina
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: zturner
Date: Fri Aug 21 17:11:09 2015
New Revision: 245747
URL: http://llvm.org/viewvc/llvm-project?rev=245747view=rev
Log:
XFAIL Tests that require C++ exceptions on Windows.
clang-cl does not yet support C++ exceptions, so these tests will
not even compile.
Re-enabling these tests is
Author: zturner
Date: Fri Aug 21 17:11:40 2015
New Revision: 245750
URL: http://llvm.org/viewvc/llvm-project?rev=245750view=rev
Log:
Fix TestPaths on Windows.
Modified:
lldb/trunk/test/functionalities/paths/TestPaths.py
Modified: lldb/trunk/test/functionalities/paths/TestPaths.py
URL:
tberghammer created this revision.
tberghammer added reviewers: sas, clayborg.
tberghammer added a subscriber: lldb-commits.
Add absolute load address support for the DynamicLoader plugins
The POSIX linker generally reports the load bias for the loaded
libraries but in some case it is useful to
tberghammer added a comment.
Fixed by http://reviews.llvm.org/rL245546
Repository:
rL LLVM
http://reviews.llvm.org/D11947
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
By the way, I'm actively working on getting the test suite completely
running on a buildbot, but I need to get down to a green baseline first.
Still a few weeks out, but hopefully this type of thing will be caught
automatically in the future.
On Fri, Aug 21, 2015 at 5:00 PM Zachary Turner
Hi Stephane, I'm sorry but I had to revert this change. When I tested it
locally, I did it without running the full test suite, but when I did run
the full test suite it showed about 15-20 new test failures. I should have
caught this earlier by running the full test suite, so sorry about that.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL245681: [NativeProcessLinux] Reduce the number of casts
(authored by labath).
Changed prior to commit:
http://reviews.llvm.org/D12187?vs=32673id=32805#toc
Repository:
rL LLVM
labath marked an inline comment as done.
labath added a comment.
Passing around pointers (shared or otherwise) encourages people to litter the
code with null pointer checks. For the next cleanup, I would like to move these
checks to a single place and then convert more of these functions to
tberghammer resigned from this revision.
tberghammer removed a reviewer: tberghammer.
tberghammer added a comment.
I leave this review to the others as I have no idea about how library loading
works on Windows. (On Linux/Android we use a breakpoint on a special symbol
exposed by the linker)
26 matches
Mail list logo
