Any reason dotest / dosep cannot just print the stats?
On Thu, Aug 27, 2015 at 4:17 PM Todd Fiala via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> tfiala updated this revision to Diff 33375.
>
> http://reviews.llvm.org/D12416
>
> Files:
> test/reports/dotest_stats.py
>
> ___
I think it's still worth printing something, even if it's just "Testing
LLDB with N processes", where you fill in the value for N
On Thu, Aug 27, 2015 at 4:07 PM Stephane Sezer wrote:
> sas added a comment.
>
> I removed the "Testing..." messages because $ won't be
> expanded in the context of a
looks good
On Thu, Aug 27, 2015 at 4:43 PM Adrian McCarthy wrote:
> amccarth updated this revision to Diff 33379.
> amccarth added a comment.
>
> Now uses llvm/Support/ConvertUTF.h instead of WinAPI WideCharToMultiByte.
>
>
> http://reviews.llvm.org/D12363
>
> Files:
> source/Plugins/Process/W
chaoren created this revision.
chaoren added reviewers: clayborg, jaydeep.
chaoren added a subscriber: lldb-commits.
Update to http://reviews.llvm.org/rL243618.
http://reviews.llvm.org/D12420
Files:
source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
Index: source/Plugins/Process/gdb-remot
Try this out:
% svn commit
Sendinginclude/lldb/Symbol/ClangASTContext.h
Sendinginclude/lldb/Symbol/TypeSystem.h
Sendinglldb.xcodeproj/project.pbxproj
Sendingsource/Plugins/SymbolFile/DWARF/CMakeLists.txt
Adding source/Plugins/SymbolFile/DWARF/DWARFASTParser.
amccarth updated this revision to Diff 33379.
amccarth added a comment.
Now uses llvm/Support/ConvertUTF.h instead of WinAPI WideCharToMultiByte.
http://reviews.llvm.org/D12363
Files:
source/Plugins/Process/Windows/MiniDump/ProcessWinMiniDump.cpp
source/Plugins/Process/Windows/MiniDump/Proc
amccarth marked an inline comment as done.
amccarth added a comment.
New patch coming up.
http://reviews.llvm.org/D12363
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
spyffe added a comment.
I looked at this with Jim, and once his suggestions are applied this patch is
fine. Thanks for working with us on it.
I want to follow up and make non-Apple platforms not force ObjC (it doesn't
matter for making the expression parser work).
http://reviews.llvm.org/D111
jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.
This seems fine. The only things you should fix (see inline comments) are the
name of GetDefaultExpressionLanguage and the comment on why the upgrading is
necessary. If you do th
tfiala updated this revision to Diff 33375.
http://reviews.llvm.org/D12416
Files:
test/reports/dotest_stats.py
Index: test/reports/dotest_stats.py
===
--- test/reports/dotest_stats.py
+++ test/reports/dotest_stats.py
@@ -0,0 +1,14
tfiala added a comment.
And, the file is actually in test/reports/, not reports/...
http://reviews.llvm.org/D12416
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala added a comment.
Note the output is formatted for whitespace and left justified, with the
numeric columns all lined up. My verbatim mode above doesn't look like it did
what I expected...
http://reviews.llvm.org/D12416
___
lldb-commits mail
tfiala created this revision.
tfiala added a reviewer: clayborg.
tfiala added a subscriber: lldb-commits.
The new script can be run against output of dotest.py/dosep.py, with the
primary benefit of providing a detailed breakdown of the number of test methods
that skip for a given reason.
Output
sas added a comment.
I removed the "Testing..." messages because $ won't be
expanded in the context of a log message. Basically, you'll end up with
ninja/msvc/make printing "Testing LLDB with args:
--arch=x86_64;--executable;$;-s;/..." (even though it will be
running the right command with the
On Thu, Aug 27, 2015 at 03:57:30PM -0700, Greg Clayton wrote:
>
> I can probably clean this up by making a DWARFASTParser a plug-in type and
> move all DWARF parsing code over into it and place that inside the DWARF
> plug-in folder. I see if I can do that quick to get the code organization
> b
I'm not familiar with that $ expression, but if you're certain
that it's equivalent to what was there previously, this looks fine.
But why were the two "Testing LLDB..." messages removed?
On Thu, Aug 27, 2015 at 3:55 PM Stephane Sezer wrote:
> sas created this revision.
> sas added reviewers: z
> On Aug 27, 2015, at 2:12 PM, Zachary Turner wrote:
>
> If I'm following this discussion correctly, Greg are you saying that
> ClangASTContext could be renamed to DwarfASTContext? And that for other
> types of Debug info we could have PascalASTContext and PdbASTContext?
No. ClangASTContext
sas created this revision.
sas added reviewers: zturner, clayborg.
sas added a subscriber: lldb-commits.
Instead of hardcoding the path, we should use $ which
works better when the output path differs, e.g. when building with MSVC.
$ is expanded during the generation of the final build
files, so
dawn added a comment.
In http://reviews.llvm.org/D11102#234450, @clayborg wrote:
> Please wait for the OK from Jim and Sean.
Jim/Sean, you guys OK with this? All tests pass - we've been running with this
patch locally since it was proposed and have had no issues with it.
http://reviews.llvm
Author: enrico
Date: Thu Aug 27 17:14:06 2015
New Revision: 246222
URL: http://llvm.org/viewvc/llvm-project?rev=246222&view=rev
Log:
Include
Modified:
lldb/trunk/source/Target/Language.cpp
Modified: lldb/trunk/source/Target/Language.cpp
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/s
Author: enrico
Date: Thu Aug 27 16:55:55 2015
New Revision: 246220
URL: http://llvm.org/viewvc/llvm-project?rev=246220&view=rev
Log:
Fixup one of the CMakeLists
Modified:
lldb/trunk/source/Plugins/Language/ObjC/CMakeLists.txt
Modified: lldb/trunk/source/Plugins/Language/ObjC/CMakeLists.txt
U
zturner added inline comments.
Comment at: source/Plugins/Process/Windows/MiniDump/ProcessWinMiniDump.cpp:57-63
@@ +56,9 @@
+const auto length_required =
+::WideCharToMultiByte(CP_UTF8, 0, md_string->Buffer, md_string->Length,
+ nullptr, 0,
Author: enrico
Date: Thu Aug 27 16:45:59 2015
New Revision: 246216
URL: http://llvm.org/viewvc/llvm-project?rev=246216&view=rev
Log:
Added a missing file to the CMakeLists
Modified:
lldb/trunk/source/Target/CMakeLists.txt
Modified: lldb/trunk/source/Target/CMakeLists.txt
URL:
http://llvm.or
Author: enrico
Date: Thu Aug 27 16:33:50 2015
New Revision: 246212
URL: http://llvm.org/viewvc/llvm-project?rev=246212&view=rev
Log:
Add a new type of plugin: Language plugin
The Language plugin is menat to answer language-specific questions that are not
bound to the existence of a process. Thos
What I'm getting at is that, assuming my understanding is correct,
something like an adapter could be created that each plugin could
implement. Say you've got a DebugInfoAdapter interface with
DebugInfoDwarf, etc implementations. Then ClangASTContext could just use
this.
On Thu, Aug 27, 2015 at
On Thu, Aug 27, 2015 at 09:12:06PM +, Zachary Turner wrote:
> If I'm following this discussion correctly, Greg are you saying that
> ClangASTContext could be renamed to DwarfASTContext? And that for other
> types of Debug info we could have PascalASTContext and PdbASTContext?
>
> If that's th
If I'm following this discussion correctly, Greg are you saying that
ClangASTContext could be renamed to DwarfASTContext? And that for other
types of Debug info we could have PascalASTContext and PdbASTContext?
If that's the case, then it seems there is a lot of code inside of
ClangASTContext (ak
On Thu, Aug 27, 2015 at 07:58:50PM +, Greg Clayton wrote:
> clayborg added a comment.
>
> Please wait for the OK from Jim and Sean.
I've been waiting for 1.5 months already.
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm
On Thu, Aug 27, 2015 at 12:56:57PM -0700, Greg Clayton via lldb-commits wrote:
> >
> > Our Delphi compiler generates an alternate debug format as well - it took
> > me all of yesterday to fix merge conflicts and I've still not got things
> > working properly. Greg, can you please move the DWARF
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
This seems to be very variable specific.
I would like to see if be able to ask a lldb_private::Block or a
lldb_private::Compile and to provide a list of CompilerDeclContext objec
clayborg added a subscriber: clayborg.
clayborg accepted this revision.
clayborg added a reviewer: clayborg.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks fine as long as the test suite tests are passing.
http://reviews.llvm.org/D11102
__
clayborg added a comment.
Please wait for the OK from Jim and Sean.
http://reviews.llvm.org/D11102
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
>
> Our Delphi compiler generates an alternate debug format as well - it took me
> all of yesterday to fix merge conflicts and I've still not got things working
> properly. Greg, can you please move the DWARF dependencies back into the
> SymbolFileDWARF plugin? Thanks!
Sorry to not be clear
dawn added a comment.
Hi guys, I'd still really like to get this into tot. May I commit it please?
http://reviews.llvm.org/D11102
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
dawn raised a concern with this commit.
dawn added a comment.
Our Delphi compiler generates an alternate debug format as well - it took me
all of yesterday to fix merge conflicts and I've still not got things working
properly. Greg, can you please move the DWARF dependencies back into the
Symb
paulherman updated this revision to Diff 33345.
paulherman added a comment.
Add scope tree for variable searching
http://reviews.llvm.org/D12304
Files:
include/lldb/Symbol/Block.h
include/lldb/Symbol/CompileUnit.h
include/lldb/Symbol/Function.h
include/lldb/Symbol/Symbol.h
include/lld
> On Aug 26, 2015, at 9:08 PM, Dawn Perchik via lldb-commits
> wrote:
>
> dawn added a subscriber: dawn.
> dawn added a comment.
>
> Hi Greg,
>
> While I really appreciate that you're making lldb less Clang specific (e.g.
> renaming ClangASTType to CompilerType), I'm concerned about this com
Author: enrico
Date: Thu Aug 27 13:18:49 2015
New Revision: 246177
URL: http://llvm.org/viewvc/llvm-project?rev=246177&view=rev
Log:
Remove class Language - the only thing it was actually being used for is
provided by LanguageRuntime already
Removed:
lldb/trunk/include/lldb/Core/Language.h
Author: gclayton
Date: Thu Aug 27 13:09:44 2015
New Revision: 246172
URL: http://llvm.org/viewvc/llvm-project?rev=246172&view=rev
Log:
More cleanup to make sure no one plays with DWARFDebugInfoEntry. Clients
outside of DWARFDebugInfoEntry of DWARFCompileUnit should use DWARFDIE only.
Modified:
zturner added a subscriber: zturner.
zturner added a comment.
This is definitely going to be a serious problem once I integrate our PDB
support for Windows
http://reviews.llvm.org/rL245090
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
ht
This is definitely going to be a serious problem once I integrate our PDB
support for Windows
On Wed, Aug 26, 2015 at 9:09 PM Dawn Perchik via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> dawn added a subscriber: dawn.
> dawn added a comment.
>
> Hi Greg,
>
> While I really appreciate tha
tberghammer added a comment.
I don't know too much about mips so I haven't checked if the emulation is
actually correct but the general concept looks good to me. I added a few
comments inline but they are mostly suggestions what you might want to consider.
Comment at:
source/
sagar updated this revision to Diff 33323.
sagar added a comment.
Addressed review comments
Repository:
rL LLVM
http://reviews.llvm.org/D12356
Files:
source/Plugins/Instruction/MIPS64/EmulateInstructionMIPS64.cpp
source/Plugins/Instruction/MIPS64/EmulateInstructionMIPS64.h
Index: source
43 matches
Mail list logo
