sagar updated this revision to Diff 33567.
sagar added a comment.
Addressed review commenst
Repository:
rL LLVM
http://reviews.llvm.org/D12356
Files:
source/Plugins/Instruction/MIPS64/EmulateInstructionMIPS64.cpp
source/Plugins/Instruction/MIPS64/EmulateInstructionMIPS64.h
Index: source
sagar marked 7 inline comments as done.
Comment at: source/Plugins/Instruction/MIPS64/EmulateInstructionMIPS64.cpp:3160
@@ +3159,3 @@
+if((*ptr == 0 && bnz) || (*ptr != 0 && !bnz) )
+branch_hit = false;
+break;
T
krytarowski created this revision.
krytarowski added a reviewer: joerg.
krytarowski added a subscriber: lldb-commits.
krytarowski set the repository for this revision to rL LLVM.
accept4(2) and paccept(2) are nonstandard extensions.
Repository:
rL LLVM
http://reviews.llvm.org/D12485
Files:
> On Aug 28, 2015, at 9:36 AM, Zachary Turner wrote:
>
>
>
> On Fri, Aug 28, 2015 at 8:41 AM Todd Fiala wrote:
> tfiala added a comment.
>
> In http://reviews.llvm.org/D12416#235112, @labath wrote:
>
> > Same question as Zachary. This sounds like a very useful feature and it
> > would be n
It doesn't necessarily have to be through fancy pipes, I guess the point is
just that right now we use stdio as a way to print stuff that a person will
read, so naturally it's formatted differently than if we were trying to
produce something that would be consumed by a machine.
But you're probably
clayborg added a comment.
We do want processes to have individual copies that are copied from the
platform. Does this actually make a copy? I don't see the copy.
http://reviews.llvm.org/D12420
___
lldb-commits mailing list
lldb-commits@lists.llvm.o
sas added a subscriber: sas.
sas accepted this revision.
sas added a reviewer: sas.
sas added a comment.
This revision is now accepted and ready to land.
Looks like accept4(2) is linux-only.
Repository:
rL LLVM
http://reviews.llvm.org/D12485
___
emaste added a subscriber: emaste.
emaste added a comment.
In http://reviews.llvm.org/D12485#236538, @sas wrote:
> Looks like accept4(2) is linux-only.
And FreeBSD -- from the man page `The accept4() system call appeared in FreeBSD
10.0.`
Repository:
rL LLVM
http://reviews.llvm.org/D12485
chaoren added inline comments.
Comment at: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:2910
@@ +2909,3 @@
+{
+Process::SetUnixSignals(std::make_shared(signals_sp));
+}
Here's the copy.
http://reviews.llvm.org/D12420
Author: gclayton
Date: Mon Aug 31 16:25:45 2015
New Revision: 246488
URL: http://llvm.org/viewvc/llvm-project?rev=246488&view=rev
Log:
Stop objects from keeping a strong reference to the process when they should
have a weak reference.
Modified:
lldb/trunk/source/Plugins/InstrumentationRunt
Author: emaste
Date: Mon Aug 31 16:37:15 2015
New Revision: 246490
URL: http://llvm.org/viewvc/llvm-project?rev=246490&view=rev
Log:
Remove expectedFailureFreeBSD for passing pexpect tests
These tests work when run locally. They had been occasionally failing
on the FreeBSD buildbot due to pexpect
amccarth created this revision.
amccarth added a reviewer: zturner.
amccarth added a subscriber: lldb-commits.
Implements DoReadMemory for Windows mini dumps. The dumps can use two slightly
different methods for capturing ranges of memory, so I abstracted away the
search for a range from the ac
Author: enrico
Date: Mon Aug 31 19:19:35 2015
New Revision: 246512
URL: http://llvm.org/viewvc/llvm-project?rev=246512&view=rev
Log:
Make FormatEntity be a little bit smarter when printing function arguments
Modified:
lldb/trunk/source/Core/FormatEntity.cpp
Modified: lldb/trunk/source/Core/
Author: enrico
Date: Mon Aug 31 20:01:48 2015
New Revision: 246515
URL: http://llvm.org/viewvc/llvm-project?rev=246515&view=rev
Log:
Add support for language plugins to provide data formatters
Historically, data formatters all exist in a global repository (the category
map)
On top of that, some
Author: enrico
Date: Mon Aug 31 20:23:22 2015
New Revision: 246519
URL: http://llvm.org/viewvc/llvm-project?rev=246519&view=rev
Log:
And of course, typos
Modified:
lldb/trunk/source/Plugins/Language/CMakeLists.txt
Modified: lldb/trunk/source/Plugins/Language/CMakeLists.txt
URL:
http://llvm.
Author: enrico
Date: Mon Aug 31 20:23:02 2015
New Revision: 246518
URL: http://llvm.org/viewvc/llvm-project?rev=246518&view=rev
Log:
Attempt at fixing the CMake build
Modified:
lldb/trunk/cmake/LLDBDependencies.cmake
lldb/trunk/source/Plugins/Language/CMakeLists.txt
Modified: lldb/trunk/
> On Aug 31, 2015, at 6:23 PM, Enrico Granata via lldb-commits
> wrote:
>
> Author: enrico
> Date: Mon Aug 31 20:23:02 2015
> New Revision: 246518
>
> URL: http://llvm.org/viewvc/llvm-project?rev=246518&view=rev
> Log:
> Attempt at fixing the CMake build
>
> Modified:
>lldb/trunk/cmake/LL
brucem created this revision.
brucem added a reviewer: clayborg.
brucem added a subscriber: lldb-commits.
This was previously only established within debugserver, but
there is a use of the VLA extension in source/Host/macosx/Symbols.cpp,
so ignore this warning globally.
http://reviews.llvm.org/D1
brucem created this revision.
brucem added reviewers: ki.stfu, abidh.
brucem added a subscriber: lldb-commits.
find_first_of will look for any of the characters, not the full
string passed in. When looking for "--" then, we must use find
and not find_first_of.
http://reviews.llvm.org/D12517
File
Author: brucem
Date: Mon Aug 31 23:36:54 2015
New Revision: 246529
URL: http://llvm.org/viewvc/llvm-project?rev=246529&view=rev
Log:
[lldb-mi] Use find, not find_first_of, for "--".
Summary:
find_first_of will look for any of the characters, not the full
string passed in. When looking for "--" th
This revision was automatically updated to reflect the committed changes.
Closed by commit rL246529: [lldb-mi] Use find, not find_first_of, for "--".
(authored by brucem).
Changed prior to commit:
http://reviews.llvm.org/D12517?vs=33662&id=33663#toc
Repository:
rL LLVM
http://reviews.llvm.o
brucem created this revision.
brucem added a reviewer: clayborg.
brucem added a subscriber: lldb-commits.
When calling find_first_of and find_last_of on a single character,
we can instead just call find / rfind and make our intent more
clear.
http://reviews.llvm.org/D12518
Files:
source/Core/F
brucem added a comment.
This touches random files across the tree, including lldb-mi. I wasn't sure how
best this should be reviewed or by who (despite it being pretty mechanical).
http://reviews.llvm.org/D12518
___
lldb-commits mailing list
lldb-c
Author: jmolenda
Date: Tue Sep 1 00:17:01 2015
New Revision: 246530
URL: http://llvm.org/viewvc/llvm-project?rev=246530&view=rev
Log:
A few small comment fixups with terminology "gcc" -> "eh_frame", "gdb" ->
"stabs".
Just noticed these while reading through some code.
Modified:
lldb/trunk/s
brucem created this revision.
brucem added a reviewer: clayborg.
brucem added a subscriber: lldb-commits.
Comparing m_page_size against kInvalidPageSize was resulting in
a warning about comparing integers with different signs. Since
kInvalidPageSize isn't used anywhere outside of MachVMMemory.cpp,
sagar updated this revision to Diff 33668.
sagar marked 4 inline comments as done.
sagar added a comment.
Corrected code indent and initialized wr_val correctly.
Repository:
rL LLVM
http://reviews.llvm.org/D12356
Files:
source/Plugins/Instruction/MIPS64/EmulateInstructionMIPS64.cpp
sourc
26 matches
Mail list logo