ki.stfu requested changes to this revision.
This revision now requires changes to proceed.
Comment at: test/tools/lldb-mi/symbol/main.cpp:12
@@ +11,3 @@
+// included in -symbol-list-lines main.cpp, by checking that all the lines
+// are between 20 and 29.
+// line 13
-
tfiala added a comment.
@emaste, I'm adding you because I have no idea what the state of the *BSD world
is with regards to lldb-server. It looks like you might still use the native
process bits so lldb-server might not be interesting over there. If it is, we
can extend the "always add the lld
tfiala created this revision.
tfiala added reviewers: labath, clayborg, emaste.
tfiala added a subscriber: lldb-commits.
Addresses:
* https://llvm.org/bugs/show_bug.cgi?id=24831: cmake + ninja: 'ninja lldb'
misses lib/python2.7 build dependency on Linux
* https://llvm.org/bugs/show_bug.cgi?id=248
paulherman added a comment.
Please also look at http://reviews.llvm.org/D12897
It fixes the imported decls and some bugs that I have missed (evaluating
Fun::fun_var reports an error in TestCppNsImport). Unfortunately I don't think
there is a way to report ambiguity without for "imported" withou
jaydeep updated this revision to Diff 34873.
jaydeep added a comment.
Addressed review comments
Repository:
rL LLVM
http://reviews.llvm.org/D12079
Files:
source/Core/Address.cpp
source/Plugins/Disassembler/llvm/DisassemblerLLVMC.cpp
source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
sou
jaydeep closed this revision.
jaydeep added a comment.
Closed by commit http://reviews.llvm.org/rL247773
Repository:
rL LLVM
http://reviews.llvm.org/D12876
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
Author: jaydeep
Date: Tue Sep 15 23:04:01 2015
New Revision: 247773
URL: http://llvm.org/viewvc/llvm-project?rev=247773&view=rev
Log:
[LLDB][MIPS] Debug bare-iron targets lacking support for qC /qfThreadInfo
SUMMARY:
Refer to http://lists.llvm.org/pipermail/lldb-dev/2015-August/008024.html
paulherman created this revision.
paulherman added reviewers: sivachandra, chaoren, clayborg.
paulherman added a subscriber: lldb-commits.
Supports the parsing of the "using namespace XXX" and "using XXX::XXX"
directives. Added ambiguity errors when it two decls with the same name are
encountere
jasonmolenda added a subscriber: jasonmolenda.
jasonmolenda added a comment.
Maybe I'm an outlier here -- but I don't think we should show assembly code,
unless specifically requested by the user, when we can't find a source file
(but we have source-level debug information).
lldb used to behave
Author: chaoren
Date: Tue Sep 15 20:20:34 2015
New Revision: 247766
URL: http://llvm.org/viewvc/llvm-project?rev=247766&view=rev
Log:
Fix off-by-one size check.
Modified:
lldb/trunk/source/Expression/IRInterpreter.cpp
Modified: lldb/trunk/source/Expression/IRInterpreter.cpp
URL:
http://llvm
clayborg added a comment.
Ah, the test_with_dsym_and_run_command() wasn't marked as fail...
I fixed the test with:
% svn commit
Sendingtest/lang/cpp/nsimport/TestCppNsImport.py
Transmitting file data .
Committed revision 247764.
Feel free to correct it. I would also say that we might wa
Author: gclayton
Date: Tue Sep 15 19:42:50 2015
New Revision: 247764
URL: http://llvm.org/viewvc/llvm-project?rev=247764&view=rev
Log:
Fix MacOSX since "imported" and "Imported::imported" are ambiguous. Test that
we can read the global when specified with the global namespace and test that
we ca
paulherman added a comment.
The test was supposed to be marked as an XFAIL. I'm currently writing a fix for
this that reports ambiguity in a context and deals with imported decls.
http://reviews.llvm.org/D12658
___
lldb-commits mailing list
lldb-co
clayborg added a subscriber: clayborg.
clayborg added a comment.
I am seeing line 89 fail on MacOSX from your new TestCppNsImport.py:
test_result = frame.EvaluateExpression("imported")
self.assertTrue(test_result.IsValid() and test_result.GetValueAsSigned() ==
99, "imported = 99")
Ours is p
Author: paulherman
Date: Tue Sep 15 19:29:10 2015
New Revision: 247760
URL: http://llvm.org/viewvc/llvm-project?rev=247760&view=rev
Log:
Fix double include in CompilerDeclContext.h
Modified:
lldb/trunk/include/lldb/Symbol/CompilerDeclContext.h
Modified: lldb/trunk/include/lldb/Symbol/Compile
Author: paulherman
Date: Tue Sep 15 19:26:12 2015
New Revision: 247759
URL: http://llvm.org/viewvc/llvm-project?rev=247759&view=rev
Log:
Fix missing include in CompilerDeclContext.h
Modified:
lldb/trunk/include/lldb/Symbol/CompilerDeclContext.h
Modified: lldb/trunk/include/lldb/Symbol/Compil
Author: gclayton
Date: Tue Sep 15 19:03:14 2015
New Revision: 247756
URL: http://llvm.org/viewvc/llvm-project?rev=247756&view=rev
Log:
Fix Xcode project by adding CompilerDecl.cpp and .h.
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
This revision was automatically updated to reflect the committed changes.
Closed by commit rL247755: Return false, not 0, for bools. (authored by brucem).
Changed prior to commit:
http://reviews.llvm.org/D12873?vs=34777&id=34856#toc
Repository:
rL LLVM
http://reviews.llvm.org/D12873
Files:
Author: brucem
Date: Tue Sep 15 19:00:16 2015
New Revision: 247755
URL: http://llvm.org/viewvc/llvm-project?rev=247755&view=rev
Log:
Return false, not 0, for bools.
Reviewers: clayborg
Subscribers: lldb-commits
Differential Revision: http://reviews.llvm.org/D12873
Modified:
lldb/trunk/sour
Author: gclayton
Date: Tue Sep 15 18:59:25 2015
New Revision: 247753
URL: http://llvm.org/viewvc/llvm-project?rev=247753&view=rev
Log:
Avoid a missing override warning.
Modified:
lldb/trunk/include/lldb/Symbol/ClangASTContext.h
Modified: lldb/trunk/include/lldb/Symbol/ClangASTContext.h
URL:
Author: gclayton
Date: Tue Sep 15 18:59:41 2015
New Revision: 247754
URL: http://llvm.org/viewvc/llvm-project?rev=247754&view=rev
Log:
Fix the MacOSX build.
Modified:
lldb/trunk/include/lldb/Symbol/CompilerDeclContext.h
Modified: lldb/trunk/include/lldb/Symbol/CompilerDeclContext.h
URL:
ht
Author: jmolenda
Date: Tue Sep 15 18:49:57 2015
New Revision: 247751
URL: http://llvm.org/viewvc/llvm-project?rev=247751&view=rev
Log:
A partner to the cleanup in r247741, change the variables names in
debugserver to match. "gcc" is now "ehframe" and "gdb" is now
"debugserver". Because this is d
Author: paulherman
Date: Tue Sep 15 18:44:17 2015
New Revision: 247746
URL: http://llvm.org/viewvc/llvm-project?rev=247746&view=rev
Log:
Search variables based on clang::DeclContext and clang::Decl tree
Summary: SymbolFileDWARF now creates VarDecl and BlockDecl and adds them to the
Decl tree. Th
paulherman updated this revision to Diff 34850.
paulherman added a comment.
Search variables based on clang::DeclContext and clang::Decl tree
Rebased the patch.
http://reviews.llvm.org/D12658
Files:
include/lldb/Symbol/ClangASTContext.h
include/lldb/Symbol/CompilerDecl.h
include/lldb/Sym
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
Comment at: source/Core/PluginManager.cpp:2628
@@ -2627,3 +2627,3 @@
static lldb::OptionValuePropertiesSP
GetDebuggerPropertyForPluginsOldStyle (Debugger &de
jasonmolenda closed this revision.
jasonmolenda added a comment.
Landed in r247741.
http://reviews.llvm.org/D12791
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ovyalov added inline comments.
Comment at: source/Core/PluginManager.cpp:2628
@@ -2627,3 +2627,3 @@
static lldb::OptionValuePropertiesSP
GetDebuggerPropertyForPluginsOldStyle (Debugger &debugger,
const ConstString &plugin_type_name,
--
ovyalov created this revision.
ovyalov added reviewers: clayborg, tberghammer.
ovyalov added a subscriber: lldb-commits.
Add plugin.jit-loader.gdb.enable-jit-breakpoint property to make JIT loader
breakpoint optional with default value set true.
If we're not interested in debugging JIT code there
jasonmolenda added a comment.
Ah, those failures were due to
Index: gdbremote_testcase.py
- gdbremote_testcase.py (revision 247726)
+++ gdbremote_testcase.py (working copy)
@@ -548,7 +548,7 @@
"encoding",
"format",
"set",
- "gcc",
+"ehframe",
clayborg added a comment.
Blech... Ok, one more try: does GCC always emit the same line and file with the
same address? If so we could do:
{
// GCC don't use the is_prologue_end flag to mark the first instruction
after the prologue.
// Instead of it it is issueing a line table ent
clayborg requested changes to this revision.
clayborg added a comment.
Ok, so Jim and I agreed verbally on the solution. If we have source, but we
don't have the source file itself, then we should print the line table entry
out. This can be done with:
if (num_lines == 0)
{
const bool
clayborg added a comment.
Maybe we can enable mixed mode display where it intersperses the source file
and line in the disassembly when/if there is source info, but no source file?
Repository:
rL LLVM
http://reviews.llvm.org/D12877
___
lldb-comm
Author: enrico
Date: Tue Sep 15 17:11:20 2015
New Revision: 247727
URL: http://llvm.org/viewvc/llvm-project?rev=247727&view=rev
Log:
Teach the ObjC data formatters to use the correct language when printing strings
Modified:
lldb/trunk/source/Plugins/Language/ObjC/Cocoa.cpp
Modified: lldb/tr
tberghammer added a comment.
In http://reviews.llvm.org/D12757#246497, @clayborg wrote:
> Maybe we can try still removing duplicates, but remembering the first index
> where we had a duplicate line entry. If we don't get a prologue end, then we
> got back to the index we remembered for the firs
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good as long as my inlined comment doesn't point out an error, then this
is good to go! Good stuff.
Comment at: source/Symbol/Variable.cpp:250-258
@@ -233,1 +249,11
clayborg added a comment.
Moving to SectionType is even more efficient than searching for symbols by
name, so please switch to that.
Repository:
rL LLVM
http://reviews.llvm.org/D5871
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
We have the notion of hard coded section types. See lldb::SectionType in
lldb-enumerations.h. You could always add your Go section to this section list
and then find the section
ribrdb updated this revision to Diff 34839.
ribrdb added a comment.
Fix cmake build.
Repository:
rL LLVM
http://reviews.llvm.org/D5871
Files:
cmake/LLDBDependencies.cmake
include/lldb/Core/PluginManager.h
lib/Makefile
lldb.xcodeproj/project.pbxproj
source/Core/PluginManager.cpp
s
amccarth created this revision.
amccarth added a reviewer: zturner.
amccarth added a subscriber: lldb-commits.
This includes a dump file captured using Visual Studio, of the enclosed sample
program, which was also build with Visual Studio.
The tests just verify that LLDB can access some very bas
tfiala added a comment.
> I'm glad to see the test suite finally get some love.
Me too! It's about time :-)
http://reviews.llvm.org/D12831
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/ll
tfiala closed this revision.
tfiala added a comment.
Sendingtest/dosep.py
Sendingtest/dotest.py
Sendingtest/dotest_args.py
Adding test/dotest_channels.py
Sendingtest/settings/TestSettings.py
Adding test/test_results.py
Transmitting file data ..
C
Author: tfiala
Date: Tue Sep 15 16:38:04 2015
New Revision: 247722
URL: http://llvm.org/viewvc/llvm-project?rev=247722&view=rev
Log:
Add JUnit/XUnit-formatted output to the lldb test run system
Also introduces the test event system into our test runner framework.
See the following for details:
ht
tfiala added a comment.
Thanks, Zachary!
I'll get this in now.
http://reviews.llvm.org/D12831
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jasonmolenda added a comment.
Thanks Tamas. I have access to a linux machine, I had a little trouble getting
TOT set up correctly yesterday but I'll get that figured out today and fix
whatever the issue is.
http://reviews.llvm.org/D12791
___
lldb
> On Sep 15, 2015, at 2:27 PM, Greg Clayton wrote:
>
> clayborg accepted this revision.
> clayborg added a comment.
>
> I would rather not see a warning. If you don't have sources I don't really
> want to see:
>
> warning: couldn't find foo.c
> 0x1000: add r1, r2, r3
>
>
>
Why not? T
This appears to work now. Thansk for working on this, I'm glad to see the
test suite finally get some love.
On Tue, Sep 15, 2015 at 2:08 PM Todd Fiala wrote:
> tfiala added a comment.
>
> @zturner, can you give this a shot? Thanks!
>
>
> http://reviews.llvm.org/D12831
>
>
>
>
_
clayborg accepted this revision.
clayborg added a comment.
I would rather not see a warning. If you don't have sources I don't really want
to see:
warning: couldn't find foo.c
0x1000: add r1, r2, r3
Repository:
rL LLVM
http://reviews.llvm.org/D12877
_
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Looks good, we just need to relocate the DWARF expression printing stuff over
into DWARFExpression as static functions.
Comment at: source/Plugins/SymbolFile/DW
clayborg added a comment.
Maybe we can try still removing duplicates, but remembering the first index
where we had a duplicate line entry. If we don't get a prologue end, then we
got back to the index we remembered for the first duplicate and if it is valid,
modify that entry to say "prologue_e
tfiala added a comment.
@zturner, can you give this a shot? Thanks!
http://reviews.llvm.org/D12831
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala updated this revision to Diff 34834.
tfiala added a comment.
Strips out asyncore-based stdout/stderr dotest inferior handling. Unnecessary
for the final implementation that moved the socket handling into the main
thread/main process of the parallel test runner.
http://reviews.llvm.org/
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
Repository:
rL LLVM
http://reviews.llvm.org/D12876
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
One last change to make line table parsing more efficient by not having to
check the arch for every line table entry.
Comment at: source/Plugins/SymbolFile/DWAR
If you check the python docs, it looks like you just can't use
asyncore.file_dispatcher and asyncore.file_wrapper. Everything else seems
ok. Just search the page for "Availability" and the only hits you get are
on those 2 fields, which says they are UNIX specific.
On Tue, Sep 15, 2015 at 12:44 P
tfiala added a comment.
In http://reviews.llvm.org/D12831#246394, @zturner wrote:
> Sorry this took so long. Here's my first run:
No worries.
> Traceback (most recent call last):
>
> File "D:/src/llvm/tools/lldb/test/dotest.py", line 1416, in
> import dosep
> File "D:\src\llvm\t
sivachandra added inline comments.
Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.h:200
@@ -198,1 +199,3 @@
+void
+GetMangledNamesForFunction (const std::string &scope_qualified_name,
sivachandra wrote:
> spyffe wrote:
> > Why is this attach
Sorry this took so long. Here's my first run:
Traceback (most recent call last):
File "D:/src/llvm/tools/lldb/test/dotest.py", line 1416, in
import dosep
File "D:\src\llvm\tools\lldb\test\dosep.py", line 48, in
import dotest_channels
File "D:\src\llvm\tools\lldb\test\dotest_channe
paulherman updated this revision to Diff 34823.
paulherman added a comment.
Search variables based on clang::DeclContext and clang::Decl tree
This adds handling of imported declarations, but there is no call to actually
process them as I am not sure where to do this. I believe that the right pla
ribrdb updated this revision to Diff 34813.
ribrdb added a comment.
Ok, I've changed it to use the symbol table like the ASAN runtime does.
I'm not seeing any language info in the elf or macho file headers.
It looks like there's also a gosymtab section I could look for, but the name is
different
Author: jingham
Date: Tue Sep 15 13:03:00 2015
New Revision: 247709
URL: http://llvm.org/viewvc/llvm-project?rev=247709&view=rev
Log:
Make the source-map help grammatical.
Modified:
lldb/trunk/source/Target/Target.cpp
Modified: lldb/trunk/source/Target/Target.cpp
URL:
http://llvm.org/viewvc
dawn updated this revision to Diff 34812.
dawn added a comment.
Oops - forgot patch to CMakeLists.txt.
Repository:
rL LLVM
http://reviews.llvm.org/D12115
Files:
test/tools/lldb-mi/symbol/Makefile
test/tools/lldb-mi/symbol/TestMiSymbol.py
test/tools/lldb-mi/symbol/main.cpp
test/tools/
paulherman updated this revision to Diff 34808.
paulherman added a comment.
Search variables based on clang::DeclContext and clang::Decl tree
http://reviews.llvm.org/D12658
Files:
include/lldb/Symbol/ClangASTContext.h
include/lldb/Symbol/CompilerDecl.h
include/lldb/Symbol/CompilerDeclCont
jingham added a subscriber: jingham.
jingham requested changes to this revision.
jingham added a reviewer: jingham.
jingham added a comment.
This revision now requires changes to proceed.
This change means that the two cases "no debug info" and "couldn't find your
sources" end up looking very sim
tberghammer added a subscriber: tberghammer.
tberghammer requested changes to this revision.
tberghammer added a reviewer: tberghammer.
tberghammer added a comment.
This revision now requires changes to proceed.
If I understand this change correctly then OperatingSystemGo::CreateInstance
will be
Author: dsanders
Date: Tue Sep 15 11:33:17 2015
New Revision: 247703
URL: http://llvm.org/viewvc/llvm-project?rev=247703&view=rev
Log:
Fix build after llvm r247683 was reverted.
Modified:
lldb/trunk/source/Plugins/Disassembler/llvm/DisassemblerLLVMC.cpp
Modified: lldb/trunk/source/Plugins/D
ribrdb updated the summary for this revision.
ribrdb set the repository for this revision to rL LLVM.
ribrdb updated this revision to Diff 34806.
ribrdb added a comment.
I've updated this to load the plugin when modules are loaded, added a setting
to enable/disable the goroutine plugin, and added
tberghammer created this revision.
tberghammer added a reviewer: clayborg.
tberghammer added a subscriber: lldb-commits.
Add support for the DWARFLocationList used by split-dwarf
Split-dwarf uses a different header format to specify the address range for the
elements of the location lists.
http
tberghammer added a comment.
Hi Greg, what do you think about my inline suggestion? Are you fine with
removing the original hack about removing duplicate entries from the line table
end then solve the problem around duplicate line entries with always returning
the last entry if we have multiple
Author: tberghammer
Date: Tue Sep 15 09:04:52 2015
New Revision: 247690
URL: http://llvm.org/viewvc/llvm-project?rev=247690&view=rev
Log:
Skip TestGoASTContext on remote targets as it it not remote compatible
Modified:
lldb/trunk/test/lang/go/types/TestGoASTContext.py
Modified: lldb/trunk/te
Author: labath
Date: Tue Sep 15 08:49:10 2015
New Revision: 247687
URL: http://llvm.org/viewvc/llvm-project?rev=247687&view=rev
Log:
Fix build after llvm r247683
Modified:
lldb/trunk/source/Plugins/Disassembler/llvm/DisassemblerLLVMC.cpp
Modified: lldb/trunk/source/Plugins/Disassembler/llvm/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL247677: [lldb-mi] Clean up CMICmdArgSet usage. (authored by
brucem).
Changed prior to commit:
http://reviews.llvm.org/D12878?vs=34790&id=34797#toc
Repository:
rL LLVM
http://reviews.llvm.org/D12878
Author: brucem
Date: Tue Sep 15 07:00:08 2015
New Revision: 247677
URL: http://llvm.org/viewvc/llvm-project?rev=247677&view=rev
Log:
[lldb-mi] Clean up CMICmdArgSet usage.
Summary:
CMICmdArgSet stores a vector of non-const pointers to the arguments
that it is validating. It owns them and is respo
brucem added inline comments.
Comment at: tools/lldb-mi/MICmdArgSet.cpp:92
@@ -91,3 +91,3 @@
// Type:Method.
// Args:vArg- (R) A command argument object.
// Return: None.
ki.stfu wrote:
> brucem wrote:
> > Should this say something other than `(R)`
ki.stfu accepted this revision.
ki.stfu added a comment.
This revision is now accepted and ready to land.
lgtm
Comment at: tools/lldb-mi/MICmdArgSet.cpp:92
@@ -91,3 +91,3 @@
// Type:Method.
// Args:vArg- (R) A command argument object.
// Return: None.
---
This revision was automatically updated to reflect the committed changes.
Closed by commit rL247673: [lldb-mi] Simplify
CMICmnLLDBDebugSessionInfo::Shutdown. (authored by brucem).
Changed prior to commit:
http://reviews.llvm.org/D12879?vs=34792&id=34795#toc
Repository:
rL LLVM
http://review
Author: brucem
Date: Tue Sep 15 05:36:08 2015
New Revision: 247673
URL: http://llvm.org/viewvc/llvm-project?rev=247673&view=rev
Log:
[lldb-mi] Simplify CMICmnLLDBDebugSessionInfo::Shutdown.
Summary:
* SharedDataDestroy couldn't fail, so no need to return a status.
* No need for status, so can rem
This revision was automatically updated to reflect the committed changes.
Closed by commit rL247672: Add support for DW_OP_GNU_const_index to dwarf
expression (authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D12849?vs=34697&id=34794#toc
Repository:
rL LLVM
http://
Author: tberghammer
Date: Tue Sep 15 05:33:54 2015
New Revision: 247672
URL: http://llvm.org/viewvc/llvm-project?rev=247672&view=rev
Log:
Add support for DW_OP_GNU_const_index to dwarf expression
DW_OP_GNU_const_index is a new opcode used when split dwarf is enabled
Differential revision: http:/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL247671: Fix several issues arount dwo symbol file handling
(authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D12804?vs=34550&id=34793#toc
Repository:
rL LLVM
http://reviews
Author: tberghammer
Date: Tue Sep 15 05:33:41 2015
New Revision: 247671
URL: http://llvm.org/viewvc/llvm-project?rev=247671&view=rev
Log:
Fix several issues arount dwo symbol file handling
Differential revision: http://reviews.llvm.org/D12804
Modified:
lldb/trunk/source/Plugins/SymbolFile/DW
abidh accepted this revision.
abidh added a comment.
This revision is now accepted and ready to land.
LGTM.
http://reviews.llvm.org/D12879
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-
tberghammer added a comment.
Thank you for the clarification. I will commit in this patch without the change
we discussed (ignoring 0 file address) and I will address that issue later.
http://reviews.llvm.org/D12804
___
lldb-commits mailing list
ll
brucem created this revision.
brucem added reviewers: abidh, ki.stfu.
brucem added a subscriber: lldb-commits.
* SharedDataDestroy couldn't fail, so no need to return a status.
* No need for status, so can remove error message. The error message
wasn't displayed or used anywhere anyway.
http://
tberghammer added inline comments.
Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:3892-3893
@@ +3891,4 @@
+{
+lldb::user_id_t spec_uid = form_value.Reference();
+if (UserIDMatches(spec_uid))
+
tberghammer added a comment.
Those tests are communicating on the gdb remote protocol directly and do a
pattern matching on the response. I think they have the register set names hard
coded in one of those patters, but haven't looked into it (I expect that they
will fail on OSX too).
http://r
brucem added inline comments.
Comment at: tools/lldb-mi/MICmdArgSet.cpp:92
@@ -91,3 +91,3 @@
// Type:Method.
// Args:vArg- (R) A command argument object.
// Return: None.
Should this say something other than `(R)` here?
http://reviews.llvm.org/D1
brucem added a comment.
This could be cleaner still, but this is a good first pass and removes the
worst of it.
http://reviews.llvm.org/D12878
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
brucem created this revision.
brucem added reviewers: abidh, ki.stfu, domipheus.
brucem added a subscriber: lldb-commits.
CMICmdArgSet stores a vector of non-const pointers to the arguments
that it is validating. It owns them and is responsible for deleting
them.
We don't need to pass a const ref
abidh requested changes to this revision.
abidh added a comment.
This revision now requires changes to proceed.
You forgot to add the MIUtilParse.cpp to CMakeLists.txt. Please add it and then
it is good to go. Thanks for doing it.
Repository:
rL LLVM
http://reviews.llvm.org/D12115
___
89 matches
Mail list logo
