enlight added inline comments.
Comment at: cmake/modules/LLDBConfig.cmake:109
@@ +108,3 @@
+ set (PYTHON_EXECUTABLE
$<$:${PYTHON_DEBUG_EXE}>$<$>:${PYTHON_RELEASE_EXE}>
PARENT_SCOPE)
+ set (PYTHON_LIBRARY
$<$:${PYTHON_DEBUG_LIB}>$<$>:${PYTHON_RELEASE_LIB}>
PARENT_SCOPE)
+ se
enlight added inline comments.
Comment at: cmake/modules/LLDBConfig.cmake:56
@@ +55,3 @@
+message("LLDB embedded Python on Windows requires specifying a value for
PYTHON_HOME. Python support disabled.")
+set(LLDB_DISABLE_PYTHON 1)
+return()
This will
Author: spyffe
Date: Sat Oct 3 04:09:01 2015
New Revision: 249233
URL: http://llvm.org/viewvc/llvm-project?rev=249233&view=rev
Log:
Add PersistentVariableDelegate to handle language-specific dematerialization.
The concept here is that languages may have different ways of communicating
results.
tfiala added a comment.
Starting to look at this now.
The code looks reasonable, trying now.
Repository:
rL LLVM
http://reviews.llvm.org/D13268
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
tfiala added a comment.
You'll need to guard against exclusion of libedit:
#ifndef LLDB_DISABLE_LIBEDIT
...
#endif
We can't exclude this whole file if libedit is disabled, because if we don't
have libedit, we still need this null stub in on Linux. (i.e. the existing
behavior needs to be
tfiala added a comment.
I'm adjusting the patch for optional libedit.
Repository:
rL LLVM
http://reviews.llvm.org/D13268
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala added a comment.
I'm still testing, but this seems to do the trick:
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 55fdf77..dd2c440 100644
- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -4,7 +4,14 @@ include(cmake/modules/LLDBStandalone.cmake)
include(cmake/modules/LLDBConfig.cmake)
in
tfiala added a comment.
Yep, that modified patch worked for both:
cmake -DLLDB_DISABLE_LIBEDIT=1
where libedit is disabled from the build, and for the normal case where libedit
is available. In both cases it did the right thing - simple readline support
with libedit and your change (minor t
tfiala requested changes to this revision.
tfiala added a comment.
This revision now requires changes to proceed.
(requesting changes per the previous patch and commentary)
Repository:
rL LLVM
http://reviews.llvm.org/D13268
___
lldb-commits maili
tfiala added a comment.
(And nice work on the underlying change - with libedit it works quite nicely
for basic line editing and history!)
Repository:
rL LLVM
http://reviews.llvm.org/D13268
___
lldb-commits mailing list
lldb-commits@lists.llvm.or
Author: tfiala
Date: Sat Oct 3 20:28:51 2015
New Revision: 249256
URL: http://llvm.org/viewvc/llvm-project?rev=249256&view=rev
Log:
cmake: ensure readline python module target is added before finishing swig.
When the readline target exists (only for non-Android Linux currently),
ensure that targ
You just reminded me. Since you've been hitting a lot of this stuff lately
and doing a lot of great cleanup work, how do you feel about integrating
the swig python scripts into the Xcode build? I've been meaning to do this
for a long time but I don't have enough Xcode knowledge. Having parallel
12 matches
Mail list logo
