[Lldb-commits] [PATCH] D13942: Make SymbolFileDWARF::GetCachedSectionData thread safe

tberghammer created this revision. tberghammer added reviewers: labath, clayborg. tberghammer added a subscriber: lldb-commits. Make SymbolFileDWARF::GetCachedSectionData thread safe http://reviews.llvm.org/D13942 Files: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp

[Lldb-commits] [PATCH] D13940: Fix race conditions in Core/Timer

tberghammer created this revision. tberghammer added reviewers: labath, clayborg. tberghammer added a subscriber: lldb-commits. Fix race conditions in Core/Timer The Timer class already had some support for multi-threaded access but it still contained several race conditions. This CL fixes them

[Lldb-commits] [PATCH] D13941: Fix some race condition in ConstString around Mangled name handling

tberghammer created this revision. tberghammer added reviewers: labath, clayborg. tberghammer added a subscriber: lldb-commits. Fix some race condition in ConstString around Mangled name handling http://reviews.llvm.org/D13941 Files: source/Core/ConstString.cpp Index:

Re: [Lldb-commits] [PATCH] D13715: Add initial gmake glue for the NetBSD platform

brucem added a comment. I think this looks good to me if no one disagrees. Repository: rL LLVM http://reviews.llvm.org/D13715 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r250899 - Skip TestMultithreaded on Windows.

Author: amccarth Date: Wed Oct 21 09:42:10 2015 New Revision: 250899 URL: http://llvm.org/viewvc/llvm-project?rev=250899=rev Log: Skip TestMultithreaded on Windows. Differential Revision: http://reviews.llvm.org/D13923 Modified: lldb/trunk/test/api/multithreaded/TestMultithreaded.py

Re: [Lldb-commits] [PATCH] D13923: Skip TestMultithread.py on Windows because it times out (and they'd fail anyway)

This revision was automatically updated to reflect the committed changes. Closed by commit rL250899: Skip TestMultithreaded on Windows. (authored by amccarth). Changed prior to commit: http://reviews.llvm.org/D13923?vs=37953=38012#toc Repository: rL LLVM http://reviews.llvm.org/D13923

[Lldb-commits] [lldb] r250981 - Move the launch-as-root xpc service from lldb to xcode, to

Author: jmolenda Date: Wed Oct 21 23:17:26 2015 New Revision: 250981 URL: http://llvm.org/viewvc/llvm-project?rev=250981=rev Log: Move the launch-as-root xpc service from lldb to xcode, to make it easier to run hand-built lldb roots and retain those entitlements. This is currently only used by

[Lldb-commits] [PATCH] D13947: [lldb-mi] Fix expansion of anonymous structures and unions

evgeny777 created this revision. evgeny777 added reviewers: ki.stfu, abidh. evgeny777 added subscribers: lldb-commits, KLapshin. Suppose we have the following type ``` struct S { union { inti1; unsigned u1; }; union { inti2; unsigned

Re: [Lldb-commits] [PATCH] D13940: Fix race conditions in Core/Timer

zturner added a subscriber: zturner. Comment at: include/lldb/Core/Timer.h:89 @@ +88,3 @@ + +static thread_local unsigned g_depth; + clayborg wrote: > Not sure if all platforms support thread_local correctly. MacOSX might not. I > also spoke with some

[Lldb-commits] [lldb] r250913 - Made the REPL choose a default language if only one REPL can be chosen.

Author: spyffe Date: Wed Oct 21 12:43:18 2015 New Revision: 250913 URL: http://llvm.org/viewvc/llvm-project?rev=250913=rev Log: Made the REPL choose a default language if only one REPL can be chosen. This requires REPLs to enumerate the languages they support. Modified:

Re: [Lldb-commits] [PATCH] D13951: [LLDB] Fix Clang-tidy modernize-use-override warnings in some files in source/Plugins; other minor fixes.

This revision was automatically updated to reflect the committed changes. Closed by commit rL250925: Fix Clang-tidy modernize-use-override warnings in some files in… (authored by eugenezelenko). Changed prior to commit: http://reviews.llvm.org/D13951?vs=38031=38032#toc Repository: rL LLVM

Re: [Lldb-commits] [lldb] r250913 - Made the REPL choose a default language if only one REPL can be chosen.

This breaks the build because of two things: 1. The function GetLanguagesSupportingREPLs is declared static in Language.cpp, but Language.h has it declared as a static method. 2. There is a declaration for a static method GetREPLEnumerateSupportedLanguagesCallbackAtIndex in PluginManager, but no

[Lldb-commits] [lldb] r250925 - Fix Clang-tidy modernize-use-override warnings in some files in source/Plugins; other minor fixes.

Author: eugenezelenko Date: Wed Oct 21 13:46:17 2015 New Revision: 250925 URL: http://llvm.org/viewvc/llvm-project?rev=250925=rev Log: Fix Clang-tidy modernize-use-override warnings in some files in source/Plugins; other minor fixes. Differential Revision: http://reviews.llvm.org/D13951

[Lldb-commits] [lldb] r250915 - Use six to portably handle module renames in Python 2 and 3

Author: zturner Date: Wed Oct 21 12:48:52 2015 New Revision: 250915 URL: http://llvm.org/viewvc/llvm-project?rev=250915=rev Log: Use six to portably handle module renames in Python 2 and 3 Modified: lldb/trunk/test/api/check_public_api_headers/TestPublicAPIHeaders.py

Re: [Lldb-commits] [PATCH] D13940: Fix race conditions in Core/Timer

clayborg added a comment. Yes, please use any llvm system utilities when possible. And scratch the need for LLDB_THREAD_LOCAL at any point in the future and just use llvm::ThreadLocal all the time as thread local variables have already been abstracted by llvm. http://reviews.llvm.org/D13940

[Lldb-commits] [lldb] r250927 - Revert "Made the REPL choose a default language if only one REPL can be chosen."

Author: sivachandra Date: Wed Oct 21 13:58:01 2015 New Revision: 250927 URL: http://llvm.org/viewvc/llvm-project?rev=250927=rev Log: Revert "Made the REPL choose a default language if only one REPL can be chosen." Summary: This reverts commit babd6dd74e316b1fcd9d171d7d8c83845d51a487. Reviewers:

Re: [Lldb-commits] [PATCH] D13952: Revert "Made the REPL choose a default language if only one REPL can be chosen."

sivachandra added a comment. I am going to put this in to fix the build. http://reviews.llvm.org/D13952 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D13952: Revert "Made the REPL choose a default language if only one REPL can be chosen."

sivachandra created this revision. sivachandra added a reviewer: spyffe. sivachandra added a subscriber: lldb-commits. This reverts commit babd6dd74e316b1fcd9d171d7d8c83845d51a487. http://reviews.llvm.org/D13952 Files: include/lldb/Core/PluginManager.h include/lldb/Target/Language.h

Re: [Lldb-commits] [lldb] r250913 - Made the REPL choose a default language if only one REPL can be chosen.

Yeah, this was a really lousy commit. I’m sorry I committed without checking whether it linked. Thanks for reverting. I will fix this and re-commit. Sean > On Oct 21, 2015, at 11:43 AM, Siva Chandra wrote: > > This breaks the build because of two things: > > 1. The

[Lldb-commits] [lldb] r250931 - Fix error handling when there are no REPLs installed.

Author: spyffe Date: Wed Oct 21 14:31:17 2015 New Revision: 250931 URL: http://llvm.org/viewvc/llvm-project?rev=250931=rev Log: Fix error handling when there are no REPLs installed. Before, in the absence of any configured REPLs, LLDB would act as if there were multiple possible REPL options,

[Lldb-commits] [lldb] r250930 - [SBValue] Add a method GetNumChildren(uint32_t max)

Author: sivachandra Date: Wed Oct 21 14:28:08 2015 New Revision: 250930 URL: http://llvm.org/viewvc/llvm-project?rev=250930=rev Log: [SBValue] Add a method GetNumChildren(uint32_t max) Summary: Along with this, support for an optional argument to the "num_children" method of a Python synthetic

Re: [Lldb-commits] [PATCH] D13881: Add domain socket support to gdb-remote protocol and lldb-server.

ovyalov closed this revision. ovyalov added a comment. Files: /lldb/trunk/lldb.xcodeproj/project.pbxproj /lldb/trunk/source/Host/posix/ConnectionFileDescriptorPosix.cpp /lldb/trunk/source/Plugins/Platform/Android/AdbClient.cpp /lldb/trunk/source/Plugins/Platform/Android/AdbClient.h

Re: [Lldb-commits] [PATCH] D13073: Add an expression parser for Go

On Tue, Oct 20, 2015 at 7:40 PM Jim Ingham via lldb-commits < lldb-commits@lists.llvm.org> wrote: > jingham added a comment. > > The generic parts of this change look fine to me, with a few inlined style > comments. > > I didn't read the Go specific parts of this in detail, I assume you're >

[Lldb-commits] [lldb] r250952 - Fix typo so that "./dotest.py --results-formatter=curses_results.Curses --results-file=/dev/stdout" works again.

Author: gclayton Date: Wed Oct 21 16:55:16 2015 New Revision: 250952 URL: http://llvm.org/viewvc/llvm-project?rev=250952=rev Log: Fix typo so that "./dotest.py --results-formatter=curses_results.Curses --results-file=/dev/stdout" works again. Modified: lldb/trunk/test/lldbcurses.py

Re: [Lldb-commits] [PATCH] D13948: [AppleObjCRuntime] Don't bother looking for the runtime on non-apple targets

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. This is really the fault of AppleObjCRuntimeV1::CreateInstance() and AppleObjCRuntimeV2::CreateInstance() not checking the triple to begin with, but this is a simple solution that will

Re: [Lldb-commits] [PATCH] D13942: Make SymbolFileDWARF::GetCachedSectionData thread safe

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D13942 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D13951: [LLDB] Fix Clang-tidy modernize-use-override warnings in some files in source/Plugins; other minor fixes.

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: brucem, labath, clayborg. Eugene.Zelenko added a subscriber: lldb-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. I checked this patch on my own build on RHEL 6. Repository: rL LLVM

Re: [Lldb-commits] [PATCH] D13966: [LLDB] Fix Clang-tidy modernize-use-override warnings in some files in source/Plugins/LanguageRuntime; other minor fixes.

This revision was automatically updated to reflect the committed changes. Closed by commit rL250966: Fix Clang-tidy modernize-use-override warnings in some files in… (authored by eugenezelenko). Changed prior to commit: http://reviews.llvm.org/D13966?vs=38065=38067#toc Repository: rL LLVM

[Lldb-commits] [lldb] r250966 - Fix Clang-tidy modernize-use-override warnings in some files in source/Plugins/LanguageRuntime; other minor fixes.

Author: eugenezelenko Date: Wed Oct 21 19:45:41 2015 New Revision: 250966 URL: http://llvm.org/viewvc/llvm-project?rev=250966=rev Log: Fix Clang-tidy modernize-use-override warnings in some files in source/Plugins/LanguageRuntime; other minor fixes. Differential Revision:

Re: [Lldb-commits] [PATCH] D13940: Fix race conditions in Core/Timer

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. lgtm http://reviews.llvm.org/D13940 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [Diffusion] rL250335: Fix codesign command with cmake.

dawn added a subscriber: dawn. dawn raised a concern with this commit. dawn added a comment. First, sorry for my delay in reviewing your patch, but I've been on vacation and now am at the C++ ANSI meeting in Kona for this week. But... This broke the build of cmake on OSX. We get: [...]

[Lldb-commits] [PATCH] D13964: Fix libstdc++ data formatters on Ubuntu 15.10 x86_64

tfiala created this revision. tfiala added a reviewer: granata.enrico. tfiala added a subscriber: lldb-commits. This change fixes data formatters for libstdc++ 6.0.21: * Adds std::string data formatter support in C++ (rather than Python) for 6.0.21+. * Uses std::list count field support when

Re: [Lldb-commits] [Diffusion] rL250335: Fix codesign command with cmake.

dawn added a subscriber: lldb-commits. Users: sas (Author) http://reviews.llvm.org/rL250335 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r250965 - Fix libstdc++ data formatters on Ubuntu 15.10 x86_64

Author: tfiala Date: Wed Oct 21 19:23:38 2015 New Revision: 250965 URL: http://llvm.org/viewvc/llvm-project?rev=250965=rev Log: Fix libstdc++ data formatters on Ubuntu 15.10 x86_64 See http://reviews.llvm.org/D13964 for details. Modified: lldb/trunk/examples/synthetic/gnu_libstdcpp.py

[Lldb-commits] [lldb] r250896 - Clean up more .dwo files after the tests run

Author: labath Date: Wed Oct 21 07:56:37 2015 New Revision: 250896 URL: http://llvm.org/viewvc/llvm-project?rev=250896=rev Log: Clean up more .dwo files after the tests run Modified: lldb/trunk/test/lang/cpp/incomplete-types/Makefile lldb/trunk/test/make/Makefile.rules

Re: [Lldb-commits] [Diffusion] rL250335: Fix codesign command with cmake.

brucem added a subscriber: brucem. brucem added a comment. You are correct: ``-E env`` is new after 3.0. (Not in 3.0, but it is in 3.2.) I think the minimum supported cmake is actually older then 3.0 (2.8.something) ... Users: sas (Author) dawn (Auditor) http://reviews.llvm.org/rL250335

Re: [Lldb-commits] [Diffusion] rL250335: Fix codesign command with cmake.

enlight added a subscriber: enlight. enlight added a comment. I believe LLVM requires CMake 2.8.12 or later (at least that was the case when I looked three weeks ago). Users: sas (Author) dawn (Auditor) http://reviews.llvm.org/rL250335 ___

[Lldb-commits] [lldb] r250979 - Change ModuleList::GetSharedModule so that it will reject "stub

Author: jmolenda Date: Wed Oct 21 22:50:28 2015 New Revision: 250979 URL: http://llvm.org/viewvc/llvm-project?rev=250979=rev Log: Change ModuleList::GetSharedModule so that it will reject "stub libraries" altogether. On Mac/iOS, these are libraries which have a UUID and nlist records but no text

[Lldb-commits] [lldb] r250891 - [RenderScript] Fix out of bounds warning.

Author: ewancrawford Date: Wed Oct 21 05:27:10 2015 New Revision: 250891 URL: http://llvm.org/viewvc/llvm-project?rev=250891=rev Log: [RenderScript] Fix out of bounds warning. Modified: lldb/trunk/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptRuntime.cpp

Re: [Lldb-commits] [PATCH] D13881: Add domain socket support to gdb-remote protocol and lldb-server.

tberghammer accepted this revision. Comment at: source/Plugins/Platform/gdb-server/PlatformRemoteGDBServer.cpp:39 @@ +38,3 @@ +#include +#include + Please don't include here if it isn't absolutely necessary as there is a bug on windows in the header. If you

Re: [Lldb-commits] [PATCH] D13902: [DataFormatters] Make libc++ list loop detection linear

This revision was automatically updated to reflect the committed changes. Closed by commit rL250890: [DataFormatters] Make libc++ list loop detection linear (authored by labath). Changed prior to commit: http://reviews.llvm.org/D13902?vs=37891=37981#toc Repository: rL LLVM

[Lldb-commits] [lldb] r250890 - [DataFormatters] Make libc++ list loop detection linear

Author: labath Date: Wed Oct 21 05:17:21 2015 New Revision: 250890 URL: http://llvm.org/viewvc/llvm-project?rev=250890=rev Log: [DataFormatters] Make libc++ list loop detection linear Summary: Loop detection code is being called before every element access. Although it tries to cache some of

Re: [Lldb-commits] [PATCH] D13903: [RenderScript] New commands to save/load RS allocations to file.

EwanCrawford added a comment. Thanks for spotting, comitted a quick fix Repository: rL LLVM http://reviews.llvm.org/D13903 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D13903: [RenderScript] New commands to save/load RS allocations to file.

labath added a subscriber: labath. labath added a comment. Hi, you seem to have an out-of-bounds access here: /lldb/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptRuntime.cpp:1629:5: warning: array index 3 is past the end of the array (which contains 3 elements)

[Lldb-commits] [lldb] r250886 - [RenderScript] New commands to save/load RS allocations to file.

Author: ewancrawford Date: Wed Oct 21 03:50:42 2015 New Revision: 250886 URL: http://llvm.org/viewvc/llvm-project?rev=250886=rev Log: [RenderScript] New commands to save/load RS allocations to file. Patch adds command 'language renderscript allocation save' to store the contents of an

Re: [Lldb-commits] [PATCH] D13903: [RenderScript] New commands to save/load RS allocations to file.

This revision was automatically updated to reflect the committed changes. Closed by commit rL250886: [RenderScript] New commands to save/load RS allocations to file. (authored by EwanCrawford). Changed prior to commit: http://reviews.llvm.org/D13903?vs=37889=37972#toc Repository: rL LLVM