Re: [Lldb-commits] [PATCH] D13970: Add support for abstract domain sockets.

ovyalov added a comment. In http://reviews.llvm.org/D13970#273217, @clayborg wrote: > Looks good. At some point we should add these to the PluginMananger and have > new instances found by having them register URL prefixes which match up with > CreateInstance methods that are given the URL.

Re: [Lldb-commits] [PATCH] D13942: Make SymbolFileDWARF::GetCachedSectionData thread safe

labath accepted this revision. labath added a comment. The new version of the patch looks much cleaner than the old one. Thanks. Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:641 @@ -669,3 +640,3 @@ { -if (m_flags.IsClear (got_flag)) +

Re: [Lldb-commits] [PATCH] D13602: [LLDB] Fix Clang-tidy misc-use-override warnings in some files in include/lldb/Interpreter and Host; other minor fixes.

This revision was automatically updated to reflect the committed changes. Closed by commit rL251054: Fix Clang-tidy modernize-use-override warnings in some files in… (authored by eugenezelenko). Changed prior to commit: http://reviews.llvm.org/D13602?vs=36981=38163#toc Repository: rL LLVM

[Lldb-commits] [lldb] r251054 - Fix Clang-tidy modernize-use-override warnings in some files in include/lldb/Interpreter and Host; other minor fixes.

Author: eugenezelenko Date: Thu Oct 22 14:59:21 2015 New Revision: 251054 URL: http://llvm.org/viewvc/llvm-project?rev=251054=rev Log: Fix Clang-tidy modernize-use-override warnings in some files in include/lldb/Interpreter and Host; other minor fixes. Differential Revision:

[Lldb-commits] [lldb] r251034 - Add support for abstract domain sockets.

Author: ovyalov Date: Thu Oct 22 12:50:33 2015 New Revision: 251034 URL: http://llvm.org/viewvc/llvm-project?rev=251034=rev Log: Add support for abstract domain sockets. http://reviews.llvm.org/D13970 Added: lldb/trunk/include/lldb/Host/linux/AbstractSocket.h

Re: [Lldb-commits] [PATCH] D13941: Fix some race condition in ConstString around Mangled name handling

This revision was automatically updated to reflect the committed changes. tberghammer marked 5 inline comments as done. Closed by commit rL251006: Fix some race condition in ConstString around Mangled name handling (authored by tberghammer). Changed prior to commit:

[Lldb-commits] [lldb] r251007 - Make SymbolFileDWARF::GetCachedSectionData thread safe

Author: tberghammer Date: Thu Oct 22 06:14:37 2015 New Revision: 251007 URL: http://llvm.org/viewvc/llvm-project?rev=251007=rev Log: Make SymbolFileDWARF::GetCachedSectionData thread safe Differential revision: http://reviews.llvm.org/D13942 Modified:

[Lldb-commits] [PATCH] D13995: [cmake] Fix cmake build on OSX after r250335 for older versions of cmake

dawn created this revision. dawn added reviewers: brucem, sas, krytarowski, enlight, labath. dawn added a subscriber: lldb-commits. dawn set the repository for this revision to rL LLVM. Older versions of cmake don't support the -E env option which was added in r250335, causing the build to fail

Re: [Lldb-commits] [PATCH] D13970: Add support for abstract domain sockets.

clayborg added a comment. In http://reviews.llvm.org/D13970#273267, @ovyalov wrote: > In http://reviews.llvm.org/D13970#273217, @clayborg wrote: > > > Looks good. At some point we should add these to the PluginMananger and > > have new instances found by having them register URL prefixes which

[Lldb-commits] [lldb] r251066 - Fix Clang-tidy modernize-use-override warnings in include/lldb/Disassembler and OperatingSystem; other minor fixes.

Author: eugenezelenko Date: Thu Oct 22 16:24:37 2015 New Revision: 251066 URL: http://llvm.org/viewvc/llvm-project?rev=251066=rev Log: Fix Clang-tidy modernize-use-override warnings in include/lldb/Disassembler and OperatingSystem; other minor fixes. Second attempt which should work for MSVC.

[Lldb-commits] [lldb] r251082 - [lldb-mi] display summary for simple types + refactor (use lldb formatting for all cases)

Author: dperchik Date: Thu Oct 22 19:23:53 2015 New Revision: 251082 URL: http://llvm.org/viewvc/llvm-project?rev=251082=rev Log: [lldb-mi] display summary for simple types + refactor (use lldb formatting for all cases) Previously, lldb did not use type summaries for simple types with no

[Lldb-commits] [lldb] r251073 - [cmake] Fix cmake build on OSX after r250335 for older versions of cmake

Author: dperchik Date: Thu Oct 22 17:48:52 2015 New Revision: 251073 URL: http://llvm.org/viewvc/llvm-project?rev=251073=rev Log: [cmake] Fix cmake build on OSX after r250335 for older versions of cmake Reviewed by: sas Subscribers: lldb-commits Differential Revision:

Re: [Lldb-commits] [PATCH] D13657: [lldb] char summary provider

This revision was automatically updated to reflect the committed changes. Closed by commit rL251080: Summary provider for char. (authored by dperchik). Changed prior to commit: http://reviews.llvm.org/D13657?vs=37487=38187#toc Repository: rL LLVM http://reviews.llvm.org/D13657 Files:

[Lldb-commits] [lldb] r251086 - Fix one more place where we were using the old

Author: jmolenda Date: Thu Oct 22 19:59:31 2015 New Revision: 251086 URL: http://llvm.org/viewvc/llvm-project?rev=251086=rev Log: Fix one more place where we were using the old name of the xpc service. Modified: lldb/trunk/source/Host/macosx/Host.mm Modified:

Re: [Lldb-commits] [PATCH] D13947: [lldb-mi] Fix expansion of anonymous structures and unions

abidh accepted this revision. abidh added a comment. LGTM. Thanks for doing it. For this case, the output of the lldb-mi looks more sensible then gdb. http://reviews.llvm.org/D13947 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D13964: Fix libstdc++ data formatters on Ubuntu 15.10 x86_64

labath added a subscriber: labath. Comment at: test/make/Makefile.rules:304 @@ -303,3 +303,3 @@ else - CXXFLAGS += -stdlib=libc++ + CXXFLAGS += -stdlib=libc++ -DLLDB_USING_LIBCPP LDFLAGS +=

[Lldb-commits] [lldb] r251004 - [AppleObjCRuntime] Don't bother looking for the runtime on non-apple targets

Author: labath Date: Thu Oct 22 04:34:40 2015 New Revision: 251004 URL: http://llvm.org/viewvc/llvm-project?rev=251004=rev Log: [AppleObjCRuntime] Don't bother looking for the runtime on non-apple targets Summary: This short-circuits the GetObjCVersion function to avoid iterating through target

Re: [Lldb-commits] [Diffusion] rL250335: Fix codesign command with cmake.

enlight added a comment. It seems like it should be possible to conditionally enable this using CMAKE_VERSION . However that just means anyone who's silly enough to use an older CMake version may run into

[Lldb-commits] [lldb] r251092 - Remove some tabs that snuck into debugserver-entitlements.plist, etc.

Author: jmolenda Date: Thu Oct 22 21:54:21 2015 New Revision: 251092 URL: http://llvm.org/viewvc/llvm-project?rev=251092=rev Log: Remove some tabs that snuck into debugserver-entitlements.plist, etc. Modified: lldb/trunk/tools/debugserver/source/RNBRemote.cpp

Re: [Lldb-commits] [PATCH] D13981: Disable the strict-aliasing warnings produced by gcc

brucem added a comment. It might be worthwhile to have a "janitor" where we can not enable things like this so that it is more clear that this is something we'd like to clean up over time. It would be pretty easy to just have a `if (NOT LLDB_JANITOR_MODE AND CXX_SUPPORTS_NO_STRICT_ALIASING)`

Re: [Lldb-commits] [Diffusion] rL250335: Fix codesign command with cmake.

brucem added a comment. +1 to what @labath said. Users: sas (Author) dawn (Auditor) http://reviews.llvm.org/rL250335 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D13968: [LLDB] Attempt to fix MSVC builds after rL250966

sivachandra added a subscriber: sivachandra. sivachandra added a comment. If this fixes the windows build, can you please commit it ASAP? Repository: rL LLVM http://reviews.llvm.org/D13968 ___ lldb-commits mailing list

Re: [Lldb-commits] [PATCH] D13940: Fix race conditions in Core/Timer

tberghammer updated this revision to Diff 38118. tberghammer added a comment. We already used some thread local storage in the same file to store the current Timer stack so I decided to move the depth to the same storage object (it is using the Host::ThreadLocalStorage* methods). Originally I

Re: [Lldb-commits] [Diffusion] rL250335: Fix codesign command with cmake.

labath added a subscriber: labath. labath added a comment. I don't think we should bump the version over a trivial issue like this. cmake 2.8 is still the default on alot of systems. Wouldn't a well placed quote work also? Like, `FOO="${BAR}" codesign --force --end` Or just putting the command

Re: [Lldb-commits] [PATCH] D13964: Fix libstdc++ data formatters on Ubuntu 15.10 x86_64

tfiala added a comment. Yeah, if you can make that happen, that sounds good to me. This is a "if you have libc++, please build with it, otherwise skip this test"-kinda test... :-) http://reviews.llvm.org/D13964 ___ lldb-commits mailing list

Re: [Lldb-commits] [PATCH] D13985: Enable the libc++ tests on linux

tfiala accepted this revision. tfiala added a comment. This revision is now accepted and ready to land. LGTM. Good catch! http://reviews.llvm.org/D13985 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D13985: Enable the libc++ tests on linux

tfiala added a comment. (I don't think you need to wait for Enrico, btw.) http://reviews.llvm.org/D13985 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D13964: Fix libstdc++ data formatters on Ubuntu 15.10 x86_64

tfiala closed this revision. tfiala added a comment. Forgot to mark this as closed: Closed by commit: r250965 | tfiala | 2015-10-21 17:23:38 -0700 (Wed, 21 Oct 2015) | 4 lines Fix libstdc++ data formatters on

Re: [Lldb-commits] [PATCH] D13940: Fix race conditions in Core/Timer

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D13940 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D13968: [LLDB] Attempt to fix MSVC builds after rL250966

zturner added a subscriber: zturner. zturner added a comment. I would have done this last night but I didn't have a machine handy. I'll test it out now and commit if it fixes. And yea, in the future please just commit fixes. Repository: rL LLVM http://reviews.llvm.org/D13968

Re: [Lldb-commits] [PATCH] D13970: Add support for abstract domain sockets.

clayborg accepted this revision. clayborg added a comment. Looks good. At some point we should add these to the PluginMananger and have new instances found by having them register URL prefixes which match up with CreateInstance methods that are given the URL. http://reviews.llvm.org/D13970

Re: [Lldb-commits] [PATCH] D13602: [LLDB] Fix Clang-tidy misc-use-override warnings in some files in include/lldb/Interpreter and Host; other minor fixes.

clayborg accepted this revision. clayborg added a comment. Looks good. I would venture to say just checkin any clang tidy things that aren't changing code functionality without need for review. Repository: rL LLVM http://reviews.llvm.org/D13602

Re: [Lldb-commits] [PATCH] D13968: [LLDB] Attempt to fix MSVC builds after rL250966

This revision was automatically updated to reflect the committed changes. Closed by commit rL251031: Attempt to fix MSVC builds after rL250966. (authored by eugenezelenko). Changed prior to commit: http://reviews.llvm.org/D13968?vs=38070=38143#toc Repository: rL LLVM