krytarowski added a subscriber: brucem.
krytarowski added a comment.
Bruce was involved in the older version with `config.h`.
Repository:
rL LLVM
http://reviews.llvm.org/D14037
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://list
krytarowski created this revision.
krytarowski added subscribers: lldb-commits, joerg.
krytarowski set the repository for this revision to rL LLVM.
The reason for it is limit of detecting ncurses on various systems. For
example, Ubuntu ships with and linkage from ,
isn't detected by CMake. Detec
krytarowski abandoned this revision.
krytarowski added a comment.
Closing. We are going for reuse of the NetBSD native curses(8) library.
The reason for it is limit of detecting ncurses on various systems. For
example, Ubuntu ships with `` and linkage from ``,
`ncurses.h` isn't detected by CMak
krytarowski abandoned this revision.
krytarowski added a comment.
Closing. We are going for reuse of the NetBSD native curses(8) library.
The reason for it is limit of detecting ncurses on various systems. For
example, Ubuntu ships with `` and linkage from ``,
`ncurses.h` isn't detected by CMak
Author: dperchik
Date: Fri Oct 23 21:01:28 2015
New Revision: 251176
URL: http://llvm.org/viewvc/llvm-project?rev=251176&view=rev
Log:
[lldb-mi] Fix expansion of anonymous structures and unions
A variable of type:
struct S {
union {
inti1;
unsigned u1;
This revision was automatically updated to reflect the committed changes.
Closed by commit rL251176: [lldb-mi] Fix expansion of anonymous structures and
unions (authored by dperchik).
Changed prior to commit:
http://reviews.llvm.org/D13947?vs=38017&id=38291#toc
Repository:
rL LLVM
http://re
Yeah, sorry for not getting to this earlier. Dawn fixed the issue in r251172;
Xcode 7.2 was needed to build it.
> On Oct 23, 2015, at 11:59 AM, Adrian Prantl wrote:
>
> Hi Jason,
>
> It looks like this might have broken the lldb builder on lab.llvm.org:
>
> http://lab.llvm.org:8080/green/jo
This revision was automatically updated to reflect the committed changes.
Closed by commit rL251172: [debugserver] Fix OSX build for older XCode versions
after r251091. (authored by dperchik).
Changed prior to commit:
http://reviews.llvm.org/D14036?vs=38288&id=38290#toc
Repository:
rL LLVM
Author: dperchik
Date: Fri Oct 23 20:31:12 2015
New Revision: 251172
URL: http://llvm.org/viewvc/llvm-project?rev=251172&view=rev
Log:
[debugserver] Fix OSX build for older XCode versions after r251091.
This fixes the OSX build for XCode versions older than 7 by skipping
references to LC_VERSION_
This revision was automatically updated to reflect the committed changes.
Closed by commit rL251171: Add initial gmake glue for the NetBSD platform
(authored by brucem).
Changed prior to commit:
http://reviews.llvm.org/D13715?vs=37957&id=38289#toc
Repository:
rL LLVM
http://reviews.llvm.org
Author: brucem
Date: Fri Oct 23 20:28:24 2015
New Revision: 251171
URL: http://llvm.org/viewvc/llvm-project?rev=251171&view=rev
Log:
Add initial gmake glue for the NetBSD platform
Summary:
These changes aren't everything what is needed for the autotools target, but
it's significantly approaching
Author: eugenezelenko
Date: Fri Oct 23 20:28:05 2015
New Revision: 251170
URL: http://llvm.org/viewvc/llvm-project?rev=251170&view=rev
Log:
Revert r251167 in source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp to fix
MSVC builds failures.
Modified:
lldb/trunk/source/Plugins/Process/gdb-re
Author: dperchik
Date: Fri Oct 23 20:24:00 2015
New Revision: 251169
URL: http://llvm.org/viewvc/llvm-project?rev=251169&view=rev
Log:
[debugserver] Fix indentation in RNBRemote.cpp.
Modified:
lldb/trunk/tools/debugserver/source/RNBRemote.cpp
Modified: lldb/trunk/tools/debugserver/source/RNB
jasonmolenda accepted this revision.
jasonmolenda added a comment.
This revision is now accepted and ready to land.
Thanks, I was trying to spot problems like this but missed this one.
Repository:
rL LLVM
http://reviews.llvm.org/D14036
___
lldb-c
Author: eugenezelenko
Date: Fri Oct 23 20:08:35 2015
New Revision: 251167
URL: http://llvm.org/viewvc/llvm-project?rev=251167&view=rev
Log:
Fix Clang-tidy modernize-use-override warnings in some files in source/Plugins;
other minor fixes.
Modified:
lldb/trunk/source/Plugins/MemoryHistory/asa
dawn created this revision.
dawn added reviewers: jasonmolenda, clayborg.
dawn added a subscriber: lldb-commits.
dawn set the repository for this revision to rL LLVM.
svn r251091 introduced references to LC_VERSION_MIN_TVOS and
LC_VERSION_MIN_WATCHOS which aren't defined in XCode versions older t
Author: brucem
Date: Fri Oct 23 19:30:18 2015
New Revision: 251166
URL: http://llvm.org/viewvc/llvm-project?rev=251166&view=rev
Log:
[lldb-mi] Fix unused variable warning.
Modified:
lldb/trunk/tools/lldb-mi/MICmnLLDBDebugger.cpp
Modified: lldb/trunk/tools/lldb-mi/MICmnLLDBDebugger.cpp
URL:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL251164: Add initial CMake glue for the NetBSD platform
(authored by brucem).
Changed prior to commit:
http://reviews.llvm.org/D13711?vs=37300&id=38286#toc
Repository:
rL LLVM
http://reviews.llvm.org
Author: brucem
Date: Fri Oct 23 19:27:04 2015
New Revision: 251164
URL: http://llvm.org/viewvc/llvm-project?rev=251164&view=rev
Log:
Add initial CMake glue for the NetBSD platform
Summary:
These changes aren't everything what is needed for the CMake target, but it's
significantly approaching it.
Author: eugenezelenko
Date: Fri Oct 23 19:20:14 2015
New Revision: 251162
URL: http://llvm.org/viewvc/llvm-project?rev=251162&view=rev
Log:
Fix Clang-tidy modernize-use-nullptr warnings in include/lldb/Interpreter;
other minor fixes.
Differential Revision: http://reviews.llvm.org/D14025
Modifie
This revision was automatically updated to reflect the committed changes.
Closed by commit rL251162: Fix Clang-tidy modernize-use-nullptr warnings in
include/lldb/Interpreter… (authored by eugenezelenko).
Changed prior to commit:
http://reviews.llvm.org/D14025?vs=38247&id=38283#toc
Repository:
Author: enrico
Date: Fri Oct 23 19:15:57 2015
New Revision: 251161
URL: http://llvm.org/viewvc/llvm-project?rev=251161&view=rev
Log:
Lower the depth of the recursion in this test since it would on occasion
timeout and add noise to test runs
Modified:
lldb/trunk/test/functionalities/recursion
Author: spyffe
Date: Fri Oct 23 16:45:02 2015
New Revision: 251151
URL: http://llvm.org/viewvc/llvm-project?rev=251151&view=rev
Log:
Fixed some issues with reporting "this" when the current function is not listed
in DWARF as a member of a class, but it has a "this" parameter. Specifically,
*this
Author: sivachandra
Date: Fri Oct 23 16:38:04 2015
New Revision: 251150
URL: http://llvm.org/viewvc/llvm-project?rev=251150&view=rev
Log:
[TestBreakpointCommand] Fix after r251121
Summary:
"from __future__ import print_function" was added to the test file but
not to the embedded interpreter. This
sivachandra updated this revision to Diff 38265.
sivachandra added a comment.
Put back the import of print_function from __future__.
http://reviews.llvm.org/D14029
Files:
test/functionalities/breakpoint/breakpoint_command/TestBreakpointCommand.py
Index:
test/functionalities/breakpoint/break
Can you leave the from __future__ import print_function at the top? That's
orthogonal to changing the dynamically executed code.
I can reproduce this problem by running LLDB in 2.7 and entering the
embedded interpreter and typing print("foo", file=sys.stdout). So I can
probably fix that and this
sivachandra created this revision.
sivachandra added a reviewer: zturner.
sivachandra added a subscriber: lldb-commits.
"from __future__ import print_function" was added to the test file but
not to the embedded interpreter. This change uses file.write instead to
avoid all problems with print.
htt
zturner created this revision.
zturner added a reviewer: tfiala.
zturner added a subscriber: lldb-commits.
In a few of the examples fixed up here, the distinction between long and int
was not important here. As a result, I converted those to use int instead of
long everywhere to make the code s
Hi,
I decided to take a quick look at PR25300 (roughly, an '*' at the end
of an environment variable crashes lldb-server). The issue is that
during packet decompression (apparently even for uncompressed packets)
there is basic RLE, triggered by '*', so it needs to be quoted in some
way before bein
Author: zturner
Date: Fri Oct 23 14:52:36 2015
New Revision: 251139
URL: http://llvm.org/viewvc/llvm-project?rev=251139&view=rev
Log:
Make uses of unicode literals portable.
Six provides six.u() which resolves to either u"" or "" depending on
Python version, and and six.unichr() which resolves to
Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: labath, clayborg.
Eugene.Zelenko added a subscriber: lldb-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.
This is new Clang-tidy check which I run through LLDB code base, so I think
will be good idea to
Author: eugenezelenko
Date: Fri Oct 23 13:39:37 2015
New Revision: 251134
URL: http://llvm.org/viewvc/llvm-project?rev=251134&view=rev
Log:
Fix Clang-tidy modernize-use-override warnings in source/Target; other minor
fixes.
Modified:
lldb/trunk/source/Target/LanguageRuntime.cpp
lldb/trun
zturner added inline comments.
Comment at: test/lang/go/types/TestGoASTContext.py:134
@@ -131,3 +133,3 @@
self.assertEqual(5, v.GetNumChildren())
-for i in xrange(5):
+for i in six.moves.xrange(5):
self.assertEqual(str(i + 1), v.GetChildAtInde
zturner created this revision.
zturner added a reviewer: tfiala.
zturner added a subscriber: lldb-commits.
Herald added subscribers: srhines, danalbert, tberghammer.
Hi Todd,
I've been putting most of this stuff in withouty review, but I figure every
once in a while I should pass one your way as
Author: zturner
Date: Fri Oct 23 12:54:00 2015
New Revision: 251130
URL: http://llvm.org/viewvc/llvm-project?rev=251130&view=rev
Log:
Disable a compiler warning on MSVC.
This is caused by a bug in MSVC's library implementation. It's
fixed in the next version of the compiler, but for now the only
Author: zturner
Date: Fri Oct 23 12:53:51 2015
New Revision: 251129
URL: http://llvm.org/viewvc/llvm-project?rev=251129&view=rev
Log:
Python3 - Wrap more statements in calls to list()
Modified:
lldb/trunk/test/attic/tester.py
lldb/trunk/test/dosep.py
lldb/trunk/test/dotest.py
lldb
Author: zturner
Date: Fri Oct 23 12:53:30 2015
New Revision: 251128
URL: http://llvm.org/viewvc/llvm-project?rev=251128&view=rev
Log:
Remove argparse_compat.
We don't support versions of Python less than 2.7
Removed:
lldb/trunk/test/argparse_compat.py
Modified:
lldb/trunk/test/dotest_arg
Yea that sounds good too.
On Fri, Oct 23, 2015 at 10:12 AM Pavel Labath wrote:
> labath added a comment.
>
> test_categories is the name of .py file. :/ How about
> `add_test_categories` ?
>
>
> http://reviews.llvm.org/D14020
>
>
>
>
___
lldb-commits m
labath added a comment.
test_categories is the name of .py file. :/ How about `add_test_categories` ?
http://reviews.llvm.org/D14020
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commit
Author: eugenezelenko
Date: Fri Oct 23 11:56:07 2015
New Revision: 251119
URL: http://llvm.org/viewvc/llvm-project?rev=251119&view=rev
Log:
Fix Clang-tidy modernize-use-override warnings in
source/Plugins/ObjectContainer and ObjectFile; other minor fixes.
Modified:
lldb/trunk/source/Plugins
zturner added a comment.
Could you call this something less generic than `categories`? The name of the
decorator should be descriptive enough to hint that it can only be applied to
test methods. `test_categories` even.
http://reviews.llvm.org/D14020
___
labath created this revision.
labath added reviewers: tberghammer, tfiala, granata.enrico, zturner.
labath added a subscriber: lldb-commits.
Per discussions on the mailing list, I have implemented a decorator which
annotates individual
test methods with categories. I have used this framework to r
Author: tberghammer
Date: Fri Oct 23 08:36:31 2015
New Revision: 25
URL: http://llvm.org/viewvc/llvm-project?rev=25&view=rev
Log:
Fix arm lldb-server on aarch64 device
* Use PTRACE_GETVFPREGS/PTRACE_SETVFPREGS to access the floating point
registers instead of the old PTRACE_GETFPREGS/PT
I agree that this isn't the perfect approach, but I don't think we want to
take the performance penalty "-fno-strict-aliasing" will cause (we are
using LLDB like this for a long time without any known issue caused by
strict aliasing violations). The best solution would be to fix the strict
aliasing
On Fri, Oct 23, 2015 at 10:34:54AM -, Tamas Berghammer via lldb-commits
wrote:
> Author: tberghammer
> Date: Fri Oct 23 05:34:53 2015
> New Revision: 251107
>
> URL: http://llvm.org/viewvc/llvm-project?rev=251107&view=rev
> Log:
> Disable the strict-aliasing warnings produced by gcc
>
> GCC
Author: tberghammer
Date: Fri Oct 23 05:53:31 2015
New Revision: 251109
URL: http://llvm.org/viewvc/llvm-project?rev=251109&view=rev
Log:
Try to fix MSVC build after r251105
Modified:
lldb/trunk/include/lldb/Core/Timer.h
lldb/trunk/source/Core/Timer.cpp
Modified: lldb/trunk/include/lldb/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL251107: Disable the strict-aliasing warnings produced by gcc
(authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D13981?vs=38115&id=38226#toc
Repository:
rL LLVM
http://revie
Author: tberghammer
Date: Fri Oct 23 05:34:49 2015
New Revision: 251106
URL: http://llvm.org/viewvc/llvm-project?rev=251106&view=rev
Log:
Re-commit "Make dwarf parsing multi-threaded"
Re-commit the change after fixing a lot of race condition in LLDB
exposed by this change
Loading the debug info
Author: tberghammer
Date: Fri Oct 23 05:34:53 2015
New Revision: 251107
URL: http://llvm.org/viewvc/llvm-project?rev=251107&view=rev
Log:
Disable the strict-aliasing warnings produced by gcc
GCC produce a lot of strict-aliasing warning for the LLDB codebase
what makes reading the compile output v
This revision was automatically updated to reflect the committed changes.
Closed by commit rL251105: Fix race conditions in Core/Timer (authored by
tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D13940?vs=38118&id=38225#toc
Repository:
rL LLVM
http://reviews.llvm.org/D13940
Author: tberghammer
Date: Fri Oct 23 05:34:29 2015
New Revision: 251105
URL: http://llvm.org/viewvc/llvm-project?rev=251105&view=rev
Log:
Fix race conditions in Core/Timer
The Timer class already had some support for multi-threaded access
but it still contained several race conditions. This CL fi
tberghammer added a comment.
I decided to go with your approach primarily because I tried it out with lower
number of threads and it performed marginally better (~10%) in that case
http://reviews.llvm.org/D13662
___
lldb-commits mailing list
lldb-c
Author: aidandodds
Date: Fri Oct 23 05:27:16 2015
New Revision: 251104
URL: http://llvm.org/viewvc/llvm-project?rev=251104&view=rev
Log:
Fix the build when building with LLDB_DISABLE_PYTHON.
Modified:
lldb/trunk/tools/lldb-mi/MICmnLLDBDebugger.cpp
Modified: lldb/trunk/tools/lldb-mi/MICmnLLDB
tberghammer added a comment.
I created a bug for it as https://llvm.org/bugs/show_bug.cgi?id=25296
I don't see too much value in creating a "janitor" mode because I think when
people want to do some cleanup, they will focus on one specific area where they
enable the necessary warnings manually.
Author: labath
Date: Fri Oct 23 04:17:30 2015
New Revision: 251102
URL: http://llvm.org/viewvc/llvm-project?rev=251102&view=rev
Log:
Enable the libc++ tests on linux
Summary:
The list of loaded modules which skip_if_library_missing is depending on is not
available on
linux until after we run the
This revision was automatically updated to reflect the committed changes.
Closed by commit rL251102: Enable the libc++ tests on linux (authored by
labath).
Changed prior to commit:
http://reviews.llvm.org/D13985?vs=38129&id=38221#toc
Repository:
rL LLVM
http://reviews.llvm.org/D13985
Files
56 matches
Mail list logo