abidh updated this revision to Diff 38879.
abidh added a comment.
Handled review comment.
Added a test for -data-disassemble without "--" separator.
http://reviews.llvm.org/D14197
Files:
packages/Python/lldbsuite/test/tools/lldb-mi/data/TestMiData.py
tools/lldb-mi/MICmdBase.cpp
tools/lld
abidh added inline comments.
Comment at: tools/lldb-mi/MICmdBase.cpp:102
@@ -99,2 +101,3 @@
m_setCmdArgs.Add(new CMICmdArgValOptionLong(m_constStrArgFrame,
m_FrameArgMandatory, true, CMICmdArgValListBase::eArgValType_Number, 1));
+m_setCmdArgs.Add(new CMICmdArgValConsume
ki.stfu accepted this revision.
ki.stfu added a comment.
This revision is now accepted and ready to land.
lgtm
Comment at: tools/lldb-mi/MICmdBase.cpp:102
@@ -99,2 +101,3 @@
m_setCmdArgs.Add(new CMICmdArgValOptionLong(m_constStrArgFrame,
m_FrameArgMandatory, true, CMICmdAr
abidh marked an inline comment as done.
Comment at: tools/lldb-mi/MICmdBase.cpp:102
@@ -99,2 +101,3 @@
m_setCmdArgs.Add(new CMICmdArgValOptionLong(m_constStrArgFrame,
m_FrameArgMandatory, true, CMICmdArgValListBase::eArgValType_Number, 1));
+m_setCmdArgs.Add(new CMICmdAr
Author: abidh
Date: Mon Nov 2 05:43:40 2015
New Revision: 251793
URL: http://llvm.org/viewvc/llvm-project?rev=251793&view=rev
Log:
Handle the options and parameters separator in every MI command
Summary:
As per the following link, the "--" separator can appear between the options
and parameters
ki.stfu added inline comments.
Comment at: tools/lldb-mi/MICmdBase.cpp:102
@@ -99,2 +101,3 @@
m_setCmdArgs.Add(new CMICmdArgValOptionLong(m_constStrArgFrame,
m_FrameArgMandatory, true, CMICmdArgValListBase::eArgValType_Number, 1));
+m_setCmdArgs.Add(new CMICmdArgValConsu
Enrico,
> +@expectedFailureDarwin
isn’t this commit supposed to fix the test? Why are you making it xfail?
Sean
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Much better.
Repository:
rL LLVM
http://reviews.llvm.org/D13859
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llv
clayborg resigned from this revision.
clayborg removed a reviewer: clayborg.
clayborg added a comment.
I will defer to Jason Molenda.
http://reviews.llvm.org/D14226
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-
I looked into this some more, and unfortunately I can't reproduce it. That
being said, I'm not convinced this patch fixes anything. The reason is
that when you import something, whether it be through the `__import__`
function or the `import` statement, the module itself is cached in
`sys.modules`
Author: zturner
Date: Mon Nov 2 13:19:49 2015
New Revision: 251819
URL: http://llvm.org/viewvc/llvm-project?rev=251819&view=rev
Log:
Make dosep correctly invoke the top-level script when forking out
packages/Python/lldbsuite is now a Python package, and it relies
on its __init__.py being called
BTW, is lldb/test/dotest.py here to stay? I thought it was there just to
avoid breaking anybody who runs dotest directly (instead of ninja
check-lldb), and therefore we will remove it once everybody gets a chance
to migrate (I have already changed our buildbots to not use it).
Is that correct or I
Don't change your buildbot to not use it. That's an error.
packages/Python/lldbsuite/test/dotest *must* be imported, as it depends on
its __init__.py being run. If your buildbot doesn't use it anymore, then I
think the patch I just submitted (r251819) will break your buildbot,
because I added th
If you want to have a way to run the test suite without typing a long
relative path to go into the packages tree, then one thing that might work
is to make a new file packages/Python/dotest.py.
Then make it a copy of test/dotest.py. Not real crazy about copying code,
but let me know what you thin
Sorry for the email spam. I still think the buildbot should run the
version in lldb/test though. `test` should be a top-level folder, it makes
it easy for people who clone the repo to instantly look and figure out how
our test suite works. So I think that's the flow that the buildbot should
test
Author: zturner
Date: Mon Nov 2 13:38:58 2015
New Revision: 251822
URL: http://llvm.org/viewvc/llvm-project?rev=251822&view=rev
Log:
Remove the __import__ hack of lldbtest_config.
I think the underlying problem was fixed by r251819, but I can't
reproduce the problem. So this is to check whether
It doesn't matter to me which dotest to run, I just want to know what is
the "right way". Due to enrico's patch, I couldn't run one dotest, so I
switched to another one. Now, with your patch, the other way is also
broken. Could you also go through with the other part of your change
(reverting enric
The other part of the patch should be in now (r251822). Can you make sure
the bot is passing by running the top-level script now? If not let me know.
On Mon, Nov 2, 2015 at 11:50 AM Pavel Labath wrote:
> It doesn't matter to me which dotest to run, I just want to know what is
> the "right way"
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
Yes.
Repository:
rL LLVM
http://reviews.llvm.org/D13296
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-
BTW, is your buildbot not just using "ninja check-lldb"? So far I haven't
been able to reproduce any problems by using ninja check-lldb, but if I
know what command line is being used maybe I can reproduce a failure and
diagnose it.
On Mon, Nov 2, 2015 at 11:51 AM Zachary Turner wrote:
> The oth
Author: ovyalov
Date: Mon Nov 2 14:04:18 2015
New Revision: 251825
URL: http://llvm.org/viewvc/llvm-project?rev=251825&view=rev
Log:
Calculate size of sockaddr_un manually for abstract sockets:
- SUN_LEN doesn't work because strlen(sun_path) == 0
- sizeof(sockaddr_un) doesn't work on Android.
Author: labath
Date: Mon Nov 2 14:54:25 2015
New Revision: 251830
URL: http://llvm.org/viewvc/llvm-project?rev=251830&view=rev
Log:
[dosep] Fix-up callers of process_dir, after it got its argument removed
Modified:
lldb/trunk/packages/Python/lldbsuite/test/dosep.py
Modified: lldb/trunk/pack
Thanks. I literally just built on Linux in order to try and reproduce some
of these issues others were seeing and I was just about to fix this before
you beat me to it.
On Mon, Nov 2, 2015 at 12:56 PM Pavel Labath via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Author: labath
> Date: Mo
Author: tfiala
Date: Mon Nov 2 15:05:28 2015
New Revision: 251831
URL: http://llvm.org/viewvc/llvm-project?rev=251831&view=rev
Log:
First pass on www docs: Adding Programming Language Support to LLDB
We'll hook this up to the main page after Greg, Sean and others
iterate on it to a useful point.
Author: ribrdb
Date: Mon Nov 2 15:28:18 2015
New Revision: 251835
URL: http://llvm.org/viewvc/llvm-project?rev=251835&view=rev
Log:
Move go expression tests to the new location.
Added:
lldb/trunk/packages/Python/lldbsuite/test/lang/go/expressions/
lldb/trunk/packages/Python/lldbsuite/te
Author: enrico
Date: Mon Nov 2 15:52:05 2015
New Revision: 251838
URL: http://llvm.org/viewvc/llvm-project?rev=251838&view=rev
Log:
Change ValueObject::IsLogicalTrue so that it starts by asking the applicable
Language plugin before using the C-style rule
Modified:
lldb/trunk/include/lldb/Ta
Author: zturner
Date: Mon Nov 2 16:13:13 2015
New Revision: 251840
URL: http://llvm.org/viewvc/llvm-project?rev=251840&view=rev
Log:
Revert part of r239007 related to creating the Python symlink.
This has apparently been broken since June, but only on non-Windows.
Perhaps nobody noticed it becau
angling symlink. Please see r251840 (
> http://lists.llvm.org/pipermail/lldb-commits/Week-of-Mon-20151102/024878.html)
> for
> more information in case you're interested in resubmitting after you figure
> out the correct fix.
>
> On Wed, Jun 3, 2015 at 8:56 PM Andrew Wilkins wrote
Finally managed to get a working Linux build. This seems to be fixed on
Linux -- or at the very least, it works right now (maybe it always did?)
So I'm hoping this means it's fixed on OSX now too, but please let me know
if it's still broken.
On Mon, Nov 2, 2015 at 11:59 AM Zachary Turner wrote:
Author: enrico
Date: Mon Nov 2 16:26:55 2015
New Revision: 251844
URL: http://llvm.org/viewvc/llvm-project?rev=251844&view=rev
Log:
Add a sketched out section on adding Language and LanguageRuntime plugins for
language support
Modified:
lldb/trunk/www/adding-language-support.html
Modified:
Author: zturner
Date: Mon Nov 2 16:41:01 2015
New Revision: 251847
URL: http://llvm.org/viewvc/llvm-project?rev=251847&view=rev
Log:
Create lldbsuite.support package with `seven` file.
This file will be useful for filling in the gaps where `six` is
missing some things we need.
Added:
lldb/t
ovyalov created this revision.
ovyalov added reviewers: clayborg, tberghammer.
ovyalov added a subscriber: lldb-commits.
Herald added subscribers: danalbert, tberghammer.
Provide ADB port forwarding support for abstract sockets.
http://reviews.llvm.org/D14262
Files:
include/lldb/Host/posix/Con
Author: enrico
Date: Mon Nov 2 17:37:55 2015
New Revision: 251861
URL: http://llvm.org/viewvc/llvm-project?rev=251861&view=rev
Log:
This test case does not actually depend on Cocoa; Foundation is good enoguh
Modified:
lldb/trunk/packages/Python/lldbsuite/test/python_api/objc_type/Makefile
Author: labath
Date: Mon Nov 2 17:39:09 2015
New Revision: 251862
URL: http://llvm.org/viewvc/llvm-project?rev=251862&view=rev
Log:
Revert "Remove the __import__ hack of lldbtest_config."
The hack still seems to be necessary. Putting it back in until we figure out
why.
Modified:
lldb/trunk
Author: labath
Date: Mon Nov 2 17:41:44 2015
New Revision: 251863
URL: http://llvm.org/viewvc/llvm-project?rev=251863&view=rev
Log:
Revert "Make new dotest.py executable"
This was a misunderstanding on my part. The new dotest.py is not meant to be
executed directly.
Modified:
lldb/trunk/pa
ovyalov created this revision.
ovyalov added a reviewer: tberghammer.
ovyalov added a subscriber: lldb-commits.
Herald added subscribers: danalbert, tberghammer, aemerson.
Pass symbol file platform's file spec to ModuleCache::Put - i.e., to make sym
link path like this:
.lldb/module_cache/remot
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D14264
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
Author: ovyalov
Date: Mon Nov 2 18:30:19 2015
New Revision: 251871
URL: http://llvm.org/viewvc/llvm-project?rev=251871&view=rev
Log:
Fix module cache sym links' creation for symbol files.
http://reviews.llvm.org/D14264
Modified:
lldb/trunk/source/Utility/ModuleCache.cpp
Modified: lldb/tru
I think what is happening is that when we go through unittest2, the package
link is being broken.
Inside dotest.py : __package__ = lldbsuite.test
Inside unittest2.loadTestsFromName : __package__ = unittest2
Inside TestMultithreaded.py : __package__ = None
Restoring the link by writing
__package_
ovyalov closed this revision.
ovyalov added a comment.
Submitted as http://reviews.llvm.org/rL251871
http://reviews.llvm.org/D14264
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: source/Host/posix/ConnectionFileDescriptorPosix.cpp:182
@@ -156,2 +181,3 @@
{
-if (strstr(s, "listen://") == s)
+const char *ad
+Enrico Granata
On Mon, Nov 2, 2015 at 4:42 PM Zachary Turner wrote:
> Ok, I think I figured out the root of all the problems.
>
> First, in setupSysPath we have this:
>
> sys.path.insert(0, scriptPath)
>
> This basically adds `lldb/packages/Python/lldbsuite/test` to sys.path.
>
> Then, in
Ok, I think I figured out the root of all the problems.
First, in setupSysPath we have this:
sys.path.insert(0, scriptPath)
This basically adds `lldb/packages/Python/lldbsuite/test` to sys.path.
Then, in the individual tests we write this:
from lldbtest import *
It finds lldbtest at the a
Good news Zachary, I'm glad we finally got to the bottom of this.
I've tested your proposed changes locally, and on our buildbot (which,
for whatever reason, did not like Enrico's workaround). Could we get
this in as soon as possible?
cheers,
pl
On 2 November 2015 at 16:43, Zachary Turner wrot
Author: ovyalov
Date: Mon Nov 2 19:37:01 2015
New Revision: 251879
URL: http://llvm.org/viewvc/llvm-project?rev=251879&view=rev
Log:
Provide ADB port forwarding support for abstract sockets.
http://reviews.llvm.org/D14262
Modified:
lldb/trunk/include/lldb/Host/posix/ConnectionFileDescripto
ovyalov closed this revision.
ovyalov added a comment.
Files:
/lldb/trunk/include/lldb/Host/posix/ConnectionFileDescriptorPosix.h
/lldb/trunk/source/Host/posix/ConnectionFileDescriptorPosix.cpp
/lldb/trunk/source/Plugins/Platform/Android/AdbClient.cpp
/lldb/trunk/source/Plugins/Platform/A
Yes, but it's a VERY large mechanical code change. For example, everywhere
we were doign something like this:
import lldbutil
from one of the tests, we have to rewrite this as:
import lldbsuite.test.lldbutil as lldbutil
And we have to catch all the different ways of importing, like:
from lldb
Author: labath
Date: Mon Nov 2 19:39:03 2015
New Revision: 251880
URL: http://llvm.org/viewvc/llvm-project?rev=251880&view=rev
Log:
Fix usage of removed decorator in TestExpressions
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lang/go/expressions/TestExpressions.py
Modified:
lldb/t
As an alternative, since this is breaking your buildbot, I can check in the
lion's share of the work (which should fix about 95% of the fixups), and
you can do any remaining ones that pop up on the linux buildbot after I'm
gone. Do you prefer that?
On Mon, Nov 2, 2015 at 5:40 PM Zachary Turner
Author: enrico
Date: Mon Nov 2 19:47:19 2015
New Revision: 251882
URL: http://llvm.org/viewvc/llvm-project?rev=251882&view=rev
Log:
Emit an error message if the current working directory does not exist when the
user is trying to launch argdumper to do shell expansion
Modified:
lldb/trunk/so
Author: jingham
Date: Mon Nov 2 20:11:24 2015
New Revision: 251887
URL: http://llvm.org/viewvc/llvm-project?rev=251887&view=rev
Log:
Add the ability to pass an EvaluateExpressionOptions when you make a
UserExpression. This
isn't used in this commit but will be in a future commit.
Modified:
Author: enrico
Date: Mon Nov 2 20:34:43 2015
New Revision: 251889
URL: http://llvm.org/viewvc/llvm-project?rev=251889&view=rev
Log:
Do not try to copy host memory from address 0
Modified:
lldb/trunk/source/Core/ValueObject.cpp
Modified: lldb/trunk/source/Core/ValueObject.cpp
URL:
http://ll
On Mon, Nov 2, 2015 at 10:02 PM Todd Fiala wrote:
> Do you have a script you used to tweak these?
>
> (We have a ton of stuff broken internally on this that I need to fix up).
>
> We're starting to need to do quite a bit of extra typing for the package
> structure :-/
>
No, I just used a recursi
Also as far as I can tell, X has to be in the following set: [lldbutil,
lldbtest, lldbinline, lldbbench]. In theory there are other possibilities
(any .py file that is in packages/Python/lldbsuite/test is fair game) but I
don't think I encountered any aside from those 4.
On Mon, Nov 2, 2015 at 10
Also, one last thing. The reason this is probably wreaking havoc on your
stuff internally is because I removed scriptDir from sys.path (diff the
changes of dotest.py to see). I think it should stay removed upstream
(mucking with sys.path so you can import from a parent directory is a bad
thing to
On Mon, Nov 2, 2015 at 10:12 PM, Zachary Turner wrote:
> On Mon, Nov 2, 2015 at 10:02 PM Todd Fiala wrote:
>
>> Do you have a script you used to tweak these?
>>
>> (We have a ton of stuff broken internally on this that I need to fix up).
>>
>> We're starting to need to do quite a bit of extra ty
No, we won't need/want to revert. I just wanted to see if you already had
a snazzy script I could whiz through a directory tree with.
-Todd
On Mon, Nov 2, 2015 at 10:26 PM, Zachary Turner wrote:
> Also, one last thing. The reason this is probably wreaking havoc on your
> stuff internally is b
On Mon, Nov 2, 2015 at 10:27 PM Todd Fiala wrote:
> On Mon, Nov 2, 2015 at 10:12 PM, Zachary Turner
> wrote:
>
>>
>> Luckily the extra typing only comes at the import site. If you use the
>> syntax I suggested in #2 and #3 above (import lldbsuite.test.X as X) then
>> the syntax at any sites whe
:-)
On Mon, Nov 2, 2015 at 10:30 PM, Zachary Turner wrote:
>
>
> On Mon, Nov 2, 2015 at 10:27 PM Todd Fiala wrote:
>
>> On Mon, Nov 2, 2015 at 10:12 PM, Zachary Turner
>> wrote:
>>
>>>
>>> Luckily the extra typing only comes at the import site. If you use the
>>> syntax I suggested in #2 and
59 matches
Mail list logo
