[Lldb-commits] [lldb] r252035 - Option letter o was already in use; use an uppercase E instead

2015-11-03 Thread Enrico Granata via lldb-commits
Author: enrico Date: Tue Nov 3 20:12:09 2015 New Revision: 252035 URL: http://llvm.org/viewvc/llvm-project?rev=252035&view=rev Log: Option letter o was already in use; use an uppercase E instead Modified: lldb/trunk/source/Commands/CommandObjectMemory.cpp Modified: lldb/trunk/source/Command

Re: [Lldb-commits] [lldb] r252031 - Add a few useful methods to ThreadSafeDense{Map, Set}. Not used yet.

2015-11-03 Thread Jim Ingham via lldb-commits
We had a few uses of it back before it actually had any mutex at all and that only caused very infrequent crashes - usually on teardown. So not very much contended, and probably a RWMutex is overkill. But it might be useful for the general class. I'm in the middle of other things right now, a

Re: [Lldb-commits] [lldb] r252031 - Add a few useful methods to ThreadSafeDense{Map, Set}. Not used yet.

2015-11-03 Thread Zachary Turner via lldb-commits
Seems like this class would be a good candidate for using an RWMutex. Any reason you can think of why that wouldn't work? On Tue, Nov 3, 2015 at 5:41 PM Jim Ingham via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: jingham > Date: Tue Nov 3 19:39:05 2015 > New Revision: 252031 > >

[Lldb-commits] [lldb] r252031 - Add a few useful methods to ThreadSafeDense{Map, Set}. Not used yet.

2015-11-03 Thread Jim Ingham via lldb-commits
Author: jingham Date: Tue Nov 3 19:39:05 2015 New Revision: 252031 URL: http://llvm.org/viewvc/llvm-project?rev=252031&view=rev Log: Add a few useful methods to ThreadSafeDense{Map,Set}. Not used yet. Modified: lldb/trunk/include/lldb/Core/ThreadSafeDenseMap.h lldb/trunk/include/lldb/Co

[Lldb-commits] [lldb] r252030 - Revert "Python 3 - Don't add the _d suffix to the symlink on Windows."

2015-11-03 Thread Zachary Turner via lldb-commits
Author: zturner Date: Tue Nov 3 19:26:48 2015 New Revision: 252030 URL: http://llvm.org/viewvc/llvm-project?rev=252030&view=rev Log: Revert "Python 3 - Don't add the _d suffix to the symlink on Windows." This reverts commit e59c95ca936f5a0a8abb987b8605fd8bf82b03b6. This was a mistake on my part

[Lldb-commits] [lldb] r252029 - Fix a shadowed ivar in SearchFilterByModuleListAndCU.

2015-11-03 Thread Jim Ingham via lldb-commits
Author: jingham Date: Tue Nov 3 19:24:04 2015 New Revision: 252029 URL: http://llvm.org/viewvc/llvm-project?rev=252029&view=rev Log: Fix a shadowed ivar in SearchFilterByModuleListAndCU. Modified: lldb/trunk/include/lldb/Core/SearchFilter.h Modified: lldb/trunk/include/lldb/Core/SearchFilte

[Lldb-commits] [lldb] r252025 - Python 3 - Use universal_newlines when calling subprocess.check_output

2015-11-03 Thread Zachary Turner via lldb-commits
Author: zturner Date: Tue Nov 3 19:03:47 2015 New Revision: 252025 URL: http://llvm.org/viewvc/llvm-project?rev=252025&view=rev Log: Python 3 - Use universal_newlines when calling subprocess.check_output By default in Python 3, check_output() returns a program's output as an encoded byte sequenc

[Lldb-commits] [lldb] r252026 - Python 3 - Don't add the _d suffix to the symlink on Windows.

2015-11-03 Thread Zachary Turner via lldb-commits
Author: zturner Date: Tue Nov 3 19:03:57 2015 New Revision: 252026 URL: http://llvm.org/viewvc/llvm-project?rev=252026&view=rev Log: Python 3 - Don't add the _d suffix to the symlink on Windows. In Python 2, a debug extension module required an _d suffix, so for example the extension module `_ll

[Lldb-commits] [lldb] r252024 - Actually implement Section::GetSectionData.

2015-11-03 Thread Jim Ingham via lldb-commits
Author: jingham Date: Tue Nov 3 19:02:43 2015 New Revision: 252024 URL: http://llvm.org/viewvc/llvm-project?rev=252024&view=rev Log: Actually implement Section::GetSectionData. Modified: lldb/trunk/include/lldb/Core/Section.h lldb/trunk/source/Core/Section.cpp Modified: lldb/trunk/inclu

[Lldb-commits] [lldb] r252023 - Try a little harder to provide a legit CWD to argdumper if

2015-11-03 Thread Jim Ingham via lldb-commits
Author: jingham Date: Tue Nov 3 19:02:06 2015 New Revision: 252023 URL: http://llvm.org/viewvc/llvm-project?rev=252023&view=rev Log: Try a little harder to provide a legit CWD to argdumper if the user hasn't provided one. Modified: lldb/trunk/source/Host/macosx/Host.mm Modified: lldb/trunk

[Lldb-commits] [lldb] r252018 - Fix an issue where LLDB would truncate summaries for string types without producing any evidence thereof

2015-11-03 Thread Enrico Granata via lldb-commits
Author: enrico Date: Tue Nov 3 18:02:08 2015 New Revision: 252018 URL: http://llvm.org/viewvc/llvm-project?rev=252018&view=rev Log: Fix an issue where LLDB would truncate summaries for string types without producing any evidence thereof Modified: lldb/trunk/include/lldb/Core/ValueObject.h

[Lldb-commits] [lldb] r252012 - Fix __fp16 types so we can display them and use them in expressions.

2015-11-03 Thread Greg Clayton via lldb-commits
Author: gclayton Date: Tue Nov 3 17:23:22 2015 New Revision: 252012 URL: http://llvm.org/viewvc/llvm-project?rev=252012&view=rev Log: Fix __fp16 types so we can display them and use them in expressions. I am not adding a test case for this since I don't know how portable the __fp16 type is betw

[Lldb-commits] [lldb] r252013 - All instance variables start with "m_". Fix "options" to be "m_options".

2015-11-03 Thread Greg Clayton via lldb-commits
Author: gclayton Date: Tue Nov 3 17:23:59 2015 New Revision: 252013 URL: http://llvm.org/viewvc/llvm-project?rev=252013&view=rev Log: All instance variables start with "m_". Fix "options" to be "m_options". Modified: lldb/trunk/include/lldb/DataFormatters/ValueObjectPrinter.h lldb/trunk

Re: [Lldb-commits] [PATCH] D13819: LLDBStandalone: Report nice errors on missing vars

2015-11-03 Thread Bruce Mitchener via lldb-commits
brucem added a comment. This looks reasonable to me as well, but I also have never built standalone. http://reviews.llvm.org/D13819 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r252007 - Fix build for go parser unittest.

2015-11-03 Thread Ryan Brown via lldb-commits
Author: ribrdb Date: Tue Nov 3 16:46:37 2015 New Revision: 252007 URL: http://llvm.org/viewvc/llvm-project?rev=252007&view=rev Log: Fix build for go parser unittest. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj lldb/trunk/unittests/Expression/GoParserTest.cpp Modified: lldb/trunk

[Lldb-commits] [lldb] r252005 - Fix a deadlock when connecting to a remote GDB server that might not support all packets that lldb-server or debugserver supports. The issue was the m_last_stop_packet_

2015-11-03 Thread Greg Clayton via lldb-commits
Author: gclayton Date: Tue Nov 3 16:42:04 2015 New Revision: 252005 URL: http://llvm.org/viewvc/llvm-project?rev=252005&view=rev Log: Fix a deadlock when connecting to a remote GDB server that might not support all packets that lldb-server or debugserver supports. The issue was the m_last_stop_

[Lldb-commits] [lldb] r252001 - With the new modules debugging, we have seen cases where clang is not emitting full definitions for types that are member variables of classes. If we try to make a clas

2015-11-03 Thread Greg Clayton via lldb-commits
Author: gclayton Date: Tue Nov 3 16:40:07 2015 New Revision: 252001 URL: http://llvm.org/viewvc/llvm-project?rev=252001&view=rev Log: With the new modules debugging, we have seen cases where clang is not emitting full definitions for types that are member variables of classes. If we try to make

[Lldb-commits] [lldb] r251997 - Revert change comitted in accidentally as r251992

2015-11-03 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Tue Nov 3 16:31:50 2015 New Revision: 251997 URL: http://llvm.org/viewvc/llvm-project?rev=251997&view=rev Log: Revert change comitted in accidentally as r251992 Modified: lldb/trunk/source/Symbol/Symtab.cpp Modified: lldb/trunk/source/Symbol/Symtab.cpp URL: http:/

[Lldb-commits] [lldb] r251993 - Use std::list::splice in TaskPool to avoid an allocation

2015-11-03 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Tue Nov 3 16:29:20 2015 New Revision: 251993 URL: http://llvm.org/viewvc/llvm-project?rev=251993&view=rev Log: Use std::list::splice in TaskPool to avoid an allocation Using std::list::splice to move an element from one list to an other avoids the allocation of a new el

[Lldb-commits] [lldb] r251992 - wip

2015-11-03 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Tue Nov 3 16:29:16 2015 New Revision: 251992 URL: http://llvm.org/viewvc/llvm-project?rev=251992&view=rev Log: wip Modified: lldb/trunk/source/Symbol/Symtab.cpp Modified: lldb/trunk/source/Symbol/Symtab.cpp URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/sourc

Re: [Lldb-commits] [PATCH] D13819: LLDBStandalone: Report nice errors on missing vars

2015-11-03 Thread Greg Clayton via lldb-commits
clayborg resigned from this revision. clayborg edited reviewers, added: tfiala; removed: clayborg. clayborg added a comment. I don't build cmake either, I am probably not a great person to ask. Todd Fiala might be a good person. http://reviews.llvm.org/D13819

[Lldb-commits] [lldb] r251983 - Python 3 - Fix checking of string types in unittest2 module.

2015-11-03 Thread Zachary Turner via lldb-commits
Author: zturner Date: Tue Nov 3 15:37:42 2015 New Revision: 251983 URL: http://llvm.org/viewvc/llvm-project?rev=251983&view=rev Log: Python 3 - Fix checking of string types in unittest2 module. This patch actually introduces a dependency from unittest2 to six. This should be ok since both packa

[Lldb-commits] [lldb] r251982 - Introduce seven.cmp_ and use it instead of cmp

2015-11-03 Thread Zachary Turner via lldb-commits
Author: zturner Date: Tue Nov 3 15:37:27 2015 New Revision: 251982 URL: http://llvm.org/viewvc/llvm-project?rev=251982&view=rev Log: Introduce seven.cmp_ and use it instead of cmp Modified: lldb/trunk/packages/Python/lldbsuite/support/seven.py lldb/trunk/packages/Python/lldbsuite/test/do

Re: [Lldb-commits] [PATCH] D13816: Fix a some silly warnings

2015-11-03 Thread Ramkumar Ramachandra via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL251979: Squelch a silly warning regarding an extra 'default' in 'case' (authored by artagnon). Changed prior to commit: http://reviews.llvm.org/D13816?vs=37611&id=39111#toc Repository: rL LLVM http:

[Lldb-commits] [lldb] r251979 - Squelch a silly warning regarding an extra 'default' in 'case'

2015-11-03 Thread Ramkumar Ramachandra via lldb-commits
Author: artagnon Date: Tue Nov 3 15:29:52 2015 New Revision: 251979 URL: http://llvm.org/viewvc/llvm-project?rev=251979&view=rev Log: Squelch a silly warning regarding an extra 'default' in 'case' Let the editor also clean up whitespace for that file. Reviewers: clayborg Subscribers: lldb-comm

[Lldb-commits] [lldb] r251978 - Python 3 - Fix some issues in unittest2.

2015-11-03 Thread Zachary Turner via lldb-commits
Author: zturner Date: Tue Nov 3 15:02:00 2015 New Revision: 251978 URL: http://llvm.org/viewvc/llvm-project?rev=251978&view=rev Log: Python 3 - Fix some issues in unittest2. unittest2 was using print statements in a few places, and also using the `cmp` function (which is removed in Python 3). A

[Lldb-commits] [lldb] r251977 - Python 3: Modernize exception raising syntax.

2015-11-03 Thread Zachary Turner via lldb-commits
Author: zturner Date: Tue Nov 3 15:01:45 2015 New Revision: 251977 URL: http://llvm.org/viewvc/llvm-project?rev=251977&view=rev Log: Python 3: Modernize exception raising syntax. Old-style: `raise foo, bar` New-style: `raise foo(bar)` These two statements are equivalent, but the former is an er

[Lldb-commits] [lldb] r251968 - Python 3 - modernize exception catching syntax.

2015-11-03 Thread Zachary Turner via lldb-commits
Author: zturner Date: Tue Nov 3 13:49:05 2015 New Revision: 251968 URL: http://llvm.org/viewvc/llvm-project?rev=251968&view=rev Log: Python 3 - modernize exception catching syntax. Old-style syntax: `except Exception, e:` New-style syntax: `except Exception as e:` These two statements are ide

[Lldb-commits] [lldb] r251959 - Python 3 - Don't use `commands` module anymore.

2015-11-03 Thread Zachary Turner via lldb-commits
Author: zturner Date: Tue Nov 3 12:55:22 2015 New Revision: 251959 URL: http://llvm.org/viewvc/llvm-project?rev=251959&view=rev Log: Python 3 - Don't use `commands` module anymore. The `commands` module was deprecated in 2.7 and removed in 3.x. As a workaround, we introduce a new module `seven`

[Lldb-commits] [lldb] r251956 - Revert r251882 as it breaks the test suite

2015-11-03 Thread Enrico Granata via lldb-commits
Author: enrico Date: Tue Nov 3 12:35:17 2015 New Revision: 251956 URL: http://llvm.org/viewvc/llvm-project?rev=251956&view=rev Log: Revert r251882 as it breaks the test suite Modified: lldb/trunk/source/Host/macosx/Host.mm Modified: lldb/trunk/source/Host/macosx/Host.mm URL: http://llvm.or

[Lldb-commits] [lldb] r251954 - Fix flakyness in TestWatchLocationWithWatchSet

2015-11-03 Thread Pavel Labath via lldb-commits
Author: labath Date: Tue Nov 3 12:17:21 2015 New Revision: 251954 URL: http://llvm.org/viewvc/llvm-project?rev=251954&view=rev Log: Fix flakyness in TestWatchLocationWithWatchSet Two threads in the test can hit the watchpoint simultaneously. Fix the test to account for that. Modified: lld

[Lldb-commits] [lldb] r251951 - Skip TestBacktraceAll on android-arm

2015-11-03 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Tue Nov 3 12:03:47 2015 New Revision: 251951 URL: http://llvm.org/viewvc/llvm-project?rev=251951&view=rev Log: Skip TestBacktraceAll on android-arm The android compiler can't compile the inferior because of an issue in the standard library. Modified: lldb/trunk/pa

[Lldb-commits] [lldb] r251950 - Leave TestAttachResume as flakey on linux

2015-11-03 Thread Pavel Labath via lldb-commits
Author: labath Date: Tue Nov 3 11:33:31 2015 New Revision: 251950 URL: http://llvm.org/viewvc/llvm-project?rev=251950&view=rev Log: Leave TestAttachResume as flakey on linux there must be (at least) one more race hidden there... Modified: lldb/trunk/packages/Python/lldbsuite/test/functiona

Re: [Lldb-commits] [PATCH] D14201: Fix race during process detach

2015-11-03 Thread Pavel Labath via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL251932: Fix race during process detach (authored by labath). Changed prior to commit: http://reviews.llvm.org/D14201?vs=38806&id=39068#toc Repository: rL LLVM http://reviews.llvm.org/D14201 Files:

[Lldb-commits] [lldb] r251932 - Fix race during process detach

2015-11-03 Thread Pavel Labath via lldb-commits
Author: labath Date: Tue Nov 3 10:05:18 2015 New Revision: 251932 URL: http://llvm.org/viewvc/llvm-project?rev=251932&view=rev Log: Fix race during process detach Summary: The code which was preventing the usage of the OS plugin while detach is in progress also prevented us to update the thread

Re: [Lldb-commits] [PATCH] Fix for PR25300

2015-11-03 Thread Pavel Labath via lldb-commits
Hi, Looks good, but I'd like to avoid adding new "not remote ready" tests to the test suite. Your test looks like it should be easy to fix -- the only problem there is the stdout redirection. If you *don't* redirect the output, you should be able to access the stdout via self.process.GetSTDOUT() a

Re: [Lldb-commits] [lldb] r251917 - Changes for Bug 25251

2015-11-03 Thread Pavel Labath via lldb-commits
Hi, in the future, please add "lldb-commits" as a subscriber when you are having your patches reviewed. pl On 3 November 2015 at 06:24, Ravitheja Addepally via lldb-commits wrote: > Author: ravitheja > Date: Tue Nov 3 08:24:24 2015 > New Revision: 251917 > > URL: http://llvm.org/viewvc/llvm-p

Re: [Lldb-commits] [PATCH] D14118: Changes for Bug 17384

2015-11-03 Thread Ravitheja Addepally via lldb-commits
ravitheja added a comment. Hello, I tried making an instance on GCE but it asks for a credit card information which I unfortunately don’t have. Can you provide me maybe access through some other way ? btw I checked the logs u sent me and the vdso is being loaded but the unwinding till m

[Lldb-commits] [lldb] r251917 - Changes for Bug 25251

2015-11-03 Thread Ravitheja Addepally via lldb-commits
Author: ravitheja Date: Tue Nov 3 08:24:24 2015 New Revision: 251917 URL: http://llvm.org/viewvc/llvm-project?rev=251917&view=rev Log: Changes for Bug 25251 Summary: The solution to bug 24074,rL249673 needed to parse the function information from the Dwarf in order to set the SymbolContext. For

Re: [Lldb-commits] [lldb] r239007 - [lldb] Enable building with Cmake/BUILD_SHARED_LIBS

2015-11-03 Thread Andrew Wilkins via lldb-commits
Thanks, Zachary, I'll look into it. Cheers, Andrew On Tue, 3 Nov 2015 6:18 am Zachary Turner wrote: > Resending to the correct mailing list. > > > On Mon, Nov 2, 2015 at 2:17 PM Zachary Turner wrote: > >> Hi Andrew, >> >> This CL has been in for quite a while, but apparently it was broken all

Re: [Lldb-commits] [PATCH] D13859: [LLDB][LLGS Test] Check length of register, only when its available

2015-11-03 Thread Mohit Bhakkad via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL251906: [LLDB][MIPS] Fix GetUserRegisterInfoCount to count no of regs which are… (authored by mohit.bhakkad). Changed prior to commit: http://reviews.llvm.org/D13859?vs=38785&id=39037#toc Repository:

[Lldb-commits] [lldb] r251906 - [LLDB][MIPS] Fix GetUserRegisterInfoCount to count no of regs which are physically present

2015-11-03 Thread Mohit K. Bhakkad via lldb-commits
Author: mohit.bhakkad Date: Tue Nov 3 03:13:45 2015 New Revision: 251906 URL: http://llvm.org/viewvc/llvm-project?rev=251906&view=rev Log: [LLDB][MIPS] Fix GetUserRegisterInfoCount to count no of regs which are physically present Reviewers: clayborg, labath. Subscribers: jaydeep, bhushan, sagar

Re: [Lldb-commits] [PATCH] D13296: [LLDB] Fix watchpoint ignore feature for architectures with watchpoint_exceptions_received=before

2015-11-03 Thread Mohit Bhakkad via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL251905: [LLDB][Watchpoint] Change ignore_count condition location to fix watchpoint… (authored by mohit.bhakkad). Changed prior to commit: http://reviews.llvm.org/D13296?vs=36119&id=39035#toc Repositor

[Lldb-commits] [lldb] r251905 - [LLDB][Watchpoint] Change ignore_count condition location to fix watchpoint ignore feature for architectures with watchpoint_exceptions_received=before

2015-11-03 Thread Mohit K. Bhakkad via lldb-commits
Author: mohit.bhakkad Date: Tue Nov 3 03:04:33 2015 New Revision: 251905 URL: http://llvm.org/viewvc/llvm-project?rev=251905&view=rev Log: [LLDB][Watchpoint] Change ignore_count condition location to fix watchpoint ignore feature for architectures with watchpoint_exceptions_received=before Revi