[Lldb-commits] [PATCH] D15326: Rework breakpoint language filtering to use the symbol context's language.

2015-12-07 Thread Dawn Perchik via lldb-commits
dawn created this revision. dawn added a reviewer: jingham. dawn added a subscriber: lldb-commits. dawn set the repository for this revision to rL LLVM. This patch reworks the breakpoint filter-by-language patch to use the symbol context instead of trying to guess the language solely from the sym

[Lldb-commits] [lldb] r255005 - [LLDB][MIPS] Handle PIC calling convention for MIPS32

2015-12-07 Thread Bhushan D. Attarde via lldb-commits
Author: bhushan.attarde Date: Tue Dec 8 00:05:57 2015 New Revision: 255005 URL: http://llvm.org/viewvc/llvm-project?rev=255005&view=rev Log: [LLDB][MIPS] Handle PIC calling convention for MIPS32 SUMMARY: - PrepareTrivialCall() to setup register r25 with the address of function to be

Re: [Lldb-commits] [PATCH] D15318: Get rid of global variables in dotest.py

2015-12-07 Thread Zachary Turner via lldb-commits
To be clear, we explicitly set the LLDB_TEST environment variable as part of initialization, and it's now trying to read the value of the environment variable before it's been set. At least I think anyway, I'm going off of memory, don't have code in front of me. On Mon, Dec 7, 2015 at 9:58 PM Zac

Re: [Lldb-commits] [PATCH] D15318: Get rid of global variables in dotest.py

2015-12-07 Thread Zachary Turner via lldb-commits
zturner added a comment. To be clear, we explicitly set the LLDB_TEST environment variable as part of initialization, and it's now trying to read the value of the environment variable before it's been set. At least I think anyway, I'm going off of memory, don't have code in front of me. http://

Re: [Lldb-commits] [PATCH] D15318: Get rid of global variables in dotest.py

2015-12-07 Thread Zachary Turner via lldb-commits
zturner added a subscriber: zturner. zturner added a comment. Hmm, yea that code path only gets run on OSX. I think the problem is that I changed the order that happens in. It now happens right when you import `configuration` for the first time, and it used to happen explicitly in `main()`. So

Re: [Lldb-commits] [PATCH] D15318: Get rid of global variables in dotest.py

2015-12-07 Thread Zachary Turner via lldb-commits
Hmm, yea that code path only gets run on OSX. I think the problem is that I changed the order that happens in. It now happens right when you import `configuration` for the first time, and it used to happen explicitly in `main()`. So maybe just make that function public, and call in the same plac

Re: [Lldb-commits] [PATCH] D15318: Get rid of global variables in dotest.py

2015-12-07 Thread Todd Fiala via lldb-commits
tfiala added a comment. Here's what I'm seeing so far (as of r254983) when running on OS X: $ test/dotest.py --results-formatter lldbsuite.test.basic_results_formatter.BasicResultsFormatter Traceback (most recent call last): File "test/dotest.py", line 6, in import lldbsuite.test

Re: [Lldb-commits] [lldb] r254979 - Refactor ResultsFormatter creation into result_formatter.

2015-12-07 Thread Zachary Turner via lldb-commits
I'll hold off a bit on major changes for now. I'm going to start working on non-controversial command line options tomorrow, but no more major code moves. I worked on this today since I wanted to get final agreement on the command line options first. On Mon, Dec 7, 2015 at 9:21 PM Todd Fiala wr

Re: [Lldb-commits] [PATCH] D15318: Get rid of global variables in dotest.py

2015-12-07 Thread Todd Fiala via lldb-commits
tfiala accepted this revision. tfiala added a comment. This revision is now accepted and ready to land. Yep, sounds good. I saw it go in. I'll do a couple runs here but I'm sure we'll fix up anything if something breaks. I much prefer to get it in :-) http://reviews.llvm.org/D15318 __

Re: [Lldb-commits] [lldb] r254946 - Rename test_results.py to result_formatter.py.

2015-12-07 Thread Todd Fiala via lldb-commits
Yep all good. We'll get to it soon enough. On Mon, Dec 7, 2015 at 4:30 PM, Zachary Turner wrote: > Yea, that actually came up on my radar too, but when I tried to do more > things at once it started turning into a rats nest. Refactoring Python is > kind of hard so I want to make the changes as

Re: [Lldb-commits] [lldb] r254979 - Refactor ResultsFormatter creation into result_formatter.

2015-12-07 Thread Todd Fiala via lldb-commits
(We're highly intersecting right now - I've got some other goo that I figured I'd hold off on since I'm sure we're hitting the same files). On Mon, Dec 7, 2015 at 9:21 PM, Todd Fiala wrote: > Yep sure thing. > > On Mon, Dec 7, 2015 at 5:00 PM, Zachary Turner wrote: > >> I'm going to have to mer

Re: [Lldb-commits] [lldb] r254979 - Refactor ResultsFormatter creation into result_formatter.

2015-12-07 Thread Todd Fiala via lldb-commits
Yep sure thing. On Mon, Dec 7, 2015 at 5:00 PM, Zachary Turner wrote: > I'm going to have to merge this into my patch. Can you hold off on any > other patches until I get in? > > On Mon, Dec 7, 2015 at 4:56 PM Todd Fiala via lldb-commits < > lldb-commits@lists.llvm.org> wrote: > >> Author: tfia

[Lldb-commits] [lldb] r254983 - Move LLDBTestResult class to its own module.

2015-12-07 Thread Zachary Turner via lldb-commits
Author: zturner Date: Mon Dec 7 19:15:44 2015 New Revision: 254983 URL: http://llvm.org/viewvc/llvm-project?rev=254983&view=rev Log: Move LLDBTestResult class to its own module. Added: lldb/trunk/packages/Python/lldbsuite/test/test_result.py Modified: lldb/trunk/packages/Python/lldbsuite

Re: [Lldb-commits] [PATCH] D15318: Get rid of global variables in dotest.py

2015-12-07 Thread Zachary Turner via lldb-commits
zturner added a comment. This is mostly mechanical, and since it looks like we have 2 people making big changes at the same time I'll go ahead and put this in so we don't step on each others' toes. But feel free to revert if this breaks anything. If you do experience any errors, it is most li

[Lldb-commits] [lldb] r254980 - Trying to submit 254476 one more time. This implement -gmodule debugging support.

2015-12-07 Thread Greg Clayton via lldb-commits
Author: gclayton Date: Mon Dec 7 19:02:08 2015 New Revision: 254980 URL: http://llvm.org/viewvc/llvm-project?rev=254980&view=rev Log: Trying to submit 254476 one more time. This implement -gmodule debugging support. It was previously reverted due to issues that showed up only on linux. I was a

Re: [Lldb-commits] [lldb] r254979 - Refactor ResultsFormatter creation into result_formatter.

2015-12-07 Thread Zachary Turner via lldb-commits
I'm going to have to merge this into my patch. Can you hold off on any other patches until I get in? On Mon, Dec 7, 2015 at 4:56 PM Todd Fiala via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: tfiala > Date: Mon Dec 7 18:53:56 2015 > New Revision: 254979 > > URL: http://llvm.org/

[Lldb-commits] [lldb] r254979 - Refactor ResultsFormatter creation into result_formatter.

2015-12-07 Thread Todd Fiala via lldb-commits
Author: tfiala Date: Mon Dec 7 18:53:56 2015 New Revision: 254979 URL: http://llvm.org/viewvc/llvm-project?rev=254979&view=rev Log: Refactor ResultsFormatter creation into result_formatter. This cleans up dotest.py and is a pre-step for getting the test inferior runner to send post-inferior run

[Lldb-commits] [PATCH] D15318: Get rid of global variables in dotest.py

2015-12-07 Thread Zachary Turner via lldb-commits
zturner created this revision. zturner added reviewers: tfiala, clayborg. zturner added a subscriber: lldb-commits. Herald added subscribers: srhines, danalbert, tberghammer. Since this is a big patch, you may just want to apply it locally and verify that nothing breaks. I've tested both the old

[Lldb-commits] Buildbot numbers for week of 11/29/2015 - 12/05/2015

2015-12-07 Thread Galina Kistanova via lldb-commits
Hello everyone, Below are some buildbot numbers for the last week of 11/29/2015 - 12/05/2015. Thanks Galina Top 10 fastest builders(not docs): lldb-amd64-ninja-freebsd11 clang-bpf-build llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast libomp-gcc-x86_64-linux-debian sanitizer-windows llvm-hex

Re: [Lldb-commits] [lldb] r254946 - Rename test_results.py to result_formatter.py.

2015-12-07 Thread Zachary Turner via lldb-commits
Yea, that actually came up on my radar too, but when I tried to do more things at once it started turning into a rats nest. Refactoring Python is kind of hard so I want to make the changes as small as possible that if anything breaks, bisecting will narrow the problem down as much as possible. On

Re: [Lldb-commits] [PATCH] D15312: Fix scope-based lookup when more than one function is found.

2015-12-07 Thread Greg Clayton via lldb-commits
clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. So one of two things needs to happen here: - ClangASTContext::DeclContextCountDeclLevels() becomes a function that is on ClangASTContext only and the opaque arguments get changed

Re: [Lldb-commits] [lldb] r254946 - Rename test_results.py to result_formatter.py.

2015-12-07 Thread Todd Fiala via lldb-commits
This is okay, but I was planning on breaking that out into multiple files. Right now the test_results module also has the EventBuilder in it, which is not a results formatter. But we can break that out separately. On Mon, Dec 7, 2015 at 1:23 PM, Zachary Turner via lldb-commits < lldb-commits@list

Re: [Lldb-commits] [PATCH] D15312: Fix scope-based lookup when more than one function is found.

2015-12-07 Thread Dawn Perchik via lldb-commits
dawn updated this revision to Diff 42115. dawn added a comment. Updated patch to removed change related to Pascal language - it should be part of a separate patch. Repository: rL LLVM http://reviews.llvm.org/D15312 Files: include/lldb/Symbol/ClangASTContext.h include/lldb/Symbol/GoASTCo

[Lldb-commits] [PATCH] D15312: Fix scope-based lookup when more than one function is found.

2015-12-07 Thread Dawn Perchik via lldb-commits
dawn created this revision. dawn added reviewers: paulherman, clayborg, granata.enrico. dawn added a subscriber: lldb-commits. dawn set the repository for this revision to rL LLVM. When multiple functions are found by name, lldb removes duplicate entries of functions with the same type, so the fi

Re: [Lldb-commits] [PATCH] D15263: Add NetBSD in platform specific logging of the specified category in RegisterCommandsTestCase()

2015-12-07 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. Thank you! Repository: rL LLVM http://reviews.llvm.org/D15263 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D15262: Add initial NetBSD support in lldbsuite/test/lldbtest.py

2015-12-07 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. Thank you! Repository: rL LLVM http://reviews.llvm.org/D15262 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D15260: getwd(3) with NULL pointer extension is supported on NetBSD

2015-12-07 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. Thank you! Repository: rL LLVM http://reviews.llvm.org/D15260 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D15261: Return gmake as the default name for GNU make on NetBSD

2015-12-07 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. Thank you! Repository: rL LLVM http://reviews.llvm.org/D15261 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r254949 - Add NetBSD in platform specific logging of the specified category in RegisterCommandsTestCase()

2015-12-07 Thread Kamil Rytarowski via lldb-commits
Author: kamil Date: Mon Dec 7 15:26:56 2015 New Revision: 254949 URL: http://llvm.org/viewvc/llvm-project?rev=254949&view=rev Log: Add NetBSD in platform specific logging of the specified category in RegisterCommandsTestCase() Summary: NetBSD soon will reuse this feature while running tests. R

[Lldb-commits] [lldb] r254948 - Add initial NetBSD support in lldbsuite/test/lldbtest.py

2015-12-07 Thread Kamil Rytarowski via lldb-commits
Author: kamil Date: Mon Dec 7 15:25:57 2015 New Revision: 254948 URL: http://llvm.org/viewvc/llvm-project?rev=254948&view=rev Log: Add initial NetBSD support in lldbsuite/test/lldbtest.py Summary: Add new functions: - expectedFailureNetBSD() - expectedFlakeyNetBSD() - skipIfNetBSD() Add

[Lldb-commits] [lldb] r254947 - Return gmake as the default name for GNU make on NetBSD

2015-12-07 Thread Kamil Rytarowski via lldb-commits
Author: kamil Date: Mon Dec 7 15:24:25 2015 New Revision: 254947 URL: http://llvm.org/viewvc/llvm-project?rev=254947&view=rev Log: Return gmake as the default name for GNU make on NetBSD Summary: The base make(1) on NetBSD is BSD make. In the default installation of NetBSD GNU make comes via pk

[Lldb-commits] [lldb] r254946 - Rename test_results.py to result_formatter.py.

2015-12-07 Thread Zachary Turner via lldb-commits
Author: zturner Date: Mon Dec 7 15:23:41 2015 New Revision: 254946 URL: http://llvm.org/viewvc/llvm-project?rev=254946&view=rev Log: Rename test_results.py to result_formatter.py. There is already a class called LLDBTestResults which I would like to move into a separate file, but the most approp

[Lldb-commits] [lldb] r254944 - getwd(3) with NULL pointer extension is supported on NetBSD

2015-12-07 Thread Kamil Rytarowski via lldb-commits
Author: kamil Date: Mon Dec 7 15:21:12 2015 New Revision: 254944 URL: http://llvm.org/viewvc/llvm-project?rev=254944&view=rev Log: getwd(3) with NULL pointer extension is supported on NetBSD Summary: The getwd() and getcwd() functions conform to IEEE Std 1003.1-1990 (POSIX.1). The IEEE Std 1003

[Lldb-commits] [lldb] r254941 - Allow variable names to be quoted with -var-list-children

2015-12-07 Thread Chuck Ries via lldb-commits
Author: chuckr Date: Mon Dec 7 14:43:52 2015 New Revision: 254941 URL: http://llvm.org/viewvc/llvm-project?rev=254941&view=rev Log: Allow variable names to be quoted with -var-list-children Allow both '-var-list-children var0' and '-var-list-children "var0"' to be used with the -var-list-childr

[Lldb-commits] [lldb] r254931 - Fix watchpoint check to use watchpoint ranges

2015-12-07 Thread Ted Woodward via lldb-commits
Author: ted Date: Mon Dec 7 13:38:58 2015 New Revision: 254931 URL: http://llvm.org/viewvc/llvm-project?rev=254931&view=rev Log: Fix watchpoint check to use watchpoint ranges Summary: Watchpoints, unlike breakpoints, have an address range. This patch changes WatchpointList::FindByAddress() to m

[Lldb-commits] [lldb] r254924 - test commit.

2015-12-07 Thread Chuck Ries via lldb-commits
Author: chuckr Date: Mon Dec 7 13:08:15 2015 New Revision: 254924 URL: http://llvm.org/viewvc/llvm-project?rev=254924&view=rev Log: test commit. Modified: lldb/trunk/tools/lldb-mi/MIExtensions.txt Modified: lldb/trunk/tools/lldb-mi/MIExtensions.txt URL: http://llvm.org/viewvc/llvm-project/

Re: [Lldb-commits] [PATCH] D14952: Modify "platform connect" to connect to processes as well

2015-12-07 Thread Tamas Berghammer via lldb-commits
tberghammer added inline comments. Comment at: source/Commands/CommandObjectPlatform.cpp:414-419 @@ -413,1 +413,8 @@ + + platform_sp->ConnectToWaitingProcesses(m_interpreter.GetDebugger(), error); +if (error.Fail()) +{ +

Re: [Lldb-commits] [PATCH] D14952: Modify "platform connect" to connect to processes as well

2015-12-07 Thread Greg Clayton via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good, just check me inline comment and make changes if you think you need to. Comment at: source/Commands/CommandObjectPlatform.cpp:414-419 @@ -413,1 +413,8 @@ + +

[Lldb-commits] LLVM buildmaster outage during the weekend

2015-12-07 Thread Galina Kistanova via lldb-commits
Hello everyone, There was LLVM buildmaster outage during the weekend. Sorry about this. It seems llvm lab outgrow consumer-grade router and should be updated later or sooner. I will look more at this what could be done about this. Thanks Galina ___ lld

[Lldb-commits] [lldb] r254910 - [RenderScript] Mips64 allocations workaround

2015-12-07 Thread Ewan Crawford via lldb-commits
Author: ewancrawford Date: Mon Dec 7 07:50:32 2015 New Revision: 254910 URL: http://llvm.org/viewvc/llvm-project?rev=254910&view=rev Log: [RenderScript] Mips64 allocations workaround Workaround for Mips64 compiler bug by using function pointers to call functions for expression evaluation. This

Re: [Lldb-commits] [PATCH] D14952: Modify "platform connect" to connect to processes as well

2015-12-07 Thread Tamas Berghammer via lldb-commits
tberghammer added a comment. I can't move the functionality into Platform::ConnectRemote because to connect to a process we need a debugger instance while Platform::ConnectRemote is called in scenarios where we don't have access to it (from SBPlatform::ConnectRemote). To clean up the API I adde

Re: [Lldb-commits] [PATCH] D14952: Modify "platform connect" to connect to processes as well

2015-12-07 Thread Tamas Berghammer via lldb-commits
tberghammer updated this revision to Diff 42063. http://reviews.llvm.org/D14952 Files: docs/lldb-gdb-remote.txt include/lldb/Target/Platform.h packages/Python/lldbsuite/test/lldbtest.py packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py packages/Python/lldbsuite/tes

[Lldb-commits] [lldb] r254902 - Recommit "Fix race during process interruption"

2015-12-07 Thread Pavel Labath via lldb-commits
Author: labath Date: Mon Dec 7 06:36:52 2015 New Revision: 254902 URL: http://llvm.org/viewvc/llvm-project?rev=254902&view=rev Log: Recommit "Fix race during process interruption" This is a resubmit of r254403, see that commit's message for context. This fixes an issue in the original commit, w

Re: [Lldb-commits] [PATCH] D15152: Add a new option to Platform::LoadImage to install the image

2015-12-07 Thread Tamas Berghammer via lldb-commits
tberghammer added inline comments. Comment at: include/lldb/API/SBProcess.h:301-307 @@ +300,9 @@ + +// Load an image to the currently running process. +// If both local and remote image is specified then copy the local image to the remote image and +// then load it fr

Re: [Lldb-commits] [PATCH] D15152: Add a new option to Platform::LoadImage to install the image

2015-12-07 Thread Tamas Berghammer via lldb-commits
tberghammer updated this revision to Diff 42055. tberghammer added a comment. Update API documentation in SBProcess.h http://reviews.llvm.org/D15152 Files: include/lldb/API/SBProcess.h include/lldb/Target/Platform.h packages/Python/lldbsuite/test/functionalities/load_unload/TestLoadUnload

Re: [Lldb-commits] [PATCH] D15233: Make TestThreadStates more stable

2015-12-07 Thread Pavel Labath via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL254901: Make TestThreadStates more stable (authored by labath). Changed prior to commit: http://reviews.llvm.org/D15233?vs=41885&id=42044#toc Repository: rL LLVM http://reviews.llvm.org/D15233 File

[Lldb-commits] [lldb] r254901 - Make TestThreadStates more stable

2015-12-07 Thread Pavel Labath via lldb-commits
Author: labath Date: Mon Dec 7 05:09:14 2015 New Revision: 254901 URL: http://llvm.org/viewvc/llvm-project?rev=254901&view=rev Log: Make TestThreadStates more stable Summary: Because of the large number of XFAILs TestThreadStates has decayed quite a bit. This commit does the following: - remove

Re: [Lldb-commits] [PATCH] D13970: Add support for abstract domain sockets.

2015-12-07 Thread Pavel Labath via lldb-commits
labath closed this revision. labath added a comment. I believe this has landed a while back. http://reviews.llvm.org/D13970 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D15273: [LLDB][MIPS] Handle PIC calling convention for MIPS32

2015-12-07 Thread Bhushan Attarde via lldb-commits
bhushan created this revision. bhushan added a reviewer: clayborg. bhushan added subscribers: lldb-commits, nitesh.jain, sagar, mohit.bhakkad, jaydeep. bhushan set the repository for this revision to rL LLVM. This patch includes: 1. PrepareTrivialCall() to setup register r25 with the address of

Re: [Lldb-commits] [PATCH] D15241: Simplify TestThreadSpecificBreakpoint.py

2015-12-07 Thread Pavel Labath via lldb-commits
labath added a comment. In http://reviews.llvm.org/D15241#302942, @zturner wrote: > I don't have any examples, one of the linux guys might. But you can look at > the decorators at the top, which say this: > > @skipIfFreeBSD # test frequently times out or hangs > @expectedFailureFreeBSD('llv