sivachandra added a comment.
I should also mention that I did not implement the complete spec as I do not
know of any producer which produces all the flavors of the new spec.
http://reviews.llvm.org/D15437
___
lldb-commits mailing list
lldb-commits
sivachandra added a comment.
The dwo_test_method fails for the added test as I think there is some GCC bug
with the combination of -gsplit-dwarf and -g3.
http://reviews.llvm.org/D15437
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http:
sivachandra created this revision.
sivachandra added reviewers: clayborg, tberghammer, spyffe.
sivachandra added a subscriber: lldb-commits.
DWARF 5 proposes a reinvented .debug_macro section. This change follows
that spec.
Currently, only GCC produces the .debug_macro section and hence
the added
zturner added a comment.
It's not so much about the speed as it is about the general principle of
exercising as little functionality as possible within a given test. This way
when a test fails, you already know exactly what the problem is. When this
test fails, is it in the step that creates
amccarth added a comment.
Conceivably, you might want to create multiple dumps of the same inferior
stopped at different points. Having to update all these when you want to
change the inferior code becomes a more manual task.
http://reviews.llvm.org/D15435
_
amccarth added a comment.
It's a fair question, but I wonder if it's a bit premature.
The tests are still pretty speedy. This way it's easy to change
(update/improve) the test and the code in parallel and get immediate results.
(There is a checked-in mini dump in this same directory, but that
dawn added a comment.
ping?
Repository:
rL LLVM
http://reviews.llvm.org/D15326
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
dawn updated this revision to Diff 42476.
dawn added a comment.
Updated Clang-specific version of patch.
Repository:
rL LLVM
http://reviews.llvm.org/D15312
Files:
include/lldb/Symbol/ClangASTContext.h
packages/Python/lldbsuite/test/lang/cpp/namespace/Makefile
packages/Python/lldbsuite/
zturner added a comment.
Would it make sense to check in a minidump? I agree we should have at least
one test somewhere that creates a minidump and loads it up and verifies it can
do something. But by making every minidump test use that same flow, then if
that first test ever fails for whatev
amccarth created this revision.
amccarth added a reviewer: zturner.
amccarth added a subscriber: lldb-commits.
More mini dump tests to make sure we can see a stack with several levels and
inspect local variables.
http://reviews.llvm.org/D15435
Files:
packages/Python/lldbsuite/test/functionali
That probably got turned on by default by me on accident when I removed
some of the command line options that mucked with the verbosity setting.
Thanks!
On Thu, Dec 10, 2015 at 3:17 PM Todd Fiala via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Author: tfiala
> Date: Thu Dec 10 17:14:24 2
Author: tfiala
Date: Thu Dec 10 17:14:24 2015
New Revision: 255310
URL: http://llvm.org/viewvc/llvm-project?rev=255310&view=rev
Log:
test result details now print module.class.test_name in verbose mode.
And, turns off verbose mode by default. This must have been switched
on as the default when s
krytarowski added a comment.
Thanks!
Repository:
rL LLVM
http://reviews.llvm.org/D15374
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL255308: Add NetBSD support in the buildDriver and
buildLibrary routines (authored by kamil).
Changed prior to commit:
http://reviews.llvm.org/D15374?vs=42372&id=42467#toc
Repository:
rL LLVM
http://
Author: kamil
Date: Thu Dec 10 16:56:56 2015
New Revision: 255308
URL: http://llvm.org/viewvc/llvm-project?rev=255308&view=rev
Log:
Add NetBSD support in the buildDriver and buildLibrary routines
Summary: NetBSD is like FreeBSD and Linux in these routines.
Reviewers: clay.chang, tfiala, emaste,
zturner created this revision.
zturner added reviewers: labath, tberghammer.
zturner added a subscriber: lldb-commits.
I'm not sure if I did this right, but the end result of this CL is removal of
the -N command line option, and making people go through the categories system
instead.
http://rev
zturner updated this revision to Diff 42452.
zturner added a comment.
Actually remove the -N command line option as well.
http://reviews.llvm.org/D15428
Files:
packages/Python/lldbsuite/test/configuration.py
packages/Python/lldbsuite/test/dotest.py
packages/Python/lldbsuite/test/dotest_ar
Author: zturner
Date: Thu Dec 10 12:51:02 2015
New Revision: 255277
URL: http://llvm.org/viewvc/llvm-project?rev=255277&view=rev
Log:
Remove the --output-on-success command line argument from dotest.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/configuration.py
lldb/trunk/packages/
Author: zturner
Date: Thu Dec 10 12:52:09 2015
New Revision: 255280
URL: http://llvm.org/viewvc/llvm-project?rev=255280&view=rev
Log:
Remove the -y option from dotest.py.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/benchmarks/disassembly/TestDisassembly.py
lldb/trunk/packages/Py
Author: zturner
Date: Thu Dec 10 12:50:49 2015
New Revision: 255276
URL: http://llvm.org/viewvc/llvm-project?rev=255276&view=rev
Log:
Remove the -T option from dotest.py.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/configuration.py
lldb/trunk/packages/Python/lldbsuite/test/dotest.
Author: zturner
Date: Thu Dec 10 12:51:40 2015
New Revision: 255279
URL: http://llvm.org/viewvc/llvm-project?rev=255279&view=rev
Log:
Remove the -x option from dotest.py.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/benchmarks/frame_variable/TestFrameVariableResponse.py
lldb/trun
Author: zturner
Date: Thu Dec 10 12:51:21 2015
New Revision: 255278
URL: http://llvm.org/viewvc/llvm-project?rev=255278&view=rev
Log:
Remove deprecated command line options from dotest.py
Modified:
lldb/trunk/packages/Python/lldbsuite/test/dotest.py
lldb/trunk/packages/Python/lldbsuite/te
Author: zturner
Date: Thu Dec 10 12:50:32 2015
New Revision: 255275
URL: http://llvm.org/viewvc/llvm-project?rev=255275&view=rev
Log:
Remove -w option from dotest.py.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/dotest.py
lldb/trunk/packages/Python/lldbsuite/test/dotest_args.py
ted added a comment.
Oops! :-)
-
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux
Foundation Collaborative Project
http://reviews.llvm.org/D15422
___
lldb-commits mailing list
lldb-co
Author: ted
Date: Thu Dec 10 11:53:07 2015
New Revision: 255268
URL: http://llvm.org/viewvc/llvm-project?rev=255268&view=rev
Log:
Add Hexagon ABI to System Initialization
Summary: When the Hexagon ABI was added, it was inadvertently left out of
initialization/termination. This patch adds it.
Re
clayborg added a subscriber: clayborg.
clayborg added a comment.
I like the clang specific patch here better. Mainly because if you add a
function like this to TypeSystem.h:
virtual uint32_t
DeclContextCountDeclLevels (void *opaque_decl_ctx,
void *opaque_find_de
I like the clang specific patch here better. Mainly because if you add a
function like this to TypeSystem.h:
virtual uint32_t
DeclContextCountDeclLevels (void *opaque_decl_ctx,
void *opaque_find_decl_ctx,
ConstString *find_na
This revision was automatically updated to reflect the committed changes.
Closed by commit rL255260: Add modules downloaded by ModuleCache to the global
ModuleList (authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D15415?vs=42422&id=42433#toc
Repository:
rL LLVM
ht
Author: tberghammer
Date: Thu Dec 10 11:08:23 2015
New Revision: 255260
URL: http://llvm.org/viewvc/llvm-project?rev=255260&view=rev
Log:
Add modules downloaded by ModuleCache to the global ModuleList
Adding the modules to the global module list eleminate issues in the
case when a module is unloa
ovyalov accepted this revision.
ovyalov added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D15415
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/ll
EwanCrawford added a comment.
ping
Repository:
rL LLVM
http://reviews.llvm.org/D15116
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Hi Tamas,
Your right, sorry about that, I will be sure to add a commit message in
the future.
Thanks,
Aidan
On 10/12/2015 11:10, Tamas Berghammer wrote:
Hi Aidan,
Next time please add a commit message describing the change itself
(next to the review link). In general I think copying the re
tberghammer created this revision.
tberghammer added a reviewer: ovyalov.
tberghammer added a subscriber: lldb-commits.
Herald added subscribers: danalbert, tberghammer.
Add modules downloaded by ModuleCache to the global ModuleList
Adding the modules to the global module list eliminate issues in
Hi Aidan,
Next time please add a commit message describing the change itself (next to
the review link). In general I think copying the review title and the
summary into the commit message is a good baseline. It will help us
understand your change when somebody looking at git logs as we don't have
This revision was automatically updated to reflect the committed changes.
Closed by commit rL255240: Switch to gold linker on android x86, x86_64, arm
(authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D15379?vs=42295&id=42407#toc
Repository:
rL LLVM
http://reviews.
tberghammer added inline comments.
Comment at: cmake/platforms/Android.cmake:124
@@ -123,1 +123,3 @@
+# Use gold linker and enable safe ICF in case of x86, x86_64 and arm
+if ( ANDROID_ABI STREQUAL "x86"OR
ovyalov wrote:
> Just out of curiosity - you haven't
Author: tberghammer
Date: Thu Dec 10 05:02:51 2015
New Revision: 255240
URL: http://llvm.org/viewvc/llvm-project?rev=255240&view=rev
Log:
Switch to gold linker on android x86, x86_64, arm
These architectures already using the gold linker for the android
framework and switching to gold gives us th
Author: ewancrawford
Date: Thu Dec 10 04:20:39 2015
New Revision: 255238
URL: http://llvm.org/viewvc/llvm-project?rev=255238&view=rev
Log:
[RenderScript] Refactor condition deciding when to JIT RS runtime
Patch creates a member function that decides when to JIT all the details about
an allocatio
Author: aidandodds
Date: Thu Dec 10 04:11:49 2015
New Revision: 255237
URL: http://llvm.org/viewvc/llvm-project?rev=255237&view=rev
Log:
Differential Revision: http://reviews.llvm.org/D15333
Modified:
lldb/trunk/source/Core/DataExtractor.cpp
Modified: lldb/trunk/source/Core/DataExtractor.cpp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL255237: Differential Revision:
http://reviews.llvm.org/D15333 (authored by aidandodds).
Changed prior to commit:
http://reviews.llvm.org/D15333?vs=42167&id=42401#toc
Repository:
rL LLVM
http://revie
40 matches
Mail list logo
