[Lldb-commits] [PATCH] D16132: [LLDB][MIPS] Fix TestExprsChar.py

2016-01-12 Thread Nitesh Jain via lldb-commits
nitesh.jain created this revision. nitesh.jain added reviewers: clayborg, ovyalov. nitesh.jain added subscribers: jaydeep, bhushan, sagar, mohit.bhakkad, lldb-commits. nitesh.jain set the repository for this revision to rL LLVM. When incorrect type used for 'char' then (at least) one of the expre

[Lldb-commits] [lldb] r257569 - Add a small refinement to the qSymbol:: support in lldb.

2016-01-12 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Tue Jan 12 22:08:10 2016 New Revision: 257569 URL: http://llvm.org/viewvc/llvm-project?rev=257569&view=rev Log: Add a small refinement to the qSymbol:: support in lldb. This is a packet which allows the remote gdb stub to ask for the address of a symbol in the process. lldb

Re: [Lldb-commits] [PATCH] D16046: [LLDB][MIPS] Handle PIC calling convention for MIPS64

2016-01-12 Thread Bhushan Attarde via lldb-commits
bhushan closed this revision. bhushan added a comment. Closed by commit http://reviews.llvm.org/rL257441 Repository: rL LLVM http://reviews.llvm.org/D16046 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

Re: [Lldb-commits] [PATCH] D16051: [LLDB][MIPS] Merge emulation of similar instructions for MIPS64

2016-01-12 Thread Bhushan Attarde via lldb-commits
bhushan closed this revision. bhushan added a comment. Closed by commit http://reviews.llvm.org/rL257442 Repository: rL LLVM http://reviews.llvm.org/D16051 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

Re: [Lldb-commits] [PATCH] D16128: Fix TestProcessLaunch.test_environment_with_special_char for Python 3

2016-01-12 Thread Adrian McCarthy via lldb-commits
amccarth accepted this revision. amccarth added a comment. This revision is now accepted and ready to land. I don't know enough about SWIG to give that a thorough review. Comment at: source/Host/windows/ProcessLauncherWindows.cpp:38 @@ +37,3 @@ +cur_entry += strlen(cur_e

[Lldb-commits] [PATCH] D16128: Fix TestProcessLaunch.test_environment_with_special_char for Python 3

2016-01-12 Thread Zachary Turner via lldb-commits
zturner created this revision. zturner added a reviewer: amccarth. zturner added a subscriber: lldb-commits. There were a number of problems preventing this from working: 1. The SWIG typemaps for converting Python lists to and from C++ arrays were not updated for Python 3. So they

[Lldb-commits] [lldb] r257531 - [TestThreadJump] Adjust match sub-string after recent change.

2016-01-12 Thread Siva Chandra via lldb-commits
Author: sivachandra Date: Tue Jan 12 16:33:19 2016 New Revision: 257531 URL: http://llvm.org/viewvc/llvm-project?rev=257531&view=rev Log: [TestThreadJump] Adjust match sub-string after recent change. Reviewers: zturner Subscribers: zturner, lldb-commits Differential Revision: http://reviews.llv

Re: [Lldb-commits] [PATCH] D16125: [TestThreadJump] Adjust match sub-string after recent change.

2016-01-12 Thread Zachary Turner via lldb-commits
zturner accepted this revision. zturner added a comment. This revision is now accepted and ready to land. If this passes on your side, go ahead. Just from looking, I think it should pass on Windows. http://reviews.llvm.org/D16125 ___ lldb-commits

Re: [Lldb-commits] [PATCH] D16125: [TestThreadJump] Adjust match sub-string after recent change.

2016-01-12 Thread Siva Chandra via lldb-commits
sivachandra updated this revision to Diff 44674. sivachandra added a comment. Address comment http://reviews.llvm.org/D16125 Files: packages/Python/lldbsuite/test/functionalities/thread/jump/TestThreadJump.py Index: packages/Python/lldbsuite/test/functionalities/thread/jump/TestThreadJump.p

Re: [Lldb-commits] [PATCH] D16125: [TestThreadJump] Adjust match sub-string after recent change.

2016-01-12 Thread Zachary Turner via lldb-commits
This isn't going to work either, because Windows doesn't the name= portion. God I really hate these tests that do substring matching. I guess there's no easy way to guarantee that the main.cpp: is on the same frame as the breakpoint. Can you change it to: substrs = ['stopped', 'main.cpp:{}'

[Lldb-commits] [PATCH] D16125: [TestThreadJump] Adjust match sub-string after recent change.

2016-01-12 Thread Siva Chandra via lldb-commits
sivachandra created this revision. sivachandra added a reviewer: zturner. sivachandra added a subscriber: lldb-commits. http://reviews.llvm.org/D16125 Files: packages/Python/lldbsuite/test/functionalities/thread/jump/TestThreadJump.py Index: packages/Python/lldbsuite/test/functionalities/thre

Re: [Lldb-commits] [PATCH] D15527: Add ability to override JIT expr compiler options.

2016-01-12 Thread Luke Drummond via lldb-commits
ldrumm added a comment. In http://reviews.llvm.org/D15527#324919, @spyffe wrote: > I'm a little concerned that LanguageRuntime::GetOverrideExprOptions() appears > to generate a new set of options from whole cloth rather than using the > existing set as a starting point. > > Specifically, since

[Lldb-commits] [lldb] r257513 - Fix TestThreadJump on Windows.

2016-01-12 Thread Zachary Turner via lldb-commits
Author: zturner Date: Tue Jan 12 14:45:29 2016 New Revision: 257513 URL: http://llvm.org/viewvc/llvm-project?rev=257513&view=rev Log: Fix TestThreadJump on Windows. The system can create threads for a system threadpool, so there is no guarantee that the thread that is stopped is thread 1. So use

[Lldb-commits] [lldb] r257510 - Fix build breakage of r257502.

2016-01-12 Thread Stephane Sezer via lldb-commits
Author: sas Date: Tue Jan 12 14:22:58 2016 New Revision: 257510 URL: http://llvm.org/viewvc/llvm-project?rev=257510&view=rev Log: Fix build breakage of r257502. Modified: lldb/trunk/source/Plugins/DynamicLoader/POSIX-DYLD/DYLDRendezvous.cpp Modified: lldb/trunk/source/Plugins/DynamicLoader/P

Re: [Lldb-commits] [lldb] r257502 - Increase use of svr4 packets to improve performance on POSIX remotes

2016-01-12 Thread Stephane Sezer via lldb-commits
Looking at it now. On Tue, Jan 12, 2016 at 11:25 AM, Siva Chandra wrote: > This breaks the build: > http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-buildserver/builds/4487 > > On Tue, Jan 12, 2016 at 11:02 AM, Stephane Sezer via lldb-commits > wrote: >> Author: sas >> Date: Tue Jan 12

Re: [Lldb-commits] [PATCH] D16107: Fix for Bug 25338

2016-01-12 Thread Oleksiy Vyalov via lldb-commits
ovyalov added a comment. vdso issue is related to ELF format and I'm wondering whether we can keep the fix contained in ObjectFileELF - for example, if a section that we're trying to read is beyond the boundaries of memory buffer we can read its content from inferior's memory using ObjectFile::

[Lldb-commits] [lldb] r257502 - Increase use of svr4 packets to improve performance on POSIX remotes

2016-01-12 Thread Stephane Sezer via lldb-commits
Author: sas Date: Tue Jan 12 13:02:41 2016 New Revision: 257502 URL: http://llvm.org/viewvc/llvm-project?rev=257502&view=rev Log: Increase use of svr4 packets to improve performance on POSIX remotes Summary: Allows the remote to enumerate the link map when adding and removing shared libraries, so

Re: [Lldb-commits] [PATCH] D15527: Add ability to override JIT expr compiler options.

2016-01-12 Thread Sean Callanan via lldb-commits
spyffe added a comment. I'm a little concerned that LanguageRuntime::GetOverrideExprOptions() appears to generate a new set of options from whole cloth rather than using the existing set as a starting point. Specifically, since your use case is wanting to override the calling convention, I thi

Re: [Lldb-commits] [PATCH] D16107: Fix for Bug 25338

2016-01-12 Thread Tamas Berghammer via lldb-commits
tberghammer added a comment. Can we calculate the size of the object file based on elf headers and the section headers instead of using the /proc file system? I think a good algorithm would be to take the maximum of the following 2 expression: Start of section header + Number of section head

Re: [Lldb-commits] [PATCH] D16107: Fix for Bug 25338

2016-01-12 Thread Pavel Labath via lldb-commits
labath added a comment. In http://reviews.llvm.org/D16107#324594, @labath wrote: > Could you explain what is the nature of the failure in the vdso parsing? Strike that. I see that you have linked the bug # in the title... http://reviews.llvm.org/D16107 _

Re: [Lldb-commits] [PATCH] D16107: Fix for Bug 25338

2016-01-12 Thread Pavel Labath via lldb-commits
labath added a comment. Could you explain what is the nature of the failure in the vdso parsing? Otherwise it's quite hard to see what's the relationship of your patch to it, as it seems that the ObjectFile should be able to handle files which are not fully contained within the initial read (co

Re: [Lldb-commits] [PATCH] D15527: Add ability to override JIT expr compiler options.

2016-01-12 Thread Luke Drummond via lldb-commits
ldrumm requested a review of this revision. ldrumm added a comment. bump Comment at: source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp:85-97 @@ -83,1 +84,15 @@ +namespace { +void debugStringVector(Log *log, const std::vector& vec, const char *name) +{ +

[Lldb-commits] [lldb] r257469 - Try to fix the mips64 build after rL257447

2016-01-12 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Tue Jan 12 04:41:43 2016 New Revision: 257469 URL: http://llvm.org/viewvc/llvm-project?rev=257469&view=rev Log: Try to fix the mips64 build after rL257447 Modified: lldb/trunk/source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp Modified: lldb/trunk/

[Lldb-commits] [lldb] r257465 - Fix for TestNoreturnUnwind.py on i386

2016-01-12 Thread Ravitheja Addepally via lldb-commits
Author: ravitheja Date: Tue Jan 12 04:08:41 2016 New Revision: 257465 URL: http://llvm.org/viewvc/llvm-project?rev=257465&view=rev Log: Fix for TestNoreturnUnwind.py on i386 Summary: The testcase TestNoreturnUnwind.py was failing because the unwind from the vdso library was not successful for cla

[Lldb-commits] [lldb] r257460 - Add clang::Type::Pipe to ClangASTContext

2016-01-12 Thread Pavel Labath via lldb-commits
Author: labath Date: Tue Jan 12 02:51:28 2016 New Revision: 257460 URL: http://llvm.org/viewvc/llvm-project?rev=257460&view=rev Log: Add clang::Type::Pipe to ClangASTContext Summary: Clang recently added support for an OpenCL pipe type. Adding the new type to relevant switches to avoid warnings.

Re: [Lldb-commits] [PATCH] D16055: Add clang::Type::Pipe to ClangASTContext

2016-01-12 Thread Pavel Labath via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL257460: Add clang::Type::Pipe to ClangASTContext (authored by labath). Changed prior to commit: http://reviews.llvm.org/D16055?vs=44456&id=44607#toc Repository: rL LLVM http://reviews.llvm.org/D1605