bhushan closed this revision.
bhushan added a comment.
Closed by commit http://reviews.llvm.org/rL258485
Repository:
rL LLVM
http://reviews.llvm.org/D14111
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
Author: bhushan.attarde
Date: Thu Jan 21 23:02:02 2016
New Revision: 258485
URL: http://llvm.org/viewvc/llvm-project?rev=258485&view=rev
Log:
Use "_$" prefix instead of "$" for dynamic checker function inserted by LLDB
during expression evaluation
SUMMARY:
The symbol "$" has a specia
Author: eddyb
Date: Thu Jan 21 21:43:23 2016
New Revision: 258481
URL: http://llvm.org/viewvc/llvm-project?rev=258481&view=rev
Log:
[opaque pointer types] [NFC] Fix fallout from DataLayout::getIndexedOffset
changes (rL258478).
Modified:
lldb/trunk/source/Expression/IRInterpreter.cpp
Modifie
This revision was automatically updated to reflect the committed changes.
Closed by commit rL258448: Fix TestImport.py to work with Python 3.5. (authored
by amccarth).
Changed prior to commit:
http://reviews.llvm.org/D16431?vs=45600&id=45603#toc
Repository:
rL LLVM
http://reviews.llvm.org/D
Author: amccarth
Date: Thu Jan 21 17:07:48 2016
New Revision: 258448
URL: http://llvm.org/viewvc/llvm-project?rev=258448&view=rev
Log:
Fix TestImport.py to work with Python 3.5.
Differential Revision: http://reviews.llvm.org/D16431
Modified:
lldb/trunk/packages/Python/lldbsuite/test/functio
amccarth created this revision.
amccarth added a reviewer: zturner.
amccarth added a subscriber: lldb-commits.
In Python 3.5, import looks only in the official packages directory unless you
tell it otherwise. I tested with Python 2.7 as well.
http://reviews.llvm.org/D16431
Files:
packages/P
Author: gclayton
Date: Thu Jan 21 16:26:13 2016
New Revision: 258443
URL: http://llvm.org/viewvc/llvm-project?rev=258443&view=rev
Log:
Always try to read DW_TAG_typedef types from DWO files first if we can.
A lot of C code uses code like:
typedef struct
{
int a;
} FooType;
This c
ldrumm updated this revision to Diff 45588.
ldrumm added a comment.
Address @spyffe's previous suggestions regarding modifying target options in
place. This allows for a simpler and more maintainable solution than previously
implemented, and requires no extra datatype definitions.
- removed unn
So, I don't actually disagree that the idea of doing a "step and see if it
still works" is ok. Because I think that -- by itself -- is useful as an
additional check. I'm not against doing extra work in a test when it adds
something concretely useful to the test. So I still think we should reduce
Author: amccarth
Date: Thu Jan 21 15:10:00 2016
New Revision: 258433
URL: http://llvm.org/viewvc/llvm-project?rev=258433&view=rev
Log:
NFC. Corrects name of test class and a comment.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/signed_types/TestSignedTypes.py
Modified:
lld
Author: zturner
Date: Thu Jan 21 15:07:30 2016
New Revision: 258432
URL: http://llvm.org/viewvc/llvm-project?rev=258432&view=rev
Log:
Remove assumptions that thread 0 is always the main thread.
Starting with Windows 10, the Windows loader is itself multi-threaded,
meaning that the loader spins up
This revision was automatically updated to reflect the committed changes.
Closed by commit rL258432: Remove assumptions that thread 0 is always the main
thread. (authored by zturner).
Changed prior to commit:
http://reviews.llvm.org/D16247?vs=45302&id=45587#toc
Repository:
rL LLVM
http://re
This revision was automatically updated to reflect the committed changes.
Closed by commit rL258429: Add CalculateSymbolSizes in
ObjectFilePECOFF::GetSymtab to ensure that… (authored by amccarth).
Changed prior to commit:
http://reviews.llvm.org/D16415?vs=45560&id=45586#toc
Repository:
rL LL
Author: amccarth
Date: Thu Jan 21 14:58:12 2016
New Revision: 258429
URL: http://llvm.org/viewvc/llvm-project?rev=258429&view=rev
Log:
Add CalculateSymbolSizes in ObjectFilePECOFF::GetSymtab to ensure that (nearly)
all the symbols have sizes.
This fixes the `thread step-over` regression exposed
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
I just added PECOFF so I could make sure I had 3 clients for the ObjectFile
class when I was developing it and I already have the PECOFF support in the
previous tool I had written, so this
tfiala added a subscriber: emaste.
tfiala added a comment.
Hi Ed - not sure if freebsd still needs the set of expected timeout tests. If
you were to run with --rerun-all-issues, then all tests are eligible for a
rerun on the first failure/timeout/error/whatever. (expected failure- and the
exp
I'm not sure this is a terribly productive discussion.
Since I know that the debugger is stateful, when I write a test where I get to
point A and do thing X, I will often add - while I'm there - "step again and
see if it still works" or something morally equivalent to that. I have found
that
zturner added a comment.
Right, but I don't agree in this case that "different" has to mean "we
discourage the use of reduced test cases". I have a hard time imagining a
scenario where not having reduced test cases is an advantage. It's also
easy to explain to people. "Write reduced test cases"
Right, but I don't agree in this case that "different" has to mean "we
discourage the use of reduced test cases". I have a hard time imagining a
scenario where not having reduced test cases is an advantage. It's also
easy to explain to people. "Write reduced test cases". It's easy to
understand
tfiala created this revision.
tfiala added a reviewer: labath.
tfiala added a subscriber: lldb-commits.
As would happen if the test suite was given "--platform-name iso-simulator".
Also removes the expected timeouts for Darwin as these are now handled by
reruns.
http://reviews.llvm.org/D16423
> On Jan 21, 2016, at 10:17 AM, Zachary Turner wrote:
>
> zturner added a comment.
>
> Sure, an interface change to Process might break the mock, but it would break
> at compile time, you just fix it up. It's not something that would happen
> frequently, this is the same situation going on i
tberghammer added a comment.
Looks good to me and if Apple using this code then I am pretty sure my CL break
them as well. Having 0 size symbols around will cause a lot of issue around
LLDB.
http://reviews.llvm.org/D16415
___
lldb-commits mailing
zturner added a reviewer: clayborg.
zturner added a comment.
looks fine to me, but some Apple targets use PE, so +greg in case he can think
of a reason why this will mess up something on the Apple side.
http://reviews.llvm.org/D16415
___
lldb-commi
amccarth created this revision.
amccarth added reviewers: tberghammer, zturner.
amccarth added a subscriber: lldb-commits.
This fixes the nine tests that regressed on Windows after
http://reviews.llvm.org/D16186
http://reviews.llvm.org/D16415
Files:
source/Plugins/ObjectFile/PECOFF/ObjectFile
zturner added a comment.
Sure, an interface change to Process might break the mock, but it would break
at compile time, you just fix it up. It's not something that would happen
frequently, this is the same situation going on in LLVM where there are unit
tests, sometimes they break, and people
zturner added a comment.
Unfortunately that's not going to work. Because lldb libraries are not layered
very well, linking against any one library is going to cause a transitive link
dependency on every other library. I did a lot of work to improve that in
order to get the Python stuff separa
This revision was automatically updated to reflect the committed changes.
Closed by commit rL258414: Enable test log collection from remote debug servers
(authored by labath).
Changed prior to commit:
http://reviews.llvm.org/D16322?vs=45273&id=45553#toc
Repository:
rL LLVM
http://reviews.ll
Author: labath
Date: Thu Jan 21 11:54:14 2016
New Revision: 258414
URL: http://llvm.org/viewvc/llvm-project?rev=258414&view=rev
Log:
Enable test log collection from remote debug servers
Summary:
We already have the ability to collect the server logs when doing local
debugging. This enables
the c
spyffe accepted this revision.
spyffe added a comment.
This revision is now accepted and ready to land.
Thank you for that clarification. In that case, I think this patch is fine as
it is.
Repository:
rL LLVM
http://reviews.llvm.org/D14111
___
ldrumm created this revision.
ldrumm added reviewers: spyffe, jingham.
ldrumm added a subscriber: lldb-commits.
It looks like there's an unused variable in
`source/Plugins/Expression/Clang/IRForTarget.cpp` `std::string name` is
assigned the function name, then never used again.
;
There don't app
granata.enrico accepted this revision.
granata.enrico added a comment.
Yes, I believe so.
http://reviews.llvm.org/D15209
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala added inline comments.
Comment at: packages/Python/lldbsuite/test/lldbtest.py:1385-1386
@@ +1384,4 @@
+# This is executed on a best-effort basis. If the file is not
there, so be it.
+lldb.remote_platform.Get(lldb.SBFileSpec("server.log"),
+
labath added inline comments.
Comment at: packages/Python/lldbsuite/test/lldbtest.py:1385-1386
@@ +1384,4 @@
+# This is executed on a best-effort basis. If the file is not
there, so be it.
+lldb.remote_platform.Get(lldb.SBFileSpec("server.log"),
+
tfiala added a comment.
Can this be closed out?
http://reviews.llvm.org/D15209
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala added a comment.
Ready to close out?
http://reviews.llvm.org/D14937
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala added a comment.
Can this be closed out?
http://reviews.llvm.org/D14885
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala added a comment.
Can this be closed out?
http://reviews.llvm.org/D14896
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala added a comment.
Is this ready to close out?
http://reviews.llvm.org/D15162
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala added a comment.
Can this be closed out?
http://reviews.llvm.org/D15318
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.
Looks reasonable.
I added one question on whether we can get a warning on failure to retrieve the
server.log file when expecting one and it doesn't show up (perhaps only in
verbose mode), whi
tfiala added a comment.
Oops, this one slipped past me. Looking now!
http://reviews.llvm.org/D16322
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath added a comment.
Any thoughts? Objections? Indifference? :)
http://reviews.llvm.org/D16322
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath added a comment.
I think a similar command as for argdumper would fix this (probably
`target_link_libraries(lldb, lldbHost)`). I thought about doing that instead,
but then I realised that netbsd probably needs this as well, and lldb-mi seems
to be using getopt also, etc. So I figured I'l
labath updated this revision to Diff 45529.
labath added a comment.
Use private keyword for linux only
http://reviews.llvm.org/D16293
Files:
cmake/modules/AddLLDB.cmake
tools/argdumper/CMakeLists.txt
Index: tools/argdumper/CMakeLists.txt
tberghammer added a comment.
In http://reviews.llvm.org/D16334#331428, @zturner wrote:
> In http://reviews.llvm.org/D16334#331420, @tberghammer wrote:
>
> > In http://reviews.llvm.org/D16334#331368, @zturner wrote:
> >
> > > I don't know, I still disagree. If something in step-over breaks, I
>
Sorry for breaking the windows tests. I don't have a windows box to
investigate it but based on your description the regression is caused by my
CL while I believe the bug is in ObjectFilePECOFF (is it the one used on
Windows?).
The problem is that you have symbols with m_byte_size == 0 while calli
46 matches
Mail list logo
