[Lldb-commits] [lldb] r259003 - A while back in revison 244716 we added support for getting the host OS version info from debugserver. We added keys to "qHostInfo" that were "osmajor", "osminor" and "

Author: gclayton Date: Wed Jan 27 18:16:11 2016 New Revision: 259003 URL: http://llvm.org/viewvc/llvm-project?rev=259003=rev Log: A while back in revison 244716 we added support for getting the host OS version info from debugserver. We added keys to "qHostInfo" that were "osmajor", "osminor"

[Lldb-commits] [PATCH] D16662: [LLDB] Remove autoconf support from source directories

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: clayborg, labath, zturner. Eugene.Zelenko added a subscriber: lldb-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. Herald added subscribers: dsanders, srhines, danalbert, tberghammer, emaste. autoconf

Re: [Lldb-commits] [PATCH] D16615: Refactor some of the skip / xfail decorators to reuse more code.

tfiala accepted this revision. tfiala added a comment. This revision is now accepted and ready to land. In http://reviews.llvm.org/D16615#337359, @zturner wrote: > If the goal is to delete all the highly specialized decorators (after all, > expectedFailureWindows is just

Re: [Lldb-commits] [lldb] r258930 - Decorarte TestInferiorAssert xfails on AArch64 Linux

Hi Omair, Can you send me some logs about the failure you see for this test both on arm and aarch64 Linux? The test is passing reliably on android both for arm and aarch64 so I would like to understand what is the difference. Thanks, Tamas On Wed, Jan 27, 2016 at 2:01 PM Omair Javaid via

Re: [Lldb-commits] [PATCH] D16615: Refactor some of the skip / xfail decorators to reuse more code.

zturner added a subscriber: zturner. zturner added a comment. Yea so basically what it does is allow you to use the same decorator with arguments or without arguments. Like this: @expectedFailureWindows # Python actually calls expectedFailureWindows(func)

Re: [Lldb-commits] [PATCH] D16627: Add support to detect arm hard float ABI based binaries for ABISysV_arm

tberghammer accepted this revision. tberghammer added a comment. This revision is now accepted and ready to land. Looks good with a few nits inline Comment at: source/Plugins/ABI/SysV-arm/ABISysV_arm.cpp:418 @@ +417,3 @@ +bool +ABISysV_arm::IsArmHardFloat (Thread *thread) const

Re: [Lldb-commits] [PATCH] D16615: Refactor some of the skip / xfail decorators to reuse more code.

On Tue, Jan 26, 2016 at 5:43 PM, Zachary Turner wrote: > zturner updated this revision to Diff 46086. > zturner added a comment. > > Add back the check for `six.callable`. Also added a detailed comment > explaining what this atrocity actually does. > Yeah - I was thinking

Re: [Lldb-commits] [PATCH] D16615: Refactor some of the skip / xfail decorators to reuse more code.

Yea so basically what it does is allow you to use the same decorator with arguments or without arguments. Like this: @expectedFailureWindows # Python actually calls expectedFailureWindows(func) @expectedFailureWindows(debug_info='dwarf') # Python calls

[Lldb-commits] [lldb] r259027 - modify Xcode build to use cmake/ninja for internal llvm/clang

Author: tfiala Date: Thu Jan 28 01:36:44 2016 New Revision: 259027 URL: http://llvm.org/viewvc/llvm-project?rev=259027=rev Log: modify Xcode build to use cmake/ninja for internal llvm/clang This change restores the Xcode build to working after Makefile support was stripped from LLVM and clang

Re: [Lldb-commits] [lldb] r258921 - Fix linking with LLVM_LINK_LLVM_DYLIB=ON

Yea I think this is fine. On Wed, Jan 27, 2016 at 9:29 AM Hans Wennborg wrote: > Zach is the lldb cmake owner. Zach, does this seem OK for 3.8? > > On Wed, Jan 27, 2016 at 7:13 AM, Pavel Labath wrote: > > Hi, > > > > could we get this patch applied to the

[Lldb-commits] [lldb] r258943 - XFail TestCPPAuto on Windows until we can find the root problem.

Author: amccarth Date: Wed Jan 27 11:03:25 2016 New Revision: 258943 URL: http://llvm.org/viewvc/llvm-project?rev=258943=rev Log: XFail TestCPPAuto on Windows until we can find the root problem. llvm.org/pr26339 Modified:

Re: [Lldb-commits] [PATCH] D15778: [lldb] Ignore breakpoints by default in SBFrame::EvaluateExpression

> On Jan 27, 2016, at 9:20 AM, Jim Ingham via lldb-commits > wrote: > > >> On Jan 27, 2016, at 8:25 AM, Enrico Granata via lldb-commits >> wrote: >> >> granata.enrico added a comment. >> >> It looks like this code is default

Re: [Lldb-commits] [lldb] r258921 - Fix linking with LLVM_LINK_LLVM_DYLIB=ON

Zach is the lldb cmake owner. Zach, does this seem OK for 3.8? On Wed, Jan 27, 2016 at 7:13 AM, Pavel Labath wrote: > Hi, > > could we get this patch applied to the 3.8 branch? > > thanks, > pl > > > On 27 January 2016 at 11:02, Pavel Labath via lldb-commits >

Re: [Lldb-commits] [PATCH] D15778: [lldb] Ignore breakpoints by default in SBFrame::EvaluateExpression

> On Jan 27, 2016, at 8:25 AM, Enrico Granata via lldb-commits > wrote: > > granata.enrico added a comment. > > It looks like this code is default constructing a SBExpressionOptions(), > which at the end of the day is a fancy wrapper for EvaluateExpressionOptions

Re: [Lldb-commits] [PATCH] D16627: Add support to detect arm hard float ABI based binaries for ABISysV_arm

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Change over to use a "Thread &" as argument to "bool ABISysV_arm::IsArmHardFloat(Thread *)" and this is good to go. http://reviews.llvm.org/D16627

[Lldb-commits] [lldb] r258966 - Refactor some of the xfail / skip decorators to share logic.

Author: zturner Date: Wed Jan 27 12:49:31 2016 New Revision: 258966 URL: http://llvm.org/viewvc/llvm-project?rev=258966=rev Log: Refactor some of the xfail / skip decorators to share logic. Previously the logic of skipIf and expectedFailure were 99% the same, but they took different sets of

Re: [Lldb-commits] [lldb] r258921 - Fix linking with LLVM_LINK_LLVM_DYLIB=ON

Merged in r258964, thanks. (I accidentally committed some local changes too; reverted those in r258968.) On Wed, Jan 27, 2016 at 10:06 AM, Zachary Turner wrote: > Yea I think this is fine. > > On Wed, Jan 27, 2016 at 9:29 AM Hans Wennborg wrote: >> >> Zach

Re: [Lldb-commits] [lldb] r258919 - [LLDB][MIPS] A small fix in GetBreakableLoadAddress() for MIPS

Just a heads up, `isinstance(foo, basestring)` doesn't work in Python 3. You need to use `isinstance(foo, six.string_types)`. I'm checking in a fix for this, but just wanted to let you know so you can keep this in the back of your head for future. On Wed, Jan 27, 2016 at 2:20 AM Bhushan D.

[Lldb-commits] [lldb] r258969 - Resubmit r258759 with proper unicode handling.

Author: zturner Date: Wed Jan 27 13:00:51 2016 New Revision: 258969 URL: http://llvm.org/viewvc/llvm-project?rev=258969=rev Log: Resubmit r258759 with proper unicode handling. Instead of opening the file in unicode mode, we need only encode data which potentially has non-ASCII characters as UTF8

Re: [Lldb-commits] [lldb] r258919 - [LLDB][MIPS] A small fix in GetBreakableLoadAddress() for MIPS

Also please add `from __future__ import print_function` to the top of every new test file you create. Sorry this didn't get caught during review, no worries. On Wed, Jan 27, 2016 at 10:42 AM Zachary Turner wrote: > Just a heads up, `isinstance(foo, basestring)` doesn't work

[Lldb-commits] [lldb] r258978 - Revert "Resubmit r258759 with proper unicode handling."

Author: zturner Date: Wed Jan 27 13:47:28 2016 New Revision: 258978 URL: http://llvm.org/viewvc/llvm-project?rev=258978=rev Log: Revert "Resubmit r258759 with proper unicode handling." This reverts commit 2c79d60214e146b13b233392a859b4f79340e90e. Modified:

Re: [Lldb-commits] [PATCH] D16293: [cmake] Make dependencies of lldb libraries private

This revision was automatically updated to reflect the committed changes. Closed by commit rL258921: Fix linking with LLVM_LINK_LLVM_DYLIB=ON (authored by labath). Changed prior to commit: http://reviews.llvm.org/D16293?vs=45667=46116#toc Repository: rL LLVM http://reviews.llvm.org/D16293

[Lldb-commits] [lldb] r258921 - Fix linking with LLVM_LINK_LLVM_DYLIB=ON

Author: labath Date: Wed Jan 27 05:02:02 2016 New Revision: 258921 URL: http://llvm.org/viewvc/llvm-project?rev=258921=rev Log: Fix linking with LLVM_LINK_LLVM_DYLIB=ON Linking with LLVM shared libraries currently produces linker errors. This works around the issue (pr24953) by disabling

[Lldb-commits] [lldb] r258919 - [LLDB][MIPS] A small fix in GetBreakableLoadAddress() for MIPS

Author: bhushan.attarde Date: Wed Jan 27 04:16:30 2016 New Revision: 258919 URL: http://llvm.org/viewvc/llvm-project?rev=258919=rev Log: [LLDB][MIPS] A small fix in GetBreakableLoadAddress() for MIPS SUMMARY: Get the load address for the address given by symbol and function.

Re: [Lldb-commits] [PATCH] D15778: [lldb] Ignore breakpoints by default in SBFrame::EvaluateExpression

evgeny777 updated this revision to Diff 46129. http://reviews.llvm.org/D15778 Files: source/API/SBFrame.cpp Index: source/API/SBFrame.cpp === --- source/API/SBFrame.cpp +++ source/API/SBFrame.cpp @@ -1389,6 +1389,7 @@

[Lldb-commits] [PATCH] D16627: Add support to detect arm hard float ABI based binaries for ABISysV_arm

omjavaid created this revision. omjavaid added reviewers: tberghammer, clayborg. omjavaid added a subscriber: lldb-commits. Herald added subscribers: rengolin, aemerson. This patch adds logic to detect if underlying binary is using arm hard float abi and use that information while handling

Re: [Lldb-commits] [PATCH] D15778: [lldb] Ignore breakpoints by default in SBFrame::EvaluateExpression

evgeny777 added a comment. Greg, Enrico, Can someone tell if it is possible to modify Python interface this way. Without this modification user breakpoints will be hit when someone evaluates expression and use Python interface. The lldb frontend ignores breakpoints, lldb-mi does not, becauses

Re: [Lldb-commits] [PATCH] D16615: Refactor some of the skip / xfail decorators to reuse more code.

labath added a comment. I like it. I noticed two small issues when running it though: - TestFdLeak calls `@expectedFailure`, the expectation fn needs to be updated to return a tuple - TestInferiorAssert calls `matchAndroid`, which now returns a tuple. condition needs updating. LGTM after

[Lldb-commits] [lldb] r258930 - Decorarte TestInferiorAssert xfails on AArch64 Linux

Author: omjavaid Date: Wed Jan 27 07:57:33 2016 New Revision: 258930 URL: http://llvm.org/viewvc/llvm-project?rev=258930=rev Log: Decorarte TestInferiorAssert xfails on AArch64 Linux This patch decorates some of TestInferiorAssert test cases with expectedFailureLinux on AArch64. Modified:

Re: [Lldb-commits] [lldb] r258921 - Fix linking with LLVM_LINK_LLVM_DYLIB=ON

Hi, could we get this patch applied to the 3.8 branch? thanks, pl On 27 January 2016 at 11:02, Pavel Labath via lldb-commits wrote: > Author: labath > Date: Wed Jan 27 05:02:02 2016 > New Revision: 258921 > > URL: http://llvm.org/viewvc/llvm-project?rev=258921=rev