Re: [Lldb-commits] [PATCH] D16736: Always write the session log file in UTF-8

2016-01-31 Thread Todd Fiala via lldb-commits
tfiala added a comment. In fact I'd say you could do this, now that I've looked at the test: diff --git a/packages/Python/lldbsuite/test/tools/lldb-server/TestGDBRemoteMemoryRead.py b/packages/Python/lldbsuite/test/tools/lldb-server/TestGDBRemoteMemoryRead.py index 7b974e5..9f80abe 100644

Re: [Lldb-commits] [PATCH] D16736: Always write the session log file in UTF-8

2016-01-31 Thread Todd Fiala via lldb-commits
tfiala added a comment. In http://reviews.llvm.org/D16736#340302, @tfiala wrote: > In any event, the right fix here probably is to have displays of > matched/expected text for known-to-be binary data *not* try to print results > in the expect-string-match code since these are just going to have

Re: [Lldb-commits] [PATCH] D16736: Always write the session log file in UTF-8

2016-01-31 Thread Todd Fiala via lldb-commits
tfiala added a comment. > I'm going to have a look at trying this modification now. I'm getting the same error with the replace. Here is the patch (okay the whole encoded_file.py) I was able to use to get past this - which ultimately looks to be an error in the match result printing of a raw

Re: [Lldb-commits] [PATCH] D16736: Always write the session log file in UTF-8

2016-01-31 Thread Todd Fiala via lldb-commits
tfiala added a comment. In http://reviews.llvm.org/D16736#339925, @tfiala wrote: > In http://reviews.llvm.org/D16736#339889, @zturner wrote: > > > Hmm, that almost looks to me like it's finding a real bug. Which it > > probably is, because higher up the callstack it's reading the response of a

Re: [Lldb-commits] [PATCH] D16508: NetBSD: Define initial RegisterContextNetBSD_x86_64

2016-01-31 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. Please review. I'm still unsure whether `FPR fpr` will be fine. Repository: rL LLVM http://reviews.llvm.org/D16508 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

Re: [Lldb-commits] [PATCH] D16508: NetBSD: Define initial RegisterContextNetBSD_x86_64

2016-01-31 Thread Kamil Rytarowski via lldb-commits
krytarowski updated this revision to Diff 46489. krytarowski added a comment. Revamped version. Changes: - change type of registers from int64_t to uint64_t, - remove unsupported debug x86 registers, - model UserArea after mcontext_t Patch building tested. Repository: rL LLVM http://review