[Lldb-commits] [PATCH] D16975: Handle floating-point type homogeneous aggregate return values in ABISysV_arm

2016-02-07 Thread Muhammad Omair Javaid via lldb-commits
omjavaid created this revision. omjavaid added reviewers: tberghammer, clayborg. omjavaid added a subscriber: lldb-commits. Herald added subscribers: rengolin, aemerson. Arm hard float ABI can use floating point registers for returning structures containing all 4 or 8 byte floating point

Re: [Lldb-commits] [PATCH] D16936: Remove expectedFailureWindows decorator

2016-02-07 Thread Todd Fiala via lldb-commits
tfiala added a comment. Yep, I'll give that a shot now. http://reviews.llvm.org/D16936 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D16936: Remove expectedFailureWindows decorator

2016-02-07 Thread Todd Fiala via lldb-commits
tfiala accepted this revision. tfiala added a comment. This revision is now accepted and ready to land. LGTM with the change you suggested above. I tried that and it worked on OS X. The change itself looked fine as well. Comment at:

Re: [Lldb-commits] [PATCH] D16936: Remove expectedFailureWindows decorator

2016-02-07 Thread Todd Fiala via lldb-commits
tfiala added a comment. I'm seeing 8 errors after applying this diff: ERROR: test_expr_stripped_dwarf (lang/objc/hidden-ivars/TestHiddenIvars.py) ERROR: test_frame_variable_stripped_dwarf (lang/objc/hidden-ivars/TestHiddenIvars.py) ERROR: test_with_python_api_dsym

Re: [Lldb-commits] [PATCH] D16936: Remove expectedFailureWindows decorator

2016-02-07 Thread Todd Fiala via lldb-commits
tfiala added a comment. Here's one: Traceback (most recent call last): File "/Users/tfiala/src/lldb-tot/lldb/packages/Python/lldbsuite/test/lldbtest.py", line 1442, in dsym_test_method return attrvalue(self) File