This revision was automatically updated to reflect the committed changes.
Closed by commit rL260362: [LLDB][MIPS] Generalise MIPS arch names (authored by
mohit.bhakkad).
Changed prior to commit:
http://reviews.llvm.org/D16840?vs=46919&id=47423#toc
Repository:
rL LLVM
http://reviews.llvm.org
Author: mohit.bhakkad
Date: Wed Feb 10 00:58:13 2016
New Revision: 260362
URL: http://llvm.org/viewvc/llvm-project?rev=260362&view=rev
Log:
[LLDB][MIPS] Generalise MIPS arch names
Patch by Nitesh Jain
Reviewers: clayborg, jaydeep.
Subscribers: zturner, bhushan, mohit.bhakkad, sagar, lldb-commits.
zturner added a subscriber: zturner.
zturner requested changes to this revision.
zturner added a reviewer: zturner.
This revision now requires changes to proceed.
Comment at:
source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp:206-210
@@ -199,1 +205,7 @@
+if (ta
bhushan updated this revision to Diff 47422.
bhushan added a comment.
Addresses review comments.
Used local variables instead of calling accessors each time.
Repository:
rL LLVM
http://reviews.llvm.org/D17022
Files:
source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
Index: so
Seems like kind of an obscure command. Why not just set a one-shot
breakpoint on foo by name, then continue, so that the first time the
breakpoint hits it gets removed.
Also what happens if bar() calls foo()?
On Tue, Feb 9, 2016 at 7:29 PM Jim Ingham via lldb-commits <
lldb-commits@lists.llvm.or
Author: jingham
Date: Tue Feb 9 21:25:24 2016
New Revision: 260352
URL: http://llvm.org/viewvc/llvm-project?rev=260352&view=rev
Log:
This is an idea to make "thread step-in --target" work for the common
case where you have:
1 ->foo (bar(),
2baz(),
3lala());
4
You are
Author: enrico
Date: Tue Feb 9 20:12:42 2016
New Revision: 260349
URL: http://llvm.org/viewvc/llvm-project?rev=260349&view=rev
Log:
Change lldb.value.__int__() so that it takes into account the signedness of the
value being cast to return a Python number with the proper value
The explicit APIs
Author: jingham
Date: Tue Feb 9 19:33:58 2016
New Revision: 260345
URL: http://llvm.org/viewvc/llvm-project?rev=260345&view=rev
Log:
Add a missing break.
Modified:
lldb/trunk/tools/debugserver/source/debugserver.cpp
Modified: lldb/trunk/tools/debugserver/source/debugserver.cpp
URL:
http://
Author: amccarth
Date: Tue Feb 9 18:06:50 2016
New Revision: 260331
URL: http://llvm.org/viewvc/llvm-project?rev=260331&view=rev
Log:
Don't dereference the first element of an empty container.
Modified:
lldb/trunk/source/Symbol/Symtab.cpp
Modified: lldb/trunk/source/Symbol/Symtab.cpp
URL:
Author: emaste
Date: Tue Feb 9 18:03:52 2016
New Revision: 260330
URL: http://llvm.org/viewvc/llvm-project?rev=260330&view=rev
Log:
Remove FreeBSD failure decorator from TestCppIncompleteTypes
CFLAGS is now being set correctly to pass -flimit-debug-info or
-fno-limit-debug-info on FreeBSD. I'm
This revision was automatically updated to reflect the committed changes.
Closed by commit rL260328: Add status for LLDB on Windows to status.html.
(authored by amccarth).
Changed prior to commit:
http://reviews.llvm.org/D16902?vs=46964&id=47390#toc
Repository:
rL LLVM
http://reviews.llvm.o
Author: amccarth
Date: Tue Feb 9 17:52:57 2016
New Revision: 260328
URL: http://llvm.org/viewvc/llvm-project?rev=260328&view=rev
Log:
Add status for LLDB on Windows to status.html.
Differential Revision: http://reviews.llvm.org/D16902
Modified:
lldb/trunk/www/status.html
Modified: lldb/tru
Author: zturner
Date: Tue Feb 9 17:45:21 2016
New Revision: 260326
URL: http://llvm.org/viewvc/llvm-project?rev=260326&view=rev
Log:
Change `CoreTests` to LLDBCoreTests to avoid name clash.
lld was already using a target named CoreTests so CMake
was erroring due to this conflict.
Modified:
Author: gclayton
Date: Tue Feb 9 17:25:54 2016
New Revision: 260322
URL: http://llvm.org/viewvc/llvm-project?rev=260322&view=rev
Log:
Added code that was commented out during testing to stops template member
functions from being added to class definitions (see revision 260308 for
details).
Not yet, but I will try to reduce one down. The best I have right now is to
debug clang, set a breakpoint at "Sema::SelectBestMethod" and then run "p Sel"
when you hit the breakpoint. This is of course only by running with a file:
lldb -- "/tmp/local/clang/install/bin/clang-3.8" -cc1 -triple
ar
amccarth added a comment.
Friendly ping.
http://reviews.llvm.org/D16902
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
krytarowski added a comment.
Just in case someone will be quicker, new version against revamped CMake dirs
is in pkgsrc-wip/lldb-git
Repository:
rL LLVM
http://reviews.llvm.org/D15067
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
htt
Any tests for this?
On Tue, Feb 9, 2016 at 2:40 PM Greg Clayton via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Author: gclayton
> Date: Tue Feb 9 16:36:24 2016
> New Revision: 260308
>
> URL: http://llvm.org/viewvc/llvm-project?rev=260308&view=rev
> Log:
> Fixed many issues that were c
Author: gclayton
Date: Tue Feb 9 16:36:24 2016
New Revision: 260308
URL: http://llvm.org/viewvc/llvm-project?rev=260308&view=rev
Log:
Fixed many issues that were causing differing type definition issues to show up
when parsing expressions.
1) Turns out we weren't correctly uniquing types for C+
Author: gclayton
Date: Tue Feb 9 16:09:26 2016
New Revision: 260299
URL: http://llvm.org/viewvc/llvm-project?rev=260299&view=rev
Log:
Don't complete a class type just to test if it is a class. Code in CompilerType
and in clang::QualType knows how to complete a type if it needs to.
Modified:
Author: zturner
Date: Tue Feb 9 15:36:38 2016
New Revision: 260292
URL: http://llvm.org/viewvc/llvm-project?rev=260292&view=rev
Log:
Fix incorrect usage of `str` in _match_decorator_property.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/decorators.py
Modified: lldb/trunk/packages/Pyt
Author: zturner
Date: Tue Feb 9 15:36:23 2016
New Revision: 260290
URL: http://llvm.org/viewvc/llvm-project?rev=260290&view=rev
Log:
Remove decorators related to debug info types.
All existing usages were ported over to the common decorators.
Modified:
lldb/trunk/packages/Python/lldbsuite/t
Author: zturner
Date: Tue Feb 9 15:36:15 2016
New Revision: 260289
URL: http://llvm.org/viewvc/llvm-project?rev=260289&view=rev
Log:
Delete all the xfail / skip decorators for specific compilers.
Ported everything over to using expectedFailureAll.
Modified:
lldb/trunk/packages/Python/lldbsu
Author: zturner
Date: Tue Feb 9 15:36:32 2016
New Revision: 260291
URL: http://llvm.org/viewvc/llvm-project?rev=260291&view=rev
Log:
Remove skipIf decorators.
These were supposed to have been removed in a previous patch,
but I missed them.
Modified:
lldb/trunk/packages/Python/lldbsuite/test
Author: zturner
Date: Tue Feb 9 15:36:02 2016
New Revision: 260288
URL: http://llvm.org/viewvc/llvm-project?rev=260288&view=rev
Log:
Remove expected failure and skip decorators for host os.
All decorator invocations are updated to use the generic
expectedFailureAll and skipIf decorators.
Modifi
Author: gclayton
Date: Tue Feb 9 15:20:17 2016
New Revision: 260284
URL: http://llvm.org/viewvc/llvm-project?rev=260284&view=rev
Log:
If we set the DYLD_INSERT_LIBRARIES environment variable when launching
debugserver, for use with /usr/lib/libgmalloc.dylib, then make sure we don't
pass this en
Author: gclayton
Date: Tue Feb 9 15:18:44 2016
New Revision: 260282
URL: http://llvm.org/viewvc/llvm-project?rev=260282&view=rev
Log:
Don't enable -flimit-debug-info by default for the LLDB Xcode builds. This was
put in back in 2011 when -flimit-debug-info did a lot less than it does now.
With
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D16996
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D16814
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good. Most JTAG probes actually vend their own GDB server these days. If
so, we will used the Z packets in order to set breakpoints, so we will be
isolated from these issues. If we a
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
We should use local variable and avoid calling accessors many times. See
inlined comments. I know the code was like this before, but we should fix these
things as we go.
==
Author: jingham
Date: Tue Feb 9 12:53:49 2016
New Revision: 260247
URL: http://llvm.org/viewvc/llvm-project?rev=260247&view=rev
Log:
Mention the --all-files option in the -p help string.
Modified:
lldb/trunk/source/Commands/CommandObjectBreakpoint.cpp
Modified: lldb/trunk/source/Commands/Co
zturner added a subscriber: zturner.
zturner added a comment.
True about the bugnumbers. Not always diferent bug numbers, but certainly
sometimes.
The reason I don't like writing them as separate decorators is because we
have tons of cases where the condition of multiple decorators pass, and the
True about the bugnumbers. Not always diferent bug numbers, but certainly
sometimes.
The reason I don't like writing them as separate decorators is because we
have tons of cases where the condition of multiple decorators pass, and the
best we can do is report one bugnumber / reason in the output
jingham added a comment.
This seems fine as a generic instrumentation point. Obviously, the onus in on
the passes, since they could totally ruin the expression evaluation if they
don't do their job right... But I'm not sure there's any good way to make this
not a sharp tool. But you should w
On 9 February 2016 at 17:51, Zachary Turner wrote:
> I agree that you don't need arbitrary complexity, but I think there are some
> things we would greatly benefit from. For example, have you ever seen this?
>
> @expectedFailureWindows
> @expectedFailureGcc
> @expectedFailureHostLinux
>
>
zturner added a comment.
In http://reviews.llvm.org/D16936#347186, @tberghammer wrote:
> My main concern is that we have a lot of named argument for
> skipIf/expectFailure and I expect it to increase even further as we support
> more and more configuration. In my opinion we can have some functi
zturner added a comment.
In http://reviews.llvm.org/D16936#347141, @labath wrote:
> I think this is getting way too complicated. I haven't seen any test
> which needs such complicated combinations of skip conditions (and I
> hope I never see one).
I agree that you don't need arbitrary complex
labath closed this revision.
labath added a comment.
Committed as r260239.
Repository:
rL LLVM
http://reviews.llvm.org/D16868
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: labath
Date: Tue Feb 9 11:28:01 2016
New Revision: 260239
URL: http://llvm.org/viewvc/llvm-project?rev=260239&view=rev
Log:
Fix invalid shift operator overload in Scalar
Summary: This also fixes an infinite recursion between lldb_private::operator>>
() and Scalar::operator>>= ().
Revie
Merged in r260236.
Thanks,
Hans
On Tue, Feb 9, 2016 at 1:40 AM, Bhushan Attarde
wrote:
> Hi Hans,
>
> Could you please add this (r260072) to the release branch?
>
> Thanks,
> Bhushan
>
>
> -Original Message-
> From: lldb-commits [mailto:lldb-commits-boun...@lists.llvm.org] On Behalf Of
tberghammer created this revision.
tberghammer added a reviewer: labath.
tberghammer added a subscriber: lldb-commits.
Add new option to lldb-server to display its version
http://reviews.llvm.org/D17030
Files:
tools/lldb-server/lldb-server.cpp
Index: tools/lldb-server/lldb-server.cpp
ldrumm created this revision.
ldrumm added reviewers: jingham, spyffe.
ldrumm added a subscriber: lldb-commits.
During expression evaluation, the `ClangExpressionParser` preforms a number of
hard-coded fixups on the expression's IR before the module is assembled and
dispatched to be run in a `Th
tberghammer added inline comments.
Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:2939
@@ +2938,3 @@
+symbol_id, // Symbol table index.
+symbol_name, // Symbol name.
+false, //
tberghammer updated this revision to Diff 47314.
http://reviews.llvm.org/D16996
Files:
include/lldb/Core/RangeMap.h
include/lldb/Symbol/DWARFCallFrameInfo.h
include/lldb/Symbol/ObjectFile.h
include/lldb/Symbol/Symtab.h
source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
source/Plugins/Obj
mamai added a comment.
I don't have commit access. It would be great if you can push it for me. Thanks
!
Repository:
rL LLVM
http://reviews.llvm.org/D16868
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
tberghammer abandoned this revision.
tberghammer added a comment.
The change was submitted with a different CL
http://reviews.llvm.org/D16680
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/ll
tberghammer added a comment.
Jason: Can you take at the change in the unwinding logic?
Comment at: source/Plugins/Instruction/ARM/EmulateInstructionARM.cpp:13653
@@ -13656,2 +13652,3 @@
const uint32_t cond = CurrentCond (m_opcode.GetOpcode32());
-return cond != 0xe && c
tberghammer added a comment.
In http://reviews.llvm.org/D16853#347120, @omjavaid wrote:
> GDB doesnt use bkpt instruction for user debugging for the reason that it
> interferes with jtag debug probes. I am not sure if LLDB will be ever used
> with a jtag probe in near future but still a jtag pr
tberghammer added a comment.
My main concern is that we have a lot of named argument for
skipIf/expectFailure and I expect it to increase even further as we support
more and more configuration. In my opinion we can have some functional style
solution as readable as the current solution with gre
bhushan created this revision.
bhushan added reviewers: clayborg, spyffe.
bhushan added subscribers: lldb-commits, nitesh.jain, jaydeep, sagar,
mohit.bhakkad.
bhushan set the repository for this revision to rL LLVM.
Currently, LLDB (ClangExpressionParser) does not pass
`clang::TargetOptions::CPU
Author: tberghammer
Date: Tue Feb 9 04:10:42 2016
New Revision: 260216
URL: http://llvm.org/viewvc/llvm-project?rev=260216&view=rev
Log:
Fix a typo in an xfail decorator in TestExprsChar
Modified:
lldb/trunk/packages/Python/lldbsuite/test/expression_command/char/TestExprsChar.py
Modified:
Hi Hans,
Could you please add this (r260072) to the release branch?
Thanks,
Bhushan
-Original Message-
From: lldb-commits [mailto:lldb-commits-boun...@lists.llvm.org] On Behalf Of
Bhushan D. Attarde via lldb-commits
Sent: 08 February 2016 10:06
To: lldb-commits@lists.llvm.org
Subject:
labath added a subscriber: labath.
labath added a comment.
I think this is getting way too complicated. I haven't seen any test
which needs such complicated combinations of skip conditions (and I
hope I never see one).
Repository:
rL LLVM
http://reviews.llvm.org/D16936
I think this is getting way too complicated. I haven't seen any test
which needs such complicated combinations of skip conditions (and I
hope I never see one).
On 9 February 2016 at 01:24, Zachary Turner wrote:
> 1. Skips if all conditions are true. @skipIf(all(A=a, B=b, C=c))
> 2. Skips if any
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
That's perfect. Thanks for adding that test.
Do you have commit access, or shall I put this in?
Repository:
rL LLVM
http://reviews.llvm.org/D16868
__
omjavaid added a comment.
GDB doesnt use bkpt instruction for user debugging for the reason that it
interferes with jtag debug probes. I am not sure if LLDB will be ever used with
a jtag probe in near future but still a jtag prob might be connected to the
same hardware which is using LLDB to de
57 matches
Mail list logo
