Re: [Lldb-commits] [PATCH] D16840: [LLDB][MIPS] Generalise MIPS arch names

2016-02-09 Thread Mohit Bhakkad via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL260362: [LLDB][MIPS] Generalise MIPS arch names (authored by mohit.bhakkad). Changed prior to commit: http://reviews.llvm.org/D16840?vs=46919&id=47423#toc Repository: rL LLVM http://reviews.llvm.org

[Lldb-commits] [lldb] r260362 - [LLDB][MIPS] Generalise MIPS arch names

2016-02-09 Thread Mohit K. Bhakkad via lldb-commits
Author: mohit.bhakkad Date: Wed Feb 10 00:58:13 2016 New Revision: 260362 URL: http://llvm.org/viewvc/llvm-project?rev=260362&view=rev Log: [LLDB][MIPS] Generalise MIPS arch names Patch by Nitesh Jain Reviewers: clayborg, jaydeep. Subscribers: zturner, bhushan, mohit.bhakkad, sagar, lldb-commits.

Re: [Lldb-commits] [PATCH] D17022: [LLDB][MIPS] Provide CPU string to compiler for appropriate code generation for MIPS

2016-02-09 Thread Zachary Turner via lldb-commits
zturner added a subscriber: zturner. zturner requested changes to this revision. zturner added a reviewer: zturner. This revision now requires changes to proceed. Comment at: source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp:206-210 @@ -199,1 +205,7 @@ +if (ta

Re: [Lldb-commits] [PATCH] D17022: [LLDB][MIPS] Provide CPU string to compiler for appropriate code generation for MIPS

2016-02-09 Thread Bhushan Attarde via lldb-commits
bhushan updated this revision to Diff 47422. bhushan added a comment. Addresses review comments. Used local variables instead of calling accessors each time. Repository: rL LLVM http://reviews.llvm.org/D17022 Files: source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp Index: so

Re: [Lldb-commits] [lldb] r260352 - This is an idea to make "thread step-in --target" work for the common

2016-02-09 Thread Zachary Turner via lldb-commits
Seems like kind of an obscure command. Why not just set a one-shot breakpoint on foo by name, then continue, so that the first time the breakpoint hits it gets removed. Also what happens if bar() calls foo()? On Tue, Feb 9, 2016 at 7:29 PM Jim Ingham via lldb-commits < lldb-commits@lists.llvm.or

[Lldb-commits] [lldb] r260352 - This is an idea to make "thread step-in --target" work for the common

2016-02-09 Thread Jim Ingham via lldb-commits
Author: jingham Date: Tue Feb 9 21:25:24 2016 New Revision: 260352 URL: http://llvm.org/viewvc/llvm-project?rev=260352&view=rev Log: This is an idea to make "thread step-in --target" work for the common case where you have: 1 ->foo (bar(), 2baz(), 3lala()); 4 You are

[Lldb-commits] [lldb] r260349 - Change lldb.value.__int__() so that it takes into account the signedness of the value being cast to return a Python number with the proper value

2016-02-09 Thread Enrico Granata via lldb-commits
Author: enrico Date: Tue Feb 9 20:12:42 2016 New Revision: 260349 URL: http://llvm.org/viewvc/llvm-project?rev=260349&view=rev Log: Change lldb.value.__int__() so that it takes into account the signedness of the value being cast to return a Python number with the proper value The explicit APIs

[Lldb-commits] [lldb] r260345 - Add a missing break.

2016-02-09 Thread Jim Ingham via lldb-commits
Author: jingham Date: Tue Feb 9 19:33:58 2016 New Revision: 260345 URL: http://llvm.org/viewvc/llvm-project?rev=260345&view=rev Log: Add a missing break. Modified: lldb/trunk/tools/debugserver/source/debugserver.cpp Modified: lldb/trunk/tools/debugserver/source/debugserver.cpp URL: http://

[Lldb-commits] [lldb] r260331 - Don't dereference the first element of an empty container.

2016-02-09 Thread Adrian McCarthy via lldb-commits
Author: amccarth Date: Tue Feb 9 18:06:50 2016 New Revision: 260331 URL: http://llvm.org/viewvc/llvm-project?rev=260331&view=rev Log: Don't dereference the first element of an empty container. Modified: lldb/trunk/source/Symbol/Symtab.cpp Modified: lldb/trunk/source/Symbol/Symtab.cpp URL:

[Lldb-commits] [lldb] r260330 - Remove FreeBSD failure decorator from TestCppIncompleteTypes

2016-02-09 Thread Ed Maste via lldb-commits
Author: emaste Date: Tue Feb 9 18:03:52 2016 New Revision: 260330 URL: http://llvm.org/viewvc/llvm-project?rev=260330&view=rev Log: Remove FreeBSD failure decorator from TestCppIncompleteTypes CFLAGS is now being set correctly to pass -flimit-debug-info or -fno-limit-debug-info on FreeBSD. I'm

Re: [Lldb-commits] [PATCH] D16902: Add status for LLDB on Windows to status.html.

2016-02-09 Thread Adrian McCarthy via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL260328: Add status for LLDB on Windows to status.html. (authored by amccarth). Changed prior to commit: http://reviews.llvm.org/D16902?vs=46964&id=47390#toc Repository: rL LLVM http://reviews.llvm.o

[Lldb-commits] [lldb] r260328 - Add status for LLDB on Windows to status.html.

2016-02-09 Thread Adrian McCarthy via lldb-commits
Author: amccarth Date: Tue Feb 9 17:52:57 2016 New Revision: 260328 URL: http://llvm.org/viewvc/llvm-project?rev=260328&view=rev Log: Add status for LLDB on Windows to status.html. Differential Revision: http://reviews.llvm.org/D16902 Modified: lldb/trunk/www/status.html Modified: lldb/tru

[Lldb-commits] [lldb] r260326 - Change `CoreTests` to LLDBCoreTests to avoid name clash.

2016-02-09 Thread Zachary Turner via lldb-commits
Author: zturner Date: Tue Feb 9 17:45:21 2016 New Revision: 260326 URL: http://llvm.org/viewvc/llvm-project?rev=260326&view=rev Log: Change `CoreTests` to LLDBCoreTests to avoid name clash. lld was already using a target named CoreTests so CMake was erroring due to this conflict. Modified:

[Lldb-commits] [lldb] r260322 - Added code that was commented out during testing to stops template member functions from being added to class definitions (see revision 260308 for details).

2016-02-09 Thread Greg Clayton via lldb-commits
Author: gclayton Date: Tue Feb 9 17:25:54 2016 New Revision: 260322 URL: http://llvm.org/viewvc/llvm-project?rev=260322&view=rev Log: Added code that was commented out during testing to stops template member functions from being added to class definitions (see revision 260308 for details).

Re: [Lldb-commits] [lldb] r260308 - Fixed many issues that were causing differing type definition issues to show up when parsing expressions.

2016-02-09 Thread Greg Clayton via lldb-commits
Not yet, but I will try to reduce one down. The best I have right now is to debug clang, set a breakpoint at "Sema::SelectBestMethod" and then run "p Sel" when you hit the breakpoint. This is of course only by running with a file: lldb -- "/tmp/local/clang/install/bin/clang-3.8" -cc1 -triple ar

Re: [Lldb-commits] [PATCH] D16902: Add status for LLDB on Windows to status.html.

2016-02-09 Thread Adrian McCarthy via lldb-commits
amccarth added a comment. Friendly ping. http://reviews.llvm.org/D16902 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D15067: Design building out of sources

2016-02-09 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. Just in case someone will be quicker, new version against revamped CMake dirs is in pkgsrc-wip/lldb-git Repository: rL LLVM http://reviews.llvm.org/D15067 ___ lldb-commits mailing list lldb-commits@lists.llvm.org htt

Re: [Lldb-commits] [lldb] r260308 - Fixed many issues that were causing differing type definition issues to show up when parsing expressions.

2016-02-09 Thread Zachary Turner via lldb-commits
Any tests for this? On Tue, Feb 9, 2016 at 2:40 PM Greg Clayton via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: gclayton > Date: Tue Feb 9 16:36:24 2016 > New Revision: 260308 > > URL: http://llvm.org/viewvc/llvm-project?rev=260308&view=rev > Log: > Fixed many issues that were c

[Lldb-commits] [lldb] r260308 - Fixed many issues that were causing differing type definition issues to show up when parsing expressions.

2016-02-09 Thread Greg Clayton via lldb-commits
Author: gclayton Date: Tue Feb 9 16:36:24 2016 New Revision: 260308 URL: http://llvm.org/viewvc/llvm-project?rev=260308&view=rev Log: Fixed many issues that were causing differing type definition issues to show up when parsing expressions. 1) Turns out we weren't correctly uniquing types for C+

[Lldb-commits] [lldb] r260299 - Don't complete a class type just to test if it is a class. Code in CompilerType and in clang::QualType knows how to complete a type if it needs to.

2016-02-09 Thread Greg Clayton via lldb-commits
Author: gclayton Date: Tue Feb 9 16:09:26 2016 New Revision: 260299 URL: http://llvm.org/viewvc/llvm-project?rev=260299&view=rev Log: Don't complete a class type just to test if it is a class. Code in CompilerType and in clang::QualType knows how to complete a type if it needs to. Modified:

[Lldb-commits] [lldb] r260292 - Fix incorrect usage of `str` in _match_decorator_property.

2016-02-09 Thread Zachary Turner via lldb-commits
Author: zturner Date: Tue Feb 9 15:36:38 2016 New Revision: 260292 URL: http://llvm.org/viewvc/llvm-project?rev=260292&view=rev Log: Fix incorrect usage of `str` in _match_decorator_property. Modified: lldb/trunk/packages/Python/lldbsuite/test/decorators.py Modified: lldb/trunk/packages/Pyt

[Lldb-commits] [lldb] r260290 - Remove decorators related to debug info types.

2016-02-09 Thread Zachary Turner via lldb-commits
Author: zturner Date: Tue Feb 9 15:36:23 2016 New Revision: 260290 URL: http://llvm.org/viewvc/llvm-project?rev=260290&view=rev Log: Remove decorators related to debug info types. All existing usages were ported over to the common decorators. Modified: lldb/trunk/packages/Python/lldbsuite/t

[Lldb-commits] [lldb] r260289 - Delete all the xfail / skip decorators for specific compilers.

2016-02-09 Thread Zachary Turner via lldb-commits
Author: zturner Date: Tue Feb 9 15:36:15 2016 New Revision: 260289 URL: http://llvm.org/viewvc/llvm-project?rev=260289&view=rev Log: Delete all the xfail / skip decorators for specific compilers. Ported everything over to using expectedFailureAll. Modified: lldb/trunk/packages/Python/lldbsu

[Lldb-commits] [lldb] r260291 - Remove skipIf decorators.

2016-02-09 Thread Zachary Turner via lldb-commits
Author: zturner Date: Tue Feb 9 15:36:32 2016 New Revision: 260291 URL: http://llvm.org/viewvc/llvm-project?rev=260291&view=rev Log: Remove skipIf decorators. These were supposed to have been removed in a previous patch, but I missed them. Modified: lldb/trunk/packages/Python/lldbsuite/test

[Lldb-commits] [lldb] r260288 - Remove expected failure and skip decorators for host os.

2016-02-09 Thread Zachary Turner via lldb-commits
Author: zturner Date: Tue Feb 9 15:36:02 2016 New Revision: 260288 URL: http://llvm.org/viewvc/llvm-project?rev=260288&view=rev Log: Remove expected failure and skip decorators for host os. All decorator invocations are updated to use the generic expectedFailureAll and skipIf decorators. Modifi

[Lldb-commits] [lldb] r260284 - If we set the DYLD_INSERT_LIBRARIES environment variable when launching debugserver, for use with /usr/lib/libgmalloc.dylib, then make sure we don't pass this environme

2016-02-09 Thread Greg Clayton via lldb-commits
Author: gclayton Date: Tue Feb 9 15:20:17 2016 New Revision: 260284 URL: http://llvm.org/viewvc/llvm-project?rev=260284&view=rev Log: If we set the DYLD_INSERT_LIBRARIES environment variable when launching debugserver, for use with /usr/lib/libgmalloc.dylib, then make sure we don't pass this en

[Lldb-commits] [lldb] r260282 - Don't enable -flimit-debug-info by default for the LLDB Xcode builds. This was put in back in 2011 when -flimit-debug-info did a lot less than it does now. With llvm-ds

2016-02-09 Thread Greg Clayton via lldb-commits
Author: gclayton Date: Tue Feb 9 15:18:44 2016 New Revision: 260282 URL: http://llvm.org/viewvc/llvm-project?rev=260282&view=rev Log: Don't enable -flimit-debug-info by default for the LLDB Xcode builds. This was put in back in 2011 when -flimit-debug-info did a lot less than it does now. With

Re: [Lldb-commits] [PATCH] D16996: Improve the handling of missing elf symtab and missing symbol sizes

2016-02-09 Thread Greg Clayton via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D16996 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

Re: [Lldb-commits] [PATCH] D16814: Fix handling of the arm IT instruction in the unwinder

2016-02-09 Thread Greg Clayton via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D16814 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

Re: [Lldb-commits] [PATCH] D16853: Use BKPT instead of UDF for arm/thumb breakpoints

2016-02-09 Thread Greg Clayton via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. Most JTAG probes actually vend their own GDB server these days. If so, we will used the Z packets in order to set breakpoints, so we will be isolated from these issues. If we a

Re: [Lldb-commits] [PATCH] D17022: [LLDB][MIPS] Provide CPU string to compiler for appropriate code generation for MIPS

2016-02-09 Thread Greg Clayton via lldb-commits
clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. We should use local variable and avoid calling accessors many times. See inlined comments. I know the code was like this before, but we should fix these things as we go. ==

[Lldb-commits] [lldb] r260247 - Mention the --all-files option in the -p help string.

2016-02-09 Thread Jim Ingham via lldb-commits
Author: jingham Date: Tue Feb 9 12:53:49 2016 New Revision: 260247 URL: http://llvm.org/viewvc/llvm-project?rev=260247&view=rev Log: Mention the --all-files option in the -p help string. Modified: lldb/trunk/source/Commands/CommandObjectBreakpoint.cpp Modified: lldb/trunk/source/Commands/Co

Re: [Lldb-commits] [PATCH] D16936: Remove expectedFailureWindows decorator

2016-02-09 Thread Zachary Turner via lldb-commits
zturner added a subscriber: zturner. zturner added a comment. True about the bugnumbers. Not always diferent bug numbers, but certainly sometimes. The reason I don't like writing them as separate decorators is because we have tons of cases where the condition of multiple decorators pass, and the

Re: [Lldb-commits] [PATCH] D16936: Remove expectedFailureWindows decorator

2016-02-09 Thread Zachary Turner via lldb-commits
True about the bugnumbers. Not always diferent bug numbers, but certainly sometimes. The reason I don't like writing them as separate decorators is because we have tons of cases where the condition of multiple decorators pass, and the best we can do is report one bugnumber / reason in the output

Re: [Lldb-commits] [PATCH] D17027: [expression evaluator] Allow runtimes to execute custom LLVM ModulePasses over the generated IR at various stages after expression compilation.

2016-02-09 Thread Jim Ingham via lldb-commits
jingham added a comment. This seems fine as a generic instrumentation point. Obviously, the onus in on the passes, since they could totally ruin the expression evaluation if they don't do their job right... But I'm not sure there's any good way to make this not a sharp tool. But you should w

Re: [Lldb-commits] [PATCH] D16936: Remove expectedFailureWindows decorator

2016-02-09 Thread Pavel Labath via lldb-commits
On 9 February 2016 at 17:51, Zachary Turner wrote: > I agree that you don't need arbitrary complexity, but I think there are some > things we would greatly benefit from. For example, have you ever seen this? > > @expectedFailureWindows > @expectedFailureGcc > @expectedFailureHostLinux > >

Re: [Lldb-commits] [PATCH] D16936: Remove expectedFailureWindows decorator

2016-02-09 Thread Zachary Turner via lldb-commits
zturner added a comment. In http://reviews.llvm.org/D16936#347186, @tberghammer wrote: > My main concern is that we have a lot of named argument for > skipIf/expectFailure and I expect it to increase even further as we support > more and more configuration. In my opinion we can have some functi

Re: [Lldb-commits] [PATCH] D16936: Remove expectedFailureWindows decorator

2016-02-09 Thread Zachary Turner via lldb-commits
zturner added a comment. In http://reviews.llvm.org/D16936#347141, @labath wrote: > I think this is getting way too complicated. I haven't seen any test > which needs such complicated combinations of skip conditions (and I > hope I never see one). I agree that you don't need arbitrary complex

Re: [Lldb-commits] [PATCH] D16868: [lldb] Fix invalid shift operator overload in Scalar

2016-02-09 Thread Pavel Labath via lldb-commits
labath closed this revision. labath added a comment. Committed as r260239. Repository: rL LLVM http://reviews.llvm.org/D16868 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r260239 - Fix invalid shift operator overload in Scalar

2016-02-09 Thread Pavel Labath via lldb-commits
Author: labath Date: Tue Feb 9 11:28:01 2016 New Revision: 260239 URL: http://llvm.org/viewvc/llvm-project?rev=260239&view=rev Log: Fix invalid shift operator overload in Scalar Summary: This also fixes an infinite recursion between lldb_private::operator>> () and Scalar::operator>>= (). Revie

Re: [Lldb-commits] [lldb] r260072 - [LLDB][MIPS] Fix TestExpressionInSyscall.py for MIPS

2016-02-09 Thread Hans Wennborg via lldb-commits
Merged in r260236. Thanks, Hans On Tue, Feb 9, 2016 at 1:40 AM, Bhushan Attarde wrote: > Hi Hans, > > Could you please add this (r260072) to the release branch? > > Thanks, > Bhushan > > > -Original Message- > From: lldb-commits [mailto:lldb-commits-boun...@lists.llvm.org] On Behalf Of

[Lldb-commits] [PATCH] D17030: Add new option to lldb-server to display its version

2016-02-09 Thread Tamas Berghammer via lldb-commits
tberghammer created this revision. tberghammer added a reviewer: labath. tberghammer added a subscriber: lldb-commits. Add new option to lldb-server to display its version http://reviews.llvm.org/D17030 Files: tools/lldb-server/lldb-server.cpp Index: tools/lldb-server/lldb-server.cpp

[Lldb-commits] [PATCH] D17027: [expression evaluator] Allow runtimes to execute custom LLVM ModulePasses over the generated IR at various stages after expression compilation.

2016-02-09 Thread Luke Drummond via lldb-commits
ldrumm created this revision. ldrumm added reviewers: jingham, spyffe. ldrumm added a subscriber: lldb-commits. During expression evaluation, the `ClangExpressionParser` preforms a number of hard-coded fixups on the expression's IR before the module is assembled and dispatched to be run in a `Th

Re: [Lldb-commits] [PATCH] D16996: Improve the handling of missing elf symtab and missing symbol sizes

2016-02-09 Thread Tamas Berghammer via lldb-commits
tberghammer added inline comments. Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:2939 @@ +2938,3 @@ +symbol_id, // Symbol table index. +symbol_name, // Symbol name. +false, //

Re: [Lldb-commits] [PATCH] D16996: Improve the handling of missing elf symtab and missing symbol sizes

2016-02-09 Thread Tamas Berghammer via lldb-commits
tberghammer updated this revision to Diff 47314. http://reviews.llvm.org/D16996 Files: include/lldb/Core/RangeMap.h include/lldb/Symbol/DWARFCallFrameInfo.h include/lldb/Symbol/ObjectFile.h include/lldb/Symbol/Symtab.h source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp source/Plugins/Obj

Re: [Lldb-commits] [PATCH] D16868: [lldb] Fix invalid shift operator overload in Scalar

2016-02-09 Thread Marianne Mailhot-Sarrasin via lldb-commits
mamai added a comment. I don't have commit access. It would be great if you can push it for me. Thanks ! Repository: rL LLVM http://reviews.llvm.org/D16868 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/m

Re: [Lldb-commits] [PATCH] D16680: Re-submit rL258759: Write the session log file in UTF-8.

2016-02-09 Thread Tamas Berghammer via lldb-commits
tberghammer abandoned this revision. tberghammer added a comment. The change was submitted with a different CL http://reviews.llvm.org/D16680 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/ll

Re: [Lldb-commits] [PATCH] D16814: Fix handling of the arm IT instruction in the unwinder

2016-02-09 Thread Tamas Berghammer via lldb-commits
tberghammer added a comment. Jason: Can you take at the change in the unwinding logic? Comment at: source/Plugins/Instruction/ARM/EmulateInstructionARM.cpp:13653 @@ -13656,2 +13652,3 @@ const uint32_t cond = CurrentCond (m_opcode.GetOpcode32()); -return cond != 0xe && c

Re: [Lldb-commits] [PATCH] D16853: Use BKPT instead of UDF for arm/thumb breakpoints

2016-02-09 Thread Tamas Berghammer via lldb-commits
tberghammer added a comment. In http://reviews.llvm.org/D16853#347120, @omjavaid wrote: > GDB doesnt use bkpt instruction for user debugging for the reason that it > interferes with jtag debug probes. I am not sure if LLDB will be ever used > with a jtag probe in near future but still a jtag pr

Re: [Lldb-commits] [PATCH] D16936: Remove expectedFailureWindows decorator

2016-02-09 Thread Tamas Berghammer via lldb-commits
tberghammer added a comment. My main concern is that we have a lot of named argument for skipIf/expectFailure and I expect it to increase even further as we support more and more configuration. In my opinion we can have some functional style solution as readable as the current solution with gre

[Lldb-commits] [PATCH] D17022: [LLDB][MIPS] Provide CPU string to compiler for appropriate code generation for MIPS

2016-02-09 Thread Bhushan Attarde via lldb-commits
bhushan created this revision. bhushan added reviewers: clayborg, spyffe. bhushan added subscribers: lldb-commits, nitesh.jain, jaydeep, sagar, mohit.bhakkad. bhushan set the repository for this revision to rL LLVM. Currently, LLDB (ClangExpressionParser) does not pass `clang::TargetOptions::CPU

[Lldb-commits] [lldb] r260216 - Fix a typo in an xfail decorator in TestExprsChar

2016-02-09 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Tue Feb 9 04:10:42 2016 New Revision: 260216 URL: http://llvm.org/viewvc/llvm-project?rev=260216&view=rev Log: Fix a typo in an xfail decorator in TestExprsChar Modified: lldb/trunk/packages/Python/lldbsuite/test/expression_command/char/TestExprsChar.py Modified:

Re: [Lldb-commits] [lldb] r260072 - [LLDB][MIPS] Fix TestExpressionInSyscall.py for MIPS

2016-02-09 Thread Bhushan Attarde via lldb-commits
Hi Hans, Could you please add this (r260072) to the release branch? Thanks, Bhushan -Original Message- From: lldb-commits [mailto:lldb-commits-boun...@lists.llvm.org] On Behalf Of Bhushan D. Attarde via lldb-commits Sent: 08 February 2016 10:06 To: lldb-commits@lists.llvm.org Subject:

Re: [Lldb-commits] [PATCH] D16936: Remove expectedFailureWindows decorator

2016-02-09 Thread Pavel Labath via lldb-commits
labath added a subscriber: labath. labath added a comment. I think this is getting way too complicated. I haven't seen any test which needs such complicated combinations of skip conditions (and I hope I never see one). Repository: rL LLVM http://reviews.llvm.org/D16936

Re: [Lldb-commits] [PATCH] D16936: Remove expectedFailureWindows decorator

2016-02-09 Thread Pavel Labath via lldb-commits
I think this is getting way too complicated. I haven't seen any test which needs such complicated combinations of skip conditions (and I hope I never see one). On 9 February 2016 at 01:24, Zachary Turner wrote: > 1. Skips if all conditions are true. @skipIf(all(A=a, B=b, C=c)) > 2. Skips if any

Re: [Lldb-commits] [PATCH] D16868: [lldb] Fix invalid shift operator overload in Scalar

2016-02-09 Thread Pavel Labath via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. That's perfect. Thanks for adding that test. Do you have commit access, or shall I put this in? Repository: rL LLVM http://reviews.llvm.org/D16868 __

Re: [Lldb-commits] [PATCH] D16853: Use BKPT instead of UDF for arm/thumb breakpoints

2016-02-09 Thread Muhammad Omair Javaid via lldb-commits
omjavaid added a comment. GDB doesnt use bkpt instruction for user debugging for the reason that it interferes with jtag debug probes. I am not sure if LLDB will be ever used with a jtag probe in near future but still a jtag prob might be connected to the same hardware which is using LLDB to de